222841 2021-03-05 16:46:51 -0800 Potential crash under NotificationPermissionRequestManagerProxy::invalidateRequests() 2021-03-05 18:56:16 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez darin kkinnunen webkit-bug-importer oldest_to_newest 1736659 0 cdumez 2021-03-05 16:46:51 -0800 Potential crash under NotificationPermissionRequestManagerProxy::invalidateRequests(): Thread 0 Crashed ↩:: Dispatch queue: com.apple.main-thread 8 com.apple.WebKit 0x000000012f762f1c bool WTF::HashTraitsEmptyValueChecker<WTF::HashTraits<unsigned long long>, false>::isEmptyValue<unsigned long long>(unsigned long long const&) + 76 9 com.apple.WebKit 0x000000012f762ebf bool WTF::isHashTraitsEmptyValue<WTF::HashTraits<unsigned long long>, unsigned long long>(unsigned long long const&) + 15 10 com.apple.WebKit 0x0000000131738287 WTF::HashTable<unsigned long long, WTF::KeyValuePair<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > > >, WTF::DefaultHash<unsigned long long>, WTF::HashMap<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> >, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> >::isEmptyBucket(WTF::KeyValuePair<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > > const&) + 23 11 com.apple.WebKit 0x0000000131738244 WTF::HashTable<unsigned long long, WTF::KeyValuePair<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > > >, WTF::DefaultHash<unsigned long long>, WTF::HashMap<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> >, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> >::isEmptyOrDeletedBucket(WTF::KeyValuePair<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > > const&) + 20 12 com.apple.WebKit 0x00000001317381b5 WTF::HashTableConstIterator<unsigned long long, WTF::KeyValuePair<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > > >, WTF::DefaultHash<unsigned long long>, WTF::HashMap<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> >, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> >::skipEmptyBuckets() + 85 13 com.apple.WebKit 0x0000000131738439 WTF::HashTableConstIterator<unsigned long long, WTF::KeyValuePair<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > > >, WTF::DefaultHash<unsigned long long>, WTF::HashMap<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> >, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> >::operator++() + 57 14 com.apple.WebKit 0x00000001317383f4 WTF::HashTableIterator<unsigned long long, WTF::KeyValuePair<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > > >, WTF::DefaultHash<unsigned long long>, WTF::HashMap<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> >, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> >::operator++() + 20 15 com.apple.WebKit 0x00000001317383c8 WTF::HashTableIteratorAdapter<WTF::HashTable<unsigned long long, WTF::KeyValuePair<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > > >, WTF::DefaultHash<unsigned long long>, WTF::HashMap<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> >, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> >, WTF::KeyValuePair<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > > >::operator++() + 24 16 com.apple.WebKit 0x0000000131721de4 WTF::HashTableValuesIterator<WTF::HashTable<unsigned long long, WTF::KeyValuePair<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > >, WTF::KeyValuePairKeyExtractor<WTF::KeyValuePair<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > > >, WTF::DefaultHash<unsigned long long>, WTF::HashMap<unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> >, WTF::DefaultHash<unsigned long long>, WTF::HashTraits<unsigned long long>, WTF::HashTraits<WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > > >::KeyValuePairTraits, WTF::HashTraits<unsigned long long> >, unsigned long long, WTF::RefPtr<WebKit::NotificationPermissionRequest, WTF::RawPtrTraits<WebKit::NotificationPermissionRequest>, WTF::DefaultRefDerefTraits<WebKit::NotificationPermissionRequest> > >::operator++() + 20 17 com.apple.WebKit 0x0000000131721a15 WebKit::NotificationPermissionRequestManagerProxy::invalidateRequests() + 373 18 com.apple.WebKit 0x000000013116978a WebKit::WebPageProxy::resetState(WebKit::WebPageProxy::ResetStateReason) + 810 19 com.apple.WebKit 0x00000001311b8dc5 WebKit::WebPageProxy::resetStateAfterProcessExited(WebKit::ProcessTerminationReason) + 821 20 com.apple.WebKit 0x0000000131185322 WebKit::WebPageProxy::processDidTerminate(WebKit::ProcessTerminationReason) + 354 21 com.apple.WebKit 0x000000013135c80a WebKit::WebProcessProxy::processDidTerminateOrFailedToLaunch() + 1754 22 com.apple.WebKit 0x000000013135bf23 WebKit::WebProcessProxy::didClose(IPC::Connection&) + 323 1736662 1 422454 cdumez 2021-03-05 16:54:42 -0800 Created attachment 422454 Patch 1736705 2 ews-feeder 2021-03-05 18:55:23 -0800 Committed r274026: <https://commits.webkit.org/r274026> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422454. 1736707 3 webkit-bug-importer 2021-03-05 18:56:16 -0800 <rdar://problem/75123049> 422454 2021-03-05 16:54:42 -0800 2021-03-05 18:55:24 -0800 Patch bug-222841-20210305165441.patch text/plain 1927 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0MDIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM5YTFhMTFhMGNkYTQ5MGZl NzA0YmM0NTBhYWVkMzYwNGZkNmJiNjguLmNlODhhMzhiNDRjNTI4NTQyMjAxYTc0OWYzZDQ2NjMx ZTdkOTUzNDggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDMtMDUgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBQb3RlbnRpYWwgY3Jhc2ggdW5kZXIg Tm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyUHJveHk6OmludmFsaWRhdGVSZXF1 ZXN0cygpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0y MjI4NDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBN YWtlIHN1cmUgd2UgY29weSB0aGUgSGFzaE1hcCBiZWZvcmUgaXRlcmF0aW5nIG92ZXIgaXQgYW5k IGNhbGxpbmcgZGVueSgpIG9uIHRoZSByZXF1ZXN0cy4KKworICAgICAgICAqIFVJUHJvY2Vzcy9O b3RpZmljYXRpb25zL05vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlclByb3h5LmNw cDoKKyAgICAgICAgKFdlYktpdDo6Tm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2Vy UHJveHk6OmludmFsaWRhdGVSZXF1ZXN0cyk6CisKIDIwMjEtMDMtMDUgIENocmlzIER1bWV6ICA8 Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGUgSFRNTE1lZGlhRWxlbWVudDo6b3Jp Z2luc0luTWVkaWFDYWNoZSgpIHRvIHJldHVybiBTZWN1cml0eU9yaWdpbkRhdGEgaW5zdGVhZCBv ZiBTZWN1cml0eU9yaWdpbiBvYmplY3RzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJv Y2Vzcy9Ob3RpZmljYXRpb25zL05vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlclBy b3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL05vdGlmaWNhdGlvbnMvTm90aWZpY2F0 aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyUHJveHkuY3BwCmluZGV4IDNmMjg3MzJhYjVlMjM2 ZjA3NTFkZTQ4MWQ4ZGI2NjNjZjViMTAzOGUuLjM2MzM4ZWQyMTljNjAzNmNmMmQ2ZGJkMWZiNWYw NDY0Y2NhZmUyZjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL05vdGlmaWNh dGlvbnMvTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyUHJveHkuY3BwCisrKyBi L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL05vdGlmaWNhdGlvbnMvTm90aWZpY2F0aW9uUGVybWlz c2lvblJlcXVlc3RNYW5hZ2VyUHJveHkuY3BwCkBAIC00MCwxMCArNDAsOSBAQCBOb3RpZmljYXRp b25QZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXJQcm94eTo6Tm90aWZpY2F0aW9uUGVybWlzc2lvblJl cXVlc3RNYW5hZ2VyUAogCiB2b2lkIE5vdGlmaWNhdGlvblBlcm1pc3Npb25SZXF1ZXN0TWFuYWdl clByb3h5OjppbnZhbGlkYXRlUmVxdWVzdHMoKQogewotICAgIGZvciAoYXV0byYgcmVxdWVzdCA6 IG1fcGVuZGluZ1JlcXVlc3RzLnZhbHVlcygpKQorICAgIGF1dG8gcGVuZGluZ1JlcXVlc3RzID0g c3RkOjpleGNoYW5nZShtX3BlbmRpbmdSZXF1ZXN0cywgeyB9KTsKKyAgICBmb3IgKGF1dG8mIHJl cXVlc3QgOiBwZW5kaW5nUmVxdWVzdHMudmFsdWVzKCkpCiAgICAgICAgIHJlcXVlc3QtPmRlbnko KTsKLQotICAgIG1fcGVuZGluZ1JlcXVlc3RzLmNsZWFyKCk7CiB9CiAKIFJlZjxOb3RpZmljYXRp b25QZXJtaXNzaW9uUmVxdWVzdD4gTm90aWZpY2F0aW9uUGVybWlzc2lvblJlcXVlc3RNYW5hZ2Vy UHJveHk6OmNyZWF0ZVJlcXVlc3QodWludDY0X3Qgbm90aWZpY2F0aW9uSUQpCg==