22284 2008-11-15 13:22:44 -0800 Incorrect assert caused by uninitialized variable in NetworkStateNotifier 2008-11-15 15:39:56 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED Gtk, Qt, Wx P2 Normal --- 1 kevino webkit-unassigned oldest_to_newest 98892 0 kevino 2008-11-15 13:22:44 -0800 If m_networkStateChangedFunction is not initialized to null, then the assert checking that it wasn't set will fail even though it hasn't been set. This has been fixed already for Safari on Win/Mac and Chrome, but the issue exists for the fallback implementation. 98893 1 25192 kevino 2008-11-15 13:23:52 -0800 Created attachment 25192 Fix that initializes m_networkStateChangedFunction 98900 2 kevino 2008-11-15 15:39:56 -0800 Landed in r38436, thanks! 25192 2008-11-15 13:23:52 -0800 2008-11-15 15:32:38 -0800 Fix that initializes m_networkStateChangedFunction networkstatenotifier.patch text/plain 991 kevino SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiAzODQyNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTIgQEAKKzIwMDgtMTEtMTUgIEtldmluIE9sbGl2aWVyICA8a2V2aW5vQHRoZW9s bGl2aWVycy5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgSW5pdGlhbGl6ZSBtX25ldHdvcmtTdGF0ZUNoYW5nZWRGdW5jdGlvbiB0byAwIGFzIG90 aGVyd2lzZSB0aGUgY2hlY2sgZm9yIG51bGwgd2lsbCBmYWlsLgorCisgICAgICAgICogcGxhdGZv cm0vbmV0d29yay9OZXR3b3JrU3RhdGVOb3RpZmllci5oOgorICAgICAgICAoV2ViQ29yZTo6TmV0 d29ya1N0YXRlTm90aWZpZXI6Ok5ldHdvcmtTdGF0ZU5vdGlmaWVyKToKKwogMjAwOC0xMS0xNSAg R2VvZmZyZXkgR2FyZW4gIDxnZ2FyZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFNhbSBXZWluaWcuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvTmV0d29ya1N0YXRl Tm90aWZpZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvTmV0d29y a1N0YXRlTm90aWZpZXIuaAkocmV2aXNpb24gMzg0MjApCisrKyBXZWJDb3JlL3BsYXRmb3JtL25l dHdvcmsvTmV0d29ya1N0YXRlTm90aWZpZXIuaAkod29ya2luZyBjb3B5KQpAQCAtODUsNiArODUs NyBAQAogCiBpbmxpbmUgTmV0d29ya1N0YXRlTm90aWZpZXI6Ok5ldHdvcmtTdGF0ZU5vdGlmaWVy KCkKICAgICA6IG1faXNPbkxpbmUodHJ1ZSkKKyAgICAsIG1fbmV0d29ya1N0YXRlQ2hhbmdlZEZ1 bmN0aW9uKDApCiB7ICAgIAogfQogCg==