222830 2021-03-05 14:33:55 -0800 Fix potential thread safety issue in WebsiteDataStore::fetchDataAndApply() 2021-03-05 16:09:41 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=222828 InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson ggaren kkinnunen webkit-bug-importer oldest_to_newest 1736554 0 cdumez 2021-03-05 14:33:55 -0800 Fix potential thread safety issue in WebsiteDataStore::fetchDataAndApply(). 1736559 1 422423 cdumez 2021-03-05 14:38:31 -0800 Created attachment 422423 Patch 1736564 2 422423 ggaren 2021-03-05 14:45:32 -0800 Comment on attachment 422423 Patch r=me 1736625 3 ews-feeder 2021-03-05 16:08:14 -0800 Committed r274017: <https://commits.webkit.org/r274017> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422423. 1736629 4 webkit-bug-importer 2021-03-05 16:09:41 -0800 <rdar://problem/75117265> 422423 2021-03-05 14:38:31 -0800 2021-03-05 16:08:15 -0800 Patch bug-222830-20210305143830.patch text/plain 4347 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjczOTk3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDM0NzQ0OWUyNmU3OWNiZWQ4 ZjU4NzU3MjlhYzc1ZmY1OGEzY2Q5YTcuLjBkMWUzMWVjNGMyNDI2YzMxYTBlY2YyNTk5ZWZmNTc5 ZTdmYjA3NDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMjEtMDMtMDUgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBGaXggcG90ZW50aWFsIHRocmVhZCBz YWZldHkgaXNzdWUgaW4gV2Vic2l0ZURhdGFTdG9yZTo6ZmV0Y2hEYXRhQW5kQXBwbHkoKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyODMwCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIHByZXZpb3Vz IGNvZGUgd2FzIHBhc3NpbmcgU2VjdXJpdHlPcmlnaW5EYXRhIG9iamVjdHMgZnJvbSB0aGUgZGF0 YSBzdG9yZSBxdWV1ZSB0byB0aGUgbWFpbgorICAgICAgICB0aHJlYWQgd2l0aG91dCBpc29sYXRl ZCBjb3B5LiBUaGlzIGNvZGUgd291bGQgbm90IGJlIHRocmVhZC1zYWZlIGlmIHRoZSBmdW5jdGlv biB3ZSBnb3QgdGhlCisgICAgICAgIG9yaWdpbnMgZnJvbSB3b3VsZCBrZWVwIGEgY29weSBvZiB0 aGUgb3JpZ2lucyAoZS5nLiBjYWNoaW5nKS4gVG8gbWFrZSB0aGlzIG1vcmUgcm9idXN0IGZyb20g YQorICAgICAgICB0aHJlYWQtc2FmZXR5IHN0YW5kcG9pbnQsIHdlIG5vdyBjcm9zc1RocmVhZENv cHkoKSB0byBvcmlnaW5zIGJlZm9yZSBwYXNzaW5nIHRoZW0gdG8gdGhlIG1haW4KKyAgICAgICAg dGhyZWFkLgorCisgICAgICAgIEkgYWxzbyB1cGRhdGVkIHRoZXNlIHRvIGNvbnN0cnVjdCB0aGUg V2Vic2l0ZURhdGEgb24gdGhlIGRhdGEgc3RvcmUgcXVldWUgaW5zdGVhZCBvZiB0aGUgbWFpbgor ICAgICAgICB0aHJlYWQgZm9yIGNvbnNpc3RlbmN5IHdpdGggb3RoZXIgY2FzZXMgaW5zaWRlIFdl YnNpdGVEYXRhU3RvcmU6OmZldGNoRGF0YUFuZEFwcGx5KCkuCisKKyAgICAgICAgKiBVSVByb2Nl c3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFTdG9yZS5jcHA6CisgICAgICAgIChXZWJLaXQ6Oldl YnNpdGVEYXRhU3RvcmU6OmZldGNoRGF0YUFuZEFwcGx5KToKKwogMjAyMS0wMy0wNSAgQ2hyaXMg RHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFVwZGF0ZSBBcHBsaWNhdGlvbkNh Y2hlU3RvcmFnZTo6b3JpZ2luc1dpdGhDYWNoZSgpIHRvIHJldHVybiBhIEhhc2hTZXQ8U2VjdXJp dHlPcmlnaW5EYXRhPiBpbnN0ZWFkIG9mIGEgVmVjdG9yPFJlZjxTZWN1cml0eU9yaWdpbj4+CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0 YVN0b3JlLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVE YXRhU3RvcmUuY3BwCmluZGV4IDgyZTYyZDc5YjM1YWVlNWFjNmNiZTBhZTIzN2UyYmVhMTI0OGY2 YTYuLmIwYTEzODM3NWI4NWYwNjAxNjkxYTg3YzBmNWM0NDcwMWEwNDAwY2MgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3Bw CisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3Rv cmUuY3BwCkBAIC01NDAsMTIgKzU0MCwxMSBAQCB2b2lkIFdlYnNpdGVEYXRhU3RvcmU6OmZldGNo RGF0YUFuZEFwcGx5KE9wdGlvblNldDxXZWJzaXRlRGF0YVR5cGU+IGRhdGFUeXBlcywgTwogICAg IGlmIChkYXRhVHlwZXMuY29udGFpbnMoV2Vic2l0ZURhdGFUeXBlOjpXZWJTUUxEYXRhYmFzZXMp ICYmIGlzUGVyc2lzdGVudCgpKSB7CiAgICAgICAgIGNhbGxiYWNrQWdncmVnYXRvci0+YWRkUGVu ZGluZ0NhbGxiYWNrKCk7CiAKLSAgICAgICAgbV9xdWV1ZS0+ZGlzcGF0Y2goW3dlYlNRTERhdGFi YXNlRGlyZWN0b3J5ID0gbV9jb25maWd1cmF0aW9uLT53ZWJTUUxEYXRhYmFzZURpcmVjdG9yeSgp Lmlzb2xhdGVkQ29weSgpLCBjYWxsYmFja0FnZ3JlZ2F0b3JdIHsKLSAgICAgICAgICAgIGF1dG8g b3JpZ2lucyA9IFdlYkNvcmU6OkRhdGFiYXNlVHJhY2tlcjo6dHJhY2tlcldpdGhEYXRhYmFzZVBh dGgod2ViU1FMRGF0YWJhc2VEaXJlY3RvcnkpLT5vcmlnaW5zKCk7Ci0gICAgICAgICAgICBSdW5M b29wOjptYWluKCkuZGlzcGF0Y2goW2NhbGxiYWNrQWdncmVnYXRvciwgb3JpZ2lucyA9IFdURk1v dmUob3JpZ2lucyldKCkgbXV0YWJsZSB7Ci0gICAgICAgICAgICAgICAgV2Vic2l0ZURhdGEgd2Vi c2l0ZURhdGE7Ci0gICAgICAgICAgICAgICAgZm9yIChhdXRvJiBvcmlnaW4gOiBvcmlnaW5zKQot ICAgICAgICAgICAgICAgICAgICB3ZWJzaXRlRGF0YS5lbnRyaWVzLmFwcGVuZChXZWJzaXRlRGF0 YTo6RW50cnkgeyBXVEZNb3ZlKG9yaWdpbiksIFdlYnNpdGVEYXRhVHlwZTo6V2ViU1FMRGF0YWJh c2VzLCAwIH0pOworICAgICAgICBtX3F1ZXVlLT5kaXNwYXRjaChbd2ViU1FMRGF0YWJhc2VEaXJl Y3RvcnkgPSBtX2NvbmZpZ3VyYXRpb24tPndlYlNRTERhdGFiYXNlRGlyZWN0b3J5KCkuaXNvbGF0 ZWRDb3B5KCksIGNhbGxiYWNrQWdncmVnYXRvcl0oKSB7CisgICAgICAgICAgICBXZWJzaXRlRGF0 YSB3ZWJzaXRlRGF0YTsKKyAgICAgICAgICAgIGZvciAoYXV0byYgb3JpZ2luIDogV2ViQ29yZTo6 RGF0YWJhc2VUcmFja2VyOjp0cmFja2VyV2l0aERhdGFiYXNlUGF0aCh3ZWJTUUxEYXRhYmFzZURp cmVjdG9yeSktPm9yaWdpbnMoKSkKKyAgICAgICAgICAgICAgICB3ZWJzaXRlRGF0YS5lbnRyaWVz LmFwcGVuZChXZWJzaXRlRGF0YTo6RW50cnkgeyBjcm9zc1RocmVhZENvcHkob3JpZ2luKSwgV2Vi c2l0ZURhdGFUeXBlOjpXZWJTUUxEYXRhYmFzZXMsIDAgfSk7CisgICAgICAgICAgICBSdW5Mb29w OjptYWluKCkuZGlzcGF0Y2goW2NhbGxiYWNrQWdncmVnYXRvciwgd2Vic2l0ZURhdGEgPSBXVEZN b3ZlKHdlYnNpdGVEYXRhKV0oKSBtdXRhYmxlIHsKICAgICAgICAgICAgICAgICBjYWxsYmFja0Fn Z3JlZ2F0b3ItPnJlbW92ZVBlbmRpbmdDYWxsYmFjayhXVEZNb3ZlKHdlYnNpdGVEYXRhKSk7CiAg ICAgICAgICAgICB9KTsKICAgICAgICAgfSk7CkBAIC01NTUsMTMgKzU1NCwxMCBAQCB2b2lkIFdl YnNpdGVEYXRhU3RvcmU6OmZldGNoRGF0YUFuZEFwcGx5KE9wdGlvblNldDxXZWJzaXRlRGF0YVR5 cGU+IGRhdGFUeXBlcywgTwogICAgICAgICBjYWxsYmFja0FnZ3JlZ2F0b3ItPmFkZFBlbmRpbmdD YWxsYmFjaygpOwogCiAgICAgICAgIG1fcXVldWUtPmRpc3BhdGNoKFttZWRpYUtleXNTdG9yYWdl RGlyZWN0b3J5ID0gbV9jb25maWd1cmF0aW9uLT5tZWRpYUtleXNTdG9yYWdlRGlyZWN0b3J5KCku aXNvbGF0ZWRDb3B5KCksIGNhbGxiYWNrQWdncmVnYXRvcl0gewotICAgICAgICAgICAgYXV0byBv cmlnaW5zID0gbWVkaWFLZXlPcmlnaW5zKG1lZGlhS2V5c1N0b3JhZ2VEaXJlY3RvcnkpOwotCi0g ICAgICAgICAgICBSdW5Mb29wOjptYWluKCkuZGlzcGF0Y2goW2NhbGxiYWNrQWdncmVnYXRvciwg b3JpZ2lucyA9IFdURk1vdmUob3JpZ2lucyldKCkgbXV0YWJsZSB7Ci0gICAgICAgICAgICAgICAg V2Vic2l0ZURhdGEgd2Vic2l0ZURhdGE7Ci0gICAgICAgICAgICAgICAgZm9yIChhdXRvJiBvcmln aW4gOiBvcmlnaW5zKQotICAgICAgICAgICAgICAgICAgICB3ZWJzaXRlRGF0YS5lbnRyaWVzLmFw cGVuZChXZWJzaXRlRGF0YTo6RW50cnkgeyBvcmlnaW4sIFdlYnNpdGVEYXRhVHlwZTo6TWVkaWFL ZXlzLCAwIH0pOwotCisgICAgICAgICAgICBXZWJzaXRlRGF0YSB3ZWJzaXRlRGF0YTsKKyAgICAg ICAgICAgIGZvciAoYXV0byYgb3JpZ2luIDogbWVkaWFLZXlPcmlnaW5zKG1lZGlhS2V5c1N0b3Jh Z2VEaXJlY3RvcnkpKQorICAgICAgICAgICAgICAgIHdlYnNpdGVEYXRhLmVudHJpZXMuYXBwZW5k KFdlYnNpdGVEYXRhOjpFbnRyeSB7IGNyb3NzVGhyZWFkQ29weShvcmlnaW4pLCBXZWJzaXRlRGF0 YVR5cGU6Ok1lZGlhS2V5cywgMCB9KTsKKyAgICAgICAgICAgIFJ1bkxvb3A6Om1haW4oKS5kaXNw YXRjaChbY2FsbGJhY2tBZ2dyZWdhdG9yLCB3ZWJzaXRlRGF0YSA9IFdURk1vdmUod2Vic2l0ZURh dGEpXSgpIG11dGFibGUgewogICAgICAgICAgICAgICAgIGNhbGxiYWNrQWdncmVnYXRvci0+cmVt b3ZlUGVuZGluZ0NhbGxiYWNrKFdURk1vdmUod2Vic2l0ZURhdGEpKTsKICAgICAgICAgICAgIH0p OwogICAgICAgICB9KTsK