222807 2021-03-05 10:08:41 -0800 Fix potential thread-safety issue in WebsiteDataStore::fetchDataAndApply() 2021-03-05 12:50:16 -0800 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 cdumez cdumez achristensen beidson ggaren kkinnunen webkit-bug-importer oldest_to_newest 1736394 0 cdumez 2021-03-05 10:08:41 -0800 Fix potential thread-safety issue in WebsiteDataStore::fetchDataAndApply(). 1736400 1 422379 cdumez 2021-03-05 10:16:49 -0800 Created attachment 422379 Patch 1736482 2 422379 ggaren 2021-03-05 12:45:26 -0800 Comment on attachment 422379 Patch r=me 1736484 3 ews-feeder 2021-03-05 12:49:32 -0800 Committed r273996: <https://commits.webkit.org/r273996> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422379. 1736485 4 webkit-bug-importer 2021-03-05 12:50:16 -0800 <rdar://problem/75107582> 422379 2021-03-05 10:16:49 -0800 2021-03-05 12:49:33 -0800 Patch bug-222807-20210305101648.patch text/plain 6179 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjczOTcxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDk5MTE1ODYyZTYwY2VmNjY2 NDg0YTMwNWJjMTk0ZDRiNWE4NWQxMzQuLjdiNDJlZTJhYzBlYzQyYTQxMDJlYTRlN2FlODI2ZjVi ODllMzQyNGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMjEtMDMtMDUgIENocmlzIER1 bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KKworICAgICAgICBGaXggcG90ZW50aWFsIHRocmVhZC1z YWZldHkgaXNzdWUgaW4gV2Vic2l0ZURhdGFTdG9yZTo6ZmV0Y2hEYXRhQW5kQXBwbHkoKQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyODA3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IGFuIGlzc3Vl IHdoZW4gV2Vic2l0ZURhdGFTdG9yZTo6ZmV0Y2hEYXRhQW5kQXBwbHkoKSBmYWlsZWQgdG8gY3Jl YXRlIGFuIGlzb2xhdGVkCisgICAgICAgIGNvcHkgb2YgdGhlIFdlYnNpdGVEYXRhUmVjb3JkcyBi ZWZvcmUgcGFzc2luZyB0aGVtIHRvIGl0cyBpbnRlcm5hbCBkaXNwYXRjaCBxdWV1ZS4KKyAgICAg ICAgQWxzbyBhZGQgbW9yZSB0aHJlYWRpbmcgYXNzZXJ0aW9ucyB0byBoZWxwIGNhdGNoIGlzc3Vl cyBzaW5jZSB3ZSBoYXZlIGNyYXNoZXMgaW4gdGhpcworICAgICAgICBhcmVhIG9mIHRoZSBjb2Rl LgorCisgICAgICAgICogVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhUmVjb3JkLmNw cDoKKyAgICAgICAgKFdlYktpdDo6V2Vic2l0ZURhdGFSZWNvcmQ6Omlzb2xhdGVkQ29weSBjb25z dCk6CisgICAgICAgICogVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhUmVjb3JkLmg6 CisgICAgICAgICogVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhU3RvcmUuY3BwOgor ICAgICAgICAoV2ViS2l0OjpXZWJzaXRlRGF0YVN0b3JlOjpmZXRjaERhdGFBbmRBcHBseSk6CisK IDIwMjEtMDMtMDUgIEVyaWMgQ2FybHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CiAKICAg ICAgICAgW0dQVSBQcm9jZXNzXSBSZW1vdGUgY29udHJvbCBjb21tYW5kIHNob3VsZCBvbmx5IGdv IHRvIHRoZSBjdXJyZW50IE5vd1BsYXlpbmcgc2Vzc2lvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFSZWNvcmQuY3BwIGIvU291cmNl L1dlYktpdC9VSVByb2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFSZWNvcmQuY3BwCmluZGV4 IDUwNmFiNjNlYjAyZTdjYjU5YzA2YmQxYjUxMTAyZDk5ZDI4OWExNjUuLmU5MTllMTE4ZGZmYjMw YjEwOTBjN2ZiY2Y1NjU2MDI3ZGM4YjlmZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhUmVjb3JkLmNwcAorKysgYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVJlY29yZC5jcHAKQEAgLTI5LDYg KzI5LDcgQEAKICNpbmNsdWRlIDxXZWJDb3JlL0xvY2FsaXplZFN0cmluZ3MuaD4KICNpbmNsdWRl IDxXZWJDb3JlL1B1YmxpY1N1ZmZpeC5oPgogI2luY2x1ZGUgPFdlYkNvcmUvU2VjdXJpdHlPcmln aW4uaD4KKyNpbmNsdWRlIDx3dGYvQ3Jvc3NUaHJlYWRDb3BpZXIuaD4KIAogI2lmIFBMQVRGT1JN KENPQ09BKQogI2ltcG9ydCA8cGFsL3NwaS9jZi9DRk5ldHdvcmtTUEkuaD4KQEAgLTE3MCw0ICsx NzEsMjMgQEAgU3RyaW5nIFdlYnNpdGVEYXRhUmVjb3JkOjp0b3BQcml2YXRlbHlDb250cm9sbGVk RG9tYWluKCkKICAgICByZXR1cm4gZW1wdHlTdHJpbmcoKTsKIH0KIAorV2Vic2l0ZURhdGFSZWNv cmQgV2Vic2l0ZURhdGFSZWNvcmQ6Omlzb2xhdGVkQ29weSgpIGNvbnN0Cit7CisgICAgcmV0dXJu IFdlYnNpdGVEYXRhUmVjb3JkIHsKKyAgICAgICAgY3Jvc3NUaHJlYWRDb3B5KGRpc3BsYXlOYW1l KSwKKyAgICAgICAgdHlwZXMsCisgICAgICAgIHNpemUsCisgICAgICAgIGNyb3NzVGhyZWFkQ29w eShvcmlnaW5zKSwKKyAgICAgICAgY3Jvc3NUaHJlYWRDb3B5KGNvb2tpZUhvc3ROYW1lcyksCisj aWYgRU5BQkxFKE5FVFNDQVBFX1BMVUdJTl9BUEkpCisgICAgICAgIGNyb3NzVGhyZWFkQ29weShw bHVnaW5EYXRhSG9zdE5hbWVzKSwKKyNlbmRpZgorICAgICAgICBjcm9zc1RocmVhZENvcHkoSFNU U0NhY2hlSG9zdE5hbWVzKSwKKyAgICAgICAgY3Jvc3NUaHJlYWRDb3B5KGFsdGVybmF0aXZlU2Vy dmljZXNIb3N0TmFtZXMpLAorI2lmIEVOQUJMRShSRVNPVVJDRV9MT0FEX1NUQVRJU1RJQ1MpCisg ICAgICAgIGNyb3NzVGhyZWFkQ29weShyZXNvdXJjZUxvYWRTdGF0aXN0aWNzUmVnaXN0cmFibGVE b21haW5zKSwKKyNlbmRpZgorICAgIH07Cit9CisKIH0KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhUmVjb3JkLmggYi9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9XZWJzaXRlRGF0YVJlY29yZC5oCmluZGV4IDRhMGZj MGM1ZDVjMGVmN2Y5MzUwYjYzNTdmNDY3Y2QzOTE3NDQ5OTIuLmMzNTI2MTJmZmM5OWU0MDliNTM1 M2U4ZDllYmVkZWM3YzEwNzlkNTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRhUmVjb3JkLmgKKysrIGIvU291cmNlL1dlYktpdC9VSVBy b2Nlc3MvV2Vic2l0ZURhdGEvV2Vic2l0ZURhdGFSZWNvcmQuaApAQCAtNTksNiArNTksMTEgQEAg c3RydWN0IFdlYnNpdGVEYXRhUmVjb3JkIHsKICAgICB2b2lkIGFkZFJlc291cmNlTG9hZFN0YXRp c3RpY3NSZWdpc3RyYWJsZURvbWFpbihjb25zdCBXZWJDb3JlOjpSZWdpc3RyYWJsZURvbWFpbiYp OwogI2VuZGlmCiAKKyAgICBib29sIG1hdGNoZXMoY29uc3QgV2ViQ29yZTo6UmVnaXN0cmFibGVE b21haW4mKSBjb25zdDsKKyAgICBTdHJpbmcgdG9wUHJpdmF0ZWx5Q29udHJvbGxlZERvbWFpbigp OworCisgICAgV2Vic2l0ZURhdGFSZWNvcmQgaXNvbGF0ZWRDb3B5KCkgY29uc3Q7CisKICAgICBT dHJpbmcgZGlzcGxheU5hbWU7CiAgICAgT3B0aW9uU2V0PFdlYnNpdGVEYXRhVHlwZT4gdHlwZXM7 CiAKQEAgLTc4LDkgKzgzLDYgQEAgc3RydWN0IFdlYnNpdGVEYXRhUmVjb3JkIHsKICNpZiBFTkFC TEUoUkVTT1VSQ0VfTE9BRF9TVEFUSVNUSUNTKQogICAgIEhhc2hTZXQ8V2ViQ29yZTo6UmVnaXN0 cmFibGVEb21haW4+IHJlc291cmNlTG9hZFN0YXRpc3RpY3NSZWdpc3RyYWJsZURvbWFpbnM7CiAj ZW5kaWYKLQotICAgIGJvb2wgbWF0Y2hlcyhjb25zdCBXZWJDb3JlOjpSZWdpc3RyYWJsZURvbWFp biYpIGNvbnN0OwotICAgIFN0cmluZyB0b3BQcml2YXRlbHlDb250cm9sbGVkRG9tYWluKCk7CiB9 OwogCiB9CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJzaXRlRGF0YS9X ZWJzaXRlRGF0YVN0b3JlLmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRh L1dlYnNpdGVEYXRhU3RvcmUuY3BwCmluZGV4IGI1Zjc4MGY1Yjc3NmMzMmFhZTBiMWZkZGNhZWIy N2VlNmUyODFiOWIuLjZhYjk3ODQ5OTUwOWI5MjA4NWY0YjE5ZTM4MTdlMzAyYjNiMmZjMzQgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNpdGVEYXRh U3RvcmUuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dlYnNpdGVEYXRhL1dlYnNp dGVEYXRhU3RvcmUuY3BwCkBAIC0zMTAsNyArMzEwLDcgQEAgdm9pZCBXZWJzaXRlRGF0YVN0b3Jl OjpmZXRjaERhdGEoT3B0aW9uU2V0PFdlYnNpdGVEYXRhVHlwZT4gZGF0YVR5cGVzLCBPcHRpb25T ZXQKIAogdm9pZCBXZWJzaXRlRGF0YVN0b3JlOjpmZXRjaERhdGFBbmRBcHBseShPcHRpb25TZXQ8 V2Vic2l0ZURhdGFUeXBlPiBkYXRhVHlwZXMsIE9wdGlvblNldDxXZWJzaXRlRGF0YUZldGNoT3B0 aW9uPiBmZXRjaE9wdGlvbnMsIFJlZlB0cjxXb3JrUXVldWU+JiYgcXVldWUsIEZ1bmN0aW9uPHZv aWQoVmVjdG9yPFdlYnNpdGVEYXRhUmVjb3JkPik+JiYgYXBwbHkpCiB7Ci0gICAgc3RydWN0IENh bGxiYWNrQWdncmVnYXRvciBmaW5hbCA6IFRocmVhZFNhZmVSZWZDb3VudGVkPENhbGxiYWNrQWdn cmVnYXRvcj4geworICAgIHN0cnVjdCBDYWxsYmFja0FnZ3JlZ2F0b3IgZmluYWwgOiBUaHJlYWRT YWZlUmVmQ291bnRlZDxDYWxsYmFja0FnZ3JlZ2F0b3IsIFdURjo6RGVzdHJ1Y3Rpb25UaHJlYWQ6 Ok1haW5SdW5Mb29wPiB7CiAgICAgICAgIENhbGxiYWNrQWdncmVnYXRvcihPcHRpb25TZXQ8V2Vi c2l0ZURhdGFGZXRjaE9wdGlvbj4gZmV0Y2hPcHRpb25zLCBSZWZQdHI8V29ya1F1ZXVlPiYmIHF1 ZXVlLCBGdW5jdGlvbjx2b2lkKFZlY3RvcjxXZWJzaXRlRGF0YVJlY29yZD4pPiYmIGFwcGx5LCBX ZWJzaXRlRGF0YVN0b3JlJiBkYXRhU3RvcmUpCiAgICAgICAgICAgICA6IGZldGNoT3B0aW9ucyhm ZXRjaE9wdGlvbnMpCiAgICAgICAgICAgICAsIHF1ZXVlKFdURk1vdmUocXVldWUpKQpAQCAtMzIy LDE5ICszMjIsMTkgQEAgdm9pZCBXZWJzaXRlRGF0YVN0b3JlOjpmZXRjaERhdGFBbmRBcHBseShP cHRpb25TZXQ8V2Vic2l0ZURhdGFUeXBlPiBkYXRhVHlwZXMsIE8KIAogICAgICAgICB+Q2FsbGJh Y2tBZ2dyZWdhdG9yKCkKICAgICAgICAgeworICAgICAgICAgICAgQVNTRVJUKFJ1bkxvb3A6Omlz TWFpbigpKTsKICAgICAgICAgICAgIEFTU0VSVCghcGVuZGluZ0NhbGxiYWNrcyk7Ci0KLSAgICAg ICAgICAgIC8vIE1ha2Ugc3VyZSB0aGUgZGF0YSBzdG9yZSBnZXRzIGRlc3Ryb3llZCBvbiB0aGUg bWFpbiB0aHJlYWQgZXZlbiB0aG91Z2ggdGhlIENhbGxiYWNrQWdncmVnYXRvciBjYW4gZ2V0IGRl c3Ryb3llZCBvbiBhIGJhY2tncm91bmQgcXVldWUuCi0gICAgICAgICAgICBSdW5Mb29wOjptYWlu KCkuZGlzcGF0Y2goW3Byb3RlY3RlZERhdGFTdG9yZSA9IFdURk1vdmUocHJvdGVjdGVkRGF0YVN0 b3JlKV0geyB9KTsKICAgICAgICAgfQogCiAgICAgICAgIHZvaWQgYWRkUGVuZGluZ0NhbGxiYWNr KCkKICAgICAgICAgewotICAgICAgICAgICAgcGVuZGluZ0NhbGxiYWNrcysrOworICAgICAgICAg ICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFpbigpKTsKKyAgICAgICAgICAgICsrcGVuZGluZ0NhbGxi YWNrczsKICAgICAgICAgfQogCiAgICAgICAgIHZvaWQgcmVtb3ZlUGVuZGluZ0NhbGxiYWNrKFdl YnNpdGVEYXRhIHdlYnNpdGVEYXRhKQogICAgICAgICB7CisgICAgICAgICAgICBBU1NFUlQoUnVu TG9vcDo6aXNNYWluKCkpOwogICAgICAgICAgICAgQVNTRVJUKHBlbmRpbmdDYWxsYmFja3MpOwog ICAgICAgICAgICAgLS1wZW5kaW5nQ2FsbGJhY2tzOwogCkBAIC00MjAsMTMgKzQyMCwxNCBAQCB2 b2lkIFdlYnNpdGVEYXRhU3RvcmU6OmZldGNoRGF0YUFuZEFwcGx5KE9wdGlvblNldDxXZWJzaXRl RGF0YVR5cGU+IGRhdGFUeXBlcywgTwogCiAgICAgICAgIHZvaWQgY2FsbElmTmVlZGVkKCkKICAg ICAgICAgeworICAgICAgICAgICAgQVNTRVJUKFJ1bkxvb3A6OmlzTWFpbigpKTsKICAgICAgICAg ICAgIGlmIChwZW5kaW5nQ2FsbGJhY2tzKQogICAgICAgICAgICAgICAgIHJldHVybjsKIAogICAg ICAgICAgICAgVmVjdG9yPFdlYnNpdGVEYXRhUmVjb3JkPiByZWNvcmRzOwogICAgICAgICAgICAg cmVjb3Jkcy5yZXNlcnZlSW5pdGlhbENhcGFjaXR5KG1fd2Vic2l0ZURhdGFSZWNvcmRzLnNpemUo KSk7CiAgICAgICAgICAgICBmb3IgKGF1dG8mIHJlY29yZCA6IG1fd2Vic2l0ZURhdGFSZWNvcmRz LnZhbHVlcygpKQotICAgICAgICAgICAgICAgIHJlY29yZHMudW5jaGVja2VkQXBwZW5kKFdURk1v dmUocmVjb3JkKSk7CisgICAgICAgICAgICAgICAgcmVjb3Jkcy51bmNoZWNrZWRBcHBlbmQocXVl dWUgPyBjcm9zc1RocmVhZENvcHkocmVjb3JkKSA6IFdURk1vdmUocmVjb3JkKSk7CiAKICAgICAg ICAgICAgIGF1dG8gcHJvY2Vzc1JlY29yZHMgPSBbYXBwbHkgPSBXVEZNb3ZlKGFwcGx5KSwgcmVj b3JkcyA9IFdURk1vdmUocmVjb3JkcyldICgpIG11dGFibGUgewogICAgICAgICAgICAgICAgIGFw cGx5KFdURk1vdmUocmVjb3JkcykpOwo=