222797 2021-03-05 04:05:41 -0800 [GTK] Clang warnings in MiniBrowser build 2021-03-05 05:15:33 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 pnormand pnormand bugs-noreply cgarcia oldest_to_newest 1736291 0 pnormand 2021-03-05 04:05:41 -0800 [19/73] Building C object Tools/MiniBrowser/gtk/CMakeFiles/MiniBrowser.dir/BrowserCellRendererVariant.c.o ../../Tools/MiniBrowser/gtk/BrowserCellRendererVariant.c:296:6: warning: expression result unused [-Wunused-value] ((__typeof__ (renderer->toggleRenderer)) (g_object_ref_sink) (renderer->toggleRenderer)); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../../Tools/MiniBrowser/gtk/BrowserCellRendererVariant.c:302:6: warning: expression result unused [-Wunused-value] ((__typeof__ (renderer->textRenderer)) (g_object_ref_sink) (renderer->textRenderer)); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ 2 warnings generated. [21/73] Building C object Tools/MiniBrowser/gtk/CMakeFiles/MiniBrowser.dir/BrowserTab.c.o ../../Tools/MiniBrowser/gtk/BrowserTab.c:432:6: warning: expression result unused [-Wunused-value] ((__typeof__ (request)) (g_object_ref) (request)); ^ ~~~~~~~~~~~~~~~~~~~~~~~~ 1 warning generated. 1736294 1 422361 pnormand 2021-03-05 04:07:35 -0800 Created attachment 422361 Patch 1736312 2 ews-feeder 2021-03-05 05:15:31 -0800 Committed r273963: <https://commits.webkit.org/r273963> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422361. 422361 2021-03-05 04:07:35 -0800 2021-03-05 05:15:32 -0800 Patch bug-222797-20210305040734.patch text/plain 2782 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjczOTU5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMWZmYzdkYjg4NDBhMWIwNTRiZTM2MWQwYTNmOGRmZTAy ODY5MjczZS4uNjgwNmY3OWJjNjQ4ZTM1MjEyMzVhMjhlNDQ0YTZkMTJmNTA1NmExMCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3 IEBACisyMDIxLTAzLTA1ICBQaGlsaXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXSBDbGFuZyB3YXJuaW5ncyBpbiBNaW5pQnJvd3NlciBidWlsZAorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyNzk3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRml4IHVudXNlZC12 YWx1ZSB3YXJuaW5ncy4KKworICAgICAgICAqIE1pbmlCcm93c2VyL2d0ay9Ccm93c2VyQ2VsbFJl bmRlcmVyVmFyaWFudC5jOgorICAgICAgICAoYnJvd3Nlcl9jZWxsX3JlbmRlcmVyX3ZhcmlhbnRf aW5pdCk6CisgICAgICAgICogTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJUYWIuYzoKKyAgICAgICAg KHJ1bkNvbG9yQ2hvb3NlckNhbGxiYWNrKToKKwogMjAyMS0wMy0wNCAgU2FtIFNuZWRkb24gIDxn c25lZGRlcnNAYXBwbGUuY29tPgogCiAgICAgICAgIFVuZGVwcmVjYXRlIG1hbnkgbW9yZSB3ZWJr aXQtcGF0Y2ggY29tbWFuZHMKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93 c2VyQ2VsbFJlbmRlcmVyVmFyaWFudC5jIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJD ZWxsUmVuZGVyZXJWYXJpYW50LmMKaW5kZXggY2NkMWYyZTk3ZjhhYjA4YzRiMjU3NTJjZmQwZWVk YjkzZTMyODY2Yy4uMjk3NzI3ODFhNmRhZmJmNGJkOGM2MjBhMzAxYmRkNWIwYzc0ZGZjOCAxMDA2 NDQKLS0tIGEvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJDZWxsUmVuZGVyZXJWYXJpYW50 LmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJDZWxsUmVuZGVyZXJWYXJpYW50 LmMKQEAgLTI5MywxMyArMjkzLDEzIEBAIHN0YXRpYyB2b2lkIGJyb3dzZXJfY2VsbF9yZW5kZXJl cl92YXJpYW50X2luaXQoQnJvd3NlckNlbGxSZW5kZXJlclZhcmlhbnQgKnJlbmRlCiAKICAgICBy ZW5kZXJlci0+dG9nZ2xlUmVuZGVyZXIgPSBndGtfY2VsbF9yZW5kZXJlcl90b2dnbGVfbmV3KCk7 CiAgICAgZ19vYmplY3Rfc2V0KEdfT0JKRUNUKHJlbmRlcmVyLT50b2dnbGVSZW5kZXJlciksICJ4 YWxpZ24iLCAwLjAsIE5VTEwpOwotICAgIGdfb2JqZWN0X3JlZl9zaW5rKHJlbmRlcmVyLT50b2dn bGVSZW5kZXJlcik7CisgICAgcmVuZGVyZXItPnRvZ2dsZVJlbmRlcmVyID0gZ19vYmplY3RfcmVm X3NpbmsocmVuZGVyZXItPnRvZ2dsZVJlbmRlcmVyKTsKIAogICAgIHJlbmRlcmVyLT50ZXh0UmVu ZGVyZXIgPSBndGtfY2VsbF9yZW5kZXJlcl90ZXh0X25ldygpOwogICAgIGdfc2lnbmFsX2Nvbm5l Y3Rfc3dhcHBlZChyZW5kZXJlci0+dGV4dFJlbmRlcmVyLCAiZWRpdGVkIiwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgR19DQUxMQkFDSyhicm93c2VyQ2VsbFJlbmRlcmVyVmFyaWFudENl bGxSZW5kZXJlclRleHRFZGl0ZWQpLCByZW5kZXJlcik7CiAgICAgZ19vYmplY3Rfc2V0KEdfT0JK RUNUKHJlbmRlcmVyLT50ZXh0UmVuZGVyZXIpLCAiZWRpdGFibGUiLCBUUlVFLCBOVUxMKTsKLSAg ICBnX29iamVjdF9yZWZfc2luayhyZW5kZXJlci0+dGV4dFJlbmRlcmVyKTsKKyAgICByZW5kZXJl ci0+dGV4dFJlbmRlcmVyID0gZ19vYmplY3RfcmVmX3NpbmsocmVuZGVyZXItPnRleHRSZW5kZXJl cik7CiAKICAgICByZW5kZXJlci0+c3BpblJlbmRlcmVyID0gZ3RrX2NlbGxfcmVuZGVyZXJfc3Bp bl9uZXcoKTsKICAgICBnX3NpZ25hbF9jb25uZWN0X3N3YXBwZWQocmVuZGVyZXItPnNwaW5SZW5k ZXJlciwgImVkaXRlZCIsCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJvd3Nl clRhYi5jIGIvVG9vbHMvTWluaUJyb3dzZXIvZ3RrL0Jyb3dzZXJUYWIuYwppbmRleCAzYjJmNWRl Y2RiMjZkNDJjMzliZDQ4ZTZmNWFmMDY5YzZlOTE5YzMwLi5hYjc1YTY5ZjY0YWFkZWUyYjIyZTBk OGQxMTQ5MzJkYjU1YWFhMDAwIDEwMDY0NAotLS0gYS9Ub29scy9NaW5pQnJvd3Nlci9ndGsvQnJv d3NlclRhYi5jCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL2d0ay9Ccm93c2VyVGFiLmMKQEAgLTQy OSw4ICs0MjksNyBAQCBzdGF0aWMgZ2Jvb2xlYW4gcnVuQ29sb3JDaG9vc2VyQ2FsbGJhY2soV2Vi S2l0V2ViVmlldyAqd2ViVmlldywgV2ViS2l0Q29sb3JDaG9vcwogICAgIGd0a193aWRnZXRfc2hv dyhjb2xvckNob29zZXIpOwogI2VuZGlmCiAKLSAgICBnX29iamVjdF9yZWYocmVxdWVzdCk7Ci0g ICAgZ19zaWduYWxfY29ubmVjdF9vYmplY3QocG9wb3ZlciwgImhpZGUiLCBHX0NBTExCQUNLKHBv cG92ZXJDb2xvckNsb3NlZCksIHJlcXVlc3QsIDApOworICAgIGdfc2lnbmFsX2Nvbm5lY3Rfb2Jq ZWN0KHBvcG92ZXIsICJoaWRlIiwgR19DQUxMQkFDSyhwb3BvdmVyQ29sb3JDbG9zZWQpLCBnX29i amVjdF9yZWYocmVxdWVzdCksIDApOwogICAgIGdfc2lnbmFsX2Nvbm5lY3Rfb2JqZWN0KHJlcXVl c3QsICJmaW5pc2hlZCIsIEdfQ0FMTEJBQ0soY29sb3JDaG9vc2VyUmVxdWVzdEZpbmlzaGVkKSwg cG9wb3ZlciwgMCk7CiAKICAgICBndGtfd2lkZ2V0X3Nob3cocG9wb3Zlcik7Cg==