222783 2021-03-05 00:31:45 -0800 Inline isDisabledFormControl() in isDisabledOrReadOnly() by making it final rather than duplicating code 2021-03-05 19:29:16 -0800 1 1 1 Unclassified WebKit DOM WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=221319 InRadar P2 Normal --- 1 rniwa rniwa cdumez changseok darin esprehn+autocc ews-watchlist gyuyoung.kim koivisto mifenton simon.fraser webkit-bug-importer wenson_hsieh oldest_to_newest 1736204 0 rniwa 2021-03-05 00:31:45 -0800 Address Darin's comment in https://bugs.webkit.org/show_bug.cgi?id=221319. 1736205 1 422341 rniwa 2021-03-05 00:33:51 -0800 Created attachment 422341 Patch 1736718 2 422341 rniwa 2021-03-05 19:28:56 -0800 Comment on attachment 422341 Patch Clearing flags on attachment: 422341 Committed r274029 (234965@main): <https://commits.webkit.org/234965@main> 1736719 3 rniwa 2021-03-05 19:28:59 -0800 All reviewed patches have been landed. Closing bug. 1736720 4 webkit-bug-importer 2021-03-05 19:29:16 -0800 <rdar://problem/75123754> 422341 2021-03-05 00:33:51 -0800 2021-03-05 19:28:56 -0800 Patch bug-222783-20210305003350.patch text/plain 2779 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3Mzk1MCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDIxLTAzLTA1ICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIElubGluZSBpc0Rpc2FibGVkRm9y bUNvbnRyb2woKSBpbiBpc0Rpc2FibGVkT3JSZWFkT25seSgpIGJ5IG1ha2luZyBpdCBmaW5hbCBy YXRoZXIgdGhhbiBkdXBsaWNhdGluZyBjb2RlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI3ODMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBJbmxpbmUgaXNEaXNhYmxlZEZvcm1Db250cm9sIGludG8gaXNE aXNhYmxlZE9yUmVhZE9ubHkgYnkgbWFraW5nIGl0IGZpbmFsIGFuZCBkZWZpbmluZyBpbiB0aGUg aGVhZGVyIGZpbGUKKyAgICAgICAgaW5zdGVhZCBvZiBtYW51YWxseSBkdXBsaWNhdGluZyB0aGUg Y29kZSBhcyBkb25lIGluIHIyNzIyOTkuCisKKyAgICAgICAgKiBodG1sL0hUTUxGb3JtQ29udHJv bEVsZW1lbnQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SFRNTEZvcm1Db250cm9sRWxlbWVudDo6 aXNEaXNhYmxlZEZvcm1Db250cm9sIGNvbnN0KTogRGVsZXRlZC4KKyAgICAgICAgKiBodG1sL0hU TUxGb3JtQ29udHJvbEVsZW1lbnQuaDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxGb3JtQ29udHJv bEVsZW1lbnQ6OmlzRGlzYWJsZWRGb3JtQ29udHJvbCBjb25zdCk6IE1vdmVkIHRoZSBkZWZpbml0 aW9uIGhlcmUuCisgICAgICAgIChXZWJDb3JlOjpIVE1MRm9ybUNvbnRyb2xFbGVtZW50Ojppc0Rp c2FibGVkT3JSZWFkT25seSBjb25zdCk6IENhbGwgaXNEaXNhYmxlZEZvcm1Db250cm9sIGluc3Rl YWQgb2YKKyAgICAgICAgZHVwbGljYXRpbmcgdGhlIGNvZGUgYXMgZG9uZSBpbiByMjcyMjk5Lgor CiAyMDIxLTAzLTA0ICBBZGl0eWEgS2VlcnRoaSAgPGFrZWVydGhpQGFwcGxlLmNvbT4KIAogICAg ICAgICBbaU9TXSBBZGQgbGVnYWN5IHByZWZpeCB0byB0aGUgZm9ybSBjb250cm9scyBVQSBzdHls ZXNoZWV0CkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxGb3JtQ29udHJvbEVsZW1lbnQu Y3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxl bWVudC5jcHAJKHJldmlzaW9uIDI3Mzk0OSkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZv cm1Db250cm9sRWxlbWVudC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM1NCwxMSArMzU0LDYgQEAg dm9pZCBIVE1MRm9ybUNvbnRyb2xFbGVtZW50OjpkaXNwYXRjaEZvcgogICAgIGRpc3BhdGNoSW5w dXRFdmVudCgpOwogfQogCi1ib29sIEhUTUxGb3JtQ29udHJvbEVsZW1lbnQ6OmlzRGlzYWJsZWRG b3JtQ29udHJvbCgpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIG1fZGlzYWJsZWQgfHwgbV9kaXNhYmxl ZEJ5QW5jZXN0b3JGaWVsZHNldDsKLX0KLQogYm9vbCBIVE1MRm9ybUNvbnRyb2xFbGVtZW50Ojpp c1JlcXVpcmVkKCkgY29uc3QKIHsKICAgICByZXR1cm4gbV9pc1JlcXVpcmVkOwpJbmRleDogU291 cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmgKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYkNvcmUvaHRtbC9IVE1MRm9ybUNvbnRyb2xFbGVtZW50LmgJKHJldmlzaW9uIDI3 Mzk0OSkKKysrIFNvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEZvcm1Db250cm9sRWxlbWVudC5oCSh3 b3JraW5nIGNvcHkpCkBAIC03Miw3ICs3Miw3IEBAIHB1YmxpYzoKICAgICB2b2lkIGRpc3BhdGNo Q2hhbmdlRXZlbnQoKTsKICAgICB2b2lkIGRpc3BhdGNoRm9ybUNvbnRyb2xJbnB1dEV2ZW50KCk7 CiAKLSAgICBib29sIGlzRGlzYWJsZWRGb3JtQ29udHJvbCgpIGNvbnN0IG92ZXJyaWRlOworICAg IGJvb2wgaXNEaXNhYmxlZEZvcm1Db250cm9sKCkgY29uc3QgZmluYWwgeyByZXR1cm4gbV9kaXNh YmxlZCB8fCBtX2Rpc2FibGVkQnlBbmNlc3RvckZpZWxkc2V0OyB9CiAKICAgICBib29sIGlzRW51 bWVyYXRhYmxlKCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4gZmFsc2U7IH0KIApAQCAtMTE0LDcg KzExNCw3IEBAIHB1YmxpYzoKICAgICB2b2lkIHNldEN1c3RvbVZhbGlkaXR5KGNvbnN0IFN0cmlu ZyYpIG92ZXJyaWRlOwogCiAgICAgYm9vbCBpc1JlYWRPbmx5KCkgY29uc3QgeyByZXR1cm4gbV9p c1JlYWRPbmx5OyB9Ci0gICAgYm9vbCBpc0Rpc2FibGVkT3JSZWFkT25seSgpIGNvbnN0IHsgcmV0 dXJuIG1fZGlzYWJsZWQgfHwgbV9kaXNhYmxlZEJ5QW5jZXN0b3JGaWVsZHNldCB8fCBtX2lzUmVh ZE9ubHk7IH0KKyAgICBib29sIGlzRGlzYWJsZWRPclJlYWRPbmx5KCkgY29uc3QgeyByZXR1cm4g aXNEaXNhYmxlZEZvcm1Db250cm9sKCkgfHwgbV9pc1JlYWRPbmx5OyB9CiAKICAgICBib29sIGhh c0F1dG9mb2N1c2VkKCkgeyByZXR1cm4gbV9oYXNBdXRvZm9jdXNlZDsgfQogICAgIHZvaWQgc2V0 QXV0b2ZvY3VzZWQoKSB7IG1faGFzQXV0b2ZvY3VzZWQgPSB0cnVlOyB9Cg==