222776 2021-03-04 20:07:24 -0800 Don't open a new window in MiniBrowser if already opening a file from the command line 2021-03-05 12:01:35 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 heycam heycam aakash_jain dino webkit-bug-importer oldest_to_newest 1736154 0 heycam 2021-03-04 20:07:24 -0800 Don't open a new window in MiniBrowser if already opening a file from the command line 1736155 1 422327 heycam 2021-03-04 20:09:18 -0800 Created attachment 422327 Patch 1736365 2 422327 dino 2021-03-05 09:01:42 -0800 Comment on attachment 422327 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422327&action=review > Tools/MiniBrowser/mac/AppDelegate.h:41 > + bool _openNewWindowAtStartup; It doesn't matter, but ObjC usually uses BOOL. > Tools/MiniBrowser/mac/AppDelegate.m:75 > + _openNewWindowAtStartup = true; ... making this YES. > Tools/MiniBrowser/mac/AppDelegate.m:271 > + _openNewWindowAtStartup = false; ... and this NO. 1736376 3 ews-feeder 2021-03-05 09:26:49 -0800 commit-queue failed to commit attachment 422327 to WebKit repository. To retry, please set cq+ flag again. 1736415 4 ews-feeder 2021-03-05 10:37:55 -0800 commit-queue failed to commit attachment 422327 to WebKit repository. To retry, please set cq+ flag again. 1736423 5 ews-feeder 2021-03-05 10:45:08 -0800 commit-queue failed to commit attachment 422327 to WebKit repository. To retry, please set cq+ flag again. 1736460 6 ews-feeder 2021-03-05 12:00:15 -0800 Committed r273993: <https://commits.webkit.org/r273993> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422327. 1736461 7 webkit-bug-importer 2021-03-05 12:01:35 -0800 <rdar://problem/75105616> 422327 2021-03-04 20:09:18 -0800 2021-03-05 12:00:16 -0800 Patch bug-222776-20210305150917.patch text/plain 2478 heycam U3VidmVyc2lvbiBSZXZpc2lvbjogMjczOTMzCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNDRhZjgxMzQ2ZmE4NjhkOTZjOTUyNTc4NmQ2OGQ5NTg0 YjFhNDY5ZS4uOTQ1MzkzYmE1MTQ1ZGQ4ODQ3YzJmNDFiZWNlN2Q3MDMxODVjYjNlMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDIxLTAzLTA0ICBDYW1lcm9uIE1jQ29ybWFjayAgPGhleWNhbUBhcHBsZS5jb20+CisK KyAgICAgICAgRG9uJ3Qgb3BlbiBhIG5ldyB3aW5kb3cgaW4gTWluaUJyb3dzZXIgaWYgYWxyZWFk eSBvcGVuaW5nIGEgZmlsZSBmcm9tIHRoZSBjb21tYW5kIGxpbmUKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjc3NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTWluaUJyb3dzZXIvbWFjL0FwcERlbGVn YXRlLmg6CisgICAgICAgICogTWluaUJyb3dzZXIvbWFjL0FwcERlbGVnYXRlLm06CisgICAgICAg ICgtW0Jyb3dzZXJBcHBEZWxlZ2F0ZSBpbml0XSk6CisgICAgICAgICgtW0Jyb3dzZXJBcHBEZWxl Z2F0ZSBhcHBsaWNhdGlvbkRpZEZpbmlzaExhdW5jaGluZzpdKToKKyAgICAgICAgKC1bQnJvd3Nl ckFwcERlbGVnYXRlIGFwcGxpY2F0aW9uOm9wZW5GaWxlOl0pOgorCiAyMDIxLTAzLTA0ICBBYWth c2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNvbT4KIAogICAgICAgICBSZWR1Y2UgdW5uZWNl c3NhcnkgbG9nZ2luZyBpbiBld3MtYXBwCmRpZmYgLS1naXQgYS9Ub29scy9NaW5pQnJvd3Nlci9t YWMvQXBwRGVsZWdhdGUuaCBiL1Rvb2xzL01pbmlCcm93c2VyL21hYy9BcHBEZWxlZ2F0ZS5oCmlu ZGV4IGNhOTgwMzZlNTE0OTE2OTViYzk3NmZlZGNkMTBjOWU2M2QzODYxNDQuLjM0ZWRjYzFkZDk0 OTVhOThmNWJjNTlkNGIwNDIxMjk5M2Y2NmViNmUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93 c2VyL21hYy9BcHBEZWxlZ2F0ZS5oCisrKyBiL1Rvb2xzL01pbmlCcm93c2VyL21hYy9BcHBEZWxl Z2F0ZS5oCkBAIC0zNyw2ICszNyw4IEBACiAgICAgSUJPdXRsZXQgTlNNZW51SXRlbSAqX25ld1dl YktpdDJXaW5kb3dJdGVtOwogICAgIElCT3V0bGV0IE5TTWVudUl0ZW0gKl9uZXdXZWJLaXQxRWRp dG9ySXRlbTsKICAgICBJQk91dGxldCBOU01lbnVJdGVtICpfbmV3V2ViS2l0MkVkaXRvckl0ZW07 CisKKyAgICBib29sIF9vcGVuTmV3V2luZG93QXRTdGFydHVwOwogfQogCiAtICh2b2lkKWJyb3dz ZXJXaW5kb3dXaWxsQ2xvc2U6KE5TV2luZG93ICopd2luZG93OwpkaWZmIC0tZ2l0IGEvVG9vbHMv TWluaUJyb3dzZXIvbWFjL0FwcERlbGVnYXRlLm0gYi9Ub29scy9NaW5pQnJvd3Nlci9tYWMvQXBw RGVsZWdhdGUubQppbmRleCA2NWMxNzNmZGJhZDkzZTVhYjMxZjllYzIzOGJiYjE1NWQ1Yjk4MDE0 Li43NWQ2OTFkZTI2YmZhOWYzZWRjMjBjNTMzMDBiN2EzMTQ5YjczOWRhIDEwMDY0NAotLS0gYS9U b29scy9NaW5pQnJvd3Nlci9tYWMvQXBwRGVsZWdhdGUubQorKysgYi9Ub29scy9NaW5pQnJvd3Nl ci9tYWMvQXBwRGVsZWdhdGUubQpAQCAtNzIsNiArNzIsNyBAQCAtIChpZClpbml0CiAgICAgaWYg KHNlbGYpIHsKICAgICAgICAgX2Jyb3dzZXJXaW5kb3dDb250cm9sbGVycyA9IFtbTlNNdXRhYmxl U2V0IGFsbG9jXSBpbml0XTsKICAgICAgICAgX2V4dGVuc2lvbk1hbmFnZXJXaW5kb3dDb250cm9s bGVyID0gW1tFeHRlbnNpb25NYW5hZ2VyV2luZG93Q29udHJvbGxlciBhbGxvY10gaW5pdF07Cisg ICAgICAgIF9vcGVuTmV3V2luZG93QXRTdGFydHVwID0gdHJ1ZTsKICAgICB9CiAKICAgICByZXR1 cm4gc2VsZjsKQEAgLTIzNCw2ICsyMzUsOSBAQCAtICh2b2lkKWFwcGxpY2F0aW9uRGlkRmluaXNo TGF1bmNoaW5nOihOU05vdGlmaWNhdGlvbiAqKWFOb3RpZmljYXRpb24KIAogICAgIFtzZWxmIF91 cGRhdGVOZXdXaW5kb3dLZXlFcXVpdmFsZW50c107CiAKKyAgICBpZiAoIV9vcGVuTmV3V2luZG93 QXRTdGFydHVwKQorICAgICAgICByZXR1cm47CisKICAgICBpZiAoX3NldHRpbmdzQ29udHJvbGxl ci5jcmVhdGVFZGl0b3JCeURlZmF1bHQpCiAgICAgICAgIFtzZWxmIG5ld0VkaXRvcldpbmRvdzpz ZWxmXTsKICAgICBlbHNlCkBAIC0yNjQsNiArMjY4LDcgQEAgLSAoQk9PTClhcHBsaWNhdGlvbjoo TlNBcHBsaWNhdGlvbiAqKXRoZUFwcGxpY2F0aW9uIG9wZW5GaWxlOihOU1N0cmluZyAqKWZpbGVu YW0KIAogICAgIFtjb250cm9sbGVyLndpbmRvdyBtYWtlS2V5QW5kT3JkZXJGcm9udDpzZWxmXTsK ICAgICBbY29udHJvbGxlciBsb2FkVVJMU3RyaW5nOltOU1VSTCBmaWxlVVJMV2l0aFBhdGg6Zmls ZW5hbWVdLmFic29sdXRlU3RyaW5nXTsKKyAgICBfb3Blbk5ld1dpbmRvd0F0U3RhcnR1cCA9IGZh bHNlOwogICAgIHJldHVybiBZRVM7CiB9CiAK