222774 2021-03-04 19:09:56 -0800 Canvas: drawImage should normalize srcRect before checking if it's empty 2021-03-05 15:07:51 -0800 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 lmoura lmoura aakash_jain bugs-noreply cdumez changseok clord darin dino esprehn+autocc ews-watchlist gyuyoung.kim webkit-bug-importer oldest_to_newest 1736139 0 lmoura 2021-03-04 19:09:56 -0800 Canvas: drawImage should normalize srcRect before checking if it's empty 1736140 1 422321 lmoura 2021-03-04 19:12:55 -0800 Created attachment 422321 Patch 1736378 2 ews-feeder 2021-03-05 09:30:28 -0800 commit-queue failed to commit attachment 422321 to WebKit repository. To retry, please set cq+ flag again. 1736419 3 ews-feeder 2021-03-05 10:41:36 -0800 commit-queue failed to commit attachment 422321 to WebKit repository. To retry, please set cq+ flag again. 1736452 4 ews-feeder 2021-03-05 11:26:52 -0800 Committed r273986: <https://commits.webkit.org/r273986> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422321. 1736453 5 webkit-bug-importer 2021-03-05 11:27:13 -0800 <rdar://problem/75103972> 1736576 6 422321 darin 2021-03-05 15:07:51 -0800 Comment on attachment 422321 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422321&action=review > Source/WebCore/html/canvas/CanvasRenderingContext2DBase.cpp:1697 > + if (!srcBitmapRect.contains(normalizedSrcRect) || !dstRect.width() || !dstRect.height()) Is the rendering correct in all the cases below when srcRect gets normalized? Noting that the code below uses srcRect not normalizedSrcRect. 422321 2021-03-04 19:12:55 -0800 2021-03-05 11:26:54 -0800 Patch bug-222774-20210305001254.patch text/plain 2450 lmoura U3VidmVyc2lvbiBSZXZpc2lvbjogMjczODg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzYyZWRiOTQzOGUwYmEw OWQ1NDVmYTQ3YTNlMTVhYjYwYTk0MDc3My4uOTBkZmFiMDI3MWFiN2I5ZWI2MTZhMWI3NDM0Mjdj Njc2MmIxZjEzNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDIxLTAzLTA0ICBMYXVy byBNb3VyYSAgPGxtb3VyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIENhbnZhczogZHJhd0ltYWdl IHNob3VsZCBub3JtYWxpemUgc3JjUmVjdCBiZWZvcmUgY2hlY2tpbmcgaWYgaXQncyBlbXB0eQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyNzc0CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRnJvbSA0LjEy LjUuMS4xNCBEcmF3aW5nIGltYWdlcywgc3RlcCA0OgorCisgICAgICAgICJUaGUgc291cmNlIHJl Y3RhbmdsZSBpcyB0aGUgcmVjdGFuZ2xlIHdob3NlIGNvcm5lcnMgYXJlIHRoZSBmb3VyCisgICAg ICAgIHBvaW50cyAoc3gsIHN5KSwgKHN4K3N3LCBzeSksIChzeCtzdywgc3krc2gpLCAoc3gsIHN5 K3NoKS4iCisKKyAgICAgICAgV2hlbiBhIG5lZ2F0aXZlIGhlaWdodC93aWR0aCBpcyBnaXZlbiwg ZS5nLiB5OjEwMCBhbmQgaGVpZ2h0Oi01MCwgaXQKKyAgICAgICAgc2hvdWxkIGJlIHRyZWF0ZWQg bGlrZSB0aGUgcmVjdCB3aXRoIHk6NTAsIGhlaWdodDogNTAgKGkuZS4gbm9ybWFsaXplZCksIHRv CisgICAgICAgIGF2b2lkIEZsb2F0UmVjdDppc0VtcHR5IHJldHVybmluZyB0cnVlLgorCisgICAg ICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdDoKKworICAgICAgICBpbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL2h0bWwvY2FudmFzL29mZnNjcmVlbi9kcmF3aW5nLWltYWdlcy10by10 aGUtY2FudmFzLzJkLmRyYXdJbWFnZS5uZWdhdGl2ZWRpci5odG1sCisKKyAgICAgICAgKiBodG1s L2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OkNhbnZhc1JlbmRlcmluZ0NvbnRleHQyREJhc2U6OmRyYXdJbWFnZSk6CisKIDIwMjEtMDMt MDQgIFphbGFuIEJ1anRhcyAgPHphbGFuQGFwcGxlLmNvbT4KIAogICAgICAgICBbTEZDXVtJRkNd IElubGluZUNvbnRlbnRCdWlsZGVyOjpjcmVhdGVEaXNwbGF5Tm9uUm9vdElubGluZUJveGVzIHNo b3VsZCBjaGVjayBpZiB0aGUgbGluZSBoYXMgaW5saW5lIGJveGVzIGF0IGFsbApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvaHRtbC9jYW52YXMvQ2FudmFzUmVuZGVyaW5nQ29udGV4dDJEQmFz ZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0 MkRCYXNlLmNwcAppbmRleCA5ZmYyMmE3YzNkNWRlY2NlNmE2NGJhYWE2YWNiZWMxMTZiMTAyYzBi Li4xYjY5ZjdjZTljNTJlNjE2Njc1ZjljYjNmYTg4NjIwYzAwZGRiOWI2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlLmNw cAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1sL2NhbnZhcy9DYW52YXNSZW5kZXJpbmdDb250ZXh0 MkRCYXNlLmNwcApAQCAtMTY4NywxMiArMTY4NywxNCBAQCBFeGNlcHRpb25Pcjx2b2lkPiBDYW52 YXNSZW5kZXJpbmdDb250ZXh0MkRCYXNlOjpkcmF3SW1hZ2UoSW1hZ2VCaXRtYXAmIGltYWdlQml0 bQogICAgIGlmICghaW1hZ2VCaXRtYXAud2lkdGgoKSB8fCAhaW1hZ2VCaXRtYXAuaGVpZ2h0KCkp CiAgICAgICAgIHJldHVybiBFeGNlcHRpb24geyBJbnZhbGlkU3RhdGVFcnJvciB9OwogCi0gICAg aWYgKHNyY1JlY3QuaXNFbXB0eSgpKQorICAgIGF1dG8gbm9ybWFsaXplZFNyY1JlY3QgPSBub3Jt YWxpemVSZWN0KHNyY1JlY3QpOworCisgICAgaWYgKG5vcm1hbGl6ZWRTcmNSZWN0LmlzRW1wdHko KSkKICAgICAgICAgcmV0dXJuIHsgfTsKIAogICAgIEZsb2F0UmVjdCBzcmNCaXRtYXBSZWN0ID0g RmxvYXRSZWN0KEZsb2F0UG9pbnQoKSwgRmxvYXRTaXplKGltYWdlQml0bWFwLndpZHRoKCksIGlt YWdlQml0bWFwLmhlaWdodCgpKSk7CiAKLSAgICBpZiAoIXNyY0JpdG1hcFJlY3QuY29udGFpbnMo bm9ybWFsaXplUmVjdChzcmNSZWN0KSkgfHwgIWRzdFJlY3Qud2lkdGgoKSB8fCAhZHN0UmVjdC5o ZWlnaHQoKSkKKyAgICBpZiAoIXNyY0JpdG1hcFJlY3QuY29udGFpbnMobm9ybWFsaXplZFNyY1Jl Y3QpIHx8ICFkc3RSZWN0LndpZHRoKCkgfHwgIWRzdFJlY3QuaGVpZ2h0KCkpCiAgICAgICAgIHJl dHVybiB7IH07CiAKICAgICBHcmFwaGljc0NvbnRleHQqIGMgPSBkcmF3aW5nQ29udGV4dCgpOwo=