<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>222767</bug_id>
          
          <creation_ts>2021-03-04 16:13:06 -0800</creation_ts>
          <short_desc>Make RegistrableDomain() private constructor take the String as an rvalue reference</short_desc>
          <delta_ts>2021-03-04 20:37:15 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebCore Misc.</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Chris Dumez">cdumez</reporter>
          <assigned_to name="Chris Dumez">cdumez</assigned_to>
          <cc>achristensen</cc>
    
    <cc>ggaren</cc>
    
    <cc>webkit-bug-importer</cc>
    
    <cc>wilander</cc>
    
    <cc>youennf</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1736084</commentid>
    <comment_count>0</comment_count>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2021-03-04 16:13:06 -0800</bug_when>
    <thetext>Mak RegistrableDomain() private constructor take the String as an rvalue reference. Most call sites have an rvalue reference and it reduces ref counting churn this way.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1736089</commentid>
    <comment_count>1</comment_count>
      <attachid>422306</attachid>
    <who name="Chris Dumez">cdumez</who>
    <bug_when>2021-03-04 16:14:43 -0800</bug_when>
    <thetext>Created attachment 422306
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1736166</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-03-04 20:36:18 -0800</bug_when>
    <thetext>Committed r273944: &lt;https://commits.webkit.org/r273944&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 422306.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1736167</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-03-04 20:37:15 -0800</bug_when>
    <thetext>&lt;rdar://problem/75075378&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>422306</attachid>
            <date>2021-03-04 16:14:43 -0800</date>
            <delta_ts>2021-03-04 20:36:19 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-222767-20210304161443.patch</filename>
            <type>text/plain</type>
            <size>2433</size>
            <attacher name="Chris Dumez">cdumez</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjczOTI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTFmMThlY2VhZjBiYjZm
YjY2MzlmNWVhMjM4ODFiNjI5MTgzZDExMy4uYTkwYzZkZjQ2ZjUwZDMyNjI4MTUzM2YwMTdhYTg2
ZDg4ZGRjYTkyNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIxLTAzLTA0ICBDaHJp
cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTWFrZSBSZWdpc3RyYWJsZURv
bWFpbigpIHByaXZhdGUgY29uc3RydWN0b3IgdGFrZSB0aGUgU3RyaW5nIGFzIGFuIHJ2YWx1ZSBy
ZWZlcmVuY2UKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTIyMjc2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg
IE1ha2UgUmVnaXN0cmFibGVEb21haW4oKSBwcml2YXRlIGNvbnN0cnVjdG9yIHRha2UgdGhlIFN0
cmluZyBhcyBhbiBydmFsdWUgcmVmZXJlbmNlLgorICAgICAgICBNb3N0IGNhbGwgc2l0ZXMgaGF2
ZSBhbiBydmFsdWUgcmVmZXJlbmNlIGFuZCBpdCByZWR1Y2VzIHJlZiBjb3VudGluZyBjaHVybiB0
aGlzIHdheS4KKworICAgICAgICAqIHBsYXRmb3JtL1JlZ2lzdHJhYmxlRG9tYWluLmg6CisgICAg
ICAgIChXZWJDb3JlOjpSZWdpc3RyYWJsZURvbWFpbjo6dW5jaGVja2VkQ3JlYXRlRnJvbVJlZ2lz
dHJhYmxlRG9tYWluU3RyaW5nKToKKyAgICAgICAgKFdlYkNvcmU6OlJlZ2lzdHJhYmxlRG9tYWlu
Ojp1bmNoZWNrZWRDcmVhdGVGcm9tSG9zdCk6CisgICAgICAgIChXZWJDb3JlOjpSZWdpc3RyYWJs
ZURvbWFpbjo6UmVnaXN0cmFibGVEb21haW4pOgorCiAyMDIxLTAzLTA0ICBDaHJpcyBEdW1leiAg
PGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAgUmVkdWNlIHVzZSBvZiBDRlJldGFpbigpIC8g
Q0ZSZWxlYXNlKCkgLyBDRkF1dG9SZWxlYXNlKCkgaW4gV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3Vy
Y2UvV2ViQ29yZS9wbGF0Zm9ybS9SZWdpc3RyYWJsZURvbWFpbi5oIGIvU291cmNlL1dlYkNvcmUv
cGxhdGZvcm0vUmVnaXN0cmFibGVEb21haW4uaAppbmRleCA0MDJmYmRhZjM2MTc2YmNmYjk4ZDBh
NDg2ZTBkOTlmYjVmZmQ3N2NlLi5hNWZhMDc3ZDE2NzE5Yjg2YWJkY2Y4Zjk3YTE2NzhmMzZmZmQ3
OTQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9SZWdpc3RyYWJsZURvbWFp
bi5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL1JlZ2lzdHJhYmxlRG9tYWluLmgKQEAg
LTgxLDcgKzgxLDcgQEAgcHVibGljOgogCiAgICAgc3RhdGljIFJlZ2lzdHJhYmxlRG9tYWluIHVu
Y2hlY2tlZENyZWF0ZUZyb21SZWdpc3RyYWJsZURvbWFpblN0cmluZyhjb25zdCBTdHJpbmcmIGRv
bWFpbikKICAgICB7Ci0gICAgICAgIHJldHVybiBSZWdpc3RyYWJsZURvbWFpbiB7IGRvbWFpbiB9
OworICAgICAgICByZXR1cm4gUmVnaXN0cmFibGVEb21haW4geyBTdHJpbmcgeyBkb21haW4gfSB9
OwogICAgIH0KICAgICAKICAgICBzdGF0aWMgUmVnaXN0cmFibGVEb21haW4gdW5jaGVja2VkQ3Jl
YXRlRnJvbUhvc3QoY29uc3QgU3RyaW5nJiBob3N0KQpAQCAtOTAsNyArOTAsNyBAQCBwdWJsaWM6
CiAgICAgICAgIGF1dG8gcmVnaXN0cmFibGVEb21haW4gPSB0b3BQcml2YXRlbHlDb250cm9sbGVk
RG9tYWluKGhvc3QpOwogICAgICAgICBpZiAocmVnaXN0cmFibGVEb21haW4uaXNFbXB0eSgpKQog
ICAgICAgICAgICAgcmV0dXJuIHVuY2hlY2tlZENyZWF0ZUZyb21SZWdpc3RyYWJsZURvbWFpblN0
cmluZyhob3N0KTsKLSAgICAgICAgcmV0dXJuIFJlZ2lzdHJhYmxlRG9tYWluIHsgcmVnaXN0cmFi
bGVEb21haW4gfTsKKyAgICAgICAgcmV0dXJuIFJlZ2lzdHJhYmxlRG9tYWluIHsgV1RGTW92ZShy
ZWdpc3RyYWJsZURvbWFpbikgfTsKICNlbHNlCiAgICAgICAgIHJldHVybiB1bmNoZWNrZWRDcmVh
dGVGcm9tUmVnaXN0cmFibGVEb21haW5TdHJpbmcoaG9zdCk7CiAjZW5kaWYKQEAgLTEwMiw4ICsx
MDIsOCBAQCBwdWJsaWM6CiBwcm90ZWN0ZWQ6CiAKIHByaXZhdGU6Ci0gICAgZXhwbGljaXQgUmVn
aXN0cmFibGVEb21haW4oY29uc3QgU3RyaW5nJiBkb21haW4pCi0gICAgICAgIDogbV9yZWdpc3Ry
YWJsZURvbWFpbiB7IGRvbWFpbi5pc0VtcHR5KCkgPyAibnVsbE9yaWdpbiJfcyA6IGRvbWFpbiB9
CisgICAgZXhwbGljaXQgUmVnaXN0cmFibGVEb21haW4oU3RyaW5nJiYgZG9tYWluKQorICAgICAg
ICA6IG1fcmVnaXN0cmFibGVEb21haW4geyBkb21haW4uaXNFbXB0eSgpID8gIm51bGxPcmlnaW4i
X3MgOiBXVEZNb3ZlKGRvbWFpbikgfQogICAgIHsKICAgICB9CiAK
</data>

          </attachment>
      

    </bug>

</bugzilla>