222744 2021-03-04 09:44:11 -0800 [ews] Add python 3 support - part 5 2021-03-04 16:10:50 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=222672 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap dean_johnson jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1735870 0 aakash_jain 2021-03-04 09:44:11 -0800 Add Python 3 support to ews code (to make it compatible with both Python 2 and 3). 1735906 1 422252 aakash_jain 2021-03-04 10:14:06 -0800 Created attachment 422252 Patch 1735907 2 aakash_jain 2021-03-04 10:17:10 -0800 This patch fixes the exception encountered in: https://ews-build.webkit-uat.org/#/builders/1/builds/1191 File "/var/buildbot/OpenSource/Tools/CISupport/ews-build/steps.py", line 409, in _patch_is_relevant if re.search(path, change, re.IGNORECASE): builtins.TypeError: cannot use a string pattern on a bytes-like object In python 3, buildbot stores the patch as 'bytes'. See: https://github.com/buildbot/buildbot/issues/5812#issuecomment-790175979. So, we should ensure that the search pattern is also bytes. 1735980 3 ews-feeder 2021-03-04 12:42:57 -0800 Committed r273913: <https://commits.webkit.org/r273913> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422252. 1735981 4 webkit-bug-importer 2021-03-04 12:43:18 -0800 <rdar://problem/75052319> 422252 2021-03-04 10:14:06 -0800 2021-03-04 12:42:58 -0800 Patch bug-222744-20210304131405.patch text/plain 2456 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3Mzg5OSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDIxLTAzLTA0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBBZGQgcHl0aG9uIDMgc3VwcG9ydCAtIHBhcnQgNQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyNzQ0CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBDSVN1cHBvcnQvZXdz LWJ1aWxkL3N0ZXBzLnB5OgorICAgICAgICAoQ2hlY2tQYXRjaFJlbGV2YW5jZS5fcGF0Y2hfaXNf cmVsZXZhbnQpOiBFbnN1cmUgdGhhdCBpbiBweXRob24gMywgcGF0aCBhbmQgY2hhbmdlcyBhcmUg Ynl0ZXMuIFRoaXMgaXMgYmVjYXVzZSBidWlsZGJvdAorICAgICAgICBzdG9yZXMgcGF0Y2ggYXMg Ynl0ZXMsIGFzIG1lbnRpb25lZCBpbiBodHRwczovL2dpdGh1Yi5jb20vYnVpbGRib3QvYnVpbGRi b3QvaXNzdWVzLzU4MTIjaXNzdWVjb21tZW50LTc5MDE3NTk3OQorICAgICAgICAqIENJU3VwcG9y dC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHk6IFVwZGF0ZWQgb25lIHVuaXQtdGVzdCB0byB0 ZXN0IGJpbmFyeSBwYXRjaC4KKwogMjAyMS0wMy0wNCAgQWxleCBDaHJpc3RlbnNlbiAgPGFjaHJp c3RlbnNlbkB3ZWJraXQub3JnPgogCiAgICAgICAgIEludHJvZHVjZSAid2Vic29ja2V0IiwgImZl dGNoIiwgYW5kICJvdGhlciIgcmVzb3VyY2UgdHlwZXMgdG8gV0tDb250ZW50UnVsZUxpc3QKSW5k ZXg6IFRvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHMucHkKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9v bHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkocmV2aXNpb24gMjczODk3KQorKysgVG9v bHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwcy5weQkod29ya2luZyBjb3B5KQpAQCAtNDA2LDYg KzQwNiwxMSBAQCBjbGFzcyBDaGVja1BhdGNoUmVsZXZhbmNlKGJ1aWxkc3RlcC5CdWlsCiAKICAg ICAgICAgZm9yIGNoYW5nZSBpbiBwYXRjaC5zcGxpdGxpbmVzKCk6CiAgICAgICAgICAgICBmb3Ig cGF0aCBpbiByZWxldmFudF9wYXRoczoKKyAgICAgICAgICAgICAgICBpZiBzeXMudmVyc2lvbl9p bmZvID4gKDMsIDApOgorICAgICAgICAgICAgICAgICAgICBpZiB0eXBlKHBhdGgpID09IHN0cjoK KyAgICAgICAgICAgICAgICAgICAgICAgIHBhdGggPSBwYXRoLmVuY29kZShlbmNvZGluZz0ndXRm LTgnLCBlcnJvcnM9J3JlcGxhY2UnKQorICAgICAgICAgICAgICAgICAgICBpZiB0eXBlKGNoYW5n ZSkgPT0gc3RyOgorICAgICAgICAgICAgICAgICAgICAgICAgY2hhbmdlID0gY2hhbmdlLmVuY29k ZShlbmNvZGluZz0ndXRmLTgnLCBlcnJvcnM9J3JlcGxhY2UnKQogICAgICAgICAgICAgICAgIGlm IHJlLnNlYXJjaChwYXRoLCBjaGFuZ2UsIHJlLklHTk9SRUNBU0UpOgogICAgICAgICAgICAgICAg ICAgICByZXR1cm4gVHJ1ZQogICAgICAgICByZXR1cm4gRmFsc2UKSW5kZXg6IFRvb2xzL0NJU3Vw cG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvQ0lT dXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkocmV2aXNpb24gMjczODk3KQorKysg VG9vbHMvQ0lTdXBwb3J0L2V3cy1idWlsZC9zdGVwc191bml0dGVzdC5weQkod29ya2luZyBjb3B5 KQpAQCAtMjQzNyw3ICsyNDM3LDcgQEAgY2xhc3MgVGVzdENoZWNrUGF0Y2hSZWxldmFuY2UoQnVp bGRTdGVwTQogICAgICAgICByZXR1cm4gcmMKIAogICAgIGRlZiB0ZXN0X3JlbGV2YW50X3dpbmRv d3Nfd2sxX3BhdGNoKHNlbGYpOgotICAgICAgICBDaGVja1BhdGNoUmVsZXZhbmNlLl9nZXRfcGF0 Y2ggPSBsYW1iZGEgeDogJ1NhbXBsZSBwYXRjaDsgZmlsZTogU291cmNlL1dlYktpdExlZ2FjeScK KyAgICAgICAgQ2hlY2tQYXRjaFJlbGV2YW5jZS5fZ2V0X3BhdGNoID0gbGFtYmRhIHg6IGInU2Ft cGxlIHBhdGNoOyBmaWxlOiBTb3VyY2UvV2ViS2l0TGVnYWN5JwogICAgICAgICBzZWxmLnNldHVw U3RlcChDaGVja1BhdGNoUmVsZXZhbmNlKCkpCiAgICAgICAgIHNlbGYuc2V0UHJvcGVydHkoJ2J1 aWxkZXJuYW1lJywgJ1dpbmRvd3MtRVdTJykKICAgICAgICAgc2VsZi5leHBlY3RPdXRjb21lKHJl c3VsdD1TVUNDRVNTLCBzdGF0ZV9zdHJpbmc9J1BhdGNoIGNvbnRhaW5zIHJlbGV2YW50IGNoYW5n ZXMnKQo=