222740 2021-03-04 08:29:04 -0800 Web Inspector: Audits Tab: nothing happens when clicking "Start" button in the content area placeholder text 2021-03-04 10:19:22 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 rcaliman rcaliman ews-watchlist hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1735838 0 rcaliman 2021-03-04 08:29:04 -0800 rdar://75008042 Regressed by: https://bugs.webkit.org/show_bug.cgi?id=196956 1735842 1 422233 rcaliman 2021-03-04 08:34:03 -0800 Created attachment 422233 Patch 1735849 2 422233 hi 2021-03-04 09:00:47 -0800 Comment on attachment 422233 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422233&action=review > Source/WebInspectorUI/UserInterface/Views/AuditTestContentView.js:347 > + startNavigationItem.addEventListener(WI.ButtonNavigationItem.Event.Clicked, (event) => { Rather than turn this into an arrow function that will capture `this` (which will keep it alive), I think we should replace the `startNavigationItem` 3rd argument with `this` instead so that the `thisObject` that the function is invoked with will be `this` instead of `startNavigationItem`. 1735854 3 rcaliman 2021-03-04 09:15:15 -0800 <rdar://75008042> 1735857 4 422238 rcaliman 2021-03-04 09:25:33 -0800 Created attachment 422238 Patch 1735866 5 422238 hi 2021-03-04 09:41:47 -0800 Comment on attachment 422238 Patch r=me 1735908 6 ews-feeder 2021-03-04 10:19:20 -0800 Committed r273900: <https://commits.webkit.org/r273900> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422238. 422233 2021-03-04 08:34:03 -0800 2021-03-04 09:25:25 -0800 Patch bug-222740-20210304173401.patch text/plain 1862 rcaliman ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDI2ZjI2OWU5ZjNhNTI2Y2MwNmYyODIzODk3OTcw MDU2YjJhZThjYTguLjA1MzU4Yzc0NmMyNmI1NTNjZWVhNDk5YTEwZDVlYmQxZDIxNDhhMzkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTAzLTA0ICBSYXp2 YW4gQ2FsaW1hbiAgPHJjYWxpbWFuQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBBdWRpdHMgVGFiOiBub3RoaW5nIGhhcHBlbnMgd2hlbiBjbGlja2luZyAiU3RhcnQiIGJ1dHRv biBpbiB0aGUgY29udGVudCBhcmVhIHBsYWNlaG9sZGVyIHRleHQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjc0MAorICAgICAgICByZGFyOi8vNzUw MDgwNDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFVzZXJJbnRlcmZhY2UvVmlld3MvQXVkaXRUZXN0Q29udGVudFZpZXcuanM6CisgICAgICAgIChX SS5BdWRpdFRlc3RDb250ZW50Vmlldy5wcm90b3R5cGUuc2hvd05vUmVzdWx0UGxhY2Vob2xkZXIp OgorCiAyMDIxLTAzLTAzICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBgUmVjb3JkQ2FudmFzQWN0aW9uVmFyaWFudGAgY2F1c2VzIGEg aHVnZSBzeW1ib2wgdG8gYmUgY3JlYXRlZCBpbiBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9BdWRpdFRlc3RDb250ZW50Vmlldy5q cyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0F1ZGl0VGVzdENv bnRlbnRWaWV3LmpzCmluZGV4IDFlYjZiYjY2NmM5NTE2N2Q2OTk1YjY0ZTU5ZTI3M2RhYzQ0NGE4 ZjMuLjVmNjY0ZDRlNjk5MTM2ZGMwN2M4YjE5ZTdkYmE1ZDIxNTBlMjdiNTggMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0F1ZGl0VGVzdENvbnRl bnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0F1ZGl0VGVzdENvbnRlbnRWaWV3LmpzCkBAIC0zNDQsNyArMzQ0LDcgQEAgV0kuQXVkaXRUZXN0 Q29udGVudFZpZXcgPSBjbGFzcyBBdWRpdFRlc3RDb250ZW50VmlldyBleHRlbmRzIFdJLkNvbnRl bnRWaWV3CiAKICAgICAgICAgICAgIGxldCBzdGFydE5hdmlnYXRpb25JdGVtID0gbmV3IFdJLkJ1 dHRvbk5hdmlnYXRpb25JdGVtKCJydW4tYXVkaXQiLCBXSS5VSVN0cmluZygiU3RhcnQiKSwgIklt YWdlcy9BdWRpdFN0YXJ0LnN2ZyIsIDE1LCAxNSk7CiAgICAgICAgICAgICBzdGFydE5hdmlnYXRp b25JdGVtLmJ1dHRvblN0eWxlID0gV0kuQnV0dG9uTmF2aWdhdGlvbkl0ZW0uU3R5bGUuSW1hZ2VB bmRUZXh0OwotICAgICAgICAgICAgc3RhcnROYXZpZ2F0aW9uSXRlbS5hZGRFdmVudExpc3RlbmVy KFdJLkJ1dHRvbk5hdmlnYXRpb25JdGVtLkV2ZW50LkNsaWNrZWQsIGZ1bmN0aW9uKGV2ZW50KSB7 CisgICAgICAgICAgICBzdGFydE5hdmlnYXRpb25JdGVtLmFkZEV2ZW50TGlzdGVuZXIoV0kuQnV0 dG9uTmF2aWdhdGlvbkl0ZW0uRXZlbnQuQ2xpY2tlZCwgKGV2ZW50KSA9PiB7CiAgICAgICAgICAg ICAgICAgV0kuYXVkaXRNYW5hZ2VyLnN0YXJ0KFt0aGlzLnJlcHJlc2VudGVkT2JqZWN0XSk7CiAg ICAgICAgICAgICB9LCBzdGFydE5hdmlnYXRpb25JdGVtKTsKIAo= 422238 2021-03-04 09:25:33 -0800 2021-03-04 10:19:21 -0800 Patch bug-222740-20210304182531.patch text/plain 1854 rcaliman ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDI2ZjI2OWU5ZjNhNTI2Y2MwNmYyODIzODk3OTcw MDU2YjJhZThjYTguLjA1MzU4Yzc0NmMyNmI1NTNjZWVhNDk5YTEwZDVlYmQxZDIxNDhhMzkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTAzLTA0ICBSYXp2 YW4gQ2FsaW1hbiAgPHJjYWxpbWFuQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBBdWRpdHMgVGFiOiBub3RoaW5nIGhhcHBlbnMgd2hlbiBjbGlja2luZyAiU3RhcnQiIGJ1dHRv biBpbiB0aGUgY29udGVudCBhcmVhIHBsYWNlaG9sZGVyIHRleHQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjc0MAorICAgICAgICByZGFyOi8vNzUw MDgwNDIKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAq IFVzZXJJbnRlcmZhY2UvVmlld3MvQXVkaXRUZXN0Q29udGVudFZpZXcuanM6CisgICAgICAgIChX SS5BdWRpdFRlc3RDb250ZW50Vmlldy5wcm90b3R5cGUuc2hvd05vUmVzdWx0UGxhY2Vob2xkZXIp OgorCiAyMDIxLTAzLTAzICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAg ICAgICBXZWIgSW5zcGVjdG9yOiBgUmVjb3JkQ2FudmFzQWN0aW9uVmFyaWFudGAgY2F1c2VzIGEg aHVnZSBzeW1ib2wgdG8gYmUgY3JlYXRlZCBpbiBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9BdWRpdFRlc3RDb250ZW50Vmlldy5q cyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0F1ZGl0VGVzdENv bnRlbnRWaWV3LmpzCmluZGV4IDFlYjZiYjY2NmM5NTE2N2Q2OTk1YjY0ZTU5ZTI3M2RhYzQ0NGE4 ZjMuLjcxNGJjYTExMWI1MGJlNTA2OWEyYWUzYzgxNWI5NWQ4YmU2NGE4YTYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0F1ZGl0VGVzdENvbnRl bnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdz L0F1ZGl0VGVzdENvbnRlbnRWaWV3LmpzCkBAIC0zNDYsNyArMzQ2LDcgQEAgV0kuQXVkaXRUZXN0 Q29udGVudFZpZXcgPSBjbGFzcyBBdWRpdFRlc3RDb250ZW50VmlldyBleHRlbmRzIFdJLkNvbnRl bnRWaWV3CiAgICAgICAgICAgICBzdGFydE5hdmlnYXRpb25JdGVtLmJ1dHRvblN0eWxlID0gV0ku QnV0dG9uTmF2aWdhdGlvbkl0ZW0uU3R5bGUuSW1hZ2VBbmRUZXh0OwogICAgICAgICAgICAgc3Rh cnROYXZpZ2F0aW9uSXRlbS5hZGRFdmVudExpc3RlbmVyKFdJLkJ1dHRvbk5hdmlnYXRpb25JdGVt LkV2ZW50LkNsaWNrZWQsIGZ1bmN0aW9uKGV2ZW50KSB7CiAgICAgICAgICAgICAgICAgV0kuYXVk aXRNYW5hZ2VyLnN0YXJ0KFt0aGlzLnJlcHJlc2VudGVkT2JqZWN0XSk7Ci0gICAgICAgICAgICB9 LCBzdGFydE5hdmlnYXRpb25JdGVtKTsKKyAgICAgICAgICAgIH0sIHRoaXMpOwogCiAgICAgICAg ICAgICBsZXQgaW1wb3J0SGVscEVsZW1lbnQgPSBXSS5jcmVhdGVOYXZpZ2F0aW9uSXRlbUhlbHAo V0kuVUlTdHJpbmcoIlByZXNzICVzIHRvIHN0YXJ0IHJ1bm5pbmcgdGhlIGF1ZGl0LiIpLCBzdGFy dE5hdmlnYXRpb25JdGVtKTsKICAgICAgICAgICAgIHRoaXMucGxhY2Vob2xkZXJFbGVtZW50LmFw cGVuZENoaWxkKGltcG9ydEhlbHBFbGVtZW50KTsK