222724 2021-03-04 01:46:58 -0800 nullopt in ReadableStreamSource::controller() via FileReaderLoader::failed 2021-03-04 23:15:30 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 rniwa webkit-unassigned achristensen bfulgham cgarcia ews-feeder fred.wang gpoo product-security rbuis sihui_liu svillar webkit-bug-importer youennf oldest_to_newest 1735745 0 422202 rniwa 2021-03-04 01:46:58 -0800 Created attachment 422202 Test e.g. Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x000000011e1e3596 WTF::Optional<WebCore::ReadableStreamDefaultController>::value() & + 38 (Optional.h:550) 1 com.apple.WebCore 0x000000011e1e356d WebCore::ReadableStreamSource::controller() + 13 (ReadableStreamSource.h:49) 2 com.apple.WebCore 0x000000011fc1b031 WebCore::Blob::stream(WebCore::ScriptExecutionContext&)::BlobStreamSource::didFail(WebCore::ExceptionCode) + 193 (Blob.cpp:287) 3 com.apple.WebCore 0x000000011fc3ca6f WebCore::FileReaderLoader::failed(WebCore::ExceptionCode) + 319 (FileReaderLoader.cpp:243) 4 com.apple.WebCore 0x000000011fc3def3 WebCore::FileReaderLoader::didFail(WebCore::ResourceError const&) + 99 (FileReaderLoader.cpp:235) 5 com.apple.WebCore 0x0000000120656c88 WebCore::DocumentThreadableLoader::logErrorAndFail(WebCore::ResourceError const&) + 264 (DocumentThreadableLoader.cpp:736) 6 com.apple.WebCore 0x000000012065780e WebCore::DocumentThreadableLoader::loadRequest(WebCore::ResourceRequest&&, WebCore::SecurityCheckPolicy) + 2414 (DocumentThreadableLoader.cpp:578) 7 com.apple.WebCore 0x000000012065636f WebCore::DocumentThreadableLoader::DocumentThreadableLoader(WebCore::Document&, WebCore::ThreadableLoaderClient&, WebCore::DocumentThreadableLoader::BlockingBehavior, WebCore::ResourceRequest&&, WebCore::ThreadableLoaderOptions const&, WTF::RefPtr<WebCore::SecurityOrigin, WTF::RawPtrTraits<WebCore::SecurityOrigin>, WTF::DefaultRefDerefTraits<WebCore::SecurityOrigin> >&&, std::__1::unique_ptr<WebCore::ContentSecurityPolicy, std::__1::default_delete<WebCore::ContentSecurityPolicy> >&&, WTF::String&&, WebCore::DocumentThreadableLoader::ShouldLogError) + 2111 (DocumentThreadableLoader.cpp:174) 8 com.apple.WebCore 0x0000000120655216 WebCore::DocumentThreadableLoader::DocumentThreadableLoader(WebCore::Document&, WebCore::ThreadableLoaderClient&, WebCore::DocumentThreadableLoader::BlockingBehavior, WebCore::ResourceRequest&&, WebCore::ThreadableLoaderOptions const&, WTF::RefPtr<WebCore::SecurityOrigin, WTF::RawPtrTraits<WebCore::SecurityOrigin>, WTF::DefaultRefDerefTraits<WebCore::SecurityOrigin> >&&, std::__1::unique_ptr<WebCore::ContentSecurityPolicy, std::__1::default_delete<WebCore::ContentSecurityPolicy> >&&, WTF::String&&, WebCore::DocumentThreadableLoader::ShouldLogError) + 22 (DocumentThreadableLoader.cpp:129) 9 com.apple.WebCore 0x00000001206554e6 WebCore::DocumentThreadableLoader::create(WebCore::Document&, WebCore::ThreadableLoaderClient&, WebCore::ResourceRequest&&, WebCore::ThreadableLoaderOptions const&, WTF::RefPtr<WebCore::SecurityOrigin, WTF::RawPtrTraits<WebCore::SecurityOrigin>, WTF::DefaultRefDerefTraits<WebCore::SecurityOrigin> >&&, std::__1::unique_ptr<WebCore::ContentSecurityPolicy, std::__1::default_delete<WebCore::ContentSecurityPolicy> >&&, WTF::String&&, WebCore::DocumentThreadableLoader::ShouldLogError) + 166 (DocumentThreadableLoader.cpp:88) 10 com.apple.WebCore 0x0000000120655869 WebCore::DocumentThreadableLoader::create(WebCore::Document&, WebCore::ThreadableLoaderClient&, WebCore::ResourceRequest&&, WebCore::ThreadableLoaderOptions const&, WTF::String&&) + 345 (DocumentThreadableLoader.cpp:96) 11 com.apple.WebCore 0x00000001207611b8 WebCore::ThreadableLoader::create(WebCore::ScriptExecutionContext&, WebCore::ThreadableLoaderClient&, WebCore::ResourceRequest&&, WebCore::ThreadableLoaderOptions const&, WTF::String&&, WTF::String&&) + 520 (ThreadableLoader.cpp:115) 12 com.apple.WebCore 0x000000011fc3c6a7 WebCore::FileReaderLoader::start(WebCore::ScriptExecutionContext*, WebCore::Blob&) + 1079 (FileReaderLoader.cpp:99) 13 com.apple.WebCore 0x000000011fc1aa97 WebCore::Blob::stream(WebCore::ScriptExecutionContext&)::BlobStreamSource::BlobStreamSource(WebCore::ScriptExecutionContext&, WebCore::Blob&) + 423 (Blob.cpp:251) 14 com.apple.WebCore 0x000000011fc0e2f9 WebCore::Blob::stream(WebCore::ScriptExecutionContext&)::BlobStreamSource::BlobStreamSource(WebCore::ScriptExecutionContext&, WebCore::Blob&) + 9 (Blob.cpp:250) 15 com.apple.WebCore 0x000000011fc0e0b7 WebCore::Blob::stream(WebCore::ScriptExecutionContext&) + 311 (Blob.cpp:297) 16 com.apple.WebCore 0x000000011c56d8ba WebCore::jsBlobPrototypeFunction_streamBody(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSBlob*) + 330 (JSBlob.cpp:292) 17 com.apple.WebCore 0x000000011c56d6c7 long long WebCore::IDLOperation<WebCore::JSBlob>::call<&(WebCore::jsBlobPrototypeFunction_streamBody(JSC::JSGlobalObject*, JSC::CallFrame*, WebCore::JSBlob*)), (WebCore::CastedThisErrorBehavior)0>(JSC::JSGlobalObject&, JSC::CallFrame&, char const*) + 247 (JSDOMOperation.h:53) 18 com.apple.WebCore 0x000000011c56cc09 WebCore::jsBlobPrototypeFunction_stream(JSC::JSGlobalObject*, JSC::CallFrame*) + 9 (JSBlob.cpp:297) 19 ??? 0x0000573f0cc011d8 0 + 95928308470232 <rdar://problem/74638237> 1735746 1 rniwa 2021-03-04 01:47:45 -0800 Reproduced with WebKitTestRunner and DumpRenderTree at r273811. 1735778 2 youennf 2021-03-04 04:54:44 -0800 The issue is that the failure is synchronous, so stream is not started when getting the failure. Will fix it. 1735790 3 422216 youennf 2021-03-04 05:39:24 -0800 Created attachment 422216 Patch 1735839 4 ews-feeder 2021-03-04 08:32:30 -0800 Committed r273890: <https://commits.webkit.org/r273890> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422216. 1736177 5 rniwa 2021-03-04 22:03:22 -0800 Is there any security implication or no? 1736185 6 achristensen 2021-03-04 22:49:52 -0800 I don't think so. It was just hitting a release assert 1736193 7 rniwa 2021-03-04 23:15:30 -0800 (In reply to Alex Christensen from comment #6) > I don't think so. It was just hitting a release assert Thanks for the confirmation. 422202 2021-03-04 01:46:58 -0800 2021-03-04 01:46:58 -0800 Test repro_524.html text/html 76 rniwa PHNjcmlwdD4KICBvbnVubG9hZCA9ICgpID0+IHsKICAgIG5ldyBGaWxlKFtdLCAnJykuc3RyZWFt KCk7CiAgfTsKPC9zY3JpcHQ+Cg== 422216 2021-03-04 05:39:24 -0800 2021-03-04 08:32:31 -0800 Patch bug-222724-20210304143922.patch text/plain 4516 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjczODE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmVkNDQ2MTI5OGE3NjEy N2ZkZWQ0YmVhYTIzZWI1YTE3YzNlYzI4Ny4uZGNhYjZmODE4YWI1MGIxYjQ4Yjk5MWM2ZGQ2ZjI2 MGUyNzRjYTEyZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAzLTA0ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBIYW5kbGUgdGhlIGNhc2Ug b2Ygc3luY2hyb25vdXMgZmFpbHVyZSBpbiBsb2FkaW5nIGJsb2IuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI3MjQKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUZXN0OiBodHRwL3Rlc3RzL2ZldGNoL2Js b2ItaW4tdW5sb2FkLWV2ZW50LWhhbmRsZXIuaHRtbAorCisgICAgICAgICogZmlsZWFwaS9CbG9i LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkJsb2I6OnN0cmVhbSk6CisgICAgICAgIEluIGNhc2Ug b2Ygc3luY2hyb25vdXMgZmFpbHVyZSwgd2FpdCBmb3IgdGhlIHN0cmVhbSB0byBiZSBzdGFydGVk IHRvIGVycm9yIGl0LgorCiAyMDIxLTAzLTA0ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxl LmNvbT4KIAogICAgICAgICBBVkF1ZGlvU2Vzc2lvbkNhcHR1cmVEZXZpY2VNYW5hZ2VyOjpyZXRy aWV2ZUF1ZGlvU2Vzc2lvbkNhcHR1cmVEZXZpY2VzIGlzIHVubmVjZXNzYXJpbHkgY3JlYXRpbmcg YSBOU0FycmF5IHR3aWNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9maWxlYXBpL0Jsb2Iu Y3BwIGIvU291cmNlL1dlYkNvcmUvZmlsZWFwaS9CbG9iLmNwcAppbmRleCBkNjFlMTBmM2Q3MzQ5 MTI0Yjc2NTExNTMyNWFiNjViZjJmMWI5MjFiLi4zN2FkZWI3NTBmNWM0MWViODcyNWY3NWMwNjkw ZTc0MjhjN2MzYzhkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9maWxlYXBpL0Jsb2IuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2ZpbGVhcGkvQmxvYi5jcHAKQEAgLTI1NSw3ICsyNTUsMTMg QEAgRXhjZXB0aW9uT3I8UmVmPFJlYWRhYmxlU3RyZWFtPj4gQmxvYjo6c3RyZWFtKFNjcmlwdEV4 ZWN1dGlvbkNvbnRleHQmIHNjcmlwdEV4ZWMKICAgICAgICAgLy8gUmVhZGFibGVTdHJlYW1Tb3Vy Y2UKICAgICAgICAgdm9pZCBzZXRBY3RpdmUoKSBmaW5hbCB7IH0KICAgICAgICAgdm9pZCBzZXRJ bmFjdGl2ZSgpIGZpbmFsIHsgfQotICAgICAgICB2b2lkIGRvU3RhcnQoKSBmaW5hbCB7IH0KKyAg ICAgICAgdm9pZCBkb1N0YXJ0KCkgZmluYWwKKyAgICAgICAgeworICAgICAgICAgICAgbV9pc1N0 YXJ0ZWQgPSB0cnVlOworICAgICAgICAgICAgaWYgKG1fZXhjZXB0aW9uKQorICAgICAgICAgICAg ICAgIGNvbnRyb2xsZXIoKS5lcnJvcigqbV9leGNlcHRpb24pOworICAgICAgICB9CisKICAgICAg ICAgdm9pZCBkb1B1bGwoKSBmaW5hbCB7IH0KICAgICAgICAgdm9pZCBkb0NhbmNlbCgpIGZpbmFs CiAgICAgICAgIHsKQEAgLTI4MiwxMyArMjg4LDIwIEBAIEV4Y2VwdGlvbk9yPFJlZjxSZWFkYWJs ZVN0cmVhbT4+IEJsb2I6OnN0cmVhbShTY3JpcHRFeGVjdXRpb25Db250ZXh0JiBzY3JpcHRFeGVj CiAgICAgICAgIHsKICAgICAgICAgICAgIGNvbnRyb2xsZXIoKS5jbG9zZSgpOwogICAgICAgICB9 Ci0gICAgICAgIHZvaWQgZGlkRmFpbChFeGNlcHRpb25Db2RlIGV4Y2VwdGlvbikgZmluYWwKKyAg ICAgICAgdm9pZCBkaWRGYWlsKEV4Y2VwdGlvbkNvZGUgY29kZSkgZmluYWwKICAgICAgICAgewot ICAgICAgICAgICAgY29udHJvbGxlcigpLmVycm9yKEV4Y2VwdGlvbiB7IGV4Y2VwdGlvbiB9KTsK KyAgICAgICAgICAgIEV4Y2VwdGlvbiBleGNlcHRpb24geyBjb2RlIH07CisgICAgICAgICAgICBp ZiAoIW1faXNTdGFydGVkKSB7CisgICAgICAgICAgICAgICAgbV9leGNlcHRpb24gPSBXVEZNb3Zl KGV4Y2VwdGlvbik7CisgICAgICAgICAgICAgICAgcmV0dXJuOworICAgICAgICAgICAgfQorICAg ICAgICAgICAgY29udHJvbGxlcigpLmVycm9yKGV4Y2VwdGlvbik7CiAgICAgICAgIH0KIAogICAg ICAgICBVbmlxdWVSZWY8RmlsZVJlYWRlckxvYWRlcj4gbV9sb2FkZXI7CiAgICAgICAgIHNpemVf dCBtX2J5dGVzUmVhZCB7IDAgfTsKKyAgICAgICAgYm9vbCBtX2lzU3RhcnRlZCB7IGZhbHNlIH07 CisgICAgICAgIE9wdGlvbmFsPEV4Y2VwdGlvbj4gbV9leGNlcHRpb247CiAgICAgfTsKIAogICAg IGF1dG8qIGdsb2JhbE9iamVjdCA9IHNjcmlwdEV4ZWN1dGlvbkNvbnRleHQuZ2xvYmFsT2JqZWN0 KCk7CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKaW5kZXggNDllNWI4MjUwOGRhMjgzOTE4YzIwYThmODc3OGUxMDA0NjE3OWJiNy4uNDg2 MGY4ZWFjZTMzOGJiYWQ5YzlmYTk0YzkyYTQwNTljYWU0Njk2MiAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDIxLTAzLTA0ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAg ICAgICBIYW5kbGUgdGhlIGNhc2Ugb2Ygc3luY2hyb25vdXMgZmFpbHVyZSBpbiBsb2FkaW5nIGJs b2IuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI3 MjQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIGh0 dHAvdGVzdHMvZmV0Y2gvYmxvYi1pbi11bmxvYWQtZXZlbnQtaGFuZGxlci1leHBlY3RlZC50eHQ6 IEFkZGVkLgorICAgICAgICAqIGh0dHAvdGVzdHMvZmV0Y2gvYmxvYi1pbi11bmxvYWQtZXZlbnQt aGFuZGxlci5odG1sOiBBZGRlZC4KKwogMjAyMS0wMy0wNCAgWW91ZW5uIEZhYmxldCAgPHlvdWVu bkBhcHBsZS5jb20+CiAKICAgICAgICAgSW4gY2FzZSBvZiBQT1NUIG5hdmlnYXRpb24gcmVkaXJl Y3RlZCBieSBhIDMwMiwgdGhlICdPcmlnaW4nIGhlYWRlciBpcyBrZXB0IGluIHRoZSByZWRpcmVj dGVkIHJlcXVlc3QKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvZmV0Y2gvYmxv Yi1pbi11bmxvYWQtZXZlbnQtaGFuZGxlci1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9odHRw L3Rlc3RzL2ZldGNoL2Jsb2ItaW4tdW5sb2FkLWV2ZW50LWhhbmRsZXItZXhwZWN0ZWQudHh0Cm5l dyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAuLjRjNzM1MjYwOGM3ODVhYjlkYjE4OWFkY2JmOWU5NjFkOTkzMzhjMzYKLS0tIC9k ZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2ZldGNoL2Jsb2ItaW4tdW5sb2Fk LWV2ZW50LWhhbmRsZXItZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMiBAQAorbWFpbiBmcmFtZSAt IGhhcyAxIG9udW5sb2FkIGhhbmRsZXIocykKK1BBU1MKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L2h0dHAvdGVzdHMvZmV0Y2gvYmxvYi1pbi11bmxvYWQtZXZlbnQtaGFuZGxlci5odG1sIGIvTGF5 b3V0VGVzdHMvaHR0cC90ZXN0cy9mZXRjaC9ibG9iLWluLXVubG9hZC1ldmVudC1oYW5kbGVyLmh0 bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMC4uOTA3MDZjZDM1ZmVjOGFmNDI0Y2JkNzlkYWRmYjI5ZWFjZjYzMzc0Ygot LS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2h0dHAvdGVzdHMvZmV0Y2gvYmxvYi1pbi11 bmxvYWQtZXZlbnQtaGFuZGxlci5odG1sCkBAIC0wLDAgKzEsMjYgQEAKKzwhZG9jdHlwZSBodG1s PjwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsgZHVtcEpTQ29uc29sZUxvZ0luU3RkRXJyPXRydWUg XSAtLT4KKzxodG1sPgorICAgIDxoZWFkPgorICAgICAgICA8bWV0YSBjaGFyc2V0PSJ1dGYtOCI+ CisgICAgICAgIDx0aXRsZT5CbG9icyBpbiB1bmxvYWQgZXZlbnQgaGFuZGxlcjwvdGl0bGU+Cisg ICAgPC9oZWFkPgorICAgIDxib2R5PgorPHNjcmlwdD4KK2lmICh3aW5kb3cudGVzdFJ1bm5lcikg eworICAgIHRlc3RSdW5uZXIuZHVtcEFzVGV4dCgpOworICAgIHRlc3RSdW5uZXIud2FpdFVudGls RG9uZSgpOworfQorCitpZiAod2luZG93LmxvY2F0aW9uLmhhc2ggPT0gJycpIHsKKyAgICBvbnVu bG9hZCA9ICgpID0+IHsKKyAgICAgICAgbmV3IEZpbGUoW10sICcnKS5zdHJlYW0oKTsKKyAgICB9 OworICAgIHdpbmRvdy5sb2NhdGlvbiA9ICI/I2ZpbmlzaCI7Cit9IGVsc2UgeworICAgIGRvY3Vt ZW50LmJvZHkuaW5uZXJIVE1MID0gIlBBU1MiOworICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikK KyAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25lKCk7Cit9Cis8L3NjcmlwdD4KKyAgICA8L2Jv ZHk+Cis8L2h0bWw+Cg==