222717 2021-03-04 00:59:43 -0800 Use NO_MAIN_THREAD_WRAPPING to compile libwebrtc 2021-03-04 09:55:34 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf eric.carlson pnormand vjaquez webkit-bug-importer youennf oldest_to_newest 1735716 0 youennf 2021-03-04 00:59:43 -0800 <rdar://problem/74988599> 1735719 1 422193 youennf 2021-03-04 01:03:43 -0800 Created attachment 422193 Patch 1735878 2 ews-feeder 2021-03-04 09:49:14 -0800 Committed r273893: <https://commits.webkit.org/r273893> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422193. 1735887 3 422193 pnormand 2021-03-04 09:54:07 -0800 Comment on attachment 422193 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422193&action=review > Source/ThirdParty/libwebrtc/ChangeLog:10 > + This prevents creating socket server in Web Process. I suppose this could be useful in the cmake build as well. 1735889 4 youennf 2021-03-04 09:55:34 -0800 (In reply to Philippe Normand from comment #3) > Comment on attachment 422193 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=422193&action=review > > > Source/ThirdParty/libwebrtc/ChangeLog:10 > > + This prevents creating socket server in Web Process. > > I suppose this could be useful in the cmake build as well. Yes, this is my guess to0. Chromium is using that option. 422193 2021-03-04 01:03:43 -0800 2021-03-04 09:49:15 -0800 Patch bug-222717-20210304100341.patch text/plain 3319 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjczODE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9saWJ3ZWJydGMvQ2hhbmdlTG9nIGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NoYW5n ZUxvZwppbmRleCAwMWE5YjU4OWVhNDIxYWQ5NTdiMzMxMjM1ZTM3MDAwMWI5MDdkN2FmLi43N2Y3 Njk4ZDJiMWRhZTA0NDFlYTI1NDUxZTk3OWZhY2I1YmViZGQzIDEwMDY0NAotLS0gYS9Tb3VyY2Uv VGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xp YndlYnJ0Yy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAyMS0wMy0wNCAgWW91ZW5uIEZh YmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlIE5PX01BSU5fVEhSRUFEX1dS QVBQSU5HIHRvIGNvbXBpbGUgbGlid2VicnRjCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI3MTcKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc0OTg4 NTk5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog Q29uZmlndXJhdGlvbnMvbGlid2VicnRjLnhjY29uZmlnOgorICAgICAgICBUaGlzIHByZXZlbnRz IGNyZWF0aW5nIHNvY2tldCBzZXJ2ZXIgaW4gV2ViIFByb2Nlc3MuCisKIDIwMjEtMDItMjQgIFlv dWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFVwZGF0ZSBmaXBzbW9k dWxlIGNpcGhlci5jIHRvIGhhbmRsZSBFVlBfQ2lwaGVyVXBkYXRlCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ29uZmlndXJhdGlvbnMvbGlid2VicnRjLnhjY29uZmln IGIvU291cmNlL1RoaXJkUGFydHkvbGlid2VicnRjL0NvbmZpZ3VyYXRpb25zL2xpYndlYnJ0Yy54 Y2NvbmZpZwppbmRleCA0MWQ1ZTM0NzAxZmU1YjI0ZjEwMDg5NDQwNTc2ZThlOGQxNDAwM2VmLi5j YTNlYzJiNWJiZGRiNDYyMjhhNjljOTIwMWNlMGI1Y2I5NTQxZDBkIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvVGhpcmRQYXJ0eS9saWJ3ZWJydGMvQ29uZmlndXJhdGlvbnMvbGlid2VicnRjLnhjY29uZmln CisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L2xpYndlYnJ0Yy9Db25maWd1cmF0aW9ucy9saWJ3ZWJy dGMueGNjb25maWcKQEAgLTQ5LDcgKzQ5LDcgQEAgSU5TVEFMTEhEUlNfU0NSSVBUX1BIQVNFID0g WUVTOwogV0FSTklOR19DRkxBR1MgPSAtV25vLWRlcHJlY2F0ZWQtZGVjbGFyYXRpb25zICQoaW5o ZXJpdGVkKTsKIAogLy8gRklYTUU6IFNldCBXRUJSVENfVVNFX0JVSUxUSU5fSVNBQ19GSVggYW5k IFdFQlJUQ19VU0VfQlVJTFRJTl9JU0FDX0ZMT0FUIGZvciBpT1MgYW5kIE1hYwotR0NDX1BSRVBS T0NFU1NPUl9ERUZJTklUSU9OUyA9IEdURVNUX1JFTEFUSVZFX1BBVEggV0VCUlRDX09QVVNfU1VQ UE9SVF8xMjBNU19QVElNRT0wIFdFQlJUQ19QT1NJWCBXRUJSVENfTUFDIFNTTF9VU0VfT1BFTlNT TCBGRUFUVVJFX0VOQUJMRV9TU0wgSEFWRV9TUlRQIEhBVkVfTkVUSU5FVF9JTl9IIEhBVkVfT1BF TlNTTF9TU0xfSCBTQ1RQX1BST0NFU1NfTEVWRUxfTE9DS1MgU0NUUF9TSU1QTEVfQUxMT0NBVE9S IFNDVFBfVVNFX09QRU5TU0xfU0hBMSBfX1VzZXJzcGFjZV9fIEhBVkVfU0FfTEVOIEhBVkVfU0NP Tk5fTEVOIF9fQVBQTEVfVVNFX1JGQ18yMjkyIF9fVXNlcnNwYWNlX29zX0RhcndpbiBOT05fV0lO RE9XU19ERUZJTkUgSEFWRV9XRUJSVENfVklERU8gSEFWRV9XRUJSVENfVk9JQ0UgV0VCUlRDX0lO VEVMTElHSUJJTElUWV9FTkhBTkNFUj0wIFdFQlJUQ19BUE1fREVCVUdfRFVNUD0wIFdFQlJUQ19O U19GTE9BVCBXRUJSVENfVVNFX0JVSUxUSU5fT1BVUyBXRUJSVENfQ09ERUNfT1BVUyBXRUJSVENf Q09ERUNfSVNBQyBXRUJSVENfQ09ERUNfUkVEIEhBVkVfU1RESU5UX0ggSEFWRV9TVERMSUJfSCBI QVZFX1VJTlQ2NF9UIE9QRU5TU0wgSEFWRV9DT05GSUdfSCBXRUJSVENfV0VCS0lUX0JVSUxEIEhB VkVfUFRIUkVBRF9DT05EX1RJTUVEV0FJVF9SRUxBVElWRSAgSEFWRV9TQ1RQIFdFQlJUQ19DT0RF Q19HNzExIFdFQlJUQ19DT0RFQ19HNzIyIFdFQlJUQ19PUFVTX1ZBUklBQkxFX0NPTVBMRVhJVFk9 MCBXRUJSVENfVVNFX0JVSUxUSU5fSVNBQ19GSVg9MSBXRUJSVENfVVNFX0JVSUxUSU5fSVNBQ19G TE9BVD0wIFVTRV9CVUlMVElOX1NXX0NPREVDUyBXRUJSVENfV0VCS0lUX0JVSUxEIFJUQ19FTkFC TEVfVlA5ICQoaW5oZXJpdGVkKTsKK0dDQ19QUkVQUk9DRVNTT1JfREVGSU5JVElPTlMgPSBHVEVT VF9SRUxBVElWRV9QQVRIIFdFQlJUQ19PUFVTX1NVUFBPUlRfMTIwTVNfUFRJTUU9MCBXRUJSVENf UE9TSVggV0VCUlRDX01BQyBTU0xfVVNFX09QRU5TU0wgRkVBVFVSRV9FTkFCTEVfU1NMIEhBVkVf U1JUUCBIQVZFX05FVElORVRfSU5fSCBIQVZFX09QRU5TU0xfU1NMX0ggU0NUUF9QUk9DRVNTX0xF VkVMX0xPQ0tTIFNDVFBfU0lNUExFX0FMTE9DQVRPUiBTQ1RQX1VTRV9PUEVOU1NMX1NIQTEgX19V c2Vyc3BhY2VfXyBIQVZFX1NBX0xFTiBIQVZFX1NDT05OX0xFTiBfX0FQUExFX1VTRV9SRkNfMjI5 MiBfX1VzZXJzcGFjZV9vc19EYXJ3aW4gTk9OX1dJTkRPV1NfREVGSU5FIEhBVkVfV0VCUlRDX1ZJ REVPIEhBVkVfV0VCUlRDX1ZPSUNFIFdFQlJUQ19JTlRFTExJR0lCSUxJVFlfRU5IQU5DRVI9MCBX RUJSVENfQVBNX0RFQlVHX0RVTVA9MCBXRUJSVENfTlNfRkxPQVQgV0VCUlRDX1VTRV9CVUlMVElO X09QVVMgV0VCUlRDX0NPREVDX09QVVMgV0VCUlRDX0NPREVDX0lTQUMgV0VCUlRDX0NPREVDX1JF RCBIQVZFX1NURElOVF9IIEhBVkVfU1RETElCX0ggSEFWRV9VSU5UNjRfVCBPUEVOU1NMIEhBVkVf Q09ORklHX0ggV0VCUlRDX1dFQktJVF9CVUlMRCBIQVZFX1BUSFJFQURfQ09ORF9USU1FRFdBSVRf UkVMQVRJVkUgIEhBVkVfU0NUUCBXRUJSVENfQ09ERUNfRzcxMSBXRUJSVENfQ09ERUNfRzcyMiBX RUJSVENfT1BVU19WQVJJQUJMRV9DT01QTEVYSVRZPTAgV0VCUlRDX1VTRV9CVUlMVElOX0lTQUNf RklYPTEgV0VCUlRDX1VTRV9CVUlMVElOX0lTQUNfRkxPQVQ9MCBVU0VfQlVJTFRJTl9TV19DT0RF Q1MgV0VCUlRDX1dFQktJVF9CVUlMRCBSVENfRU5BQkxFX1ZQOSBOT19NQUlOX1RIUkVBRF9XUkFQ UElORyAkKGluaGVyaXRlZCk7CiAKIEdDQ19QUkVQUk9DRVNTT1JfREVGSU5JVElPTlNbc2RrPW1h Y29zeCpdID0gJChpbmhlcml0ZWQpIFdFQlJUQ19VU0VfVlRCX0hBUkRXQVJFX0VOQ09ERVI7CiBH Q0NfUFJFUFJPQ0VTU09SX0RFRklOSVRJT05TW3Nkaz1pcGhvbmVvcypdID0gJChpbmhlcml0ZWQp IFdFQlJUQ19JT1M7Cg==