222711 2021-03-03 23:25:28 -0800 ASSERTION FAILED: contentSize >= 0 in WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax 2021-05-04 11:19:55 -0700 1 1 1 Unclassified WebKit Layout and Rendering Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=222651 InRadar P2 Normal --- 1 ryanhaddad svillar bfulgham cdumez changseok esprehn+autocc ews-watchlist glenn koivisto kondapallykalyan pdr rbuis sabouhallawa simon.fraser svillar thorton webkit-bot-watchers-bugzilla webkit-bug-importer zalan oldest_to_newest 1735690 0 ryanhaddad 2021-03-03 23:25:28 -0800 imported/w3c/web-platform-tests/css/css-flexbox/frameset-crash.html, which was recently imported with https://trac.webkit.org/changeset/273825/webkit, is frequently asserting on iOS and macOS debug bots. https://results.webkit.org/?suite=layout-tests&test=imported%2Fw3c%2Fweb-platform-tests%2Fcss%2Fcss-flexbox%2Fframeset-crash.html ASSERTION FAILED: contentSize >= 0 ./rendering/RenderFlexibleBox.cpp(1210) : WebCore::LayoutUnit WefbCore::RenderFlexibleBox::adjustChildSizeForMinAndMax(const WebCore::RenderBox &, WebCore::LayoutUnit) 1 0x144404329 WTFCrash 2 0x127ee57db WTFCrashWithInfo(int, char const*, char const*, int) 3 0x12c8ccbaa WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax(WebCore::RenderBox const&, WebCore::LayoutUnit) 4 0x12c8ca6f0 WebCore::RenderFlexibleBox::constructFlexItem(WebCore::RenderBox&, bool) 5 0x12c8c585a WebCore::RenderFlexibleBox::layoutFlexItems(bool) 6 0x12c8c5364 WebCore::RenderFlexibleBox::layoutBlock(bool, WebCore::LayoutUnit) 7 0x12c7db8b9 WebCore::RenderBlock::layout() 8 0x12c7f6a02 WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox&, WebCore::RenderBlockFlow::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 9 0x12c7f5344 WebCore::RenderBlockFlow::layoutBlockChildren(bool, WebCore::LayoutUnit&) 10 0x12c7f41c3 WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) 11 0x12c7db8b9 WebCore::RenderBlock::layout() 12 0x12c7f6a02 WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox&, WebCore::RenderBlockFlow::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 13 0x12c7f5344 WebCore::RenderBlockFlow::layoutBlockChildren(bool, WebCore::LayoutUnit&) 14 0x12c7f41c3 WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) 15 0x12c7db8b9 WebCore::RenderBlock::layout() 16 0x12c7f6a02 WebCore::RenderBlockFlow::layoutBlockChild(WebCore::RenderBox&, WebCore::RenderBlockFlow::MarginInfo&, WebCore::LayoutUnit&, WebCore::LayoutUnit&) 17 0x12c7f5344 WebCore::RenderBlockFlow::layoutBlockChildren(bool, WebCore::LayoutUnit&) 18 0x12c7f41c3 WebCore::RenderBlockFlow::layoutBlock(bool, WebCore::LayoutUnit) 19 0x12c7db8b9 WebCore::RenderBlock::layout() 20 0x12caaee33 WebCore::RenderView::layout() 21 0x12be804b1 WebCore::FrameViewLayoutContext::layout() 22 0x12af61ce6 WebCore::Document::implicitClose() 23 0x12bc44d6b WebCore::FrameLoader::checkCallImplicitClose() 24 0x12bc4479a WebCore::FrameLoader::checkCompleted() 25 0x12bc42887 WebCore::FrameLoader::finishedParsing() 26 0x12af76866 WebCore::Document::finishedParsing() 27 0x12b76fdd8 WebCore::HTMLConstructionSite::finishedParsing() 28 0x12b7b8c97 WebCore::HTMLTreeBuilder::finished() 29 0x12b777418 WebCore::HTMLDocumentParser::end() 30 0x12b7750e8 WebCore::HTMLDocumentParser::attemptToRunDeferredScriptsAndEnd() 31 0x12b774e27 WebCore::HTMLDocumentParser::prepareToStopParsing() 1735691 1 webkit-bug-importer 2021-03-03 23:25:55 -0800 <rdar://problem/75022692> 1735710 2 svillar 2021-03-04 00:49:04 -0800 Committed r273876 (234837@main): <https://commits.webkit.org/234837@main> 1735712 3 svillar 2021-03-04 00:50:12 -0800 This was not meant to be closed. I've just landed in r273876 a gardening patch skipping this test in Debug until we figure out what's going on. 1739907 4 423322 svillar 2021-03-16 05:26:33 -0700 Created attachment 423322 Patch 1741172 5 svillar 2021-03-18 05:17:43 -0700 Ping reviewers 1749595 6 svillar 2021-04-13 01:52:40 -0700 Another gentle ping 1756407 7 423322 zalan 2021-05-03 18:52:25 -0700 Comment on attachment 423322 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=423322&action=review > Source/WebCore/rendering/RenderFrameSet.cpp:437 > + ASSERT(preferredLogicalWidthsDirty()); > + > + RenderBox::computePreferredLogicalWidths(style().logicalMinWidth(), style().logicalMaxWidth(), borderAndPaddingLogicalWidth()); > + setPreferredLogicalWidthsDirty(false); I am curious as to why RenderBox::computePreferredLogicalWidths() does not simply call the other computePreferredLogicalWidths() function. I did a quick grep and it looked like many RenderBox subclasses override this function. It would be interesting to know if there's another class that's missing the override and whether it is intentional or just a mistake like this. I'd move this functionality up to the RenderBox unless there's a good reason not to (so that we don't end up with this exact same bug if someone introduces a new subclass). 1756493 8 427650 svillar 2021-05-04 04:11:39 -0700 Created attachment 427650 Patch Something like this Alan? 1756514 9 zalan 2021-05-04 06:41:58 -0700 (In reply to Sergio Villar Senin from comment #8) > Created attachment 427650 [details] > Patch > > Something like this Alan? Exactly like this! Thanks! Will review it in a bit. 1756579 10 427650 zalan 2021-05-04 10:19:44 -0700 Comment on attachment 427650 Patch So it looks like there are 2 classes with no computePreferredLogicalWidths override, RenderTableRow and RenderMultiColumnSpannerPlaceholder. If this patch regresses them in any way, we could just override and leave them empty with an explanation of why they should not need to provide the preferred logical width. 1756607 11 ews-feeder 2021-05-04 11:19:51 -0700 Committed r276971 (237300@main): <https://commits.webkit.org/237300@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 427650. 423322 2021-03-16 05:26:33 -0700 2021-05-03 18:40:16 -0700 Patch bug-222711-20210316132631.patch text/plain 4064 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjc0NDcyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOGEzYWM3YzhkZWRkNjQ0 MzQ5YTkxZGU3MzlhNTg0MTBjZjNmZTBhYy4uMWUyNjdjODUwZjUwZmI1NDYxMjUwOTFiN2M2YmYz NDA4NWZlNWY0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAzLTE2ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIEFTU0VSVElP TiBGQUlMRUQ6IGNvbnRlbnRTaXplID49IDAgaW4gV2VmYkNvcmU6OlJlbmRlckZsZXhpYmxlQm94 OjphZGp1c3RDaGlsZFNpemVGb3JNaW5BbmRNYXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjcxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIEZyYW1lU2V0IGRpZCBub3QgaGF2ZSBjb2RlIHRvIGNvbXB1 dGUgdGhlIHByZWZlcnJlZCB3aWR0aHMuIEFkZGVkIGJhc2ljIHByZWZlcnJlZCB3aWR0aCBjb21w dXRhdGlvbgorICAgICAgICBzbyB0aGF0IGZsZXhib3ggZG9lcyBub3QgY29tcHV0ZSBuZWdhdGl2 ZSBjb250ZW50IHNpemVzIGZvciBGcmFtZVNldCBjaGlsZHJlbi4KKworICAgICAgICAqIHJlbmRl cmluZy9SZW5kZXJGcmFtZVNldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJGcmFtZVNl dDo6Y29tcHV0ZVByZWZlcnJlZExvZ2ljYWxXaWR0aHMpOiBOZXcgbWV0aG9kLgorICAgICAgICAq IHJlbmRlcmluZy9SZW5kZXJGcmFtZVNldC5oOgorCiAyMDIxLTAzLTE2ICBGcmVkZXJpYyBXYW5n ICA8ZndhbmdAaWdhbGlhLmNvbT4KIAogICAgICAgICBDcmFzaCBpbiBtYWtlQm91bmRhcnlQb2lu dCB2aWEgUmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQ6Omluc2VydGVkQ29udGVudFJhbmdlCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRnJhbWVTZXQuY3BwIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckZyYW1lU2V0LmNwcAppbmRleCAwYjQ4ZDkzNmIy MzU0MTUwYzljNzE1NDc1N2JkNTk0ODM4M2QzY2VlLi4xYmViZDM4ZDM3Y2YyMDMwZjk3ZjYzMjVj MTMwNzFjNTMwZGJmOGYzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVu ZGVyRnJhbWVTZXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJGcmFt ZVNldC5jcHAKQEAgLTQyOSw2ICs0MjksMTQgQEAgRnJhbWVFZGdlSW5mbyBSZW5kZXJGcmFtZVNl dDo6ZWRnZUluZm8oKSBjb25zdAogICAgIHJldHVybiByZXN1bHQ7CiB9CiAKK3ZvaWQgUmVuZGVy RnJhbWVTZXQ6OmNvbXB1dGVQcmVmZXJyZWRMb2dpY2FsV2lkdGhzKCkKK3sKKyAgICBBU1NFUlQo cHJlZmVycmVkTG9naWNhbFdpZHRoc0RpcnR5KCkpOworCisgICAgUmVuZGVyQm94Ojpjb21wdXRl UHJlZmVycmVkTG9naWNhbFdpZHRocyhzdHlsZSgpLmxvZ2ljYWxNaW5XaWR0aCgpLCBzdHlsZSgp LmxvZ2ljYWxNYXhXaWR0aCgpLCBib3JkZXJBbmRQYWRkaW5nTG9naWNhbFdpZHRoKCkpOworICAg IHNldFByZWZlcnJlZExvZ2ljYWxXaWR0aHNEaXJ0eShmYWxzZSk7Cit9CisKIHZvaWQgUmVuZGVy RnJhbWVTZXQ6OmxheW91dCgpCiB7CiAgICAgU3RhY2tTdGF0czo6TGF5b3V0Q2hlY2tQb2ludCBs YXlvdXRDaGVja1BvaW50OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1Jl bmRlckZyYW1lU2V0LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRnJhbWVTZXQu aAppbmRleCAwZjhhMDkwOTcxMjgyY2YxMTJhYjUwZjE4ODZkMGMxMDcxYzk1Y2MyLi40Y2NhMWQ3 NTdmMTI4ZmNjOGM2NjlkN2IyMGZkY2ZiMTczMGUwZmRlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9yZW5kZXJpbmcvUmVuZGVyRnJhbWVTZXQuaAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyRnJhbWVTZXQuaApAQCAtOTQsNiArOTQsOCBAQCBwcml2YXRlOgogICAgIGNv bnN0IGNoYXIqIHJlbmRlck5hbWUoKSBjb25zdCBvdmVycmlkZSB7IHJldHVybiAiUmVuZGVyRnJh bWVTZXQiOyB9CiAgICAgYm9vbCBpc0ZyYW1lU2V0KCkgY29uc3Qgb3ZlcnJpZGUgeyByZXR1cm4g dHJ1ZTsgfQogCisgICAgdm9pZCBjb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocygpIG92ZXJy aWRlOworCiAgICAgdm9pZCBsYXlvdXQoKSBvdmVycmlkZTsKICAgICB2b2lkIHBhaW50KFBhaW50 SW5mbyYsIGNvbnN0IExheW91dFBvaW50Jikgb3ZlcnJpZGU7CiAgICAgYm9vbCBjYW5IYXZlQ2hp bGRyZW4oKSBjb25zdCBvdmVycmlkZSB7IHJldHVybiB0cnVlOyB9CmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNzExN2YyYjg2 N2RkZDBmNTBiNmM5Njk2N2VhZTlmNGYyYzRhOWMzMi4uMmIzMzczMDAzYTc2N2JlZWZlZDAxOTZm OGQxZjBlODBkOTk0YmI3NyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTAzLTE2ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIEFTU0VSVElP TiBGQUlMRUQ6IGNvbnRlbnRTaXplID49IDAgaW4gV2VmYkNvcmU6OlJlbmRlckZsZXhpYmxlQm94 OjphZGp1c3RDaGlsZFNpemVGb3JNaW5BbmRNYXgKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjcxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVGVzdEV4cGVjdGF0aW9uczogVW5za2lwcGVkIGEgdGVz dCB0aGF0IGlzIHBhc3Npbmcgbm93LgorCiAyMDIxLTAzLTE2ICBGcmVkZXJpYyBXYW5nICA8Zndh bmdAaWdhbGlhLmNvbT4KIAogICAgICAgICBDcmFzaCBpbiBtYWtlQm91bmRhcnlQb2ludCB2aWEg UmVwbGFjZVNlbGVjdGlvbkNvbW1hbmQ6Omluc2VydGVkQ29udGVudFJhbmdlCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0 aW9ucwppbmRleCAxZjNiOWNhNTlhNTExOTVkYjkzM2EyOTA3ZjY2M2FhNDNlOWQ1MWUxLi41NTcy NjU2ZmMyMmMxNzNlOGFlNzA2ZjZjMzJlMDliZjdiMThmZTc1IDEwMDY0NAotLS0gYS9MYXlvdXRU ZXN0cy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMK QEAgLTQwNjIsOSArNDA2Miw2IEBAIHdlYmtpdC5vcmcvYi8yMjE0ODIgaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWZsZXhib3gvZmxleGJveC1jb2xsCiAjIFBhaW50aW5n IG9yZGVyIGluIGZsZXhib3gKIHdlYmtpdC5vcmcvYi8yMjE0ODIgaW1wb3J0ZWQvdzNjL3dlYi1w bGF0Zm9ybS10ZXN0cy9jc3MvY3NzLWZsZXhib3gvZmxleGJveC1wYWludC1vcmRlcmluZy0wMDIu eGh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIAotIyBUZXN0IEFTU0VSVGluZyBpbiBEZWJ1Zy4K LXdlYmtpdC5vcmcvYi8yMjI3MTEgWyBEZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0t dGVzdHMvY3NzL2Nzcy1mbGV4Ym94L2ZyYW1lc2V0LWNyYXNoLmh0bWwgWyBTa2lwIF0KLQogIyBO ZXdseSBpbXBvcnRlZCBDYW52YXMgV1BUIHRlc3RzIHRoYXQgYXJlIGZhaWxpbmcuCiBpbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvY2FudmFzL2VsZW1lbnQvYnVpbGRpbmctcGF0 aHMvY2FudmFzX2NvbXBsZXhzaGFwZXNfYXJjdG9fMDAxLmh0bSBbIEltYWdlT25seUZhaWx1cmUg UGFzcyBdCiBpbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvY2FudmFzL2VsZW1l bnQvZHJhd2luZy1pbWFnZXMtdG8tdGhlLWNhbnZhcy8yZC5kcmF3SW1hZ2UuYnJva2VuLmh0bWwg WyBGYWlsdXJlIFBhc3MgXQo= 427650 2021-05-04 04:11:39 -0700 2021-05-04 11:19:53 -0700 Patch bug-222711-20210504131137.patch text/plain 4625 svillar U3VidmVyc2lvbiBSZXZpc2lvbjogMjc2OTUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTMxZWE5ZTI0Mzc0OTQ2 M2Q0MGYxOGE3MDZjNTRiOGVjNGNhN2EzOC4uMjAzYWIwOWQyMTU2ZGQ0OWQ3ZDgyNjE2ZDRhMGZi ZTlkN2VlZGZkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTA1LTA0ICBTZXJn aW8gVmlsbGFyIFNlbmluICA8c3ZpbGxhckBpZ2FsaWEuY29tPgorCisgICAgICAgIEFTU0VSVElP TiBGQUlMRUQ6IGNvbnRlbnRTaXplID49IDAgaW4gV2ViQ29yZTo6UmVuZGVyRmxleGlibGVCb3g6 OmFkanVzdENoaWxkU2l6ZUZvck1pbkFuZE1heAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyNzExCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NTAy MjY5Mj4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBG bGV4Ym94IGNvZGUgd2FzIGNvbXB1dGluZyBuZWdhdGl2ZSBjb250ZW50IHNpemVzIGZvciBGcmFt ZVNldCBjaGlsZHJlbiBiZWNhdXNlIFJlbmRlckZyYW1lU2V0IGxhY2tlZAorICAgICAgICBhIGlt cGxlbWVudGF0aW9uIG9mIGNvbXB1dGVQcmVmZXJyZWRMb2dpY2FsV2lkdGhzKCkuIEFkZGVkIGJh c2ljIHByZWZlcnJlZCB3aWR0aCBjb21wdXRhdGlvbgorICAgICAgICB0byBSZW5kZXJCb3ggc28g dGhhdCBGcmFtZVNldCBhbmQgYW55IG90aGVyIHBvdGVudGlhbCBuZXcgUmVuZGVyQm94IGNoaWxk IGNvdWxkIGJlbmVmaXQgZnJvbSBpdC4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJCb3gu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyQm94Ojpjb21wdXRlUHJlZmVycmVkTG9naWNh bFdpZHRocyk6IEFkZGVkIGEgYmFzaWMgaW1wbGVtZW50YXRpb24gdGhhdCBjYWxscworICAgICAg ICBjb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocyhtaW5XaWR0aCxtYXhXaWR0aCxib3JkZXJB bmRQYWRkaW5nKSBhbmQgY2xlYXJzIHRoZSBmbGFnLgorICAgICAgICAqIHJlbmRlcmluZy9SZW5k ZXJCb3guaDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckJveDo6Y29tcHV0ZVByZWZlcnJlZExv Z2ljYWxXaWR0aHMpOiBEZWxldGVkIGRlZmF1bHQgaW1wbGVtZW50YXRpb24uCisKIDIwMjEtMDUt MDQgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgogCiAgICAgICAgIFVzZSBPcHRp b25TZXQgZm9yIE1lZGlhUHJvZHVjZXI6Ok1lZGlhU3RhdGVGbGFncwpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlckJveC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9yZW5k ZXJpbmcvUmVuZGVyQm94LmNwcAppbmRleCBkNzQ4MDZhYzlmZTYzOWI3ZTM2ZTlhMjg0NjIzM2Zi MDFmNzBhMWIzLi4xNDJjZmI0ZTQ4MGNhMDc3ZWI3ZjQ0NWFiYTA5ZTA0YWZhM2VhYTc3IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmNwcApAQCAtMzIyMyw2ICszMjIzLDE0IEBA IHN0YXRpYyBib29sIGFsbG93TWluTWF4UGVyY2VudGFnZXNJbkF1dG9IZWlnaHRCbG9ja3NRdWly aygpCiAjZW5kaWYKIH0KIAordm9pZCBSZW5kZXJCb3g6OmNvbXB1dGVQcmVmZXJyZWRMb2dpY2Fs V2lkdGhzKCkKK3sKKyAgICBBU1NFUlQocHJlZmVycmVkTG9naWNhbFdpZHRoc0RpcnR5KCkpOwor CisgICAgY29tcHV0ZVByZWZlcnJlZExvZ2ljYWxXaWR0aHMoc3R5bGUoKS5sb2dpY2FsTWluV2lk dGgoKSwgc3R5bGUoKS5sb2dpY2FsTWF4V2lkdGgoKSwgYm9yZGVyQW5kUGFkZGluZ0xvZ2ljYWxX aWR0aCgpKTsKKyAgICBzZXRQcmVmZXJyZWRMb2dpY2FsV2lkdGhzRGlydHkoZmFsc2UpOworfQor CiB2b2lkIFJlbmRlckJveDo6Y29tcHV0ZVByZWZlcnJlZExvZ2ljYWxXaWR0aHMoY29uc3QgTGVu Z3RoJiBtaW5XaWR0aCwgY29uc3QgTGVuZ3RoJiBtYXhXaWR0aCwgTGF5b3V0VW5pdCBib3JkZXJB bmRQYWRkaW5nKQogewogICAgIGlmIChzaG91bGRDb21wdXRlTG9naWNhbEhlaWdodEZyb21Bc3Bl Y3RSYXRpbygpKSB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVy Qm94LmggYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyQm94LmgKaW5kZXggNWNjYTZm NWJmZDIwMDY4Njg3ZjkzMzcxYzhhOTdlNWQ0OWY1NzdiNi4uNDZkOGY0Y2YyNTk3NTdlMGEyNDRl YTI0Nzg4N2JkMDZmNWU1OTUyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5n L1JlbmRlckJveC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCb3guaApA QCAtNzYwLDcgKzc2MCw3IEBAIHByaXZhdGU6CiAgICAgLy8gVGhpcyBmdW5jdGlvbiBjYWxjdWxh dGVzIHRoZSBtaW5pbXVtIGFuZCBtYXhpbXVtIHByZWZlcnJlZCB3aWR0aHMgZm9yIGFuIG9iamVj dC4KICAgICAvLyBUaGVzZSB2YWx1ZXMgYXJlIHVzZWQgaW4gc2hyaW5rLXRvLWZpdCBsYXlvdXQg c3lzdGVtcy4KICAgICAvLyBUaGVzZSBpbmNsdWRlIHRhYmxlcywgcG9zaXRpb25lZCBvYmplY3Rz LCBmbG9hdHMgYW5kIGZsZXhpYmxlIGJveGVzLgotICAgIHZpcnR1YWwgdm9pZCBjb21wdXRlUHJl ZmVycmVkTG9naWNhbFdpZHRocygpIHsgc2V0UHJlZmVycmVkTG9naWNhbFdpZHRoc0RpcnR5KGZh bHNlKTsgfQorICAgIHZpcnR1YWwgdm9pZCBjb21wdXRlUHJlZmVycmVkTG9naWNhbFdpZHRocygp OwogCiAgICAgTGF5b3V0UmVjdCBmcmFtZVJlY3RGb3JTdGlja3lQb3NpdGlvbmluZygpIGNvbnN0 IGZpbmFsIHsgcmV0dXJuIGZyYW1lUmVjdCgpOyB9CiAKZGlmZiAtLWdpdCBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwppbmRleCA5ZWMzNjc0MDdiMjNhZGM3 MWRkN2IzZDEzOTZmYTVhMjRhZTM5ZWE2Li5kZmU2MzUwNmNiZjkwN2IxODYyNDYxODhiOGI0Njdi NzI1MmQ2NmU2IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjEtMDUtMDQgIFNlcmdpbyBWaWxs YXIgU2VuaW4gIDxzdmlsbGFyQGlnYWxpYS5jb20+CisKKyAgICAgICAgQVNTRVJUSU9OIEZBSUxF RDogY29udGVudFNpemUgPj0gMCBpbiBXZWJDb3JlOjpSZW5kZXJGbGV4aWJsZUJveDo6YWRqdXN0 Q2hpbGRTaXplRm9yTWluQW5kTWF4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0yMjI3MTEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc1MDIyNjkyPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVGVzdEV4 cGVjdGF0aW9uczogVW5za2lwcGVkIGEgdGVzdCB0aGF0IGlzIHBhc3Npbmcgbm93LgorCiAyMDIx LTA1LTAzICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAg IFJFR1JFU1NJT04gKHIyNzQ0NjEpOiBbbWFjT1Mgd2sxXSBmYXN0L3JlcGFpbnQvY2FudmFzLW9i amVjdC1maXQuaHRtbCBpcyBmbGFrZXkgdGV4dCBmYWlsaW5nCmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucwppbmRl eCA4NGNmMGU1ZDdmZmVkNjQ3ZDQ0Zjc3MDc4ZmEyYzNmNjYxMDY0NmJiLi5jNjliYjdlNWI4ZmUw YjJmZTA4NGRhYzE2ZGNkZTQ5MDRkNzg2N2ExIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9UZXN0 RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTM5NDcs OSArMzk0Nyw2IEBAIHdlYmtpdC5vcmcvYi8yMjE0ODIgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9y bS10ZXN0cy9jc3MvY3NzLWZsZXhib3gvZmxleGJveC1jb2xsCiAjIFBhaW50aW5nIG9yZGVyIGlu IGZsZXhib3gKIHdlYmtpdC5vcmcvYi8yMjE0ODIgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10 ZXN0cy9jc3MvY3NzLWZsZXhib3gvZmxleGJveC1wYWludC1vcmRlcmluZy0wMDIueGh0bWwgWyBJ bWFnZU9ubHlGYWlsdXJlIF0KIAotIyBUZXN0IEFTU0VSVGluZyBpbiBEZWJ1Zy4KLXdlYmtpdC5v cmcvYi8yMjI3MTEgWyBEZWJ1ZyBdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3Nz L2Nzcy1mbGV4Ym94L2ZyYW1lc2V0LWNyYXNoLmh0bWwgWyBTa2lwIF0KLQogIyBOZXdseSBpbXBv cnRlZCBDYW52YXMgV1BUIHRlc3RzIHRoYXQgYXJlIGZhaWxpbmcuCiBpbXBvcnRlZC93M2Mvd2Vi LXBsYXRmb3JtLXRlc3RzL2h0bWwvY2FudmFzL2VsZW1lbnQvYnVpbGRpbmctcGF0aHMvY2FudmFz X2NvbXBsZXhzaGFwZXNfYXJjdG9fMDAxLmh0bSBbIEltYWdlT25seUZhaWx1cmUgUGFzcyBdCiBp bXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL2h0bWwvY2FudmFzL2VsZW1lbnQvZHJhd2lu Zy1pbWFnZXMtdG8tdGhlLWNhbnZhcy8yZC5kcmF3SW1hZ2UuYnJva2VuLmh0bWwgWyBGYWlsdXJl IFBhc3MgXQo=