22271 2008-11-14 14:11:26 -0800 Default pixel test tolerance should be non-zero 2008-11-18 10:56:32 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 22323 1 pol webkit-unassigned mitz simon.fraser oldest_to_newest 98823 0 pol 2008-11-14 14:11:26 -0800 After discussing on IRC, it seems consensus is to have default pixel test tolerance be non-zero: - Leopard: 0.1% - Tiger: 1.0% 98824 1 25176 pol 2008-11-14 14:39:07 -0800 Created attachment 25176 Patch v1 98825 2 25177 pol 2008-11-14 14:40:10 -0800 Created attachment 25177 Patch v2 98826 3 25177 mjs 2008-11-14 14:42:25 -0800 Comment on attachment 25177 Patch v2 r=me 99109 4 dino 2008-11-17 14:11:16 -0800 Committed r38527 M WebKitTools/ChangeLog M WebKitTools/Scripts/run-webkit-tests 25176 2008-11-14 14:39:07 -0800 2008-11-14 14:40:10 -0800 Patch v1 Patch.txt text/plain 2405 pol ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA1MTJjN2I0Li5iOGU2MmYzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMTEt MTQgIFBpZXJyZS1PbGl2aWVyIExhdG91ciAgPHBvbEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKwlQaXhlbCB0ZXN0cyBzaG91bGQgdXNlIGEgZGVm YXVsdCB0b2xlcmFuY2Ugb2YgMC4xJSBvbiBMZW9wYXJkIGFuZCAxLjAlIG9uIFRpZ2VyLgorCisJ aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjcxCisKKyAgICAgICAg KiBTY3JpcHRzL3J1bi13ZWJraXQtdGVzdHM6CisKIDIwMDgtMTEtMDYgIERhdmlkIEtpbHplciAg PGRka2lsemVyQGFwcGxlLmNvbT4KIAogICAgICAgICBCVUlMRCBGSVg6IEJhY2tlZCBvdXQgcjM4 MTg5IChhbmQgcjM4MjAzKSBmb3IgWGNvZGUgMy4wLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMv U2NyaXB0cy9ydW4td2Via2l0LXRlc3RzIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0 LXRlc3RzCmluZGV4IDRmMTI5YjcuLmQxNDZiYzkgMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1Nj cmlwdHMvcnVuLXdlYmtpdC10ZXN0cworKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJr aXQtdGVzdHMKQEAgLTE0NiwxMCArMTQ2LDEzIEBAIG15ICRlcnJvclRhZyA9ICJzdGRlcnIiOwog CiBpZiAoaXNUaWdlcigpKSB7CiAgICAgJHBsYXRmb3JtID0gIm1hYy10aWdlciI7CisgICAgJHRv bGVyYW5jZSA9IDEuMDsKIH0gZWxzaWYgKGlzTGVvcGFyZCgpKSB7CiAgICAgJHBsYXRmb3JtID0g Im1hYy1sZW9wYXJkIjsKKyAgICAkdG9sZXJhbmNlID0gMC4xOwogfSBlbHNpZiAoaXNTbm93TGVv cGFyZCgpKSB7CiAgICAgJHBsYXRmb3JtID0gIm1hYy1zbm93bGVvcGFyZCI7CisgICAgJHRvbGVy YW5jZSA9IDAuMTsKIH0gZWxzaWYgKGlzT1NYKCkpIHsKICAgICAkcGxhdGZvcm0gPSAibWFjIjsK IH0gZWxzaWYgKGlzUXQoKSkgewpAQCAtMTg0LDcgKzE4Nyw3IEBAIFVzYWdlOiAkcHJvZ3JhbU5h bWUgW29wdGlvbnNdIFt0ZXN0ZGlyfHRlc3RwYXRoIC4uLl0KICAgLWx8LS1sZWFrcyAgICAgICAg ICAgICAgICAgICAgICBFbmFibGUgbGVha3MgY2hlY2tpbmcKICAgLS1bbm8tXW5ldy10ZXN0LXJl c3VsdHMgICAgICAgICBHZW5lcmF0ZSByZXN1bHRzIGZvciBuZXcgdGVzdHMKICAgLXB8LS1waXhl bC10ZXN0cyAgICAgICAgICAgICAgICBFbmFibGUgcGl4ZWwgdGVzdHMKLSAgLS10b2xlcmFuY2Ug dCAgICAgICAgICAgICAgICAgICBJZ25vcmUgaW1hZ2UgZGlmZmVyZW5jZXMgbGVzcyB0aGFuIHRo aXMgcGVyY2VudGFnZSAoaW1wbGllcyAtLXBpeGVsLXRlc3RzKQorICAtLXRvbGVyYW5jZSB0ICAg ICAgICAgICAgICAgICAgIElnbm9yZSBpbWFnZSBkaWZmZXJlbmNlcyBsZXNzIHRoYW4gdGhpcyBw ZXJjZW50YWdlIChkZWZhdWx0OiAkdG9sZXJhbmNlKQogICAtLXBsYXRmb3JtICAgICAgICAgICAg ICAgICAgICAgIE92ZXJyaWRlIHRoZSBkZXRlY3RlZCBwbGF0Zm9ybSB0byB1c2UgZm9yIHRlc3Rz IGFuZCByZXN1bHRzIChkZWZhdWx0OiAkcGxhdGZvcm0pCiAgIC0tcG9ydCAgICAgICAgICAgICAg ICAgICAgICAgICAgV2ViIHNlcnZlciBwb3J0IHRvIHVzZSB3aXRoIGh0dHAgdGVzdHMKICAgLXF8 LS1xdWlldCAgICAgICAgICAgICAgICAgICAgICBMZXNzIHZlcmJvc2Ugb3V0cHV0CkBAIC0yNjEs OCArMjY0LDYgQEAgc2V0Q29uZmlndXJhdGlvbigkY29uZmlndXJhdGlvbik7CiAKIG15ICRjb25m aWd1cmF0aW9uT3B0aW9uID0gIi0tIiAuIGxjKCRjb25maWd1cmF0aW9uKTsKIAotJHBpeGVsVGVz dHMgPSAxIGlmICR0b2xlcmFuY2UgPiAwOwotCiAkdGVzdHNQZXJEdW1wVG9vbCA9IDEwMDAgaWYg ISR0ZXN0c1BlckR1bXBUb29sOwogCiAkdmVyYm9zZSA9IDEgaWYgJHRlc3RzUGVyRHVtcFRvb2wg PT0gMTsKQEAgLTMyNCw2ICszMjUsOSBAQCAkZXhwZWN0ZWREaXJlY3RvcnkgPSAkRU5WeyJXZWJL aXRFeHBlY3RlZFRlc3RSZXN1bHRzRGlyZWN0b3J5In0gaWYgJEVOVnsiV2ViS2l0RQogbXkgJHRl c3RSZXN1bHRzID0gY2F0ZmlsZSgkdGVzdFJlc3VsdHNEaXJlY3RvcnksICJyZXN1bHRzLmh0bWwi KTsKIAogcHJpbnQgIlJ1bm5pbmcgdGVzdHMgZnJvbSAkdGVzdERpcmVjdG9yeVxuIjsKK2lmICgk cGl4ZWxUZXN0cykgeworICAgIHByaW50ICJFbmFibGluZyBwaXhlbCB0ZXN0cyB3aXRoIGEgdG9s ZXJhbmNlIG9mICR0b2xlcmFuY2UlXG4iOworfQogCiBteSBAdGVzdHMgPSAoKTsKIG15ICV0ZXN0 VHlwZSA9ICgpOwo= 25177 2008-11-14 14:40:10 -0800 2008-11-14 14:42:25 -0800 Patch v2 Patch.txt text/plain 2419 pol ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA1MTJjN2I0Li40MjU3YTc5IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDgtMTEt MTQgIFBpZXJyZS1PbGl2aWVyIExhdG91ciAgPHBvbEBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGl4ZWwgdGVzdHMgc2hvdWxkIHVz ZSBhIGRlZmF1bHQgdG9sZXJhbmNlIG9mIDAuMSUgb24gTGVvcGFyZCBhbmQgMS4wJSBvbiBUaWdl ci4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIy NzEKKworICAgICAgICAqIFNjcmlwdHMvcnVuLXdlYmtpdC10ZXN0czoKKwogMjAwOC0xMS0wNiAg RGF2aWQgS2lsemVyICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEJVSUxEIEZJWDog QmFja2VkIG91dCByMzgxODkgKGFuZCByMzgyMDMpIGZvciBYY29kZSAzLjAuCmRpZmYgLS1naXQg YS9XZWJLaXRUb29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMgYi9XZWJLaXRUb29scy9TY3Jp cHRzL3J1bi13ZWJraXQtdGVzdHMKaW5kZXggNGYxMjliNy4uZDE0NmJjOSAxMDA3NTUKLS0tIGEv V2ViS2l0VG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LXRlc3RzCisrKyBiL1dlYktpdFRvb2xzL1Nj cmlwdHMvcnVuLXdlYmtpdC10ZXN0cwpAQCAtMTQ2LDEwICsxNDYsMTMgQEAgbXkgJGVycm9yVGFn ID0gInN0ZGVyciI7CiAKIGlmIChpc1RpZ2VyKCkpIHsKICAgICAkcGxhdGZvcm0gPSAibWFjLXRp Z2VyIjsKKyAgICAkdG9sZXJhbmNlID0gMS4wOwogfSBlbHNpZiAoaXNMZW9wYXJkKCkpIHsKICAg ICAkcGxhdGZvcm0gPSAibWFjLWxlb3BhcmQiOworICAgICR0b2xlcmFuY2UgPSAwLjE7CiB9IGVs c2lmIChpc1Nub3dMZW9wYXJkKCkpIHsKICAgICAkcGxhdGZvcm0gPSAibWFjLXNub3dsZW9wYXJk IjsKKyAgICAkdG9sZXJhbmNlID0gMC4xOwogfSBlbHNpZiAoaXNPU1goKSkgewogICAgICRwbGF0 Zm9ybSA9ICJtYWMiOwogfSBlbHNpZiAoaXNRdCgpKSB7CkBAIC0xODQsNyArMTg3LDcgQEAgVXNh Z2U6ICRwcm9ncmFtTmFtZSBbb3B0aW9uc10gW3Rlc3RkaXJ8dGVzdHBhdGggLi4uXQogICAtbHwt LWxlYWtzICAgICAgICAgICAgICAgICAgICAgIEVuYWJsZSBsZWFrcyBjaGVja2luZwogICAtLVtu by1dbmV3LXRlc3QtcmVzdWx0cyAgICAgICAgIEdlbmVyYXRlIHJlc3VsdHMgZm9yIG5ldyB0ZXN0 cwogICAtcHwtLXBpeGVsLXRlc3RzICAgICAgICAgICAgICAgIEVuYWJsZSBwaXhlbCB0ZXN0cwot ICAtLXRvbGVyYW5jZSB0ICAgICAgICAgICAgICAgICAgIElnbm9yZSBpbWFnZSBkaWZmZXJlbmNl cyBsZXNzIHRoYW4gdGhpcyBwZXJjZW50YWdlIChpbXBsaWVzIC0tcGl4ZWwtdGVzdHMpCisgIC0t dG9sZXJhbmNlIHQgICAgICAgICAgICAgICAgICAgSWdub3JlIGltYWdlIGRpZmZlcmVuY2VzIGxl c3MgdGhhbiB0aGlzIHBlcmNlbnRhZ2UgKGRlZmF1bHQ6ICR0b2xlcmFuY2UpCiAgIC0tcGxhdGZv cm0gICAgICAgICAgICAgICAgICAgICAgT3ZlcnJpZGUgdGhlIGRldGVjdGVkIHBsYXRmb3JtIHRv IHVzZSBmb3IgdGVzdHMgYW5kIHJlc3VsdHMgKGRlZmF1bHQ6ICRwbGF0Zm9ybSkKICAgLS1wb3J0 ICAgICAgICAgICAgICAgICAgICAgICAgICBXZWIgc2VydmVyIHBvcnQgdG8gdXNlIHdpdGggaHR0 cCB0ZXN0cwogICAtcXwtLXF1aWV0ICAgICAgICAgICAgICAgICAgICAgIExlc3MgdmVyYm9zZSBv dXRwdXQKQEAgLTI2MSw4ICsyNjQsNiBAQCBzZXRDb25maWd1cmF0aW9uKCRjb25maWd1cmF0aW9u KTsKIAogbXkgJGNvbmZpZ3VyYXRpb25PcHRpb24gPSAiLS0iIC4gbGMoJGNvbmZpZ3VyYXRpb24p OwogCi0kcGl4ZWxUZXN0cyA9IDEgaWYgJHRvbGVyYW5jZSA+IDA7Ci0KICR0ZXN0c1BlckR1bXBU b29sID0gMTAwMCBpZiAhJHRlc3RzUGVyRHVtcFRvb2w7CiAKICR2ZXJib3NlID0gMSBpZiAkdGVz dHNQZXJEdW1wVG9vbCA9PSAxOwpAQCAtMzI0LDYgKzMyNSw5IEBAICRleHBlY3RlZERpcmVjdG9y eSA9ICRFTlZ7IldlYktpdEV4cGVjdGVkVGVzdFJlc3VsdHNEaXJlY3RvcnkifSBpZiAkRU5WeyJX ZWJLaXRFCiBteSAkdGVzdFJlc3VsdHMgPSBjYXRmaWxlKCR0ZXN0UmVzdWx0c0RpcmVjdG9yeSwg InJlc3VsdHMuaHRtbCIpOwogCiBwcmludCAiUnVubmluZyB0ZXN0cyBmcm9tICR0ZXN0RGlyZWN0 b3J5XG4iOworaWYgKCRwaXhlbFRlc3RzKSB7CisgICAgcHJpbnQgIkVuYWJsaW5nIHBpeGVsIHRl c3RzIHdpdGggYSB0b2xlcmFuY2Ugb2YgJHRvbGVyYW5jZSVcbiI7Cit9CiAKIG15IEB0ZXN0cyA9 ICgpOwogbXkgJXRlc3RUeXBlID0gKCk7Cg==