222705 2021-03-03 19:31:56 -0800 [LFC][IFC] LineBox::m_rootInlineBox does not need to be a UniqueRef 2021-03-04 08:27:16 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1735648 0 zalan 2021-03-03 19:31:56 -0800 now that we don't have it in the hashmap 1735651 1 422175 zalan 2021-03-03 19:36:11 -0800 Created attachment 422175 Patch 1735668 2 koivisto 2021-03-03 21:24:26 -0800 Can the same be done for InlineLevelBoxList? Switch the map to use indexes? 1735835 3 ews-feeder 2021-03-04 08:26:34 -0800 Committed r273889: <https://commits.webkit.org/r273889> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422175. 1735836 4 webkit-bug-importer 2021-03-04 08:27:16 -0800 <rdar://problem/75037263> 422175 2021-03-03 19:36:11 -0800 2021-03-04 08:26:35 -0800 Patch bug-222705-20210303193611.patch text/plain 5764 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjczODY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWFjNjc3NWY4YmQ2OWM1 ZWE3YWM5ODIzZDM0NjNkZmY3YzJlNWU0Ni4uMmM1ZmE0YzQ2Mzg1MGJkYzc3ZWExOTM4NDRmMWEx ZDFjY2YwMzVmZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTAzLTAzICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBMaW5lQm94 OjptX3Jvb3RJbmxpbmVCb3ggZG9lcyBub3QgbmVlZCB0byBiZSBhIFVuaXF1ZVJlZgorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyNzA1CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBsYXlvdXQvaW5saW5l Zm9ybWF0dGluZy9JbmxpbmVMaW5lQm94LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6 bV9yb290SW5saW5lQm94KToKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6TGluZUJveDo6bG9n aWNhbFJlY3RGb3JUZXh0UnVuIGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6OkxheW91dDo6TGlu ZUJveDo6bG9naWNhbFJlY3RGb3JJbmxpbmVMZXZlbEJveCBjb25zdCk6CisgICAgICAgICogbGF5 b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJveC5oOgorICAgICAgICAoV2ViQ29yZTo6 TGF5b3V0OjpMaW5lQm94Ojpsb2dpY2FsUmVjdEZvclJvb3RJbmxpbmVCb3ggY29uc3QpOgorICAg ICAgICAoV2ViQ29yZTo6TGF5b3V0OjpMaW5lQm94OjphbGlnbm1lbnRCYXNlbGluZSBjb25zdCk6 CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmVCb3g6OmlubGluZUxldmVsQm94Rm9yTGF5 b3V0Qm94KToKKwogMjAyMS0wMy0wMyAgWmFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgog CiAgICAgICAgIFtMRkNdW0lGQ10gTWFrZSBMaW5lQm94OjptX2lubGluZUxldmVsQm94UmVjdE1h cCBhIG5vbi1yb290IGlubGluZSBsZXZlbCBib3ggbWFwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lQm94LmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCb3guY3BwCmluZGV4IDBk MzhlN2E3OTY2MTEwYzFlMzEyYWMyZWI3ZjZmYTUzMjNkYmVhMTcuLmI0M2NjYzEwNDEyOWNjMjEy MTM0YzIxNjZhYjY2NWRkYWE2YWYwOWUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91 dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCb3guY3BwCisrKyBiL1NvdXJjZS9XZWJDb3Jl L2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCb3guY3BwCkBAIC04Niw3ICs4Niw3 IEBAIGJvb2wgTGluZUJveDo6SW5saW5lTGV2ZWxCb3g6Omhhc0xpbmVCb3hSZWxhdGl2ZUFsaWdu bWVudCgpIGNvbnN0CiBMaW5lQm94OjpMaW5lQm94KGNvbnN0IEJveCYgcm9vdExheW91dEJveCwg Y29uc3QgSW5saW5lTGF5b3V0UG9pbnQmIGxvZ2ljYWxUb3BsZWZ0LCBJbmxpbmVMYXlvdXRVbml0 IGxpbmVMb2dpY2FsV2lkdGgsIElubGluZUxheW91dFVuaXQgY29udGVudExvZ2ljYWxMZWZ0LCBJ bmxpbmVMYXlvdXRVbml0IGNvbnRlbnRMb2dpY2FsV2lkdGgsIHNpemVfdCBudW1iZXJPZlJ1bnMp CiAgICAgOiBtX2xvZ2ljYWxSZWN0KGxvZ2ljYWxUb3BsZWZ0LCBJbmxpbmVMYXlvdXRTaXplIHsg bGluZUxvZ2ljYWxXaWR0aCwgeyB9IH0pCiAgICAgLCBtX2NvbnRlbnRMb2dpY2FsV2lkdGgoY29u dGVudExvZ2ljYWxXaWR0aCkKLSAgICAsIG1fcm9vdElubGluZUJveChtYWtlVW5pcXVlUmVmPExp bmVCb3g6OklubGluZUxldmVsQm94Pihyb290TGF5b3V0Qm94LCBjb250ZW50TG9naWNhbExlZnQs IElubGluZUxheW91dFNpemUgeyBjb250ZW50TG9naWNhbFdpZHRoLCB7IH0gfSwgSW5saW5lTGV2 ZWxCb3g6OlR5cGU6OlJvb3RJbmxpbmVCb3gpKQorICAgICwgbV9yb290SW5saW5lQm94KHJvb3RM YXlvdXRCb3gsIGNvbnRlbnRMb2dpY2FsTGVmdCwgSW5saW5lTGF5b3V0U2l6ZSB7IGNvbnRlbnRM b2dpY2FsV2lkdGgsIHsgfSB9LCBJbmxpbmVMZXZlbEJveDo6VHlwZTo6Um9vdElubGluZUJveCkK IHsKICAgICBtX25vblJvb3RJbmxpbmVMZXZlbEJveExpc3QucmVzZXJ2ZUluaXRpYWxDYXBhY2l0 eShudW1iZXJPZlJ1bnMpOwogICAgIG1fbm9uUm9vdElubGluZUxldmVsQm94TWFwLnJlc2VydmVJ bml0aWFsQ2FwYWNpdHkobnVtYmVyT2ZSdW5zKTsKQEAgLTExMyw3ICsxMTMsNyBAQCBJbmxpbmVS ZWN0IExpbmVCb3g6OmxvZ2ljYWxSZWN0Rm9yVGV4dFJ1bihjb25zdCBMaW5lOjpSdW4mIHJ1bikg Y29uc3QKICAgICAgICAgcnVubG9naWNhbFRvcCArPSBwYXJlbnRJbmxpbmVCb3gtPmxvZ2ljYWxU b3AoKTsKICAgICB9CiAgICAgSW5saW5lTGF5b3V0VW5pdCBsb2dpY2FsSGVpZ2h0ID0gZm9udE1l dHJpY3MuaGVpZ2h0KCk7Ci0gICAgcmV0dXJuIHsgcnVubG9naWNhbFRvcCwgbV9yb290SW5saW5l Qm94LT5sb2dpY2FsTGVmdCgpICsgcnVuLmxvZ2ljYWxMZWZ0KCksIHJ1bi5sb2dpY2FsV2lkdGgo KSwgbG9naWNhbEhlaWdodCB9OworICAgIHJldHVybiB7IHJ1bmxvZ2ljYWxUb3AsIG1fcm9vdElu bGluZUJveC5sb2dpY2FsTGVmdCgpICsgcnVuLmxvZ2ljYWxMZWZ0KCksIHJ1bi5sb2dpY2FsV2lk dGgoKSwgbG9naWNhbEhlaWdodCB9OwogfQogCiBJbmxpbmVSZWN0IExpbmVCb3g6OmxvZ2ljYWxS ZWN0Rm9yTGluZUJyZWFrQm94KGNvbnN0IEJveCYgbGF5b3V0Qm94KSBjb25zdApAQCAtMTMyLDgg KzEzMiw4IEBAIElubGluZVJlY3QgTGluZUJveDo6bG9naWNhbFJlY3RGb3JJbmxpbmVMZXZlbEJv eChjb25zdCBCb3gmIGxheW91dEJveCkgY29uc3QKICAgICAgICAgcmV0dXJuIGlubGluZUJveExv Z2ljYWxSZWN0OwogCiAgICAgLy8gRmFzdCBwYXRoIGZvciBpbmxpbmUgbGV2ZWwgYm94ZXMgb24g dGhlIHJvb3QgaW5saW5lIGJveCAoZS5nIDxkaXY+PGltZz48L2Rpdj4pLgotICAgIGlmICgmbGF5 b3V0Qm94LnBhcmVudCgpID09ICZtX3Jvb3RJbmxpbmVCb3gtPmxheW91dEJveCgpKSB7Ci0gICAg ICAgIGlubGluZUJveExvZ2ljYWxSZWN0Lm1vdmVWZXJ0aWNhbGx5KG1fcm9vdElubGluZUJveC0+ bG9naWNhbFRvcCgpKTsKKyAgICBpZiAoJmxheW91dEJveC5wYXJlbnQoKSA9PSAmbV9yb290SW5s aW5lQm94LmxheW91dEJveCgpKSB7CisgICAgICAgIGlubGluZUJveExvZ2ljYWxSZWN0Lm1vdmVW ZXJ0aWNhbGx5KG1fcm9vdElubGluZUJveC5sb2dpY2FsVG9wKCkpOwogICAgICAgICByZXR1cm4g aW5saW5lQm94TG9naWNhbFJlY3Q7CiAgICAgfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lQm94LmggYi9Tb3VyY2UvV2ViQ29y ZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lQm94LmgKaW5kZXggZDg1ZTIxYjY5 ZGU2MzA1MzA2MWM5ODgwOGRjZTViODUxMTg1ZTVkNC4uZGFiMmZhMDlmMTNlMDg5YTczODI2MDU2 NDU3ODg3ZmMzYTgyNzFjZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbGF5b3V0L2lubGlu ZWZvcm1hdHRpbmcvSW5saW5lTGluZUJveC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9p bmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCb3guaApAQCAtMTUzLDcgKzE1Myw3IEBAIHB1Ymxp YzoKIAogICAgIElubGluZVJlY3QgbG9naWNhbFJlY3RGb3JUZXh0UnVuKGNvbnN0IExpbmU6OlJ1 biYpIGNvbnN0OwogICAgIElubGluZVJlY3QgbG9naWNhbFJlY3RGb3JMaW5lQnJlYWtCb3goY29u c3QgQm94JikgY29uc3Q7Ci0gICAgSW5saW5lUmVjdCBsb2dpY2FsUmVjdEZvclJvb3RJbmxpbmVC b3goKSBjb25zdCB7IHJldHVybiBtX3Jvb3RJbmxpbmVCb3gtPmxvZ2ljYWxSZWN0KCk7IH0KKyAg ICBJbmxpbmVSZWN0IGxvZ2ljYWxSZWN0Rm9yUm9vdElubGluZUJveCgpIGNvbnN0IHsgcmV0dXJu IG1fcm9vdElubGluZUJveC5sb2dpY2FsUmVjdCgpOyB9CiAgICAgSW5saW5lUmVjdCBsb2dpY2Fs Qm9yZGVyQm94Rm9yQXRvbWljSW5saW5lTGV2ZWxCb3goY29uc3QgQm94JiwgY29uc3QgQm94R2Vv bWV0cnkmKSBjb25zdDsKICAgICBJbmxpbmVSZWN0IGxvZ2ljYWxCb3JkZXJCb3hGb3JJbmxpbmVC b3goY29uc3QgQm94JiwgY29uc3QgQm94R2VvbWV0cnkmKSBjb25zdDsKIApAQCAtMTYxLDcgKzE2 MSw3IEBAIHB1YmxpYzoKICAgICB1c2luZyBJbmxpbmVMZXZlbEJveExpc3QgPSBWZWN0b3I8c3Rk Ojp1bmlxdWVfcHRyPElubGluZUxldmVsQm94Pj47CiAgICAgY29uc3QgSW5saW5lTGV2ZWxCb3hM aXN0JiBub25Sb290SW5saW5lTGV2ZWxCb3hlcygpIGNvbnN0IHsgcmV0dXJuIG1fbm9uUm9vdElu bGluZUxldmVsQm94TGlzdDsgfQogCi0gICAgSW5saW5lTGF5b3V0VW5pdCBhbGlnbm1lbnRCYXNl bGluZSgpIGNvbnN0IHsgcmV0dXJuIG1fcm9vdElubGluZUJveC0+bG9naWNhbFRvcCgpICsgbV9y b290SW5saW5lQm94LT5iYXNlbGluZSgpOyB9CisgICAgSW5saW5lTGF5b3V0VW5pdCBhbGlnbm1l bnRCYXNlbGluZSgpIGNvbnN0IHsgcmV0dXJuIG1fcm9vdElubGluZUJveC5sb2dpY2FsVG9wKCkg KyBtX3Jvb3RJbmxpbmVCb3guYmFzZWxpbmUoKTsgfQogCiBwcml2YXRlOgogICAgIGZyaWVuZCBj bGFzcyBMaW5lQm94QnVpbGRlcjsKQEAgLTE3Miw3ICsxNzIsNyBAQCBwcml2YXRlOgogCiAgICAg SW5saW5lTGV2ZWxCb3gmIHJvb3RJbmxpbmVCb3goKSB7IHJldHVybiBtX3Jvb3RJbmxpbmVCb3g7 IH0KIAotICAgIElubGluZUxldmVsQm94JiBpbmxpbmVMZXZlbEJveEZvckxheW91dEJveChjb25z dCBCb3gmIGxheW91dEJveCkgeyByZXR1cm4gJmxheW91dEJveCA9PSAmbV9yb290SW5saW5lQm94 LT5sYXlvdXRCb3goKSA/IG1fcm9vdElubGluZUJveC5nZXQoKSA6ICptX25vblJvb3RJbmxpbmVM ZXZlbEJveE1hcC5nZXQoJmxheW91dEJveCk7IH0KKyAgICBJbmxpbmVMZXZlbEJveCYgaW5saW5l TGV2ZWxCb3hGb3JMYXlvdXRCb3goY29uc3QgQm94JiBsYXlvdXRCb3gpIHsgcmV0dXJuICZsYXlv dXRCb3ggPT0gJm1fcm9vdElubGluZUJveC5sYXlvdXRCb3goKSA/IG1fcm9vdElubGluZUJveCA6 ICptX25vblJvb3RJbmxpbmVMZXZlbEJveE1hcC5nZXQoJmxheW91dEJveCk7IH0KICAgICBJbmxp bmVSZWN0IGxvZ2ljYWxSZWN0Rm9ySW5saW5lTGV2ZWxCb3goY29uc3QgQm94JiBsYXlvdXRCb3gp IGNvbnN0OwogCiAgICAgdm9pZCBzZXRIYXNDb250ZW50KGJvb2wgaGFzQ29udGVudCkgeyBtX2hh c0NvbnRlbnQgPSBoYXNDb250ZW50OyB9CkBAIC0xODMsNyArMTgzLDcgQEAgcHJpdmF0ZToKICAg ICBib29sIG1faGFzQ29udGVudCB7IGZhbHNlIH07CiAgICAgT3B0aW9uU2V0PElubGluZUxldmVs Qm94OjpUeXBlPiBtX2JveFR5cGVzOwogCi0gICAgVW5pcXVlUmVmPElubGluZUxldmVsQm94PiBt X3Jvb3RJbmxpbmVCb3g7CisgICAgSW5saW5lTGV2ZWxCb3ggbV9yb290SW5saW5lQm94OwogICAg IElubGluZUxldmVsQm94TGlzdCBtX25vblJvb3RJbmxpbmVMZXZlbEJveExpc3Q7CiAKICAgICBI YXNoTWFwPGNvbnN0IEJveCosIElubGluZUxldmVsQm94Kj4gbV9ub25Sb290SW5saW5lTGV2ZWxC b3hNYXA7Cg==