222704 2021-03-03 19:25:20 -0800 [LFC][IFC] Make LineBox::m_inlineLevelBoxRectMap a non-root inline level box map 2021-03-04 06:25:01 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan zalan bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1735645 0 zalan 2021-03-03 19:25:20 -0800 root inline box does not need to go in there. 1735647 1 422174 zalan 2021-03-03 19:27:56 -0800 Created attachment 422174 Patch 1735667 2 422174 koivisto 2021-03-03 21:21:03 -0800 Comment on attachment 422174 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422174&action=review > Source/WebCore/layout/inlineformatting/InlineLineBox.cpp:92 > - m_inlineLevelBoxRectMap.reserveInitialCapacity(numberOfRuns); > - m_inlineLevelBoxRectMap.set(&rootLayoutBox, &m_rootInlineBox); > + m_nonRootInlineLevelBoxMap.reserveInitialCapacity(numberOfRuns); Does it need one less capacity now? 1735801 3 ews-feeder 2021-03-04 06:22:51 -0800 Committed r273887: <https://commits.webkit.org/r273887> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422174. 1735803 4 webkit-bug-importer 2021-03-04 06:23:13 -0800 <rdar://problem/75033710> 1735805 5 zalan 2021-03-04 06:25:01 -0800 (In reply to Antti Koivisto from comment #2) > Comment on attachment 422174 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=422174&action=review > > > Source/WebCore/layout/inlineformatting/InlineLineBox.cpp:92 > > - m_inlineLevelBoxRectMap.reserveInitialCapacity(numberOfRuns); > > - m_inlineLevelBoxRectMap.set(&rootLayoutBox, &m_rootInlineBox); > > + m_nonRootInlineLevelBoxMap.reserveInitialCapacity(numberOfRuns); > > Does it need one less capacity now? yeah I was going to talk to you about it. we need a better approximation for this. 422174 2021-03-03 19:27:56 -0800 2021-03-04 06:22:52 -0800 Patch bug-222704-20210303192755.patch text/plain 4519 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjczODY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOThkM2QzYjc5ODU3MjY0 MDAxMjhiZmRiYWUyZDA3YjhjNGY5MzE2Mi4uMWFjNjc3NWY4YmQ2OWM1ZWE3YWM5ODIzZDM0NjNk ZmY3YzJlNWU0NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIxLTAzLTAzICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBNYWtlIExp bmVCb3g6Om1faW5saW5lTGV2ZWxCb3hSZWN0TWFwIGEgbm9uLXJvb3QgaW5saW5lIGxldmVsIGJv eCBtYXAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIy MjcwNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIExl dCdzIG5vdCB0cmlnZ2VyIGhhc2ggbG9va3VwIGZvciB0aGUgbW9zdCBjb21tb24gaW5saW5lTGV2 ZWxCb3hGb3JMYXlvdXRCb3goKSBjYWxsICh3aGVuIHdlIGxvb2t1cCB0aGUgcm9vdCBpbmxpbmUg Ym94CisgICAgICAgIGFzIHRoZSBwYXJlbnQgb2YgYSB0ZXh0IGNvbnRlbnQpLgorCisgICAgICAg ICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJveC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpMYXlvdXQ6OkxpbmVCb3g6OmFkZElubGluZUxldmVsQm94KToKKyAgICAgICAgKiBs YXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lQm94Lmg6CisgICAgICAgIChXZWJDb3Jl OjpMYXlvdXQ6OkxpbmVCb3g6OmlubGluZUxldmVsQm94Rm9yTGF5b3V0Qm94IGNvbnN0KToKKyAg ICAgICAgKFdlYkNvcmU6OkxheW91dDo6TGluZUJveDo6aW5saW5lTGV2ZWxCb3hGb3JMYXlvdXRC b3gpOgorCiAyMDIxLTAzLTAzICBKdWxpYW4gR29uemFsZXogIDxqdWxpYW5fYV9nb256YWxlekBh cHBsZS5jb20+CiAKICAgICAgICAgQ3Jhc2ggaW4gcmVtb3ZlU3ltYm9sRWxlbWVudHNGcm9tU3Vi dHJlZSgpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGlu Zy9JbmxpbmVMaW5lQm94LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0 aW5nL0lubGluZUxpbmVCb3guY3BwCmluZGV4IDhkMGY4MmFhN2E1NzdmZGEyYWJmNjk3MzRiZTM0 NzIwNzQ3YmFkNTUuLjBkMzhlN2E3OTY2MTEwYzFlMzEyYWMyZWI3ZjZmYTUzMjNkYmVhMTcgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxp bmVCb3guY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lu bGluZUxpbmVCb3guY3BwCkBAIC04OSwxNCArODksMTMgQEAgTGluZUJveDo6TGluZUJveChjb25z dCBCb3gmIHJvb3RMYXlvdXRCb3gsIGNvbnN0IElubGluZUxheW91dFBvaW50JiBsb2dpY2FsVG9w bGUKICAgICAsIG1fcm9vdElubGluZUJveChtYWtlVW5pcXVlUmVmPExpbmVCb3g6OklubGluZUxl dmVsQm94Pihyb290TGF5b3V0Qm94LCBjb250ZW50TG9naWNhbExlZnQsIElubGluZUxheW91dFNp emUgeyBjb250ZW50TG9naWNhbFdpZHRoLCB7IH0gfSwgSW5saW5lTGV2ZWxCb3g6OlR5cGU6OlJv b3RJbmxpbmVCb3gpKQogewogICAgIG1fbm9uUm9vdElubGluZUxldmVsQm94TGlzdC5yZXNlcnZl SW5pdGlhbENhcGFjaXR5KG51bWJlck9mUnVucyk7Ci0gICAgbV9pbmxpbmVMZXZlbEJveFJlY3RN YXAucmVzZXJ2ZUluaXRpYWxDYXBhY2l0eShudW1iZXJPZlJ1bnMpOwotICAgIG1faW5saW5lTGV2 ZWxCb3hSZWN0TWFwLnNldCgmcm9vdExheW91dEJveCwgJm1fcm9vdElubGluZUJveCk7CisgICAg bV9ub25Sb290SW5saW5lTGV2ZWxCb3hNYXAucmVzZXJ2ZUluaXRpYWxDYXBhY2l0eShudW1iZXJP ZlJ1bnMpOwogfQogCiB2b2lkIExpbmVCb3g6OmFkZElubGluZUxldmVsQm94KHN0ZDo6dW5pcXVl X3B0cjxJbmxpbmVMZXZlbEJveD4mJiBpbmxpbmVMZXZlbEJveCkKIHsKICAgICBtX2JveFR5cGVz LmFkZChpbmxpbmVMZXZlbEJveC0+dHlwZSgpKTsKLSAgICBtX2lubGluZUxldmVsQm94UmVjdE1h cC5zZXQoJmlubGluZUxldmVsQm94LT5sYXlvdXRCb3goKSwgaW5saW5lTGV2ZWxCb3guZ2V0KCkp OworICAgIG1fbm9uUm9vdElubGluZUxldmVsQm94TWFwLnNldCgmaW5saW5lTGV2ZWxCb3gtPmxh eW91dEJveCgpLCBpbmxpbmVMZXZlbEJveC5nZXQoKSk7CiAgICAgbV9ub25Sb290SW5saW5lTGV2 ZWxCb3hMaXN0LmFwcGVuZChXVEZNb3ZlKGlubGluZUxldmVsQm94KSk7CiB9CiAKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCb3gu aCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbmxpbmVmb3JtYXR0aW5nL0lubGluZUxpbmVCb3gu aAppbmRleCBlNmMyMGRmMDcyOTZlNWM3MDY4MDlkOTYyOWJjOGNjNDkzZDQ3ZGQ1Li5kODVlMjFi NjlkZTYzMDUzMDYxYzk4ODA4ZGNlNWI4NTExODVlNWQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVMaW5lQm94LmgKKysrIGIvU291cmNl L1dlYkNvcmUvbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lTGluZUJveC5oCkBAIC0xNDks NyArMTQ5LDcgQEAgcHVibGljOgogICAgIGJvb2wgaGFzTm9uSW5saW5lQm94KCkgY29uc3QgeyBy ZXR1cm4gbV9ib3hUeXBlcy5jb250YWluc0FueSh7IElubGluZUxldmVsQm94OjpUeXBlOjpBdG9t aWNJbmxpbmVMZXZlbEJveCwgSW5saW5lTGV2ZWxCb3g6OlR5cGU6OkxpbmVCcmVha0JveCwgSW5s aW5lTGV2ZWxCb3g6OlR5cGU6OkdlbmVyaWNJbmxpbmVMZXZlbEJveCB9KTsgfQogICAgIGJvb2wg aGFzQXRvbWljSW5saW5lTGV2ZWxCb3goKSBjb25zdCB7IHJldHVybiBtX2JveFR5cGVzLmNvbnRh aW5zKElubGluZUxldmVsQm94OjpUeXBlOjpBdG9taWNJbmxpbmVMZXZlbEJveCk7IH0KIAotICAg IGNvbnN0IElubGluZUxldmVsQm94JiBpbmxpbmVMZXZlbEJveEZvckxheW91dEJveChjb25zdCBC b3gmIGxheW91dEJveCkgY29uc3QgeyByZXR1cm4gKm1faW5saW5lTGV2ZWxCb3hSZWN0TWFwLmdl dCgmbGF5b3V0Qm94KTsgfQorICAgIGNvbnN0IElubGluZUxldmVsQm94JiBpbmxpbmVMZXZlbEJv eEZvckxheW91dEJveChjb25zdCBCb3gmIGxheW91dEJveCkgY29uc3QgeyByZXR1cm4gY29uc3Rf Y2FzdDxMaW5lQm94Jj4oKnRoaXMpLmlubGluZUxldmVsQm94Rm9yTGF5b3V0Qm94KGxheW91dEJv eCk7IH0KIAogICAgIElubGluZVJlY3QgbG9naWNhbFJlY3RGb3JUZXh0UnVuKGNvbnN0IExpbmU6 OlJ1biYpIGNvbnN0OwogICAgIElubGluZVJlY3QgbG9naWNhbFJlY3RGb3JMaW5lQnJlYWtCb3go Y29uc3QgQm94JikgY29uc3Q7CkBAIC0xNzIsNyArMTcyLDcgQEAgcHJpdmF0ZToKIAogICAgIElu bGluZUxldmVsQm94JiByb290SW5saW5lQm94KCkgeyByZXR1cm4gbV9yb290SW5saW5lQm94OyB9 CiAKLSAgICBJbmxpbmVMZXZlbEJveCYgaW5saW5lTGV2ZWxCb3hGb3JMYXlvdXRCb3goY29uc3Qg Qm94JiBsYXlvdXRCb3gpIHsgcmV0dXJuICptX2lubGluZUxldmVsQm94UmVjdE1hcC5nZXQoJmxh eW91dEJveCk7IH0KKyAgICBJbmxpbmVMZXZlbEJveCYgaW5saW5lTGV2ZWxCb3hGb3JMYXlvdXRC b3goY29uc3QgQm94JiBsYXlvdXRCb3gpIHsgcmV0dXJuICZsYXlvdXRCb3ggPT0gJm1fcm9vdElu bGluZUJveC0+bGF5b3V0Qm94KCkgPyBtX3Jvb3RJbmxpbmVCb3guZ2V0KCkgOiAqbV9ub25Sb290 SW5saW5lTGV2ZWxCb3hNYXAuZ2V0KCZsYXlvdXRCb3gpOyB9CiAgICAgSW5saW5lUmVjdCBsb2dp Y2FsUmVjdEZvcklubGluZUxldmVsQm94KGNvbnN0IEJveCYgbGF5b3V0Qm94KSBjb25zdDsKIAog ICAgIHZvaWQgc2V0SGFzQ29udGVudChib29sIGhhc0NvbnRlbnQpIHsgbV9oYXNDb250ZW50ID0g aGFzQ29udGVudDsgfQpAQCAtMTg2LDcgKzE4Niw3IEBAIHByaXZhdGU6CiAgICAgVW5pcXVlUmVm PElubGluZUxldmVsQm94PiBtX3Jvb3RJbmxpbmVCb3g7CiAgICAgSW5saW5lTGV2ZWxCb3hMaXN0 IG1fbm9uUm9vdElubGluZUxldmVsQm94TGlzdDsKIAotICAgIEhhc2hNYXA8Y29uc3QgQm94Kiwg SW5saW5lTGV2ZWxCb3gqPiBtX2lubGluZUxldmVsQm94UmVjdE1hcDsKKyAgICBIYXNoTWFwPGNv bnN0IEJveCosIElubGluZUxldmVsQm94Kj4gbV9ub25Sb290SW5saW5lTGV2ZWxCb3hNYXA7CiB9 OwogCiBpbmxpbmUgc3RkOjp1bmlxdWVfcHRyPExpbmVCb3g6OklubGluZUxldmVsQm94PiBMaW5l Qm94OjpJbmxpbmVMZXZlbEJveDo6Y3JlYXRlQXRvbWljSW5saW5lTGV2ZWxCb3goY29uc3QgQm94 JiBsYXlvdXRCb3gsIElubGluZUxheW91dFVuaXQgbG9naWNhbExlZnQsIElubGluZUxheW91dFNp emUgbG9naWNhbFNpemUpCg==