222695 2021-03-03 16:02:03 -0800 [JSC] ENABLE(JIT_CAGE) requires HAVE(JIT_CAGE) 2021-03-03 20:21:15 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki benjamin cdumez cmarcelo ews-watchlist saam webkit-bug-importer oldest_to_newest 1735574 0 ysuzuki 2021-03-03 16:02:03 -0800 [JSC] ENABLE(JIT_CAGE) requires HAVE(JIT_CAGE) 1735575 1 422157 ysuzuki 2021-03-03 16:02:40 -0800 Created attachment 422157 Patch 1735579 2 422157 ap 2021-03-03 16:05:44 -0800 Comment on attachment 422157 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422157&action=review > Source/WTF/wtf/PlatformEnable.h:894 > +#if OS(DARWIN) && ENABLE(JIT) && USE(APPLE_INTERNAL_SDK) && CPU(ARM64E) && HAVE(JIT_CAGE) && ((defined(__IPHONE_OS_VERSION_MIN_REQUIRED) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 150000) || (defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000)) Can we drop the version checks now? 1735657 3 422157 ysuzuki 2021-03-03 20:14:26 -0800 Comment on attachment 422157 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=422157&action=review >> Source/WTF/wtf/PlatformEnable.h:894 >> +#if OS(DARWIN) && ENABLE(JIT) && USE(APPLE_INTERNAL_SDK) && CPU(ARM64E) && HAVE(JIT_CAGE) && ((defined(__IPHONE_OS_VERSION_MIN_REQUIRED) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 150000) || (defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000)) > > Can we drop the version checks now? I personally prefer controlling it here since this is easy & less-error-prone compared to relying on HAVE(JIT_CAGE), but I'm OK. 1735658 4 ysuzuki 2021-03-03 20:20:05 -0800 Committed r273870 (234831@main): <https://commits.webkit.org/234831@main> 1735659 5 webkit-bug-importer 2021-03-03 20:21:15 -0800 <rdar://problem/75018054> 422157 2021-03-03 16:02:40 -0800 2021-03-03 16:04:11 -0800 Patch bug-222695-20210303160239.patch text/plain 1637 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjczODUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDBhNjM2NTdjNGQ4ZTc1NzVkYmE4ODZm MTc5N2NhZGUxY2Q1OGU5OWIuLjFkYWE5ZjVkNDczYmMyMTQ5ZjJmMjAwOTA3OWQxNTEwNjEyOWRl OTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMDMtMDMgIFl1c3VrZSBTdXp1a2kgIDx5c3V6 dWtpQGFwcGxlLmNvbT4KKworICAgICAgICBbSlNDXSBFTkFCTEUoSklUX0NBR0UpIHJlcXVpcmVz IEhBVkUoSklUX0NBR0UpCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMjI2OTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBIQVZFKEpJVF9DQUdFKSBpcyBpbnRlcm5hbGx5IGRlZmluZWQuIFdlIHVzZSBIQVZF KEpJVF9DQUdFKSB3aGVuIGRlZmluaW5nIEVOQUJMRShKSVRfQ0FHRSkuCisKKyAgICAgICAgKiB3 dGYvUGxhdGZvcm1FbmFibGUuaDoKKwogMjAyMS0wMy0wMyAgQ2hyaXMgRHVtZXogIDxjZHVtZXpA YXBwbGUuY29tPgogCiAgICAgICAgIFttYWNPU11bV0syXSBDaGFuZ2luZyB0aGUgc3lzdGVtIGxh bmd1YWdlIGRvZXMgbm90IHVwZGF0ZSBuYXZpZ2F0b3IubGFuZ3VhZ2UKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XVEYvd3RmL1BsYXRmb3JtRW5hYmxlLmggYi9Tb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybUVu YWJsZS5oCmluZGV4IDJlYjgxNTg3Y2E0NTEzYzE5ZjkxZmUzMmU0YTk0ZmY5OWI4MzNiYzQuLmZk MDU4OWYxOGJhNGNhZjNhNDJkNTQzM2Y2ZGRlOTVmNThhMmQ1ZDMgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XVEYvd3RmL1BsYXRmb3JtRW5hYmxlLmgKKysrIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm1F bmFibGUuaApAQCAtODkxLDcgKzg5MSw3IEBACiAjZXJyb3IgIkVOQUJMRShXSExTTF9DT01QSUxF UikgcmVxdWlyZXMgRU5BQkxFKFdFQkdQVSkiCiAjZW5kaWYKIAotI2lmIE9TKERBUldJTikgJiYg RU5BQkxFKEpJVCkgJiYgVVNFKEFQUExFX0lOVEVSTkFMX1NESykgJiYgQ1BVKEFSTTY0RSkgJiYg KChkZWZpbmVkKF9fSVBIT05FX09TX1ZFUlNJT05fTUlOX1JFUVVJUkVEKSAmJiBfX0lQSE9ORV9P U19WRVJTSU9OX01JTl9SRVFVSVJFRCA+PSAxNTAwMDApIHx8IChkZWZpbmVkKF9fTUFDX09TX1hf VkVSU0lPTl9NSU5fUkVRVUlSRUQpICYmIF9fTUFDX09TX1hfVkVSU0lPTl9NSU5fUkVRVUlSRUQg Pj0gMTIwMDAwKSkKKyNpZiBPUyhEQVJXSU4pICYmIEVOQUJMRShKSVQpICYmIFVTRShBUFBMRV9J TlRFUk5BTF9TREspICYmIENQVShBUk02NEUpICYmIEhBVkUoSklUX0NBR0UpICYmICgoZGVmaW5l ZChfX0lQSE9ORV9PU19WRVJTSU9OX01JTl9SRVFVSVJFRCkgJiYgX19JUEhPTkVfT1NfVkVSU0lP Tl9NSU5fUkVRVUlSRUQgPj0gMTUwMDAwKSB8fCAoZGVmaW5lZChfX01BQ19PU19YX1ZFUlNJT05f TUlOX1JFUVVJUkVEKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJUkVEID49IDEyMDAw MCkpCiAjZGVmaW5lIEVOQUJMRV9KSVRfQ0FHRSAxCiAjZW5kaWYKIAo=