222680 2021-03-03 12:39:03 -0800 [ESNext] Private methods can't be named as '#constructor' 2021-03-04 03:29:28 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ticaiolima ticaiolima ews-watchlist keith_miller mark.lam msaboff saam tzagallo webkit-bug-importer ysuzuki oldest_to_newest 1735442 0 ticaiolima 2021-03-03 12:39:03 -0800 Current implementation is not following the spec. 1735461 1 422139 ticaiolima 2021-03-03 13:00:40 -0800 Created attachment 422139 Patch 1735486 2 422139 ysuzuki 2021-03-03 13:30:37 -0800 Comment on attachment 422139 Patch r=me 1735542 3 ews-feeder 2021-03-03 15:00:14 -0800 Committed r273846: <https://commits.webkit.org/r273846> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422139. 1735545 4 webkit-bug-importer 2021-03-03 15:02:04 -0800 <rdar://problem/75005376> 422139 2021-03-03 13:00:40 -0800 2021-03-04 03:29:28 -0800 Patch bug-222680-20210303180037.patch text/plain 4949 ticaiolima U3VidmVyc2lvbiBSZXZpc2lvbjogMjczODI5CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCAx NGYyZjljNTI5NTI4YzI1OTc0OGQyOWY0NzM1M2ZlYTA5ODQzM2RmLi4wYTk1MmQ2N2I4YjhmODY4 ZDMzYmZmMDFjN2U2ZjliM2Y0YzU5ZGY5IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOCBAQAorMjAyMS0wMy0wMyAgQ2FpbyBMaW1hICA8dGljYWlvbGltYUBnbWFpbC5jb20+ CisKKyAgICAgICAgW0VTTmV4dF0gUHJpdmF0ZSBtZXRob2RzIGNhbid0IGJlIG5hbWVkIGFzICcj Y29uc3RydWN0b3InCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjI2ODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJdCdzIGEgYFN5bnRheEVycm9yYCB3aGVuIHdlIHRyeSB0byB1c2UgYCNjb25zdHJ1Y3Rv cmAgYXMgcHJpdmF0ZSBuYW1lCisgICAgICAgIGZvciBtZXRob2RzLCBhY2Nlc3NvcnMsIGFuZCBm aWVsZHMuIFRoaXMgcGF0Y2ggaXMgZml4aW5nIHN1Y2ggYnVnIGZvcgorICAgICAgICBtZXRob2Rz IGFuZCBhY2Nlc3NvcnMuCisKKyAgICAgICAgKiBwYXJzZXIvUGFyc2VyLmNwcDoKKyAgICAgICAg KEpTQzo6UGFyc2VyPExleGVyVHlwZT46OnBhcnNlQ2xhc3MpOgorICAgICAgICAoSlNDOjpQYXJz ZXI8TGV4ZXJUeXBlPjo6cGFyc2VHZXR0ZXJTZXR0ZXIpOgorCiAyMDIxLTAzLTAzICBBbGV4ZXkg U2h2YXlrYSAgPHNodmFpa2FsZXNoQGdtYWlsLmNvbT4KIAogICAgICAgICBBZGQgSlNNb2R1bGVO YW1lc3BhY2VPYmplY3Q6OmRlbGV0ZVByb3BlcnR5QnlJbmRleCgpIG1ldGhvZApkaWZmIC0tZ2l0 IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwIGIvU291cmNlL0phdmFT Y3JpcHRDb3JlL3BhcnNlci9QYXJzZXIuY3BwCmluZGV4IGI2ZTFjYzhhMDZlNzA4YWJmY2I5ZTlk M2Y3OTFiMzNjNjljNTc2ZWIuLjU1ZTBmY2JmOTUwNjA3ZTliYzY2ZmM1NTFiMWQxZDgwOWYxMjhm MWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyLmNwcAor KysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlci5jcHAKQEAgLTMwMTUsNyAr MzAxNSw3IEBAIHBhcnNlTWV0aG9kOgogICAgICAgICAgICAgbmV4dCgpOwogICAgICAgICAgICAg aWYgKE9wdGlvbnM6OnVzZVByaXZhdGVNZXRob2RzKCkgJiYgbWF0Y2goT1BFTlBBUkVOKSkgewog ICAgICAgICAgICAgICAgIHNlbWFudGljRmFpbElmVHJ1ZShjbGFzc1Njb3BlLT5kZWNsYXJlUHJp dmF0ZU1ldGhvZCgqaWRlbnQsIHRhZykgJiBEZWNsYXJhdGlvblJlc3VsdDo6SW52YWxpZER1cGxp Y2F0ZURlY2xhcmF0aW9uLCAiQ2Fubm90IGRlY2xhcmUgcHJpdmF0ZSBtZXRob2QgdHdpY2UiKTsK LSAgICAgICAgICAgICAgICBzZW1hbnRpY0ZhaWxJZlRydWUodGFnID09IENsYXNzRWxlbWVudFRh Zzo6U3RhdGljICYmICppZGVudCA9PSBwcm9wZXJ0eU5hbWVzLmNvbnN0cnVjdG9yUHJpdmF0ZUZp ZWxkLCAiQ2Fubm90IGRlY2xhcmUgYSBzdGF0aWMgcHJpdmF0ZSBtZXRob2QgbmFtZWQgJ2NvbnN0 cnVjdG9yJyIpOworICAgICAgICAgICAgICAgIHNlbWFudGljRmFpbElmVHJ1ZSgqaWRlbnQgPT0g cHJvcGVydHlOYW1lcy5jb25zdHJ1Y3RvclByaXZhdGVGaWVsZCwgIkNhbm5vdCBkZWNsYXJlIGEg cHJpdmF0ZSBtZXRob2QgbmFtZWQgJyNjb25zdHJ1Y3RvciciKTsKIAogICAgICAgICAgICAgICAg IGlmICh0YWcgPT0gQ2xhc3NFbGVtZW50VGFnOjpTdGF0aWMpCiAgICAgICAgICAgICAgICAgICAg IGRlY2xhcmVzU3RhdGljUHJpdmF0ZUFjY2Vzc29yID0gdHJ1ZTsKQEAgLTQ0ODIsNiArNDQ4Miw3 IEBAIHRlbXBsYXRlIDxjbGFzcyBUcmVlQnVpbGRlcj4gVHJlZVByb3BlcnR5IFBhcnNlcjxMZXhl clR5cGU+OjpwYXJzZUdldHRlclNldHRlcihUCiAgICAgICAgICAgICAiQ2Fubm90IGRlY2xhcmUg YSBzdGF0aWMgbWV0aG9kIG5hbWVkICdwcm90b3R5cGUnIik7CiAgICAgICAgIHNlbWFudGljRmFp bElmVHJ1ZSh0YWcgPT0gQ2xhc3NFbGVtZW50VGFnOjpJbnN0YW5jZSAmJiAqc3RyaW5nUHJvcGVy dHlOYW1lID09IG1fdm0ucHJvcGVydHlOYW1lcy0+Y29uc3RydWN0b3IsCiAgICAgICAgICAgICAi Q2Fubm90IGRlY2xhcmUgYSBnZXR0ZXIgb3Igc2V0dGVyIG5hbWVkICdjb25zdHJ1Y3RvciciKTsK KyAgICAgICAgc2VtYW50aWNGYWlsSWZUcnVlKCpzdHJpbmdQcm9wZXJ0eU5hbWUgPT0gbV92bS5w cm9wZXJ0eU5hbWVzLT5jb25zdHJ1Y3RvclByaXZhdGVGaWVsZCwgIkNhbm5vdCBkZWNsYXJlIGEg cHJpdmF0ZSBhY2Nlc3NvciBuYW1lZCAnI2NvbnN0cnVjdG9yJyIpOwogCiAgICAgICAgIGlmICht YXRjaChQUklWQVRFTkFNRSkpCiAgICAgICAgICAgICBzZW1hbnRpY0ZhaWxJZlRydWUodGFnID09 IENsYXNzRWxlbWVudFRhZzo6Tm8sICJDYW5ub3QgZGVjbGFyZSBhIHByaXZhdGUgc2V0dGVyIG9y IGdldHRlciBvdXRzaWRlIGEgY2xhc3MiKTsKZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9n IGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXggY2UzZjJlN2FhYjYxOTQ3M2MzMDBkYjIyM2YwODQw MzBmYzk0YjQ5Ny4uOTBiYWQ0YjkxNjBjMGJkNDIxNzE5YWM3ODlhMzk4YzBhZjczOGFlNyAxMDA2 NDQKLS0tIGEvSlNUZXN0cy9DaGFuZ2VMb2cKKysrIGIvSlNUZXN0cy9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxMiBAQAorMjAyMS0wMy0wMyAgQ2FpbyBMaW1hICA8dGljYWlvbGltYUBnbWFpbC5jb20+ CisKKyAgICAgICAgW0VTTmV4dF0gUHJpdmF0ZSBtZXRob2RzIGNhbid0IGJlIG5hbWVkIGFzICcj Y29uc3RydWN0b3InCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjI2ODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIHN0cmVzcy9wcml2YXRlLW1ldGhvZC1hbmQtZmllbGQtbmFtZWQtY29uc3RydWN0b3Iu anM6IEFkZGVkLgorCiAyMDIxLTAzLTAzICBBbGV4ZXkgU2h2YXlrYSAgPHNodmFpa2FsZXNoQGdt YWlsLmNvbT4KIAogICAgICAgICBBZGQgSlNNb2R1bGVOYW1lc3BhY2VPYmplY3Q6OmRlbGV0ZVBy b3BlcnR5QnlJbmRleCgpIG1ldGhvZApkaWZmIC0tZ2l0IGEvSlNUZXN0cy9zdHJlc3MvcHJpdmF0 ZS1tZXRob2QtYW5kLWZpZWxkLW5hbWVkLWNvbnN0cnVjdG9yLmpzIGIvSlNUZXN0cy9zdHJlc3Mv cHJpdmF0ZS1tZXRob2QtYW5kLWZpZWxkLW5hbWVkLWNvbnN0cnVjdG9yLmpzCm5ldyBmaWxlIG1v ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu LmYxM2JjNTQzZmVkMjM1MDVkMDg0NGZjMzIwZGQzNmU0OTQzOGE2MDAKLS0tIC9kZXYvbnVsbAor KysgYi9KU1Rlc3RzL3N0cmVzcy9wcml2YXRlLW1ldGhvZC1hbmQtZmllbGQtbmFtZWQtY29uc3Ry dWN0b3IuanMKQEAgLTAsMCArMSwzMiBAQAorLy9AIHJlcXVpcmVPcHRpb25zKCItLXVzZVByaXZh dGVNZXRob2RzPXRydWUiKQorCitmdW5jdGlvbiBhc3NlcnRTeW50YXhFcnJvcihjb2RlKSB7Cisg ICAgdHJ5IHsKKyAgICAgICAgZXZhbChjb2RlKTsKKyAgICAgICAgdGhyb3cgbmV3IEVycm9yKCJT aG91bGQgdGhyb3cgU3ludGF4RXJyb3IsIGJ1dCBleGVjdXRlZCBjb2RlIHdpdGhvdXQgdGhyb3dp bmciKTsKKyAgICB9IGNhdGNoKGUpIHsKKyAgICAgICAgaWYgKCFlIGluc3RhbmNlb2YgU3ludGF4 RXJyb3IpCisgICAgICAgICAgICB0aHJvdyBuZXcgRXJyb3IoIlNob3VsZCB0aHJvdyBTeW50YXhF cnJvciwgYnV0IHRocmV3ICIgKyBlKTsKKyAgICB9Cit9CisKK2Fzc2VydFN5bnRheEVycm9yKCJs ZXQgQyA9IGNsYXNzIHsgI2NvbnN0cnVjdG9yKCkge30gfSIpOworYXNzZXJ0U3ludGF4RXJyb3Io ImxldCBDID0gY2xhc3MgeyBzdGF0aWMgI2NvbnN0cnVjdG9yKCkge30gfSIpOworYXNzZXJ0U3lu dGF4RXJyb3IoImNsYXNzIEMgeyAjY29uc3RydWN0b3IoKSB7fSB9Iik7Cithc3NlcnRTeW50YXhF cnJvcigiY2xhc3MgQyB7IHN0YXRpYyAjY29uc3RydWN0b3IoKSB7fSB9Iik7CisKK2Fzc2VydFN5 bnRheEVycm9yKCJsZXQgQyA9IGNsYXNzIHsgZ2V0ICNjb25zdHJ1Y3RvcigpIHt9IH0iKTsKK2Fz c2VydFN5bnRheEVycm9yKCJsZXQgQyA9IGNsYXNzIHsgc3RhdGljIGdldCAjY29uc3RydWN0b3Io KSB7fSB9Iik7Cithc3NlcnRTeW50YXhFcnJvcigiY2xhc3MgQyB7IGdldCAjY29uc3RydWN0b3Io KSB7fSB9Iik7Cithc3NlcnRTeW50YXhFcnJvcigiY2xhc3MgQyB7IHN0YXRpYyBnZXQgI2NvbnN0 cnVjdG9yKCkge30gfSIpOworCithc3NlcnRTeW50YXhFcnJvcigibGV0IEMgPSBjbGFzcyB7IHNl dCAjY29uc3RydWN0b3Iodikge30gfSIpOworYXNzZXJ0U3ludGF4RXJyb3IoImxldCBDID0gY2xh c3MgeyBzdGF0aWMgc2V0ICNjb25zdHJ1Y3Rvcih2KSB7fSB9Iik7Cithc3NlcnRTeW50YXhFcnJv cigiY2xhc3MgQyB7IHNldCAjY29uc3RydWN0b3Iodikge30gfSIpOworYXNzZXJ0U3ludGF4RXJy b3IoImNsYXNzIEMgeyBzdGF0aWMgc2V0ICNjb25zdHJ1Y3Rvcih2KSB7fSB9Iik7CisKK2Fzc2Vy dFN5bnRheEVycm9yKCJsZXQgQyA9IGNsYXNzIHsgI2NvbnN0cnVjdG9yOyB9Iik7Cithc3NlcnRT eW50YXhFcnJvcigibGV0IEMgPSBjbGFzcyB7IHN0YXRpYyAjY29uc3RydWN0b3I7IH0iKTsKK2Fz c2VydFN5bnRheEVycm9yKCJjbGFzcyBDIHsgI2NvbnN0cnVjdG9yOyB9Iik7Cithc3NlcnRTeW50 YXhFcnJvcigiY2xhc3MgQyB7IHN0YXRpYyAjY29uc3RydWN0b3I7IH0iKTsKKwo=