22263 2008-11-14 07:49:29 -0800 Web Inspector: mouse drifts away from resizer when resizing docked inspector 2014-09-15 17:41:48 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 aroben webkit-unassigned beidson burg commit-queue graouts joepeck mattbaker timothy webkit-bug-importer oldest_to_newest 98777 0 aroben 2008-11-14 07:49:29 -0800 To reproduce: 1. Go to any web page (e.g., <http://webkit.org/>) 2. Show the Inspector 3. Dock the Inspector into the WebView 4. Click and hold on the top edge of the Inspector to start resizing it 5. Drag the mouse down below the bottom of the Safari window 6. Start dragging the mouse up again As soon as you begin (6), the Inspector starts growing vertically, even though the mouse is quite far from the resizer. The Inspector should instead wait until the mouse is back on top of the resizer to begin growing. 98778 1 aroben 2008-11-14 07:49:51 -0800 <rdar://problem/6371885> 867431 2 timothy 2013-04-01 16:58:57 -0700 *** Bug 35264 has been marked as a duplicate of this bug. *** 967065 3 bburg 2014-01-12 15:42:33 -0800 Still reproducible! :) 1035272 4 mattbaker 2014-09-15 11:10:06 -0700 An additional quirk when VERY quickly resizing the docked Inspector: 1. Show the Inspector docked to the bottom of the WebView. 2. Click and hold the top edge of the Inspector to start resizing it. 3. As fast as possible, flick the mouse off the bottom of the Safari window. 4. Let go once the cursor is below the bottom of the window. Rather than being set to the minimum docked height, the height of the docked Inspector window is a large value (sometimes larger than the starting height). This occurs whether docked at the bottom or right of the WebView. 1035287 5 238135 mattbaker 2014-09-15 12:19:40 -0700 Created attachment 238135 Patch 1035303 6 238135 joepeck 2014-09-15 13:43:28 -0700 Comment on attachment 238135 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=238135&action=review r=me! > Source/WebInspectorUI/UserInterface/Base/Main.js:1302 > + // Cursor position cannot be less than initial mouse down position when resizing docked Inspector smaller. Maybe we should clarify these comments. "initial mouse down position" => "initial mouse down position within the window". Since that is what clientX/Y are giving us. 1035332 7 238147 mattbaker 2014-09-15 16:39:35 -0700 Created attachment 238147 Patch 1035343 8 238147 commit-queue 2014-09-15 17:41:45 -0700 Comment on attachment 238147 Patch Clearing flags on attachment: 238147 Committed r173640: <http://trac.webkit.org/changeset/173640> 1035344 9 commit-queue 2014-09-15 17:41:48 -0700 All reviewed patches have been landed. Closing bug. 238135 2014-09-15 12:19:40 -0700 2014-09-15 16:39:33 -0700 Patch bug-22263-20140915121937.patch text/plain 3249 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNDM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk MGFmNGQ4ZjczMTZjYTA0ZWFmZWM3MzRmMzQyYjc5MjYxMGVlZDc1Li43YTkxYTY0YTZhYzlkYTJm ZmE3ZDc3OWZlNWVjNGFmZTBhMTRhMzJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNC0wOS0xNSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogbW91c2UgZHJpZnRzIGF3YXkgZnJvbSByZXNpemVy IHdoZW4gcmVzaXppbmcgZG9ja2VkIGluc3BlY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyNjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBNb2RpZmllZCB0aGUgZG9ja2VkIHJlc2l6ZXIgZHJhZ2dp bmcgbG9naWMgdG8gcmVjb3JkIHRoZSBpbml0aWFsIG1vdXNlIGRvd24gcG9zaXRpb24gcmVsYXRp dmUgdG8gdGhlCisgICAgICAgIHJlc2l6ZXIgY2xpZW50IHJlY3RhbmdsZS4gQWRkZWQgY2hlY2sg d2hpbGUgZHJhZ2dpbmcgdGhlIHJlc2l6ZXIgdG8gZW5zdXJlIHRoYXQgdGhlIGN1cnNvciBpcyBw b3NpdGlvbmVkCisgICAgICAgIGNvcnJlY3RseSB3aXRoIHJlc3BlY3QgdG8gdGhlIHJlc2l6ZSBk aXJlY3Rpb24gYmVmb3JlIHVwZGF0aW5nIHRoZSBhdHRhY2hlZCB3aW5kb3cgZGltZW5zaW9uLgor CisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNlL01haW4uanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuX2RvY2tlZFJlc2l6ZXJNb3VzZURvd24uZG9ja2VkUmVzaXplckRyYWcpOgorCiAyMDE0 LTA5LTA4ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogRml4IEVTTGludCBuby10cmFpbGluZy1zcGFjZXMgd2FybmluZ3MKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5q cyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwppbmRl eCAwZDJiODc4NDkyY2EwMjNkMTExYWI4NjI5OTk2YTIyYzkzNjdiNWZmLi5jMDY3YzI0Y2NiMjI2 Yjc4ZTEyZjhjMDMyYThmZGU3ODJlZGQ5YjMxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCkBAIC0xMjgxLDI1ICsxMjgxLDM4IEBAIFdl Ykluc3BlY3Rvci5fZG9ja2VkUmVzaXplck1vdXNlRG93biA9IGZ1bmN0aW9uKGV2ZW50KQogICAg ICAgICByZXR1cm47CiAKICAgICB2YXIgd2luZG93UHJvcGVydHkgPSB0aGlzLl9kb2NrU2lkZSA9 PT0gImJvdHRvbSIgPyAiaW5uZXJIZWlnaHQiIDogImlubmVyV2lkdGgiOwotICAgIHZhciBldmVu dFByb3BlcnR5ID0gdGhpcy5fZG9ja1NpZGUgPT09ICJib3R0b20iID8gInNjcmVlblkiIDogInNj cmVlblgiOworICAgIHZhciBldmVudFNjcmVlblByb3BlcnR5ID0gdGhpcy5fZG9ja1NpZGUgPT09 ICJib3R0b20iID8gInNjcmVlblkiIDogInNjcmVlblgiOworICAgIHZhciBldmVudENsaWVudFBy b3BlcnR5ID0gdGhpcy5fZG9ja1NpZGUgPT09ICJib3R0b20iID8gImNsaWVudFkiIDogImNsaWVu dFgiOwogCiAgICAgdmFyIHJlc2l6ZXJFbGVtZW50ID0gZXZlbnQudGFyZ2V0OwotICAgIHZhciBs YXN0U2NyZWVuUG9zaXRpb24gPSBldmVudFtldmVudFByb3BlcnR5XTsKKyAgICB2YXIgZmlyc3RD bGllbnRQb3NpdGlvbiA9IGV2ZW50W2V2ZW50Q2xpZW50UHJvcGVydHldOworICAgIHZhciBsYXN0 U2NyZWVuUG9zaXRpb24gPSBldmVudFtldmVudFNjcmVlblByb3BlcnR5XTsKIAogICAgIGZ1bmN0 aW9uIGRvY2tlZFJlc2l6ZXJEcmFnKGV2ZW50KQogICAgIHsKICAgICAgICAgaWYgKGV2ZW50LmJ1 dHRvbiAhPT0gMCkKICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICB2YXIgcG9zaXRpb24g PSBldmVudFtldmVudFByb3BlcnR5XTsKLSAgICAgICAgdmFyIGRpbWVuc2lvbiA9IHdpbmRvd1t3 aW5kb3dQcm9wZXJ0eV0gLSAocG9zaXRpb24gLSBsYXN0U2NyZWVuUG9zaXRpb24pOworICAgICAg ICB2YXIgcG9zaXRpb24gPSBldmVudFtldmVudFNjcmVlblByb3BlcnR5XTsKKyAgICAgICAgdmFy IGRlbHRhID0gcG9zaXRpb24gLSBsYXN0U2NyZWVuUG9zaXRpb247CisgICAgICAgIHZhciBjbGll bnRQb3NpdGlvbiA9IGV2ZW50W2V2ZW50Q2xpZW50UHJvcGVydHldOworCisgICAgICAgIGxhc3RT Y3JlZW5Qb3NpdGlvbiA9IHBvc2l0aW9uOworCisgICAgICAgIC8vIEN1cnNvciBwb3NpdGlvbiBj YW5ub3QgYmUgbGVzcyB0aGFuIGluaXRpYWwgbW91c2UgZG93biBwb3NpdGlvbiB3aGVuIHJlc2l6 aW5nIGRvY2tlZCBJbnNwZWN0b3Igc21hbGxlci4KKyAgICAgICAgaWYgKGRlbHRhID4gMCAmJiBj bGllbnRQb3NpdGlvbiA8IGZpcnN0Q2xpZW50UG9zaXRpb24pCisgICAgICAgICAgICByZXR1cm47 CisKKyAgICAgICAgLy8gQ3Vyc29yIHBvc2l0aW9uIGNhbm5vdCBiZSBncmVhdGVyIHRoYW4gaW5p dGlhbCBtb3VzZSBkb3duIHBvc2l0aW9uIHdoZW4gcmVzaXppbmcgZG9ja2VkIEluc3BlY3RvciBs YXJnZXIuCisgICAgICAgIGlmIChkZWx0YSA8IDAgJiYgY2xpZW50UG9zaXRpb24gPiBmaXJzdENs aWVudFBvc2l0aW9uKQorICAgICAgICAgICAgcmV0dXJuOworCisgICAgICAgIHZhciBkaW1lbnNp b24gPSBNYXRoLm1heCgwLCB3aW5kb3dbd2luZG93UHJvcGVydHldIC0gZGVsdGEpOwogCiAgICAg ICAgIGlmICh0aGlzLl9kb2NrU2lkZSA9PT0gImJvdHRvbSIpCiAgICAgICAgICAgICBJbnNwZWN0 b3JGcm9udGVuZEhvc3Quc2V0QXR0YWNoZWRXaW5kb3dIZWlnaHQoZGltZW5zaW9uKTsKICAgICAg ICAgZWxzZQogICAgICAgICAgICAgSW5zcGVjdG9yRnJvbnRlbmRIb3N0LnNldEF0dGFjaGVkV2lu ZG93V2lkdGgoZGltZW5zaW9uKTsKLQotICAgICAgICBsYXN0U2NyZWVuUG9zaXRpb24gPSBwb3Np dGlvbjsKICAgICB9CiAKICAgICBmdW5jdGlvbiBkb2NrZWRSZXNpemVyRHJhZ0VuZChldmVudCkK 238147 2014-09-15 16:39:35 -0700 2014-09-15 17:41:45 -0700 Patch bug-22263-20140915163932.patch text/plain 3464 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMTczNDM4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk MGFmNGQ4ZjczMTZjYTA0ZWFmZWM3MzRmMzQyYjc5MjYxMGVlZDc1Li43YTkxYTY0YTZhYzlkYTJm ZmE3ZDc3OWZlNWVjNGFmZTBhMTRhMzJkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNC0wOS0xNSAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogbW91c2UgZHJpZnRzIGF3YXkgZnJvbSByZXNpemVy IHdoZW4gcmVzaXppbmcgZG9ja2VkIGluc3BlY3RvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyNjMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBNb2RpZmllZCB0aGUgZG9ja2VkIHJlc2l6ZXIgZHJhZ2dp bmcgbG9naWMgdG8gcmVjb3JkIHRoZSBpbml0aWFsIG1vdXNlIGRvd24gcG9zaXRpb24gcmVsYXRp dmUgdG8gdGhlCisgICAgICAgIHJlc2l6ZXIgY2xpZW50IHJlY3RhbmdsZS4gQWRkZWQgY2hlY2sg d2hpbGUgZHJhZ2dpbmcgdGhlIHJlc2l6ZXIgdG8gZW5zdXJlIHRoYXQgdGhlIGN1cnNvciBpcyBw b3NpdGlvbmVkCisgICAgICAgIGNvcnJlY3RseSB3aXRoIHJlc3BlY3QgdG8gdGhlIHJlc2l6ZSBk aXJlY3Rpb24gYmVmb3JlIHVwZGF0aW5nIHRoZSBhdHRhY2hlZCB3aW5kb3cgZGltZW5zaW9uLgor CisgICAgICAgICogVXNlckludGVyZmFjZS9CYXNlL01haW4uanM6CisgICAgICAgIChXZWJJbnNw ZWN0b3IuX2RvY2tlZFJlc2l6ZXJNb3VzZURvd24uZG9ja2VkUmVzaXplckRyYWcpOgorCiAyMDE0 LTA5LTA4ICBKb3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAg V2ViIEluc3BlY3RvcjogRml4IEVTTGludCBuby10cmFpbGluZy1zcGFjZXMgd2FybmluZ3MKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5q cyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTWFpbi5qcwppbmRl eCAwZDJiODc4NDkyY2EwMjNkMTExYWI4NjI5OTk2YTIyYzkzNjdiNWZmLi43ODU0ZjBhMTRiZGUx YjRhZTcyNGFiYjFlNDAyZTM5YjVhNDJjZTFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCkBAIC0xMjgxLDI1ICsxMjgxLDQwIEBAIFdl Ykluc3BlY3Rvci5fZG9ja2VkUmVzaXplck1vdXNlRG93biA9IGZ1bmN0aW9uKGV2ZW50KQogICAg ICAgICByZXR1cm47CiAKICAgICB2YXIgd2luZG93UHJvcGVydHkgPSB0aGlzLl9kb2NrU2lkZSA9 PT0gImJvdHRvbSIgPyAiaW5uZXJIZWlnaHQiIDogImlubmVyV2lkdGgiOwotICAgIHZhciBldmVu dFByb3BlcnR5ID0gdGhpcy5fZG9ja1NpZGUgPT09ICJib3R0b20iID8gInNjcmVlblkiIDogInNj cmVlblgiOworICAgIHZhciBldmVudFNjcmVlblByb3BlcnR5ID0gdGhpcy5fZG9ja1NpZGUgPT09 ICJib3R0b20iID8gInNjcmVlblkiIDogInNjcmVlblgiOworICAgIHZhciBldmVudENsaWVudFBy b3BlcnR5ID0gdGhpcy5fZG9ja1NpZGUgPT09ICJib3R0b20iID8gImNsaWVudFkiIDogImNsaWVu dFgiOwogCiAgICAgdmFyIHJlc2l6ZXJFbGVtZW50ID0gZXZlbnQudGFyZ2V0OwotICAgIHZhciBs YXN0U2NyZWVuUG9zaXRpb24gPSBldmVudFtldmVudFByb3BlcnR5XTsKKyAgICB2YXIgZmlyc3RD bGllbnRQb3NpdGlvbiA9IGV2ZW50W2V2ZW50Q2xpZW50UHJvcGVydHldOworICAgIHZhciBsYXN0 U2NyZWVuUG9zaXRpb24gPSBldmVudFtldmVudFNjcmVlblByb3BlcnR5XTsKIAogICAgIGZ1bmN0 aW9uIGRvY2tlZFJlc2l6ZXJEcmFnKGV2ZW50KQogICAgIHsKICAgICAgICAgaWYgKGV2ZW50LmJ1 dHRvbiAhPT0gMCkKICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICB2YXIgcG9zaXRpb24g PSBldmVudFtldmVudFByb3BlcnR5XTsKLSAgICAgICAgdmFyIGRpbWVuc2lvbiA9IHdpbmRvd1t3 aW5kb3dQcm9wZXJ0eV0gLSAocG9zaXRpb24gLSBsYXN0U2NyZWVuUG9zaXRpb24pOworICAgICAg ICB2YXIgcG9zaXRpb24gPSBldmVudFtldmVudFNjcmVlblByb3BlcnR5XTsKKyAgICAgICAgdmFy IGRlbHRhID0gcG9zaXRpb24gLSBsYXN0U2NyZWVuUG9zaXRpb247CisgICAgICAgIHZhciBjbGll bnRQb3NpdGlvbiA9IGV2ZW50W2V2ZW50Q2xpZW50UHJvcGVydHldOworCisgICAgICAgIGxhc3RT Y3JlZW5Qb3NpdGlvbiA9IHBvc2l0aW9uOworCisgICAgICAgIC8vIElmIGRlbHRhIGlzIHBvc2l0 aXZlIHRoZSBkb2NrZWQgSW5zcGVjdG9yIHNpemUgaXMgZGVjcmVhc2luZywgaW4gd2hpY2ggY2Fz ZSB0aGUgY3Vyc29yIGNsaWVudCBwb3NpdGlvbgorICAgICAgICAvLyB3aXRoIHJlc3BlY3QgdG8g dGhlIHRhcmdldCBjYW5ub3QgYmUgbGVzcyB0aGFuIHRoZSBmaXJzdCBtb3VzZSBkb3duIHBvc2l0 aW9uIHdpdGhpbiB0aGUgdGFyZ2V0LgorICAgICAgICBpZiAoZGVsdGEgPiAwICYmIGNsaWVudFBv c2l0aW9uIDwgZmlyc3RDbGllbnRQb3NpdGlvbikKKyAgICAgICAgICAgIHJldHVybjsKKworICAg ICAgICAvLyBJZiBkZWx0YSBpcyBuZWdhdGl2ZSB0aGUgZG9ja2VkIEluc3BlY3RvciBzaXplIGlz IGluY3JlYXNpbmcsIGluIHdoaWNoIGNhc2UgdGhlIGN1cnNvciBjbGllbnQgcG9zaXRpb24KKyAg ICAgICAgLy8gd2l0aCByZXNwZWN0IHRvIHRoZSB0YXJnZXQgY2Fubm90IGJlIGdyZWF0ZXIgdGhh biB0aGUgZmlyc3QgbW91c2UgZG93biBwb3NpdGlvbiB3aXRoaW4gdGhlIHRhcmdldC4KKyAgICAg ICAgaWYgKGRlbHRhIDwgMCAmJiBjbGllbnRQb3NpdGlvbiA+IGZpcnN0Q2xpZW50UG9zaXRpb24p CisgICAgICAgICAgICByZXR1cm47CisKKyAgICAgICAgdmFyIGRpbWVuc2lvbiA9IE1hdGgubWF4 KDAsIHdpbmRvd1t3aW5kb3dQcm9wZXJ0eV0gLSBkZWx0YSk7CiAKICAgICAgICAgaWYgKHRoaXMu X2RvY2tTaWRlID09PSAiYm90dG9tIikKICAgICAgICAgICAgIEluc3BlY3RvckZyb250ZW5kSG9z dC5zZXRBdHRhY2hlZFdpbmRvd0hlaWdodChkaW1lbnNpb24pOwogICAgICAgICBlbHNlCiAgICAg ICAgICAgICBJbnNwZWN0b3JGcm9udGVuZEhvc3Quc2V0QXR0YWNoZWRXaW5kb3dXaWR0aChkaW1l bnNpb24pOwotCi0gICAgICAgIGxhc3RTY3JlZW5Qb3NpdGlvbiA9IHBvc2l0aW9uOwogICAgIH0K IAogICAgIGZ1bmN0aW9uIGRvY2tlZFJlc2l6ZXJEcmFnRW5kKGV2ZW50KQo=