22259 2008-11-14 01:28:16 -0800 Make all opcodes use eax as their final result register 2008-11-14 23:44:17 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 zwarich zwarich oldest_to_newest 98754 0 zwarich 2008-11-14 01:28:16 -0800 We should adopt a convention of using eax as the final result register. This is pretty close to what we actually do in practice: only one case of op_add and some resolve opcodes returning two results differ. 98759 1 25164 zwarich 2008-11-14 02:14:48 -0800 Created attachment 25164 Proposed patch This patch is no performance change when I test with networking on (but Safari and Mail closed). I will test again with networking off before landing. 98787 2 25164 darin 2008-11-14 09:18:23 -0800 Comment on attachment 25164 Proposed patch r=me 98854 3 zwarich 2008-11-14 23:44:17 -0800 Landed in r38419. 25164 2008-11-14 02:14:48 -0800 2008-11-14 09:18:23 -0800 Proposed patch result.diff text/plain 3794 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4Mzg3 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMDgtMTEt MTQgIENhbWVyb24gWndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAyMjI1OTogTWFrZSBhbGwgb3Bj b2RlcyB1c2UgZWF4IGFzIHRoZWlyIGZpbmFsIHJlc3VsdCByZWdpc3RlcgorICAgICAgICA8aHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjU5PgorCisgICAgICAgIENo YW5nZSBvbmUgY2FzZSBvZiBvcF9hZGQgKGFuZCB0aGUgY29ycmVzcG9uZGluZyBzbG93IGNhc2Up IHRvIHVzZSBlYXgKKyAgICAgICAgcmF0aGVyIHRoYW4gZWR4LiBBbHNvLCBjaGFuZ2UgdGhlIG9y ZGVyIGluIHdoaWNoIHRoZSB0d28gcmVzdWx0cyBvZgorICAgICAgICByZXNvbHZlX2Z1bmMgYW5k IHJlc29sdmVfYmFzZSBhcmUgZW1pdHRlZCBzbyB0aGF0IHRoZSByZXRyaWV2ZWQgdmFsdWUgaXMK KyAgICAgICAgcHV0IGxhc3QgaW50byBlYXguCisKKyAgICAgICAgKiBWTS9DVEkuY3BwOgorICAg ICAgICAoSlNDOjpDVEk6OnByaXZhdGVDb21waWxlTWFpblBhc3MpOgorICAgICAgICAoSlNDOjpD VEk6OnByaXZhdGVDb21waWxlU2xvd0Nhc2VzKToKKwogMjAwOC0xMS0xNCAgQ2FtZXJvbiBad2Fy aWNoICA8endhcmljaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVqIFN0 YWNob3dpYWsuCkluZGV4OiBWTS9DVEkuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFZNL0NUSS5jcHAJKHJl dmlzaW9uIDM4Mzg3KQorKysgVk0vQ1RJLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTEwMywxMSAr MTEwMywxMSBAQCB2b2lkIENUSTo6cHJpdmF0ZUNvbXBpbGVNYWluUGFzcygpCiAgICAgICAgICAg ICB1bnNpZ25lZCBzcmMyID0gaW5zdHJ1Y3Rpb25baSArIDNdLnUub3BlcmFuZDsKIAogICAgICAg ICAgICAgaWYgKEpTVmFsdWUqIHZhbHVlID0gZ2V0Q29uc3RhbnRJbW1lZGlhdGVOdW1lcmljQXJn KHNyYzEpKSB7Ci0gICAgICAgICAgICAgICAgZW1pdEdldEFyZyhzcmMyLCBYODY6OmVkeCwgaSk7 Ci0gICAgICAgICAgICAgICAgZW1pdEp1bXBTbG93Q2FzZUlmTm90SW1tTnVtKFg4Njo6ZWR4LCBp KTsKLSAgICAgICAgICAgICAgICBtX2ppdC5hZGRsX2kzMnIoZ2V0RGVUYWdnZWRDb25zdGFudElt bWVkaWF0ZSh2YWx1ZSksIFg4Njo6ZWR4KTsKKyAgICAgICAgICAgICAgICBlbWl0R2V0QXJnKHNy YzIsIFg4Njo6ZWF4LCBpKTsKKyAgICAgICAgICAgICAgICBlbWl0SnVtcFNsb3dDYXNlSWZOb3RJ bW1OdW0oWDg2OjplYXgsIGkpOworICAgICAgICAgICAgICAgIG1faml0LmFkZGxfaTMycihnZXRE ZVRhZ2dlZENvbnN0YW50SW1tZWRpYXRlKHZhbHVlKSwgWDg2OjplYXgpOwogICAgICAgICAgICAg ICAgIG1fc2xvd0Nhc2VzLmFwcGVuZChTbG93Q2FzZUVudHJ5KG1faml0LmVtaXRVbmxpbmtlZEpv KCksIGkpKTsKLSAgICAgICAgICAgICAgICBlbWl0UHV0UmVzdWx0KGRzdCwgWDg2OjplZHgpOwor ICAgICAgICAgICAgICAgIGVtaXRQdXRSZXN1bHQoZHN0KTsKICAgICAgICAgICAgIH0gZWxzZSBp ZiAoSlNWYWx1ZSogdmFsdWUgPSBnZXRDb25zdGFudEltbWVkaWF0ZU51bWVyaWNBcmcoc3JjMikp IHsKICAgICAgICAgICAgICAgICBlbWl0R2V0QXJnKHNyYzEsIFg4Njo6ZWF4LCBpKTsKICAgICAg ICAgICAgICAgICBlbWl0SnVtcFNsb3dDYXNlSWZOb3RJbW1OdW0oWDg2OjplYXgsIGkpOwpAQCAt MTUxNiw4ICsxNTE2LDggQEAgdm9pZCBDVEk6OnByaXZhdGVDb21waWxlTWFpblBhc3MoKQogICAg ICAgICAgICAgSWRlbnRpZmllciogaWRlbnQgPSAmKG1fY29kZUJsb2NrLT5pZGVudGlmaWVyc1tp bnN0cnVjdGlvbltpICsgM10udS5vcGVyYW5kXSk7CiAgICAgICAgICAgICBlbWl0UHV0QXJnQ29u c3RhbnQocmVpbnRlcnByZXRfY2FzdDx1bnNpZ25lZD4oaWRlbnQpLCAwKTsKICAgICAgICAgICAg IGVtaXRDVElDYWxsKGluc3RydWN0aW9uICsgaSwgaSwgTWFjaGluZTo6Y3RpX29wX3Jlc29sdmVf ZnVuYyk7Ci0gICAgICAgICAgICBlbWl0UHV0UmVzdWx0KGluc3RydWN0aW9uW2kgKyAxXS51Lm9w ZXJhbmQpOwogICAgICAgICAgICAgZW1pdFB1dFJlc3VsdChpbnN0cnVjdGlvbltpICsgMl0udS5v cGVyYW5kLCBYODY6OmVkeCk7CisgICAgICAgICAgICBlbWl0UHV0UmVzdWx0KGluc3RydWN0aW9u W2kgKyAxXS51Lm9wZXJhbmQpOwogICAgICAgICAgICAgaSArPSA0OwogICAgICAgICAgICAgYnJl YWs7CiAgICAgICAgIH0KQEAgLTE4OTUsOCArMTg5NSw4IEBAIHZvaWQgQ1RJOjpwcml2YXRlQ29t cGlsZU1haW5QYXNzKCkKICAgICAgICAgICAgIElkZW50aWZpZXIqIGlkZW50ID0gJihtX2NvZGVC bG9jay0+aWRlbnRpZmllcnNbaW5zdHJ1Y3Rpb25baSArIDNdLnUub3BlcmFuZF0pOwogICAgICAg ICAgICAgZW1pdFB1dEFyZ0NvbnN0YW50KHJlaW50ZXJwcmV0X2Nhc3Q8dW5zaWduZWQ+KGlkZW50 KSwgMCk7CiAgICAgICAgICAgICBlbWl0Q1RJQ2FsbChpbnN0cnVjdGlvbiArIGksIGksIE1hY2hp bmU6OmN0aV9vcF9yZXNvbHZlX3dpdGhfYmFzZSk7Ci0gICAgICAgICAgICBlbWl0UHV0UmVzdWx0 KGluc3RydWN0aW9uW2kgKyAxXS51Lm9wZXJhbmQpOwogICAgICAgICAgICAgZW1pdFB1dFJlc3Vs dChpbnN0cnVjdGlvbltpICsgMl0udS5vcGVyYW5kLCBYODY6OmVkeCk7CisgICAgICAgICAgICBl bWl0UHV0UmVzdWx0KGluc3RydWN0aW9uW2kgKyAxXS51Lm9wZXJhbmQpOwogICAgICAgICAgICAg aSArPSA0OwogICAgICAgICAgICAgYnJlYWs7CiAgICAgICAgIH0KQEAgLTI0MDksMTAgKzI0MDks MTAgQEAgdm9pZCBDVEk6OnByaXZhdGVDb21waWxlU2xvd0Nhc2VzKCkKICAgICAgICAgICAgIGlm IChKU1ZhbHVlKiB2YWx1ZSA9IGdldENvbnN0YW50SW1tZWRpYXRlTnVtZXJpY0FyZyhzcmMxKSkg ewogICAgICAgICAgICAgICAgIFg4NkFzc2VtYmxlcjo6Sm1wU3JjIG5vdEltbSA9IGl0ZXItPmZy b207CiAgICAgICAgICAgICAgICAgbV9qaXQubGluaygoKytpdGVyKS0+ZnJvbSwgbV9qaXQubGFi ZWwoKSk7Ci0gICAgICAgICAgICAgICAgbV9qaXQuc3VibF9pMzJyKGdldERlVGFnZ2VkQ29uc3Rh bnRJbW1lZGlhdGUodmFsdWUpLCBYODY6OmVkeCk7CisgICAgICAgICAgICAgICAgbV9qaXQuc3Vi bF9pMzJyKGdldERlVGFnZ2VkQ29uc3RhbnRJbW1lZGlhdGUodmFsdWUpLCBYODY6OmVheCk7CiAg ICAgICAgICAgICAgICAgbV9qaXQubGluayhub3RJbW0sIG1faml0LmxhYmVsKCkpOwogICAgICAg ICAgICAgICAgIGVtaXRHZXRQdXRBcmcoc3JjMSwgMCwgWDg2OjplY3gpOwotICAgICAgICAgICAg ICAgIGVtaXRQdXRBcmcoWDg2OjplZHgsIDQpOworICAgICAgICAgICAgICAgIGVtaXRQdXRBcmco WDg2OjplYXgsIDQpOwogICAgICAgICAgICAgICAgIGVtaXRDVElDYWxsKGluc3RydWN0aW9uICsg aSwgaSwgTWFjaGluZTo6Y3RpX29wX2FkZCk7CiAgICAgICAgICAgICAgICAgZW1pdFB1dFJlc3Vs dChkc3QpOwogICAgICAgICAgICAgfSBlbHNlIGlmIChKU1ZhbHVlKiB2YWx1ZSA9IGdldENvbnN0 YW50SW1tZWRpYXRlTnVtZXJpY0FyZyhzcmMyKSkgewo=