222589 2021-03-02 02:39:45 -0800 WebKitLegacy needs to keep JSDOMWindow even though it is used while its origin is not set 2021-03-03 08:55:11 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Local Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf ggaren webkit-bug-importer oldest_to_newest 1734791 0 youennf 2021-03-02 02:39:45 -0800 WebKitLegacy needs to keep JSDOMWindow even though it is used while its origin is not set 1734792 1 youennf 2021-03-02 02:40:10 -0800 <rdar://problem/74258258> 1734794 2 421917 youennf 2021-03-02 02:44:53 -0800 Created attachment 421917 Patch 1734975 3 421917 ggaren 2021-03-02 12:38:20 -0800 Comment on attachment 421917 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421917&action=review r=me > Source/WebCore/bindings/js/JSWindowProxy.cpp:109 > + if (!localWindow.document()->haveInitializedSecurityOrigin() && localWindow.document()->settings().windowObjectAlwaysInitializedWithSecurityOriginEnabled()) I wonder if this should include a linked on or after check -- or just be a linked on or after check? Would be nice to avoid unnecessary divergence in web platform behavior. 1735288 4 youennf 2021-03-03 08:36:50 -0800 (In reply to Geoffrey Garen from comment #3) > Comment on attachment 421917 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=421917&action=review > > r=me > > > Source/WebCore/bindings/js/JSWindowProxy.cpp:109 > > + if (!localWindow.document()->haveInitializedSecurityOrigin() && localWindow.document()->settings().windowObjectAlwaysInitializedWithSecurityOriginEnabled()) > > I wonder if this should include a linked on or after check -- or just be a > linked on or after check? Would be nice to avoid unnecessary divergence in > web platform behavior. I do not really know. Are WK1 APIs good enough to handle that case, ie provide easy hooks to delay what people are doing to the point where the origin is set? I guess we can do that as a follow-up. 1735297 5 ews-feeder 2021-03-03 08:55:10 -0800 Committed r273817: <https://commits.webkit.org/r273817> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421917. 421917 2021-03-02 02:44:53 -0800 2021-03-03 08:55:10 -0800 Patch bug-222589-20210302114452.patch text/plain 6309 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjczNjQyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDNjNmViY2RhMjRiODk3ZGFmY2ZhYmI1 NDcxZWJkNTA5Y2RjM2ExNWUuLmMzNTFjMjM2YmMzZjg2Y2E3N2VjNjFlYTA0MmE2NTE0ZjVkMWNk MWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjEtMDMtMDIgIFlvdWVubiBGYWJsZXQgIDx5b3Vl bm5AYXBwbGUuY29tPgorCisgICAgICAgIFdlYktpdExlZ2FjeSBuZWVkcyB0byBrZWVwIEpTRE9N V2luZG93IGV2ZW4gdGhvdWdoIGl0IGlzIHVzZWQgd2hpbGUgaXRzIG9yaWdpbiBpcyBub3Qgc2V0 CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI1ODkK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc0MjU4MjU4PgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy9QcmVmZXJlbmNlcy9XZWJQcmVm ZXJlbmNlc0ludGVybmFsLnlhbWw6CisgICAgICAgIEludHJvZHVjZSBhIGZsYWcsIG9uIGZvciBX ZWJLaXQgYW5kIG9mZiBmb3IgV2ViS2l0TGVnYWN5LgorCiAyMDIxLTAzLTAxICBZb3Vlbm4gRmFi bGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBFbmFibGUgTUVESUFfU09VUkNFIGlu IElPUyBTaW11bGF0b3IKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2OTEwNTE3NThiNDM0YjM2ZmI1OWRhNzVjYmE1 MWMwNDBlNWY2YTg3Li4yYjcyOTg3ZjU3MDVmMmU3YzE5NWQwZjVkY2RmMzhlZWFlMDdlMWI3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMjEtMDMtMDIgIFlvdWVubiBGYWJsZXQgIDx5 b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIFdlYktpdExlZ2FjeSBuZWVkcyB0byBrZWVwIEpT RE9NV2luZG93IGV2ZW4gdGhvdWdoIGl0IGlzIHVzZWQgd2hpbGUgaXRzIG9yaWdpbiBpcyBub3Qg c2V0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI1 ODkKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzc0MjU4MjU4PgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFVzZSB0aGUgbmV3IGZsYWcgdG8gYWxsb3cg cmV1c2Ugb2YgSlNET01XaW5kb3cgb2JqZWN0cyBldmVuIHRob3VnaCB0aGV5IGFyZSBjcmVhdGVk IGF0IGEgdGltZSB3aGVyZSBpdHMgU2VjdXJpdHlPcmlnaW4gaXMgbm90IHNldCB5ZXQuCisgICAg ICAgIFRoaXMgYWxsb3dzIGtlZXBpbmcgV2ViS2l0TGVnYWN5IGV4aXN0aW5nIGZ1bmN0aW9uYWxp dHkuCisKKyAgICAgICAgQ292ZXJlZCBieSBBUEkgdGVzdC4KKworICAgICAgICAqIGJpbmRpbmdz L2pzL0pTV2luZG93UHJveHkuY3BwOgorICAgICAgICAoV2ViQ29yZTo6SlNXaW5kb3dQcm94eTo6 c2V0V2luZG93KToKKwogMjAyMS0wMy0wMSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5j b20+CiAKICAgICAgICAgRW5hYmxlIE1FRElBX1NPVVJDRSBpbiBJT1MgU2ltdWxhdG9yCmRpZmYg LS1naXQgYS9Tb3VyY2UvV1RGL1NjcmlwdHMvUHJlZmVyZW5jZXMvV2ViUHJlZmVyZW5jZXNJbnRl cm5hbC55YW1sIGIvU291cmNlL1dURi9TY3JpcHRzL1ByZWZlcmVuY2VzL1dlYlByZWZlcmVuY2Vz SW50ZXJuYWwueWFtbAppbmRleCBiOTE0MTkyOGQ3NWJlYzNmYjM1Y2ViYThhNzJiODVmNGE2Y2Uy M2Y0Li5kYjRlZjUyZTFiNmU4NjJiZDdmYmQzM2E0NzEyNThlMmVjN2JmZTk0IDEwMDY0NAotLS0g YS9Tb3VyY2UvV1RGL1NjcmlwdHMvUHJlZmVyZW5jZXMvV2ViUHJlZmVyZW5jZXNJbnRlcm5hbC55 YW1sCisrKyBiL1NvdXJjZS9XVEYvU2NyaXB0cy9QcmVmZXJlbmNlcy9XZWJQcmVmZXJlbmNlc0lu dGVybmFsLnlhbWwKQEAgLTg4NSw2ICs4ODUsMTggQEAgV2ViUlRDTUROU0lDRUNhbmRpZGF0ZXNF bmFibGVkOgogICAgIFdlYktpdDoKICAgICAgIGRlZmF1bHQ6IHRydWUKIAorV2luZG93T2JqZWN0 QWx3YXlzSW5pdGlhbGl6ZWRXaXRoU2VjdXJpdHlPcmlnaW5FbmFibGVkOgorICB0eXBlOiBib29s CisgIGh1bWFuUmVhZGFibGVOYW1lOiAiRW5zdXJlIFdpbmRvdyBvYmplY3QgaXMgaW5pdGlhbGl6 ZWQgd2l0aCBhIHNlY3VyaXR5IG9yaWdpbiIKKyAgaHVtYW5SZWFkYWJsZURlc2NyaXB0aW9uOiAi RW5zdXJlIFdpbmRvdyBvYmplY3QgaXMgaW5pdGlhbGl6ZWQgd2l0aCBhIHNlY3VyaXR5IG9yaWdp biIKKyAgZGVmYXVsdFZhbHVlOgorICAgIFdlYktpdExlZ2FjeToKKyAgICAgIGRlZmF1bHQ6IGZh bHNlCisgICAgV2ViS2l0OgorICAgICAgZGVmYXVsdDogdHJ1ZQorICAgIFdlYkNvcmU6CisgICAg ICBkZWZhdWx0OiB0cnVlCisKIFpvb21PbkRvdWJsZVRhcFdoZW5Sb290OgogICB0eXBlOiBib29s CiAgIGNvbmRpdGlvbjogUExBVEZPUk0oSU9TX0ZBTUlMWSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTV2luZG93UHJveHkuY3BwIGIvU291cmNlL1dlYkNvcmUvYmlu ZGluZ3MvanMvSlNXaW5kb3dQcm94eS5jcHAKaW5kZXggYTAxMWJmYzRjNjdlZTIzNGExMTU1OWM2 ZTFiZGQxOGEyZjRhZjQwYS4uN2QyYWQyODg3NGQzZGJhZWRjZTQwNWYwMzViY2I4MjAwOWI2OGVj MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNXaW5kb3dQcm94eS5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvSlNXaW5kb3dQcm94eS5jcHAKQEAg LTEwNiw3ICsxMDYsNyBAQCB2b2lkIEpTV2luZG93UHJveHk6OnNldFdpbmRvdyhBYnN0cmFjdERP TVdpbmRvdyYgZG9tV2luZG93KQogICAgICAgICBhdXRvJiBsb2NhbFdpbmRvdyA9IGRvd25jYXN0 PERPTVdpbmRvdz4oZG9tV2luZG93KTsKICAgICAgICAgYXV0byYgd2luZG93U3RydWN0dXJlID0g KkpTRE9NV2luZG93OjpjcmVhdGVTdHJ1Y3R1cmUodm0sIG51bGxwdHIsIHByb3RvdHlwZSk7CiAg ICAgICAgIHdpbmRvdyA9IEpTRE9NV2luZG93OjpjcmVhdGUodm0sICZ3aW5kb3dTdHJ1Y3R1cmUs IGxvY2FsV2luZG93LCB0aGlzKTsKLSAgICAgICAgaWYgKCFsb2NhbFdpbmRvdy5kb2N1bWVudCgp LT5oYXZlSW5pdGlhbGl6ZWRTZWN1cml0eU9yaWdpbigpKQorICAgICAgICBpZiAoIWxvY2FsV2lu ZG93LmRvY3VtZW50KCktPmhhdmVJbml0aWFsaXplZFNlY3VyaXR5T3JpZ2luKCkgJiYgbG9jYWxX aW5kb3cuZG9jdW1lbnQoKS0+c2V0dGluZ3MoKS53aW5kb3dPYmplY3RBbHdheXNJbml0aWFsaXpl ZFdpdGhTZWN1cml0eU9yaWdpbkVuYWJsZWQoKSkKICAgICAgICAgICAgIGxvY2FsV2luZG93LnNl dEFzV3JhcHBlZFdpdGhvdXRJbml0aWFsaXplZFNlY3VyaXR5T3JpZ2luKCk7CiAgICAgfQogCmRp ZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMzcxYjk1 ODJjODc1MWNhZTFlNWFmZWFiMTQzZmJmMGI1NWEzMWIwZS4uNjRhOWI3Y2YwODIzNThlMDg4ZTFm YmNkODk3YTlmMDBlMWFhNWE2MSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rv b2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIxLTAzLTAyICBZb3Vlbm4gRmFibGV0 ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBXZWJLaXRMZWdhY3kgbmVlZHMgdG8ga2Vl cCBKU0RPTVdpbmRvdyBldmVuIHRob3VnaCBpdCBpcyB1c2VkIHdoaWxlIGl0cyBvcmlnaW4gaXMg bm90IHNldAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjIyNTg5CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NDI1ODI1OD4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RXZWJLaXRBUEkvVGVzdHMv bWFjL0pTV3JhcHBlckZvck5vZGVJbldlYkZyYW1lLm1tOgorICAgICAgICAoVGVzdFdlYktpdEFQ STo6VEVTVCk6CisKIDIwMjEtMDMtMDEgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29t PgogCiAgICAgICAgIEVuYWJsZSBNRURJQV9TT1VSQ0UgaW4gSU9TIFNpbXVsYXRvcgpkaWZmIC0t Z2l0IGEvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9tYWMvSlNXcmFwcGVyRm9yTm9kZUluV2Vi RnJhbWUubW0gYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL21hYy9KU1dyYXBwZXJGb3JOb2Rl SW5XZWJGcmFtZS5tbQppbmRleCBlZjRhNjNlODBlMmJkM2VlNjk5MGQxMmVjODI2MmYyMzI3NWI2 MWZkLi5lM2U4OWIzODJmMWI5YzRkZjc3MmQ2ZjMxMzRiNmJjOThkNzY5ZTA5IDEwMDY0NAotLS0g YS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL21hYy9KU1dyYXBwZXJGb3JOb2RlSW5XZWJGcmFt ZS5tbQorKysgYi9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL21hYy9KU1dyYXBwZXJGb3JOb2Rl SW5XZWJGcmFtZS5tbQpAQCAtMjYsNiArMjYsNyBAQAogI2ltcG9ydCAiY29uZmlnLmgiCiAjaW1w b3J0ICJQbGF0Zm9ybVV0aWxpdGllcy5oIgogI2ltcG9ydCA8V2ViS2l0L1dlYkZyYW1lUHJpdmF0 ZS5oPgorI2ltcG9ydCA8V2ViS2l0L1dlYlByZWZlcmVuY2VzUHJpdmF0ZS5oPgogI2ltcG9ydCA8 V2ViS2l0L1dlYlNjcmlwdFdvcmxkLmg+CiAjaW1wb3J0IDxKYXZhU2NyaXB0Q29yZS9KU0NvbnRl eHRSZWYuaD4KICNpbXBvcnQgPEphdmFTY3JpcHRDb3JlL0pTUmV0YWluUHRyLmg+CkBAIC05NSw0 ICs5NiwyNyBAQCBURVNUKFdlYktpdExlZ2FjeSwgSlNXcmFwcGVyRm9yTm9kZSkKICAgICBFWFBF Q1RfVFJVRShKU1ZhbHVlSXNVbmRlZmluZWQoaXNvbGF0ZWRDdHgsIEpTT2JqZWN0R2V0UHJvcGVy dHkoaXNvbGF0ZWRDdHgsIGlzb2xhdGVkTm9kZUpTT2JqZWN0LCBub3JtYWxQcm9wZXJ0eUpTU3Ry aW5nLmdldCgpLCAwKSkpOwogfQogCitURVNUKFdlYktpdExlZ2FjeSwgSlNET01XaW5kb3dXcmFw cGVyQmVmb3JlT3JpZ2luSW5pdGlhbGl6YXRpb24pCit7CisgICAgYXV0byB3ZWJWaWV3ID0gYWRv cHROUyhbW1dlYlZpZXcgYWxsb2NdIGluaXRXaXRoRnJhbWU6TlNNYWtlUmVjdCgwLCAwLCAxMjAs IDIwMCkgZnJhbWVOYW1lOm5pbCBncm91cE5hbWU6bmlsXSk7CisgICAgYXV0byBmcmFtZUxvYWRE ZWxlZ2F0ZSA9IGFkb3B0TlMoW1tKU1dyYXBwZXJGb3JOb2RlRnJhbWVMb2FkRGVsZWdhdGUgYWxs b2NdIGluaXRdKTsKKworICAgIHdlYlZpZXcuZ2V0KCkuZnJhbWVMb2FkRGVsZWdhdGUgPSBmcmFt ZUxvYWREZWxlZ2F0ZS5nZXQoKTsKKyAgICBhdXRvICptYWluRnJhbWUgPSB3ZWJWaWV3LmdldCgp Lm1haW5GcmFtZTsKKyAgICBbbWFpbkZyYW1lIGxvYWRIVE1MU3RyaW5nOkAiPGRpdiBpZD1cInRh cmdldFwiPC9kaXY+IiBiYXNlVVJMOltOU1VSTCBVUkxXaXRoU3RyaW5nOkAiaHR0cDovL2xvY2Fs aG9zdCJdXTsKKworICAgIGF1dG8gKm5vcm1hbFdvcmxkID0gW1dlYlNjcmlwdFdvcmxkIHN0YW5k YXJkV29ybGRdOworICAgIGF1dG8gbm9ybWFsQ3R4ID0gW21haW5GcmFtZSBfZ2xvYmFsQ29udGV4 dEZvclNjcmlwdFdvcmxkOm5vcm1hbFdvcmxkXTsKKworICAgIFttYWluRnJhbWUgX3N0cmluZ0J5 RXZhbHVhdGluZ0phdmFTY3JpcHRGcm9tU3RyaW5nOkAid2luZG93LmNhY2hlcyA9IDEiIHdpdGhH bG9iYWxPYmplY3Q6SlNDb250ZXh0R2V0R2xvYmFsT2JqZWN0KG5vcm1hbEN0eCkgaW5TY3JpcHRX b3JsZDpub3JtYWxXb3JsZF07CisKKyAgICBhdXRvIHJlc3VsdCA9IFttYWluRnJhbWUgX3N0cmlu Z0J5RXZhbHVhdGluZ0phdmFTY3JpcHRGcm9tU3RyaW5nOkAid2luZG93LmNhY2hlcyIgd2l0aEds b2JhbE9iamVjdDpKU0NvbnRleHRHZXRHbG9iYWxPYmplY3Qobm9ybWFsQ3R4KSBpblNjcmlwdFdv cmxkOm5vcm1hbFdvcmxkXTsKKyAgICBFWFBFQ1RfV0tfU1RSRVEocmVzdWx0LCBAIjEiKTsKKwor ICAgIFV0aWw6OnJ1bigmZGlkRmluaXNoTG9hZCk7CisKKyAgICByZXN1bHQgPSBbbWFpbkZyYW1l IF9zdHJpbmdCeUV2YWx1YXRpbmdKYXZhU2NyaXB0RnJvbVN0cmluZzpAIndpbmRvdy5jYWNoZXMi IHdpdGhHbG9iYWxPYmplY3Q6SlNDb250ZXh0R2V0R2xvYmFsT2JqZWN0KG5vcm1hbEN0eCkgaW5T Y3JpcHRXb3JsZDpub3JtYWxXb3JsZF07CisgICAgRVhQRUNUX1dLX1NUUkVRKHJlc3VsdCwgQCIx Iik7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFRlc3RXZWJLaXRBUEkK