22257 2008-11-14 00:04:37 -0800 Enable redundant read optimizations for results generated by compileBinaryArithOp() 2008-11-14 00:21:28 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 zwarich zwarich oldest_to_newest 98747 0 zwarich 2008-11-14 00:04:37 -0800 Currently redundant read optimizations are disabled for the results of compileBinaryArithOp(). We should fix this. 98748 1 25161 zwarich 2008-11-14 00:12:22 -0800 Created attachment 25161 Proposed patch 98749 2 25162 zwarich 2008-11-14 00:14:32 -0800 Created attachment 25162 Proposed patch with revised ChangeLog 98750 3 25162 mjs 2008-11-14 00:15:57 -0800 Comment on attachment 25162 Proposed patch with revised ChangeLog r=me 98752 4 zwarich 2008-11-14 00:21:28 -0800 Landed in r38387. 25161 2008-11-14 00:12:22 -0800 2008-11-14 00:14:32 -0800 Proposed patch binary.diff text/plain 2708 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4Mzg2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDgtMTEt MTQgIENhbWVyb24gWndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAyMjI1NzogRW5hYmxlIHJlZHVu ZGFudCByZWFkIG9wdGltaXphdGlvbnMgZm9yIHJlc3VsdHMgZ2VuZXJhdGVkIGJ5IGNvbXBpbGVC aW5hcnlBcml0aE9wKCkKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMjI1Nz4KKworICAgICAgICBUaGlzIHNob3dzIG5vIGNoYW5nZSBpbiBwZXJmb3Jt YW5jZSBvbiBlaXRoZXIgU3VuU3BpZGVyIG9yIHRoZSBWOAorICAgICAgICBiZW5jaG1hcmsgc3Vp dGUsIGJ1dCBpdCByZW1vdmVzIGFuIHVnbHkgc3BlY2lhbCBjYXNlIGFuZCBhbGxvd3MgZm9yCisg ICAgICAgIGZ1dHVyZSBvcHRpbWl6YXRpb25zIHRvIGJlIGltcGxlbWVudGVkIGluIGEgY2xlYW5l ciBmYXNoaW9uLgorCisgICAgICAgICogVk0vQ1RJLmNwcDoKKyAgICAgICAgKEpTQzo6Q1RJOjpw dXREb3VibGVSZXN1bHRUb0pTTnVtYmVyQ2VsbE9ySlNJbW1lZGlhdGUpOiBNb3ZlIHRoZSBmaW5h bAorICAgICAgICByZXN1bHQgdG8gZWF4IGlmIGl0IGlzIG5vdCBhbHJlYWR5IHRoZXJlLgorICAg ICAgICAoSlNDOjpDVEk6OmNvbXBpbGVCaW5hcnlBcml0aE9wKTogUmVtb3ZlIHRoZSBraWxsaW5n IG9mIHRoZSBmaW5hbCByZXN1bHQKKyAgICAgICAgcmVnaXN0ZXIgdGhhdCBkaXNhYmxlcyB0aGUg b3B0aW1pemF0aW9uLgorCiAyMDA4LTExLTEzICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9y Zz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVuLgpJbmRleDogVk0vQ1RJLmNwcAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBWTS9DVEkuY3BwCShyZXZpc2lvbiAzODM4NikKKysrIFZNL0NUSS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTg1Miw3ICs4NTIsOSBAQCB2b2lkIENUSTo6cHV0RG91YmxlUmVz dWx0VG9KU051bWJlckNlbGxPCiAgICAgCiAgICAgLy8gU3RvcmUgdGhlIHJlc3VsdCB0byB0aGUg SlNOdW1iZXJDZWxsIGFuZCBqdW1wLgogICAgIG1faml0Lm1vdnNkX3JtKHhtbVNvdXJjZSwgT0JK RUNUX09GRlNFVChKU051bWJlckNlbGwsIG1fdmFsdWUpLCBqc051bWJlckNlbGwpOwotICAgIGVt aXRQdXRSZXN1bHQoZHN0LCBqc051bWJlckNlbGwpOworICAgIGlmIChqc051bWJlckNlbGwgIT0g WDg2OjplYXgpCisgICAgICAgIG1faml0Lm1vdmxfcnIoanNOdW1iZXJDZWxsLCBYODY6OmVheCk7 CisgICAgZW1pdFB1dFJlc3VsdChkc3QpOwogICAgICp3cm90ZUpTTnVtYmVyQ2VsbCA9IG1faml0 LmVtaXRVbmxpbmtlZEptcCgpOwogCiAgICAgbV9qaXQubGluayhyZXN1bHRJc0ltbSwgbV9qaXQu bGFiZWwoKSk7CkBAIC04NjQsNyArODY2LDkgQEAgdm9pZCBDVEk6OnB1dERvdWJsZVJlc3VsdFRv SlNOdW1iZXJDZWxsTwogICAgIG1faml0LmxpbmsobV9qaXQuZW1pdFVubGlua2VkSmUoKSwgcmVz dWx0TG9va2VkTGlrZUltbUJ1dEFjdHVhbGx5SXNudCk7IC8vIEFjdHVhbGx5IHdhcyAtMAogICAg IC8vIFllcyBpdCByZWFsbHkgcmVhbGx5IHJlYWxseSBpcyByZXByZXNlbnRhYmxlIGFzIGEgSlNJ bW1lZGlhdGUuCiAgICAgZW1pdEZhc3RBcml0aEludFRvSW1tTm9DaGVjayh0ZW1wUmVnMSk7Ci0g ICAgZW1pdFB1dFJlc3VsdChkc3QsIHRlbXBSZWcxKTsKKyAgICBpZiAodGVtcFJlZzEgIT0gWDg2 OjplYXgpCisgICAgICAgIG1faml0Lm1vdmxfcnIodGVtcFJlZzEsIFg4Njo6ZWF4KTsKKyAgICBl bWl0UHV0UmVzdWx0KGRzdCk7CiB9CiAKIHZvaWQgQ1RJOjpjb21waWxlQmluYXJ5QXJpdGhPcChP cGNvZGVJRCBvcGNvZGVJRCwgdW5zaWduZWQgZHN0LCB1bnNpZ25lZCBzcmMxLCB1bnNpZ25lZCBz cmMyLCBPcGVyYW5kVHlwZXMgdHlwZXMsIHVuc2lnbmVkIGkpCkBAIC0xMDE0LDEwICsxMDE4LDYg QEAgdm9pZCBDVEk6OmNvbXBpbGVCaW5hcnlBcml0aE9wKE9wY29kZUlEIAogICAgICAgICBtX2pp dC5saW5rKHdhc0pTTnVtYmVyQ2VsbDEsIG1faml0LmxhYmVsKCkpOwogICAgICAgICBtX2ppdC5s aW5rKHdhc0pTTnVtYmVyQ2VsbDFiLCBtX2ppdC5sYWJlbCgpKTsKICAgICB9Ci0KLSAgICAvLyBG SVhNRTogbWFrZSB0aGUgZGlmZmVyZW50IGNhc2VzIG9mIHRoaXMgZnVuY3Rpb24gYWxsIHVzZSBl YXggYXMgdGhlIAotICAgIC8vIGRlc3RpbmF0aW9uIHJlZ2lzdGVyIGFuZCBlbmFibGUgdGhlIHJl Z2lzdGVyIGNhY2hpbmcgb3B0aW1pemF0aW9uLgotICAgIGtpbGxMYXN0UmVzdWx0UmVnaXN0ZXIo KTsKIH0KIAogdm9pZCBDVEk6OmNvbXBpbGVCaW5hcnlBcml0aE9wU2xvd0Nhc2UoSW5zdHJ1Y3Rp b24qIHZQQywgT3Bjb2RlSUQgb3Bjb2RlSUQsIFZlY3RvcjxTbG93Q2FzZUVudHJ5Pjo6aXRlcmF0 b3ImIGl0ZXIsIHVuc2lnbmVkIGRzdCwgdW5zaWduZWQgc3JjMSwgdW5zaWduZWQgc3JjMiwgT3Bl cmFuZFR5cGVzIHR5cGVzLCB1bnNpZ25lZCBpKQo= 25162 2008-11-14 00:14:32 -0800 2008-11-14 00:15:57 -0800 Proposed patch with revised ChangeLog binary.diff text/plain 2900 zwarich SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDM4Mzg2 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMjQgQEAKKzIwMDgtMTEt MTQgIENhbWVyb24gWndhcmljaCAgPHp3YXJpY2hAYXBwbGUuY29tPgorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAyMjI1NzogRW5hYmxlIHJlZHVu ZGFudCByZWFkIG9wdGltaXphdGlvbnMgZm9yIHJlc3VsdHMgZ2VuZXJhdGVkIGJ5IGNvbXBpbGVC aW5hcnlBcml0aE9wKCkKKyAgICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMjI1Nz4KKworICAgICAgICBUaGlzIHNob3dzIG5vIGNoYW5nZSBpbiBwZXJmb3Jt YW5jZSBvbiBlaXRoZXIgU3VuU3BpZGVyIG9yIHRoZSBWOAorICAgICAgICBiZW5jaG1hcmsgc3Vp dGUsIGJ1dCBpdCByZW1vdmVzIGFuIHVnbHkgc3BlY2lhbCBjYXNlIGFuZCBhbGxvd3MgZm9yCisg ICAgICAgIGZ1dHVyZSBvcHRpbWl6YXRpb25zIHRvIGJlIGltcGxlbWVudGVkIGluIGEgY2xlYW5l ciBmYXNoaW9uLgorCisgICAgICAgIFRoaXMgcGF0Y2ggd2FzIGVzc2VudGlhbGx5IGdpdmVuIHRv IG1lIGJ5IEdhdmluIEJhcnJhY2xvdWdoIHVwb24gbXkKKyAgICAgICAgcmVxdWVzdCwgYnV0IEkg ZGlkIHJlZ3Jlc3Npb24gYW5kIHBlcmZvcm1hbmNlIHRlc3Rpbmcgc28gdGhhdCBoZSBjb3VsZAor ICAgICAgICB3b3JrIG9uIHNvbWV0aGluZyBlbHNlLgorCisgICAgICAgICogVk0vQ1RJLmNwcDoK KyAgICAgICAgKEpTQzo6Q1RJOjpwdXREb3VibGVSZXN1bHRUb0pTTnVtYmVyQ2VsbE9ySlNJbW1l ZGlhdGUpOiBNb3ZlIHRoZSBmaW5hbAorICAgICAgICByZXN1bHQgdG8gZWF4IGlmIGl0IGlzIG5v dCBhbHJlYWR5IHRoZXJlLgorICAgICAgICAoSlNDOjpDVEk6OmNvbXBpbGVCaW5hcnlBcml0aE9w KTogUmVtb3ZlIHRoZSBraWxsaW5nIG9mIHRoZSBmaW5hbCByZXN1bHQKKyAgICAgICAgcmVnaXN0 ZXIgdGhhdCBkaXNhYmxlcyB0aGUgb3B0aW1pemF0aW9uLgorCiAyMDA4LTExLTEzICBFcmljIFNl aWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIFJvYmVu LgpJbmRleDogVk0vQ1RJLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBWTS9DVEkuY3BwCShyZXZpc2lvbiAz ODM4NikKKysrIFZNL0NUSS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTg1Miw3ICs4NTIsOSBAQCB2 b2lkIENUSTo6cHV0RG91YmxlUmVzdWx0VG9KU051bWJlckNlbGxPCiAgICAgCiAgICAgLy8gU3Rv cmUgdGhlIHJlc3VsdCB0byB0aGUgSlNOdW1iZXJDZWxsIGFuZCBqdW1wLgogICAgIG1faml0Lm1v dnNkX3JtKHhtbVNvdXJjZSwgT0JKRUNUX09GRlNFVChKU051bWJlckNlbGwsIG1fdmFsdWUpLCBq c051bWJlckNlbGwpOwotICAgIGVtaXRQdXRSZXN1bHQoZHN0LCBqc051bWJlckNlbGwpOworICAg IGlmIChqc051bWJlckNlbGwgIT0gWDg2OjplYXgpCisgICAgICAgIG1faml0Lm1vdmxfcnIoanNO dW1iZXJDZWxsLCBYODY6OmVheCk7CisgICAgZW1pdFB1dFJlc3VsdChkc3QpOwogICAgICp3cm90 ZUpTTnVtYmVyQ2VsbCA9IG1faml0LmVtaXRVbmxpbmtlZEptcCgpOwogCiAgICAgbV9qaXQubGlu ayhyZXN1bHRJc0ltbSwgbV9qaXQubGFiZWwoKSk7CkBAIC04NjQsNyArODY2LDkgQEAgdm9pZCBD VEk6OnB1dERvdWJsZVJlc3VsdFRvSlNOdW1iZXJDZWxsTwogICAgIG1faml0LmxpbmsobV9qaXQu ZW1pdFVubGlua2VkSmUoKSwgcmVzdWx0TG9va2VkTGlrZUltbUJ1dEFjdHVhbGx5SXNudCk7IC8v IEFjdHVhbGx5IHdhcyAtMAogICAgIC8vIFllcyBpdCByZWFsbHkgcmVhbGx5IHJlYWxseSBpcyBy ZXByZXNlbnRhYmxlIGFzIGEgSlNJbW1lZGlhdGUuCiAgICAgZW1pdEZhc3RBcml0aEludFRvSW1t Tm9DaGVjayh0ZW1wUmVnMSk7Ci0gICAgZW1pdFB1dFJlc3VsdChkc3QsIHRlbXBSZWcxKTsKKyAg ICBpZiAodGVtcFJlZzEgIT0gWDg2OjplYXgpCisgICAgICAgIG1faml0Lm1vdmxfcnIodGVtcFJl ZzEsIFg4Njo6ZWF4KTsKKyAgICBlbWl0UHV0UmVzdWx0KGRzdCk7CiB9CiAKIHZvaWQgQ1RJOjpj b21waWxlQmluYXJ5QXJpdGhPcChPcGNvZGVJRCBvcGNvZGVJRCwgdW5zaWduZWQgZHN0LCB1bnNp Z25lZCBzcmMxLCB1bnNpZ25lZCBzcmMyLCBPcGVyYW5kVHlwZXMgdHlwZXMsIHVuc2lnbmVkIGkp CkBAIC0xMDE0LDEwICsxMDE4LDYgQEAgdm9pZCBDVEk6OmNvbXBpbGVCaW5hcnlBcml0aE9wKE9w Y29kZUlEIAogICAgICAgICBtX2ppdC5saW5rKHdhc0pTTnVtYmVyQ2VsbDEsIG1faml0LmxhYmVs KCkpOwogICAgICAgICBtX2ppdC5saW5rKHdhc0pTTnVtYmVyQ2VsbDFiLCBtX2ppdC5sYWJlbCgp KTsKICAgICB9Ci0KLSAgICAvLyBGSVhNRTogbWFrZSB0aGUgZGlmZmVyZW50IGNhc2VzIG9mIHRo aXMgZnVuY3Rpb24gYWxsIHVzZSBlYXggYXMgdGhlIAotICAgIC8vIGRlc3RpbmF0aW9uIHJlZ2lz dGVyIGFuZCBlbmFibGUgdGhlIHJlZ2lzdGVyIGNhY2hpbmcgb3B0aW1pemF0aW9uLgotICAgIGtp bGxMYXN0UmVzdWx0UmVnaXN0ZXIoKTsKIH0KIAogdm9pZCBDVEk6OmNvbXBpbGVCaW5hcnlBcml0 aE9wU2xvd0Nhc2UoSW5zdHJ1Y3Rpb24qIHZQQywgT3Bjb2RlSUQgb3Bjb2RlSUQsIFZlY3RvcjxT bG93Q2FzZUVudHJ5Pjo6aXRlcmF0b3ImIGl0ZXIsIHVuc2lnbmVkIGRzdCwgdW5zaWduZWQgc3Jj MSwgdW5zaWduZWQgc3JjMiwgT3BlcmFuZFR5cGVzIHR5cGVzLCB1bnNpZ25lZCBpKQo=