222566 2021-03-01 11:05:28 -0800 [WinCairo] Building with ENABLE_SERVICE_WORKER=OFF fails 2021-03-01 15:07:19 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 stephan.szabo stephan.szabo webkit-bug-importer oldest_to_newest 1734497 0 stephan.szabo 2021-03-01 11:05:28 -0800 It seems after "Make the UserContentController for ServiceWorker pages be non-optional", building without ENABLE_SERVICE_WORKER on WinCairo fails with: Source\WebKit\UIProcess/WebProcessPool.cpp(1014): error C2039: 'userContentControllerIdentifierForServiceWorkers': is not a member of 'WebKit::WebProcessPool' Source\WebKit\UIProcess\Notifications\WebNotificationManagerProxy.h(50): note: see declaration of 'WebKit::WebProcessPool' Source\WebKit\UIProcess/WebProcessPool.cpp(1016): error C2065: 'm_userContentControllerForServiceWorker': undeclared identifier Source\WebKit\UIProcess/WebProcessPool.cpp(1017): error C2065: 'm_userContentControllerForServiceWorker': undeclared identifier Source\WebKit\UIProcess/WebProcessPool.cpp(1019): error C2065: 'm_userContentControllerForServiceWorker': undeclared identifier 1734508 1 421849 stephan.szabo 2021-03-01 11:20:32 -0800 Created attachment 421849 Patch 1734629 2 ews-feeder 2021-03-01 15:06:16 -0800 Committed r273694: <https://commits.webkit.org/r273694> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421849. 1734632 3 webkit-bug-importer 2021-03-01 15:07:19 -0800 <rdar://problem/74893620> 421849 2021-03-01 11:20:32 -0800 2021-03-01 15:06:17 -0800 Patch 222566.1.diff text/plain 1516 stephan.szabo ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggNmUyYjZhNGQ1YmFjLi4zMzgzZWU3YTExOGEgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTMgQEAKKzIwMjEtMDMtMDEgIFN0ZXBoYW4gU3phYm8gIDxzdGVwaGFuLnN6YWJvQHNvbnku Y29tPgorCisgICAgICAgIFtXaW5DYWlyb10gQnVpbGRpbmcgd2l0aCBFTkFCTEVfU0VSVklDRV9X T1JLRVI9T0ZGIGZhaWxzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMjI1NjYKKworICAgICAgICBVbnJldmlld2VkIGJ1aWxkIGZpeC4KKworICAgICAg ICAqIFVJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHA6IE9ubHkgY29tcGlsZSBhIG1ldGhvZCB3 aGVuIHNlcnZpY2UKKyAgICAgICAgd29ya2VyIGlzIGVuYWJsZWQuCisKIDIwMjEtMDMtMDEgIEtp bW1vIEtpbm51bmVuICA8a2tpbm51bmVuQGFwcGxlLmNvbT4KIAogICAgICAgICBUaW1lb3V0IGNh bGN1bGF0aW9ucyBhcmUgZXJyb3ItcHJvbmUgZm9yIGNvbXBvdW5kIElQQyBvcGVyYXRpb25zCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAgYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNzUG9vbC5jcHAKaW5kZXggMjdhMmZmOTZi YjdjLi4zY2E1MWU3YTRlZjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1dl YlByb2Nlc3NQb29sLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9XZWJQcm9jZXNz UG9vbC5jcHAKQEAgLTEwMTEsNiArMTAxMSw3IEBAIFdlYlByb2Nlc3NQcm94eSYgV2ViUHJvY2Vz c1Bvb2w6OnByb2Nlc3NGb3JSZWdpc3RyYWJsZURvbWFpbihXZWJzaXRlRGF0YVN0b3JlJiB3CiAg ICAgcmV0dXJuIGNyZWF0ZU5ld1dlYlByb2Nlc3MoJndlYnNpdGVEYXRhU3RvcmUpOwogfQogCisj aWYgRU5BQkxFKFNFUlZJQ0VfV09SS0VSKQogVXNlckNvbnRlbnRDb250cm9sbGVySWRlbnRpZmll ciBXZWJQcm9jZXNzUG9vbDo6dXNlckNvbnRlbnRDb250cm9sbGVySWRlbnRpZmllckZvclNlcnZp Y2VXb3JrZXJzKCkKIHsKICAgICBpZiAoIW1fdXNlckNvbnRlbnRDb250cm9sbGVyRm9yU2Vydmlj ZVdvcmtlcikKQEAgLTEwMTgsNiArMTAxOSw3IEBAIFVzZXJDb250ZW50Q29udHJvbGxlcklkZW50 aWZpZXIgV2ViUHJvY2Vzc1Bvb2w6OnVzZXJDb250ZW50Q29udHJvbGxlcklkZW50aWZpZXJGCiAK ICAgICByZXR1cm4gbV91c2VyQ29udGVudENvbnRyb2xsZXJGb3JTZXJ2aWNlV29ya2VyLT5pZGVu dGlmaWVyKCk7CiB9CisjZW5kaWYKIAogUmVmPFdlYlBhZ2VQcm94eT4gV2ViUHJvY2Vzc1Bvb2w6 OmNyZWF0ZVdlYlBhZ2UoUGFnZUNsaWVudCYgcGFnZUNsaWVudCwgUmVmPEFQSTo6UGFnZUNvbmZp Z3VyYXRpb24+JiYgcGFnZUNvbmZpZ3VyYXRpb24pCiB7Cg==