222560 2021-03-01 09:49:38 -0800 Rename the delegate property of WebAVPlayerView to webDelegate to fix a build failure with new SDKs 2021-03-01 12:20:26 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 peng.liu6 peng.liu6 eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer oldest_to_newest 1734467 0 peng.liu6 2021-03-01 09:49:38 -0800 Rename the delegate property of WebAVPlayerView to webDelegate to fix a build failure with new SDKs 1734471 1 421841 peng.liu6 2021-03-01 09:54:34 -0800 Created attachment 421841 Patch 1734537 2 ews-feeder 2021-03-01 12:19:34 -0800 Committed r273675: <https://commits.webkit.org/r273675> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421841. 1734539 3 webkit-bug-importer 2021-03-01 12:20:26 -0800 <rdar://problem/74883815> 421841 2021-03-01 09:54:34 -0800 2021-03-01 12:19:35 -0800 Patch bug-222560-20210301095433.patch text/plain 5366 peng.liu6 U3VidmVyc2lvbiBSZXZpc2lvbjogMjczNjE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0TGVn YWN5L21hYy9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9DaGFuZ2VMb2cKaW5k ZXggYzU3Njc5ZTg1MWQ2YjEyMzkyMDJkNGZmZjVhMGE2ZTJlZGY2MGQzYi4uOTNjNjNkNDkzMDZh ZTM4NjFmZTI0OTk1MzJiMjdmYTRiMzUzY2FkZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdExl Z2FjeS9tYWMvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDI1IEBACisyMDIxLTAzLTAxICBQZW5nIExpdSAgPHBlbmcubGl1NkBhcHBs ZS5jb20+CisKKyAgICAgICAgUmVuYW1lIHRoZSBkZWxlZ2F0ZSBwcm9wZXJ0eSBvZiBXZWJBVlBs YXllclZpZXcgdG8gd2ViRGVsZWdhdGUgdG8gZml4IGEgYnVpbGQgZmFpbHVyZSB3aXRoIG5ldyBT REtzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI1 NjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBo YXZlIHRvIHJlbmFtZSB0aGUgYGRlbGVnYXRlYCBwcm9wZXJ0eSBvZiBgV2ViQVZQbGF5ZXJWaWV3 YCBiZWNhdXNlIEFWS2l0IGFkZHMKKyAgICAgICAgYSBgZGVsZWdhdGVgIHByb3BlcnR5IHRvIGBB VlBsYXllclZpZXdgIHdoaWNoIHdpbGwgY29uZmxpY3Qgd2l0aCB0aGUgb25lIGluIFdlYktpdC4K KworICAgICAgICAqIFdlYlZpZXcvV2ViVmlkZW9GdWxsc2NyZWVuQ29udHJvbGxlci5tbToKKyAg ICAgICAgKFdlYkFWUGxheWVyVmlld193ZWJEZWxlZ2F0ZSk6CisgICAgICAgIChXZWJBVlBsYXll clZpZXdfc2V0V2ViRGVsZWdhdGUpOgorICAgICAgICAoV2ViQVZQbGF5ZXJWaWV3X2lzRnVsbFNj cmVlbik6CisgICAgICAgIChXZWJBVlBsYXllclZpZXdfZW50ZXJGdWxsU2NyZWVuKToKKyAgICAg ICAgKFdlYkFWUGxheWVyVmlld19leGl0RnVsbFNjcmVlbik6CisgICAgICAgIChhbGxvY1dlYkFW UGxheWVyVmlld0luc3RhbmNlKToKKyAgICAgICAgKC1bV2ViVmlkZW9GdWxsc2NyZWVuQ29udHJv bGxlciBkZWFsbG9jXSk6CisgICAgICAgICgtW1dlYlZpZGVvRnVsbHNjcmVlbkNvbnRyb2xsZXIg d2luZG93RGlkTG9hZF0pOgorICAgICAgICAoV2ViQVZQbGF5ZXJWaWV3X2RlbGVnYXRlKTogRGVs ZXRlZC4KKyAgICAgICAgKFdlYkFWUGxheWVyVmlld19zZXREZWxlZ2F0ZSk6IERlbGV0ZWQuCisK IDIwMjEtMDItMjYgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBS ZWR1Y2UgZXhwbGljaXQgdXNhZ2Ugb2YgW29iakMgcmV0YWluXSBpbiBXZWJLaXQKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViVmlkZW9GdWxsc2NyZWVuQ29u dHJvbGxlci5tbSBiL1NvdXJjZS9XZWJLaXRMZWdhY3kvbWFjL1dlYlZpZXcvV2ViVmlkZW9GdWxs c2NyZWVuQ29udHJvbGxlci5tbQppbmRleCBhOWE2NGYwNDYwODQxNzk2MzFlYjFhNGEwYTA4MTIz ZWQ1YjMxNTRmLi5lYmMwMzU2N2U0ZDExZGU2NWU3Njk2NWQyNTllMmRmOGVmM2E2ZTljIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViS2l0TGVnYWN5L21hYy9XZWJWaWV3L1dlYlZpZGVvRnVsbHNjcmVl bkNvbnRyb2xsZXIubW0KKysrIGIvU291cmNlL1dlYktpdExlZ2FjeS9tYWMvV2ViVmlldy9XZWJW aWRlb0Z1bGxzY3JlZW5Db250cm9sbGVyLm1tCkBAIC03MSwzNyArNzEsMzcgQEAgQUxMT1dfREVQ UkVDQVRFRF9ERUNMQVJBVElPTlNfQkVHSU4KIEBlbmQKIAogQGludGVyZmFjZSBXZWJBVlBsYXll clZpZXcgOiBBVlBsYXllclZpZXcKLUBwcm9wZXJ0eSAod2VhaykgaWQ8V2ViQVZQbGF5ZXJWaWV3 RGVsZWdhdGU+IGRlbGVnYXRlOworQHByb3BlcnR5ICh3ZWFrKSBpZDxXZWJBVlBsYXllclZpZXdE ZWxlZ2F0ZT4gd2ViRGVsZWdhdGU7CiBAZW5kCiAKLXN0YXRpYyBpZDxXZWJBVlBsYXllclZpZXdE ZWxlZ2F0ZT4gV2ViQVZQbGF5ZXJWaWV3X2RlbGVnYXRlKGlkIGFTZWxmLCBTRUwpCitzdGF0aWMg aWQ8V2ViQVZQbGF5ZXJWaWV3RGVsZWdhdGU+IFdlYkFWUGxheWVyVmlld193ZWJEZWxlZ2F0ZShp ZCBhU2VsZiwgU0VMKQogewotICAgIHZvaWQqIGRlbGVnYXRlID0gbmlsOwotICAgIG9iamVjdF9n ZXRJbnN0YW5jZVZhcmlhYmxlKGFTZWxmLCAiX3dlYkRlbGVnYXRlIiwgJmRlbGVnYXRlKTsKLSAg ICByZXR1cm4gc3RhdGljX2Nhc3Q8aWQ8V2ViQVZQbGF5ZXJWaWV3RGVsZWdhdGU+PihkZWxlZ2F0 ZSk7CisgICAgdm9pZCogd2ViRGVsZWdhdGUgPSBuaWw7CisgICAgb2JqZWN0X2dldEluc3RhbmNl VmFyaWFibGUoYVNlbGYsICJfd2ViRGVsZWdhdGUiLCAmd2ViRGVsZWdhdGUpOworICAgIHJldHVy biBzdGF0aWNfY2FzdDxpZDxXZWJBVlBsYXllclZpZXdEZWxlZ2F0ZT4+KHdlYkRlbGVnYXRlKTsK IH0KIAotc3RhdGljIHZvaWQgV2ViQVZQbGF5ZXJWaWV3X3NldERlbGVnYXRlKGlkIGFTZWxmLCBT RUwsIGlkPFdlYkFWUGxheWVyVmlld0RlbGVnYXRlPiBkZWxlZ2F0ZSkKK3N0YXRpYyB2b2lkIFdl YkFWUGxheWVyVmlld19zZXRXZWJEZWxlZ2F0ZShpZCBhU2VsZiwgU0VMLCBpZDxXZWJBVlBsYXll clZpZXdEZWxlZ2F0ZT4gd2ViRGVsZWdhdGUpCiB7Ci0gICAgb2JqZWN0X3NldEluc3RhbmNlVmFy aWFibGUoYVNlbGYsICJfd2ViRGVsZWdhdGUiLCBkZWxlZ2F0ZSk7CisgICAgb2JqZWN0X3NldElu c3RhbmNlVmFyaWFibGUoYVNlbGYsICJfd2ViRGVsZWdhdGUiLCB3ZWJEZWxlZ2F0ZSk7CiB9CiAK IHN0YXRpYyBCT09MIFdlYkFWUGxheWVyVmlld19pc0Z1bGxTY3JlZW4oaWQgYVNlbGYsIFNFTCkK IHsKICAgICBXZWJBVlBsYXllclZpZXcgKnBsYXllclZpZXcgPSBhU2VsZjsKLSAgICByZXR1cm4g W3BsYXllclZpZXcuZGVsZWdhdGUgcGxheWVyVmlld0lzRnVsbFNjcmVlbjpwbGF5ZXJWaWV3XTsK KyAgICByZXR1cm4gW3BsYXllclZpZXcud2ViRGVsZWdhdGUgcGxheWVyVmlld0lzRnVsbFNjcmVl bjpwbGF5ZXJWaWV3XTsKIH0KIAogc3RhdGljIHZvaWQgV2ViQVZQbGF5ZXJWaWV3X2VudGVyRnVs bFNjcmVlbihpZCBhU2VsZiwgU0VMLCBpZCBzZW5kZXIpCiB7CiAgICAgV2ViQVZQbGF5ZXJWaWV3 ICpwbGF5ZXJWaWV3ID0gYVNlbGY7Ci0gICAgW3BsYXllclZpZXcuZGVsZWdhdGUgcGxheWVyVmll d1JlcXVlc3RFbnRlckZ1bGxzY3JlZW46cGxheWVyVmlld107CisgICAgW3BsYXllclZpZXcud2Vi RGVsZWdhdGUgcGxheWVyVmlld1JlcXVlc3RFbnRlckZ1bGxzY3JlZW46cGxheWVyVmlld107CiB9 CiAKIHN0YXRpYyB2b2lkIFdlYkFWUGxheWVyVmlld19leGl0RnVsbFNjcmVlbihpZCBhU2VsZiwg U0VMLCBpZCBzZW5kZXIpCiB7CiAgICAgV2ViQVZQbGF5ZXJWaWV3ICpwbGF5ZXJWaWV3ID0gYVNl bGY7Ci0gICAgW3BsYXllclZpZXcuZGVsZWdhdGUgcGxheWVyVmlld1JlcXVlc3RFeGl0RnVsbHNj cmVlbjpwbGF5ZXJWaWV3XTsKKyAgICBbcGxheWVyVmlldy53ZWJEZWxlZ2F0ZSBwbGF5ZXJWaWV3 UmVxdWVzdEV4aXRGdWxsc2NyZWVuOnBsYXllclZpZXddOwogfQogCiBzdGF0aWMgV2ViQVZQbGF5 ZXJWaWV3ICphbGxvY1dlYkFWUGxheWVyVmlld0luc3RhbmNlKCkKQEAgLTExMiw4ICsxMTIsOCBA QCBzdGF0aWMgV2ViQVZQbGF5ZXJWaWV3ICphbGxvY1dlYkFWUGxheWVyVmlld0luc3RhbmNlKCkK ICAgICAgICAgQVNTRVJUKGdldEFWUGxheWVyVmlld0NsYXNzKCkpOwogICAgICAgICBDbGFzcyBh Q2xhc3MgPSBvYmpjX2FsbG9jYXRlQ2xhc3NQYWlyKGdldEFWUGxheWVyVmlld0NsYXNzKCksICJX ZWJBVlBsYXllclZpZXciLCAwKTsKICAgICAgICAgdGhlQ2xhc3MgPSBhQ2xhc3M7Ci0gICAgICAg IGNsYXNzX2FkZE1ldGhvZCh0aGVDbGFzcywgQHNlbGVjdG9yKHNldERlbGVnYXRlOiksIChJTVAp V2ViQVZQbGF5ZXJWaWV3X3NldERlbGVnYXRlLCAidkA6QCIpOwotICAgICAgICBjbGFzc19hZGRN ZXRob2QodGhlQ2xhc3MsIEBzZWxlY3RvcihkZWxlZ2F0ZSksIChJTVApV2ViQVZQbGF5ZXJWaWV3 X2RlbGVnYXRlLCAiQEA6Iik7CisgICAgICAgIGNsYXNzX2FkZE1ldGhvZCh0aGVDbGFzcywgQHNl bGVjdG9yKHNldFdlYkRlbGVnYXRlOiksIChJTVApV2ViQVZQbGF5ZXJWaWV3X3NldFdlYkRlbGVn YXRlLCAidkA6QCIpOworICAgICAgICBjbGFzc19hZGRNZXRob2QodGhlQ2xhc3MsIEBzZWxlY3Rv cih3ZWJEZWxlZ2F0ZSksIChJTVApV2ViQVZQbGF5ZXJWaWV3X3dlYkRlbGVnYXRlLCAiQEA6Iik7 CiAgICAgICAgIGNsYXNzX2FkZE1ldGhvZCh0aGVDbGFzcywgQHNlbGVjdG9yKGlzRnVsbFNjcmVl biksIChJTVApV2ViQVZQbGF5ZXJWaWV3X2lzRnVsbFNjcmVlbiwgIkJAOiIpOwogICAgICAgICBj bGFzc19hZGRNZXRob2QodGhlQ2xhc3MsIEBzZWxlY3RvcihlbnRlckZ1bGxTY3JlZW46KSwgKElN UClXZWJBVlBsYXllclZpZXdfZW50ZXJGdWxsU2NyZWVuLCAidkA6QCIpOwogICAgICAgICBjbGFz c19hZGRNZXRob2QodGhlQ2xhc3MsIEBzZWxlY3RvcihleGl0RnVsbFNjcmVlbjopLCAoSU1QKVdl YkFWUGxheWVyVmlld19leGl0RnVsbFNjcmVlbiwgInZAOkAiKTsKQEAgLTE2Miw3ICsxNjIsNyBA QCBzdGF0aWMgV2ViQVZQbGF5ZXJWaWV3ICphbGxvY1dlYkFWUGxheWVyVmlld0luc3RhbmNlKCkK IHsKICAgICBBU1NFUlQoIV9iYWNrZ3JvdW5kRnVsbHNjcmVlbldpbmRvdyk7CiAgICAgQVNTRVJU KCFfZmFkZUFuaW1hdGlvbik7Ci0gICAgX3BsYXllclZpZXcuZGVsZWdhdGUgPSBuaWw7CisgICAg X3BsYXllclZpZXcud2ViRGVsZWdhdGUgPSBuaWw7CiAgICAgX3BsYXliYWNrTW9kZWwgPSBuaWw7 CiAgICAgW3N1cGVyIGRlYWxsb2NdOwogfQpAQCAtMTgzLDcgKzE4Myw3IEBAIHN0YXRpYyBXZWJB VlBsYXllclZpZXcgKmFsbG9jV2ViQVZQbGF5ZXJWaWV3SW5zdGFuY2UoKQogICAgIF9wbGF5ZXJW aWV3LmNvbnRyb2xzU3R5bGUgPSBBVlBsYXllclZpZXdDb250cm9sc1N0eWxlTm9uZTsKICAgICBf cGxheWVyVmlldy5zaG93c0Z1bGxTY3JlZW5Ub2dnbGVCdXR0b24gPSBZRVM7CiAgICAgX3BsYXll clZpZXcuc2hvd3NBdWRpb09ubHlJbmRpY2F0b3JWaWV3ID0gTk87Ci0gICAgX3BsYXllclZpZXcu ZGVsZWdhdGUgPSBzZWxmOworICAgIF9wbGF5ZXJWaWV3LndlYkRlbGVnYXRlID0gc2VsZjsKICAg ICB3aW5kb3cuY29udGVudFZpZXcgPSBfcGxheWVyVmlldzsKICAgICBbX2NvbnRlbnRPdmVybGF5 IHNldEZyYW1lOl9wbGF5ZXJWaWV3LmNvbnRlbnRPdmVybGF5Vmlldy5ib3VuZHNdOwogICAgIFtf cGxheWVyVmlldy5jb250ZW50T3ZlcmxheVZpZXcgYWRkU3VidmlldzpfY29udGVudE92ZXJsYXku Z2V0KCldOwo=