222556 2021-03-01 09:04:24 -0800 [LFC][IFC] Change LineBoxBuilder::m_inlineLevelBoxesNeedVerticalAlignment to m_useSimplifiedVerticalAlignment 2021-03-01 12:52:14 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zalan webkit-unassigned bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1734441 0 zalan 2021-03-01 09:04:24 -0800 it's more descriptive. 1734464 1 421837 zalan 2021-03-01 09:47:05 -0800 Created attachment 421837 Patch 1734547 2 ews-feeder 2021-03-01 12:51:29 -0800 Committed r273681: <https://commits.webkit.org/r273681> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421837. 1734548 3 webkit-bug-importer 2021-03-01 12:52:14 -0800 <rdar://problem/74885702> 421837 2021-03-01 09:47:05 -0800 2021-03-01 12:51:30 -0800 Patch patch.txt text/plain 5741 zalan U3VidmVyc2lvbiBSZXZpc2lvbjogMjczNjUyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWUwNWU0OGMzYTQxODM1 OTg4NmQ2MDhlMjliMzFjZGU3MjM3Y2Q4Yi4uZGYzNWIwNjIyNTUyYzBiMWQ2MWVmZTY4ZTMyYTYz NTI5Y2YxNjJmYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAzLTAxICBaYWxh biBCdWp0YXMgIDx6YWxhbkBhcHBsZS5jb20+CisKKyAgICAgICAgW0xGQ11bSUZDXSBDaGFuZ2Ug TGluZUJveEJ1aWxkZXI6Om1faW5saW5lTGV2ZWxCb3hlc05lZWRWZXJ0aWNhbEFsaWdubWVudCB0 byBtX3VzZVNpbXBsaWZpZWRWZXJ0aWNhbEFsaWdubWVudAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyNTU2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgbV91c2VTaW1wbGlmaWVkVmVydGljYWxBbGlnbm1l bnQgaXMgbW9yZSBkZXNjcmlwdGl2ZS4gSXQncyBhbHNvIGluIHByZXBhcmF0aW9uIGZvciBleHBh bmRpbmcgdGhlIHNpbXBsaWZpZWQgdmVydGljYWwgYWxpZ25tZW50IGNvdmVyYWdlLgorCisgICAg ICAgICogbGF5b3V0L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHRHZW9t ZXRyeS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmVCb3hCdWlsZGVyOjpMaW5l Qm94QnVpbGRlcik6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmVCb3hCdWlsZGVyOjpi dWlsZCk6CisgICAgICAgIChXZWJDb3JlOjpMYXlvdXQ6OkxpbmVCb3hCdWlsZGVyOjpjb25zdHJ1 Y3RJbmxpbmVMZXZlbEJveGVzKToKKwogMjAyMS0wMy0wMSAgQ2hyaXMgTG9yZCAgPGNsb3JkQGln YWxpYS5jb20+CiAKICAgICAgICAgQ1NTRm9udEZhY2Ugc2hvdWxkIG5vdCBuZWVkIGl0cyBtX2Zv bnRTZWxlY3RvciBkYXRhIG1lbWJlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbGF5b3V0 L2lubGluZWZvcm1hdHRpbmcvSW5saW5lRm9ybWF0dGluZ0NvbnRleHRHZW9tZXRyeS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29u dGV4dEdlb21ldHJ5LmNwcAppbmRleCBlMGZmMTlmMDBkMTljZjg2ODdiZDFiNWIxZTExODQxNGIy ZTZiNTYyLi43MmU3MjdjMjk4ODZmMjhjNTM5MTQyYzEyMjI4YTdlYWZhMDIzNzE1IDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5lZm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0 aW5nQ29udGV4dEdlb21ldHJ5LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW5saW5l Zm9ybWF0dGluZy9JbmxpbmVGb3JtYXR0aW5nQ29udGV4dEdlb21ldHJ5LmNwcApAQCAtNTcsNyAr NTcsNyBAQCBwcml2YXRlOgogCiBwcml2YXRlOgogICAgIGNvbnN0IElubGluZUZvcm1hdHRpbmdD b250ZXh0JiBtX2lubGluZUZvcm1hdHRpbmdDb250ZXh0OwotICAgIGJvb2wgbV9pbmxpbmVMZXZl bEJveGVzTmVlZFZlcnRpY2FsQWxpZ25tZW50IHsgZmFsc2UgfTsKKyAgICBib29sIG1fdXNlU2lt cGxpZmllZFZlcnRpY2FsQWxpZ25tZW50IHsgdHJ1ZSB9OwogfTsKIAogc3RydWN0IEhhbmdpbmdU cmFpbGluZ1doaXRlc3BhY2VDb250ZW50IHsKQEAgLTE0OCw3ICsxNDgsNyBAQCBzdGF0aWMgT3B0 aW9uYWw8SW5saW5lTGF5b3V0VW5pdD4gaG9yaXpvbnRhbEFsaWdubWVudE9mZnNldChjb25zdCBM aW5lOjpSdW5MaXN0JgogCiBMaW5lQm94QnVpbGRlcjo6TGluZUJveEJ1aWxkZXIoY29uc3QgSW5s aW5lRm9ybWF0dGluZ0NvbnRleHQmIGlubGluZUZvcm1hdHRpbmdDb250ZXh0KQogICAgIDogbV9p bmxpbmVGb3JtYXR0aW5nQ29udGV4dChpbmxpbmVGb3JtYXR0aW5nQ29udGV4dCkKLSAgICAsIG1f aW5saW5lTGV2ZWxCb3hlc05lZWRWZXJ0aWNhbEFsaWdubWVudCghaW5saW5lRm9ybWF0dGluZ0Nv bnRleHQubGF5b3V0U3RhdGUoKS5pblN0YW5kYXJkc01vZGUoKSkKKyAgICAsIG1fdXNlU2ltcGxp ZmllZFZlcnRpY2FsQWxpZ25tZW50KGlubGluZUZvcm1hdHRpbmdDb250ZXh0LmxheW91dFN0YXRl KCkuaW5TdGFuZGFyZHNNb2RlKCkpCiB7CiB9CiAKQEAgLTE2MSw3ICsxNjEsNyBAQCBMaW5lQm94 IExpbmVCb3hCdWlsZGVyOjpidWlsZChjb25zdCBMaW5lQnVpbGRlcjo6TGluZUNvbnRlbnQmIGxp bmVDb250ZW50KQogICAgIGF1dG8gbGluZUJveCA9IExpbmVCb3ggeyByb290Qm94KCksIGxpbmVD b250ZW50LmxvZ2ljYWxUb3BMZWZ0LCBsaW5lTG9naWNhbFdpZHRoLCBob3Jpem9udGFsQWxpZ25t ZW50T2Zmc2V0LnZhbHVlT3IoSW5saW5lTGF5b3V0VW5pdCB7IH0pLCBjb250ZW50TG9naWNhbFdp ZHRoLCBydW5zLnNpemUoKSB9OwogCiAgICAgY29uc3RydWN0SW5saW5lTGV2ZWxCb3hlcyhsaW5l Qm94LCBydW5zKTsKLSAgICBpZiAobV9pbmxpbmVMZXZlbEJveGVzTmVlZFZlcnRpY2FsQWxpZ25t ZW50KQorICAgIGlmICghbV91c2VTaW1wbGlmaWVkVmVydGljYWxBbGlnbm1lbnQpCiAgICAgICAg IGNvbXB1dGVMaW5lQm94SGVpZ2h0QW5kQWxpZ25JbmxpbmVMZXZlbEJveGVzVmVydGljYWxseShs aW5lQm94KTsKICAgICByZXR1cm4gbGluZUJveDsKIH0KQEAgLTI5OCw3ICsyOTgsNyBAQCB2b2lk IExpbmVCb3hCdWlsZGVyOjpjb25zdHJ1Y3RJbmxpbmVMZXZlbEJveGVzKExpbmVCb3gmIGxpbmVC b3gsIGNvbnN0IExpbmU6OlJ1bgogICAgICAgICAgICAgYXRvbWljSW5saW5lTGV2ZWxCb3gtPnNl dExheW91dEJvdW5kcyhMaW5lQm94OjpJbmxpbmVMZXZlbEJveDo6TGF5b3V0Qm91bmRzIHsgYXNj ZW50LCBtYXJnaW5Cb3hIZWlnaHQgLSBhc2NlbnQgfSk7CiAgICAgICAgICAgICAvLyBMZXQncyBw cmUtY29tcHV0ZSB0aGUgbG9naWNhbCB0b3Agc28gdGhhdCB3ZSBjYW4gYXZvaWQgcnVubmluZyB0 aGUgYWxpZ25tZW50IG9uIHNpbXBsZSBpbmxpbmUgYm94ZXMuCiAgICAgICAgICAgICBhdXRvIGFs aWduSW5saW5lQm94SWZFbGlnaWJsZSA9IFsmXSB7Ci0gICAgICAgICAgICAgICAgaWYgKG1faW5s aW5lTGV2ZWxCb3hlc05lZWRWZXJ0aWNhbEFsaWdubWVudCkKKyAgICAgICAgICAgICAgICBpZiAo IW1fdXNlU2ltcGxpZmllZFZlcnRpY2FsQWxpZ25tZW50KQogICAgICAgICAgICAgICAgICAgICBy ZXR1cm47CiAgICAgICAgICAgICAgICAgLy8gQmFzZWxpbmUgYWxpZ25lZCwgbm9uLXN0cmV0Y2h5 IGRpcmVjdCBjaGlsZHJlbiBhcmUgY29uc2lkZXJlZCB0byBiZSBzaW1wbGUgZm9yIG5vdy4KICAg ICAgICAgICAgICAgICBhdXRvIGlzQ29uc2lkZXJlZFNpbXBsZSA9ICZsYXlvdXRCb3gucGFyZW50 KCkgPT0gJnJvb3RCb3goKQpAQCAtMzA3LDcgKzMwNyw3IEBAIHZvaWQgTGluZUJveEJ1aWxkZXI6 OmNvbnN0cnVjdElubGluZUxldmVsQm94ZXMoTGluZUJveCYgbGluZUJveCwgY29uc3QgTGluZTo6 UnVuCiAgICAgICAgICAgICAgICAgICAgICYmICFpbmxpbmVMZXZlbEJveEdlb21ldHJ5Lm1hcmdp bkFmdGVyKCkKICAgICAgICAgICAgICAgICAgICAgJiYgbWFyZ2luQm94SGVpZ2h0IDw9IHJvb3RJ bmxpbmVCb3guYmFzZWxpbmUoKTsKICAgICAgICAgICAgICAgICBpZiAoIWlzQ29uc2lkZXJlZFNp bXBsZSkgewotICAgICAgICAgICAgICAgICAgICBtX2lubGluZUxldmVsQm94ZXNOZWVkVmVydGlj YWxBbGlnbm1lbnQgPSB0cnVlOworICAgICAgICAgICAgICAgICAgICBtX3VzZVNpbXBsaWZpZWRW ZXJ0aWNhbEFsaWdubWVudCA9IGZhbHNlOwogICAgICAgICAgICAgICAgICAgICByZXR1cm47CiAg ICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgICAgIC8vIE9ubHkgYmFzZWxpbmUgYWxpZ25t ZW50IGZvciBub3cuCkBAIC0zMjUsNyArMzI1LDcgQEAgdm9pZCBMaW5lQm94QnVpbGRlcjo6Y29u c3RydWN0SW5saW5lTGV2ZWxCb3hlcyhMaW5lQm94JiBsaW5lQm94LCBjb25zdCBMaW5lOjpSdW4K ICAgICAgICAgLy8gRklYTUU6IEFkZCBzdXBwb3J0IGZvciBzaW1wbGUgaW5saW5lIGJveGVzIHRv by4KICAgICAgICAgLy8gV2UgY2FuIGRvIHNpbXBsaWZpZWQgdmVydGljYWwgYWxpZ25tZW50IHdp dGggbm9uLWF0b21pYyBpbmxpbmUgYm94ZXMgYXMgbG9uZyBhcyB0aGUgbGluZSBoYXMgbm8gY29u dGVudC4KICAgICAgICAgLy8gZS5nLiA8ZGl2PjxzcGFuPjwvc3Bhbj48c3Bhbj48L3NwYW4+PC9k aXY+IGlzIHN0aWxsIG9rYXkuCi0gICAgICAgIG1faW5saW5lTGV2ZWxCb3hlc05lZWRWZXJ0aWNh bEFsaWdubWVudCA9IG1faW5saW5lTGV2ZWxCb3hlc05lZWRWZXJ0aWNhbEFsaWdubWVudCB8fCBs aW5lSGFzQ29udGVudDsKKyAgICAgICAgbV91c2VTaW1wbGlmaWVkVmVydGljYWxBbGlnbm1lbnQg PSAhbGluZUhhc0NvbnRlbnQ7CiAgICAgICAgIGlmIChydW4uaXNJbmxpbmVCb3hTdGFydCgpKSB7 CiAgICAgICAgICAgICAvLyBBdCB0aGlzIHBvaW50IHdlIGRvbid0IGtub3cgeWV0IGhvdyB3aWRl IHRoaXMgaW5saW5lIGJveCBpcy4gTGV0J3MgYXNzdW1lIGl0J3MgYXMgbG9uZyBhcyB0aGUgbGlu ZSBpcwogICAgICAgICAgICAgLy8gYW5kIGFkanVzdCBpdCBsYXRlciBpZiB3ZSBjb21lIGFjcm9z cyBhbiBpbmxpbmVCb3hFbmQgcnVuIChzZWUgYmVsb3cpLgpAQCAtMzcxLDEzICszNzEsMTMgQEAg dm9pZCBMaW5lQm94QnVpbGRlcjo6Y29uc3RydWN0SW5saW5lTGV2ZWxCb3hlcyhMaW5lQm94JiBs aW5lQm94LCBjb25zdCBMaW5lOjpSdW4KICAgICBsaW5lQm94LnNldEhhc0NvbnRlbnQobGluZUhh c0NvbnRlbnQpOwogICAgIGlmICghbGluZUhhc0NvbnRlbnQpIHsKICAgICAgICAgLy8gV2Ugc2hv dWxkIGFsd2F5cyBiZSBhYmxlIHRvIGV4ZXJjaXNlIHRoZSBmYXN0IHBhdGggd2hlbiB0aGUgbGlu ZSBoYXMgbm8gY29udGVudCBhdCBhbGwuCi0gICAgICAgIG1faW5saW5lTGV2ZWxCb3hlc05lZWRW ZXJ0aWNhbEFsaWdubWVudCA9IGZhbHNlOwotICAgIH0gZWxzZSBpZiAoIW1faW5saW5lTGV2ZWxC b3hlc05lZWRWZXJ0aWNhbEFsaWdubWVudCkgeworICAgICAgICBtX3VzZVNpbXBsaWZpZWRWZXJ0 aWNhbEFsaWdubWVudCA9IHRydWU7CisgICAgfSBlbHNlIGlmIChtX3VzZVNpbXBsaWZpZWRWZXJ0 aWNhbEFsaWdubWVudCkgewogICAgICAgICAvLyBGSVhNRTogQWRkIGZhc3QgcGF0aCBzdXBwb3J0 IGZvciBsaW5lLWhlaWdodCBjb250ZW50LgotICAgICAgICBtX2lubGluZUxldmVsQm94ZXNOZWVk VmVydGljYWxBbGlnbm1lbnQgPSAhcm9vdEJveCgpLnN0eWxlKCkubGluZUhlaWdodCgpLmlzTmVn YXRpdmUoKTsKKyAgICAgICAgbV91c2VTaW1wbGlmaWVkVmVydGljYWxBbGlnbm1lbnQgPSByb290 Qm94KCkuc3R5bGUoKS5saW5lSGVpZ2h0KCkuaXNOZWdhdGl2ZSgpOwogICAgIH0KIAotICAgIGlm ICghbV9pbmxpbmVMZXZlbEJveGVzTmVlZFZlcnRpY2FsQWxpZ25tZW50KSB7CisgICAgaWYgKG1f dXNlU2ltcGxpZmllZFZlcnRpY2FsQWxpZ25tZW50KSB7CiAgICAgICAgIGlmICghbGluZUhhc0Nv bnRlbnQpIHsKICAgICAgICAgICAgIHNpbXBsaWZpZWRWZXJ0aWNhbEFsaWdubWVudC5yb290SW5s aW5lQm94VG9wID0gLXJvb3RJbmxpbmVCb3guYmFzZWxpbmUoKTsKICAgICAgICAgICAgIHNpbXBs aWZpZWRWZXJ0aWNhbEFsaWdubWVudC5saW5lQm94VG9wID0geyB9Owo=