<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>222536</bug_id>
          
          <creation_ts>2021-02-28 22:05:23 -0800</creation_ts>
          <short_desc>Remove added element from Style::Update root set</short_desc>
          <delta_ts>2021-03-01 12:38:14 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>CSS</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Antti Koivisto">koivisto</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>webkit-bug-importer</cc>
    
    <cc>zalan</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1734333</commentid>
    <comment_count>0</comment_count>
    <who name="Antti Koivisto">koivisto</who>
    <bug_when>2021-02-28 22:05:23 -0800</bug_when>
    <thetext>With combined text and element updates an element might already exist in the root set when added. Remove it from the root set to avoid updating it twice.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1734334</commentid>
    <comment_count>1</comment_count>
      <attachid>421788</attachid>
    <who name="Antti Koivisto">koivisto</who>
    <bug_when>2021-02-28 22:19:43 -0800</bug_when>
    <thetext>Created attachment 421788
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1734545</commentid>
    <comment_count>2</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-03-01 12:37:53 -0800</bug_when>
    <thetext>Committed r273680: &lt;https://commits.webkit.org/r273680&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421788.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1734546</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-03-01 12:38:14 -0800</bug_when>
    <thetext>&lt;rdar://problem/74884875&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>421788</attachid>
            <date>2021-02-28 22:19:43 -0800</date>
            <delta_ts>2021-03-01 12:37:53 -0800</delta_ts>
            <desc>patch</desc>
            <filename>style-update-root-remove.patch</filename>
            <type>text/plain</type>
            <size>1666</size>
            <attacher name="Antti Koivisto">koivisto</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No
YW5nZUxvZwppbmRleCAxOTg5YmJjYjcyZDEuLjIyMjllYTBjZDlkNSAxMDA2NDQKLS0tIGEvU291
cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt
MSwzICsxLDE3IEBACisyMDIxLTAyLTI4ICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNv
bT4KKworICAgICAgICBSZW1vdmUgYWRkZWQgZWxlbWVudCBmcm9tIFN0eWxlOjpVcGRhdGUgcm9v
dCBzZXQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIy
MjUzNgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdp
dGggY29tYmluZWQgdGV4dCBhbmQgZWxlbWVudCB1cGRhdGVzIGFuIGVsZW1lbnQgbWlnaHQgYWxy
ZWFkeSBleGlzdCBpbiB0aGUgcm9vdCBzZXQgd2hlbiBhZGRlZC4KKyAgICAgICAgUmVtb3ZlIGl0
IGZyb20gdGhlIHJvb3Qgc2V0IHRvIGF2b2lkIHVwZGF0aW5nIGl0IHR3aWNlLgorCisgICAgICAg
ICogc3R5bGUvU3R5bGVVcGRhdGUuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3R5bGU6OlVwZGF0
ZTo6YWRkRWxlbWVudCk6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZTo6VXBkYXRlOjphZGRUZXh0
KToKKwogMjAyMS0wMi0yNSAgQW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAg
ICAgICAgUmVuZGVyIHRyZWUgdXBkYXRlcyBmb3IgVGV4dCBub2RlIGNvbnRlbnQgbXV0YXRpb25z
IHNob3VsZCBoYXBwZW4gZHVyaW5nIHJlbmRlcmluZyB1cGRhdGUKZGlmZiAtLWdpdCBhL1NvdXJj
ZS9XZWJDb3JlL3N0eWxlL1N0eWxlVXBkYXRlLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0
eWxlVXBkYXRlLmNwcAppbmRleCA4ZmE4NTE4ZWU3YmEuLjYzNTkzZGQ0YTdjNiAxMDA2NDQKLS0t
IGEvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVVcGRhdGUuY3BwCisrKyBiL1NvdXJjZS9XZWJD
b3JlL3N0eWxlL1N0eWxlVXBkYXRlLmNwcApAQCAtOTAsNyArOTAsOSBAQCB2b2lkIFVwZGF0ZTo6
YWRkRWxlbWVudChFbGVtZW50JiBlbGVtZW50LCBFbGVtZW50KiBwYXJlbnQsIEVsZW1lbnRVcGRh
dGVzJiYgZWxlbQogICAgIEFTU0VSVCghbV9lbGVtZW50cy5jb250YWlucygmZWxlbWVudCkpOwog
ICAgIEFTU0VSVChjb21wb3NlZFRyZWVBbmNlc3RvcnMoZWxlbWVudCkuZmlyc3QoKSA9PSBwYXJl
bnQpOwogCisgICAgbV9yb290cy5yZW1vdmUoJmVsZW1lbnQpOwogICAgIGFkZFBvc3NpYmxlUm9v
dChwYXJlbnQpOworCiAgICAgbV9lbGVtZW50cy5hZGQoJmVsZW1lbnQsIFdURk1vdmUoZWxlbWVu
dFVwZGF0ZXMpKTsKIH0KIApAQCAtOTksNiArMTAxLDcgQEAgdm9pZCBVcGRhdGU6OmFkZFRleHQo
VGV4dCYgdGV4dCwgRWxlbWVudCogcGFyZW50LCBUZXh0VXBkYXRlJiYgdGV4dFVwZGF0ZSkKICAg
ICBBU1NFUlQoY29tcG9zZWRUcmVlQW5jZXN0b3JzKHRleHQpLmZpcnN0KCkgPT0gcGFyZW50KTsK
IAogICAgIGFkZFBvc3NpYmxlUm9vdChwYXJlbnQpOworCiAgICAgYXV0byByZXN1bHQgPSBtX3Rl
eHRzLmVuc3VyZSgmdGV4dCwgWyZdIHsKICAgICAgICAgcmV0dXJuIFdURk1vdmUodGV4dFVwZGF0
ZSk7CiAgICAgfSk7Cg==
</data>

          </attachment>
      

    </bug>

</bugzilla>