222508 2021-02-26 17:33:12 -0800 Support fast/canvas/webgl/copyBufferSubData.html, fix bugs in fast/canvas/webgl/getBufferSubData-webgl1.html in Metal ANGLE on Simulator 2021-02-26 18:45:16 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 kpiddington webkit-unassigned dino ews-watchlist graouts kondapallykalyan webkit-bug-importer oldest_to_newest 1734100 0 kpiddington 2021-02-26 17:33:12 -0800 Support fast/canvas/webgl/copyBufferSubData.html, fix bugs in fast/canvas/webgl/getBufferSubData-webgl1.html in Metal ANGLE on Simulator 1734101 1 421731 kpiddington 2021-02-26 17:33:29 -0800 Created attachment 421731 Patch 1734102 2 ews-watchlist 2021-02-26 17:34:37 -0800 Note that there are important steps to take when updating ANGLE. See https://trac.webkit.org/wiki/UpdatingANGLE 1734110 3 421731 dino 2021-02-26 18:36:26 -0800 Comment on attachment 421731 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421731&action=review > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/BufferMtl.mm:233 > + if(result) Nit: Space before ( > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm:331 > +#else //Simulator should be able to support ES3, despite not supporting ios family 4 in it's entirety. Nit: Space after // and s/it's/its/ I'll fix these when landing. 1734112 4 421731 dino 2021-02-26 18:41:36 -0800 Comment on attachment 421731 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421731&action=review > Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/DisplayMtl.mm:337 > return gl::Version(2, 0); I think this statement should go inside the else clause. It wouldn't be hit in the TARGET_OS_SIMULATOR path. 1734113 5 dino 2021-02-26 18:44:37 -0800 Committed r273612 (234658@main): <https://commits.webkit.org/234658@main> 1734114 6 webkit-bug-importer 2021-02-26 18:45:16 -0800 <rdar://problem/74817963> 421731 2021-02-26 17:33:29 -0800 2021-02-26 18:36:26 -0800 Patch bug-222508-20210226173329.patch text/plain 2582 kpiddington U3VidmVyc2lvbiBSZXZpc2lvbjogMjczNjA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9BTkdMRS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9BTkdMRS9DaGFuZ2VMb2cKaW5k ZXggMDVjM2NhNzZiMDU1ODA3ZDEyMDZmN2UyMGM2ZTEzNjM5MGJhN2IxYS4uNTExMzFjMjA3ZWRk MmJhN2ZlZThiMTg4ZWI5MmIwMTZiZjc1ZGJmOCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFy dHkvQU5HTEUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL0NoYW5nZUxv ZwpAQCAtMSwzICsxLDE1IEBACisyMDIxLTAyLTI2ICBLeWxlIFBpZGRpbmd0b24gIDxrcGlkZGlu Z3RvbkBhcHBsZS5jb20+CisKKyAgICAgICAgU3VwcG9ydCAgZmFzdC9jYW52YXMvd2ViZ2wvY29w eUJ1ZmZlclN1YkRhdGEuaHRtbCwgZml4IGJ1Z3MgaW4gZmFzdC9jYW52YXMvd2ViZ2wvZ2V0QnVm ZmVyU3ViRGF0YS13ZWJnbDEuaHRtbCBpbiBNZXRhbCBBTkdMRSBvbiBTaW11bGF0b3IKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjUwOAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3JjL2xpYkFOR0xF L3JlbmRlcmVyL21ldGFsL0J1ZmZlck10bC5tbToKKyAgICAgICAgKHJ4OjpCdWZmZXJNdGw6OnVu bWFwKToKKyAgICAgICAgKiBzcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvRGlzcGxheU10bC5t bToKKyAgICAgICAgKHJ4OjpEaXNwbGF5TXRsOjpnZXRNYXhTdXBwb3J0ZWRFU1ZlcnNpb24gY29u c3QpOgorCiAyMDIxLTAyLTI2ICBLeWxlIFBpZGRpbmd0b24gIDxrcGlkZGluZ3RvbkBhcHBsZS5j b20+CiAKICAgICAgICAgRml4IGlPUyBzaW11bGF0b3IgY3Jhc2hlcyBkdWUgdG8gdW5zdXBwb3J0 ZWQgc2ltdWxhdG9yIHBpeGVsIGZvcm1hdHM6IHI4VW5vcm1fc3JnYiwgYTFiZ3I1VW5vcm0sIGI1 ZzZyNVVub3JtLCBhYmdyNFVub3JtLCBiZ3I1QTFVbm9ybSwgYW5kIHByb2dyYW0gZ2VuZXJhdGlv biBhc3NlcnRzLgpkaWZmIC0tZ2l0IGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3JjL2xpYkFO R0xFL3JlbmRlcmVyL21ldGFsL0J1ZmZlck10bC5tbSBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xF L3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9CdWZmZXJNdGwubW0KaW5kZXggODA5Njk5NmUy ODhmNTk1MTMyMWViODhmZmVkN2RhMGQwOTkyMTRiMC4uNjI5MWQxMzM2MWQyNzg5MmQ5ODIwMWVm OGVmMTc5N2IzODMyMzFhOCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQU5HTEUvc3Jj L2xpYkFOR0xFL3JlbmRlcmVyL21ldGFsL0J1ZmZlck10bC5tbQorKysgYi9Tb3VyY2UvVGhpcmRQ YXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvQnVmZmVyTXRsLm1tCkBAIC0y MzAsNyArMjMwLDEwIEBAIGFuZ2xlOjpSZXN1bHQgQnVmZmVyTXRsOjp1bm1hcChjb25zdCBnbDo6 Q29udGV4dCAqY29udGV4dCwgR0xib29sZWFuICpyZXN1bHQpCiAgICAgICAgICAgICBBTkdMRV9U UlkoY29tbWl0U2hhZG93Q29weShjb250ZXh0KSk7CiAgICAgICAgIH0KICAgICB9Ci0KKyAgICBp ZihyZXN1bHQpCisgICAgeworICAgICAgICAqcmVzdWx0ID0gdHJ1ZTsKKyAgICB9CiAgICAgcmV0 dXJuIGFuZ2xlOjpSZXN1bHQ6OkNvbnRpbnVlOwogfQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhp cmRQYXJ0eS9BTkdMRS9zcmMvbGliQU5HTEUvcmVuZGVyZXIvbWV0YWwvRGlzcGxheU10bC5tbSBi L1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9EaXNw bGF5TXRsLm1tCmluZGV4IGEzNzhiMjRiZmVlZDg4MGUwYWY0OWJkZGRlODQ2ZmNmMDVhOGM2OTMu LjQzMWUwZWEyNzg5NjQ3MmQ4NDIyZDdhMmQ1YWYwZDVmOWI1NmVkYjUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJlci9tZXRhbC9EaXNwbGF5 TXRsLm1tCisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0FOR0xFL3NyYy9saWJBTkdMRS9yZW5kZXJl ci9tZXRhbC9EaXNwbGF5TXRsLm1tCkBAIC0zMjYsMTAgKzMyNiwxNCBAQCBTdHJlYW1Qcm9kdWNl ckltcGwgKkRpc3BsYXlNdGw6OmNyZWF0ZVN0cmVhbVByb2R1Y2VyRDNEVGV4dHVyZSgKIGdsOjpW ZXJzaW9uIERpc3BsYXlNdGw6OmdldE1heFN1cHBvcnRlZEVTVmVyc2lvbigpIGNvbnN0CiB7CiAg ICAgLy8gTk9URShocWxlKTogU3VwcG9ydHMgR0xFUyAzLjAgb24gaU9TIEdQVSBmYW1pbHkgNCsg Zm9yIG5vdy4KKyNpZiBUQVJHRVRfT1NfU0lNVUxBVE9SCisgICAgcmV0dXJuIGdsOjpWZXJzaW9u KDMsIDApOworI2Vsc2UgLy9TaW11bGF0b3Igc2hvdWxkIGJlIGFibGUgdG8gc3VwcG9ydCBFUzMs IGRlc3BpdGUgbm90IHN1cHBvcnRpbmcgaW9zIGZhbWlseSA0IGluIGl0J3MgZW50aXJldHkuCiAg ICAgaWYgKHN1cHBvcnRzRWl0aGVyR1BVRmFtaWx5KDQsIDEpKQogICAgIHsKICAgICAgICAgcmV0 dXJuIGdsOjpWZXJzaW9uKDMsIDApOwogICAgIH0KKyNlbmRpZgogICAgIHJldHVybiBnbDo6VmVy c2lvbigyLCAwKTsKIH0KIAo=