222507 2021-02-26 17:07:51 -0800 Consider removing iOS only CSS property alias -webkit-hyphenate-locale introduced in r80288 2021-02-28 18:27:13 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sam sam andersca darin esprehn+autocc ews-watchlist glenn gyuyoung.kim koivisto macpherson menard rniwa simon.fraser webkit-bug-importer oldest_to_newest 1734094 0 sam 2021-02-26 17:07:51 -0800 It's been about 10 years, we should probably remove the iOS only CSS property alias for -webkit-locale, -webkit-hyphenate-locale. It was introduced in r80288 / https://bugs.webkit.org/show_bug.cgi?id=55709, when -webkit-hyphenate-locale was renamed to -webkit-locale. 1734096 1 sam 2021-02-26 17:08:17 -0800 Anyone have any objections to trying to remove this? 1734126 2 rniwa 2021-02-26 21:45:26 -0800 Seems like we can try removing it. 1734201 3 421749 sam 2021-02-27 09:56:47 -0800 Created attachment 421749 Patch 1734303 4 ews-feeder 2021-02-28 14:21:40 -0800 Tools/Scripts/svn-apply failed to apply attachment 421749 to trunk. Please resolve the conflicts and upload a new patch. 1734318 5 421785 sam 2021-02-28 17:58:27 -0800 Created attachment 421785 Patch 1734322 6 ews-feeder 2021-02-28 18:26:05 -0800 Committed r273642: <https://commits.webkit.org/r273642> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421785. 1734323 7 webkit-bug-importer 2021-02-28 18:27:13 -0800 <rdar://problem/74848693> 421749 2021-02-27 09:56:47 -0800 2021-02-28 17:58:24 -0800 Patch bug-222507-20210227095646.patch text/plain 3703 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3MzYyNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDIxLTAyLTI3ICBTYW0gV2Vp bmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KKworICAgICAgICBDb25zaWRlciByZW1vdmluZyBpT1Mg b25seSBDU1MgcHJvcGVydHkgYWxpYXMgLXdlYmtpdC1oeXBoZW5hdGUtbG9jYWxlIGludHJvZHVj ZWQgaW4gcjgwMjg4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjI1MDcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBJdCdzIGJlZW4gYWJvdXQgMTAgeWVhcnMsIGxldCdzIHRyeSByZW1vdmluZyB0aGUgaU9T IG9ubHkgQ1NTIHByb3BlcnR5IGFsaWFzIGZvcgorICAgICAgICAtd2Via2l0LWxvY2FsZSwgLXdl YmtpdC1oeXBoZW5hdGUtbG9jYWxlLCBhbmQgc2VlIHdoYXQgaGFwcGVucy4KKworICAgICAgICAq IGNzcy9DU1NTdHlsZURlY2xhcmF0aW9uLmNwcDoKKyAgICAgICAgKiBjc3MvcGFyc2VyL0NTU1By b3BlcnR5UGFyc2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmNzc1Byb3BlcnR5SUQpOgorICAg ICAgICAoV2ViQ29yZTo6Y3NzUHJvcGVydHlOYW1lSU9TQWxpYXNpbmcpOiBEZWxldGVkLgorICAg ICAgICAqIGNzcy9wYXJzZXIvQ1NTUHJvcGVydHlQYXJzZXIuaDoKKwogMjAyMS0wMi0yNyAgWmFs YW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtMRkNdW0NvdmVyYWdlXSBB ZGQgbWlzc2luZyBub3QteWV0LW1vZGVybi1saW5lLWxheW91dCByZWFzb25zCkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVEZWNsYXJhdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvY3NzL0NTU1N0eWxlRGVjbGFyYXRpb24uY3BwCShyZXZpc2lvbiAyNzM2MjYp CisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVEZWNsYXJhdGlvbi5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTIxNiwxMCArMjE2LDYgQEAgc3RhdGljIENTU1Byb3BlcnR5SW5mbyBwYXJzZUph dmFTY3JpcHRDUwogICAgICpidWZmZXJQdHIgPSAnXDAnOwogCiAgICAgdW5zaWduZWQgb3V0cHV0 TGVuZ3RoID0gYnVmZmVyUHRyIC0gYnVmZmVyOwotI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCi0g ICAgY3NzUHJvcGVydHlOYW1lSU9TQWxpYXNpbmcoYnVmZmVyLCBuYW1lLCBvdXRwdXRMZW5ndGgp OwotI2VuZGlmCi0KICAgICBhdXRvKiBoYXNoVGFibGVFbnRyeSA9IGZpbmRQcm9wZXJ0eShuYW1l LCBvdXRwdXRMZW5ndGgpOwogICAgIGlmIChhdXRvIHByb3BlcnR5SUQgPSBoYXNoVGFibGVFbnRy eSA/IGhhc2hUYWJsZUVudHJ5LT5pZCA6IDApIHsKICAgICAgICAgYXV0byBpZCA9IHN0YXRpY19j YXN0PENTU1Byb3BlcnR5SUQ+KHByb3BlcnR5SUQpOwpJbmRleDogU291cmNlL1dlYkNvcmUvY3Nz L3BhcnNlci9DU1NQcm9wZXJ0eVBhcnNlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvY3NzL3BhcnNlci9DU1NQcm9wZXJ0eVBhcnNlci5jcHAJKHJldmlzaW9uIDI3MzYyNikKKysr IFNvdXJjZS9XZWJDb3JlL2Nzcy9wYXJzZXIvQ1NTUHJvcGVydHlQYXJzZXIuY3BwCSh3b3JraW5n IGNvcHkpCkBAIC05NiwxOCArOTYsNiBAQCBzdGF0aWMgYm9vbCBoYXNQcmVmaXgoY29uc3QgY2hh ciogc3RyaW5nCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCi0jaWYgUExBVEZPUk0oSU9TX0ZBTUlM WSkKLXZvaWQgY3NzUHJvcGVydHlOYW1lSU9TQWxpYXNpbmcoY29uc3QgY2hhciogcHJvcGVydHlO YW1lLCBjb25zdCBjaGFyKiYgcHJvcGVydHlOYW1lQWxpYXMsIHVuc2lnbmVkJiBuZXdMZW5ndGgp Ci17Ci0gICAgaWYgKCFzdHJjbXAocHJvcGVydHlOYW1lLCAiLXdlYmtpdC1oeXBoZW5hdGUtbG9j YWxlIikpIHsKLSAgICAgICAgLy8gV29ya2VkIGluIGlPUyA0LjIuCi0gICAgICAgIHN0YXRpYyBj b25zdCBjaGFyIHdlYmtpdExvY2FsZVtdID0gIi13ZWJraXQtbG9jYWxlIjsKLSAgICAgICAgcHJv cGVydHlOYW1lQWxpYXMgPSB3ZWJraXRMb2NhbGU7Ci0gICAgICAgIG5ld0xlbmd0aCA9IHN0cmxl bih3ZWJraXRMb2NhbGUpOwotICAgIH0KLX0KLSNlbmRpZgotCiB0ZW1wbGF0ZSA8dHlwZW5hbWUg Q2hhcmFjdGVyVHlwZT4KIHN0YXRpYyBDU1NQcm9wZXJ0eUlEIGNzc1Byb3BlcnR5SUQoY29uc3Qg Q2hhcmFjdGVyVHlwZSogcHJvcGVydHlOYW1lLCB1bnNpZ25lZCBsZW5ndGgpCiB7CkBAIC0xMjEs MTUgKzEwOSw3IEBAIHN0YXRpYyBDU1NQcm9wZXJ0eUlEIGNzc1Byb3BlcnR5SUQoY29uc3QKICAg ICB9CiAgICAgYnVmZmVyW2xlbmd0aF0gPSAnXDAnOwogICAgIAotICAgIGNvbnN0IGNoYXIqIG5h bWUgPSBidWZmZXI7Ci0gICAgaWYgKGJ1ZmZlclswXSA9PSAnLScpIHsKLSNpZiBQTEFURk9STShJ T1NfRkFNSUxZKQotICAgICAgICBjc3NQcm9wZXJ0eU5hbWVJT1NBbGlhc2luZyhidWZmZXIsIG5h bWUsIGxlbmd0aCk7Ci0jZW5kaWYKLSAgICB9Ci0gICAgCi0gICAgY29uc3QgUHJvcGVydHkqIGhh c2hUYWJsZUVudHJ5ID0gZmluZFByb3BlcnR5KG5hbWUsIGxlbmd0aCk7Ci0gICAgaWYgKGhhc2hU YWJsZUVudHJ5KSB7CisgICAgaWYgKGF1dG8gaGFzaFRhYmxlRW50cnkgPSBmaW5kUHJvcGVydHko YnVmZmVyLCBsZW5ndGgpKSB7CiAgICAgICAgIGF1dG8gcHJvcGVydHlJRCA9IHN0YXRpY19jYXN0 PENTU1Byb3BlcnR5SUQ+KGhhc2hUYWJsZUVudHJ5LT5pZCk7CiAgICAgICAgIC8vIEZJWE1FOiBT aG91bGQgdGFrZSBhY2NvdW50IGZvciBmbGFncyBpbiBzZXR0aW5ncygpLgogICAgICAgICBpZiAo aXNFbmFibGVkQ1NTUHJvcGVydHkocHJvcGVydHlJRCkpCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9j c3MvcGFyc2VyL0NTU1Byb3BlcnR5UGFyc2VyLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNv cmUvY3NzL3BhcnNlci9DU1NQcm9wZXJ0eVBhcnNlci5oCShyZXZpc2lvbiAyNzM2MjYpCisrKyBT b3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1Byb3BlcnR5UGFyc2VyLmgJKHdvcmtpbmcgY29w eSkKQEAgLTEyOCw4ICsxMjgsNCBAQCBDU1NQcm9wZXJ0eUlEIGNzc1Byb3BlcnR5SUQoU3RyaW5n Vmlldyk7CiBXRUJDT1JFX0VYUE9SVCBDU1NWYWx1ZUlEIGNzc1ZhbHVlS2V5d29yZElEKFN0cmlu Z1ZpZXcpOwogYm9vbCBpc0N1c3RvbVByb3BlcnR5TmFtZShjb25zdCBTdHJpbmcmKTsKIAotI2lm IFBMQVRGT1JNKElPU19GQU1JTFkpCi12b2lkIGNzc1Byb3BlcnR5TmFtZUlPU0FsaWFzaW5nKGNv bnN0IGNoYXIqIHByb3BlcnR5TmFtZSwgY29uc3QgY2hhciomIHByb3BlcnR5TmFtZUFsaWFzLCB1 bnNpZ25lZCYgbmV3TGVuZ3RoKTsKLSNlbmRpZgotCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCg== 421785 2021-02-28 17:58:27 -0800 2021-02-28 18:26:06 -0800 Patch bug-222507-20210228175826.patch text/plain 3664 sam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3MzYzOSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBACisyMDIxLTAyLTI4ICBTYW0gV2Vp bmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KKworICAgICAgICBDb25zaWRlciByZW1vdmluZyBpT1Mg b25seSBDU1MgcHJvcGVydHkgYWxpYXMgLXdlYmtpdC1oeXBoZW5hdGUtbG9jYWxlIGludHJvZHVj ZWQgaW4gcjgwMjg4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMjI1MDcKKworICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCisKKyAg ICAgICAgSXQncyBiZWVuIGFib3V0IDEwIHllYXJzLCBsZXQncyB0cnkgcmVtb3ZpbmcgdGhlIGlP UyBvbmx5IENTUyBwcm9wZXJ0eSBhbGlhcyBmb3IKKyAgICAgICAgLXdlYmtpdC1sb2NhbGUsIC13 ZWJraXQtaHlwaGVuYXRlLWxvY2FsZSwgYW5kIHNlZSB3aGF0IGhhcHBlbnMuCisKKyAgICAgICAg KiBjc3MvQ1NTU3R5bGVEZWNsYXJhdGlvbi5jcHA6CisgICAgICAgICogY3NzL3BhcnNlci9DU1NQ cm9wZXJ0eVBhcnNlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpjc3NQcm9wZXJ0eUlEKToKKyAg ICAgICAgKFdlYkNvcmU6OmNzc1Byb3BlcnR5TmFtZUlPU0FsaWFzaW5nKTogRGVsZXRlZC4KKyAg ICAgICAgKiBjc3MvcGFyc2VyL0NTU1Byb3BlcnR5UGFyc2VyLmg6CisKIDIwMjEtMDItMjggIERh cmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIFJlZHVjZSB1c2Ug b2YgcmV0YWluL3JlbGVhc2UgaW4gV0FLV2luZG93IGFuZCByZW1vdmUgdW5uZWVkZWQgbWV0aG9k cyBmcm9tIHRoYXQgY2xhc3MKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NTdHlsZURlY2xh cmF0aW9uLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9jc3MvQ1NTU3R5bGVEZWNs YXJhdGlvbi5jcHAJKHJldmlzaW9uIDI3MzYzMykKKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NT dHlsZURlY2xhcmF0aW9uLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTg0LDEwICsxODQsNiBAQCBz dGF0aWMgQ1NTUHJvcGVydHlJRCBwYXJzZUphdmFTY3JpcHRDU1NQCiAgICAgKmJ1ZmZlclB0ciA9 ICdcMCc7CiAKICAgICB1bnNpZ25lZCBvdXRwdXRMZW5ndGggPSBidWZmZXJQdHIgLSBidWZmZXI7 Ci0jaWYgUExBVEZPUk0oSU9TX0ZBTUlMWSkKLSAgICBjc3NQcm9wZXJ0eU5hbWVJT1NBbGlhc2lu ZyhidWZmZXIsIG5hbWUsIG91dHB1dExlbmd0aCk7Ci0jZW5kaWYKLQogICAgIGF1dG8gaGFzaFRh YmxlRW50cnkgPSBmaW5kUHJvcGVydHkobmFtZSwgb3V0cHV0TGVuZ3RoKTsKICAgICBpZiAoIWhh c2hUYWJsZUVudHJ5KQogICAgICAgICByZXR1cm4gQ1NTUHJvcGVydHlJbnZhbGlkOwpJbmRleDog U291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NQcm9wZXJ0eVBhcnNlci5jcHAKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NQcm9wZXJ0eVBhcnNlci5jcHAJKHJl dmlzaW9uIDI3MzYzMykKKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9wYXJzZXIvQ1NTUHJvcGVydHlQ YXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC05NiwxOCArOTYsNiBAQCBzdGF0aWMgYm9vbCBo YXNQcmVmaXgoY29uc3QgY2hhciogc3RyaW5nCiAgICAgcmV0dXJuIGZhbHNlOwogfQogCi0jaWYg UExBVEZPUk0oSU9TX0ZBTUlMWSkKLXZvaWQgY3NzUHJvcGVydHlOYW1lSU9TQWxpYXNpbmcoY29u c3QgY2hhciogcHJvcGVydHlOYW1lLCBjb25zdCBjaGFyKiYgcHJvcGVydHlOYW1lQWxpYXMsIHVu c2lnbmVkJiBuZXdMZW5ndGgpCi17Ci0gICAgaWYgKCFzdHJjbXAocHJvcGVydHlOYW1lLCAiLXdl YmtpdC1oeXBoZW5hdGUtbG9jYWxlIikpIHsKLSAgICAgICAgLy8gV29ya2VkIGluIGlPUyA0LjIu Ci0gICAgICAgIHN0YXRpYyBjb25zdCBjaGFyIHdlYmtpdExvY2FsZVtdID0gIi13ZWJraXQtbG9j YWxlIjsKLSAgICAgICAgcHJvcGVydHlOYW1lQWxpYXMgPSB3ZWJraXRMb2NhbGU7Ci0gICAgICAg IG5ld0xlbmd0aCA9IHN0cmxlbih3ZWJraXRMb2NhbGUpOwotICAgIH0KLX0KLSNlbmRpZgotCiB0 ZW1wbGF0ZSA8dHlwZW5hbWUgQ2hhcmFjdGVyVHlwZT4KIHN0YXRpYyBDU1NQcm9wZXJ0eUlEIGNz c1Byb3BlcnR5SUQoY29uc3QgQ2hhcmFjdGVyVHlwZSogcHJvcGVydHlOYW1lLCB1bnNpZ25lZCBs ZW5ndGgpCiB7CkBAIC0xMjEsMTUgKzEwOSw3IEBAIHN0YXRpYyBDU1NQcm9wZXJ0eUlEIGNzc1By b3BlcnR5SUQoY29uc3QKICAgICB9CiAgICAgYnVmZmVyW2xlbmd0aF0gPSAnXDAnOwogICAgIAot ICAgIGNvbnN0IGNoYXIqIG5hbWUgPSBidWZmZXI7Ci0gICAgaWYgKGJ1ZmZlclswXSA9PSAnLScp IHsKLSNpZiBQTEFURk9STShJT1NfRkFNSUxZKQotICAgICAgICBjc3NQcm9wZXJ0eU5hbWVJT1NB bGlhc2luZyhidWZmZXIsIG5hbWUsIGxlbmd0aCk7Ci0jZW5kaWYKLSAgICB9Ci0gICAgCi0gICAg Y29uc3QgUHJvcGVydHkqIGhhc2hUYWJsZUVudHJ5ID0gZmluZFByb3BlcnR5KG5hbWUsIGxlbmd0 aCk7Ci0gICAgaWYgKGhhc2hUYWJsZUVudHJ5KSB7CisgICAgaWYgKGF1dG8gaGFzaFRhYmxlRW50 cnkgPSBmaW5kUHJvcGVydHkoYnVmZmVyLCBsZW5ndGgpKSB7CiAgICAgICAgIGF1dG8gcHJvcGVy dHlJRCA9IHN0YXRpY19jYXN0PENTU1Byb3BlcnR5SUQ+KGhhc2hUYWJsZUVudHJ5LT5pZCk7CiAg ICAgICAgIC8vIEZJWE1FOiBTaG91bGQgdGFrZSBhY2NvdW50IGZvciBmbGFncyBpbiBzZXR0aW5n cygpLgogICAgICAgICBpZiAoaXNFbmFibGVkQ1NTUHJvcGVydHkocHJvcGVydHlJRCkpCkluZGV4 OiBTb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1Byb3BlcnR5UGFyc2VyLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NQcm9wZXJ0eVBhcnNlci5oCShyZXZp c2lvbiAyNzM2MzMpCisrKyBTb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1Byb3BlcnR5UGFy c2VyLmgJKHdvcmtpbmcgY29weSkKQEAgLTEyOCw4ICsxMjgsNCBAQCBDU1NQcm9wZXJ0eUlEIGNz c1Byb3BlcnR5SUQoU3RyaW5nVmlldyk7CiBXRUJDT1JFX0VYUE9SVCBDU1NWYWx1ZUlEIGNzc1Zh bHVlS2V5d29yZElEKFN0cmluZ1ZpZXcpOwogYm9vbCBpc0N1c3RvbVByb3BlcnR5TmFtZShjb25z dCBTdHJpbmcmKTsKIAotI2lmIFBMQVRGT1JNKElPU19GQU1JTFkpCi12b2lkIGNzc1Byb3BlcnR5 TmFtZUlPU0FsaWFzaW5nKGNvbnN0IGNoYXIqIHByb3BlcnR5TmFtZSwgY29uc3QgY2hhciomIHBy b3BlcnR5TmFtZUFsaWFzLCB1bnNpZ25lZCYgbmV3TGVuZ3RoKTsKLSNlbmRpZgotCiB9IC8vIG5h bWVzcGFjZSBXZWJDb3JlCg==