222494 2021-02-26 14:34:06 -0800 Remove bad assertion of AI ArrayMode state in various "by val" opcodes 2021-02-26 17:59:06 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 saam saam ews-watchlist fpizlo keith_miller mark.lam msaboff tzagallo webkit-bug-importer oldest_to_newest 1733980 0 saam 2021-02-26 14:34:06 -0800 ... 1733982 1 saam 2021-02-26 14:36:37 -0800 <rdar://73613460> 1733994 2 421709 saam 2021-02-26 14:57:15 -0800 Created attachment 421709 patch 1733996 3 421709 keith_miller 2021-02-26 15:00:22 -0800 Comment on attachment 421709 patch r=me too. 1734106 4 ews-feeder 2021-02-26 17:59:04 -0800 Committed r273611: <https://commits.webkit.org/r273611> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421709. 421709 2021-02-26 14:57:15 -0800 2021-02-26 17:59:05 -0800 patch c-backup.diff text/plain 6513 saam SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyNzM1OTEpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE1IEBACisyMDIxLTAyLTI2ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgorCisgICAgICAgIFJlbW92ZSBiYWQgYXNzZXJ0aW9uIG9mIEFJIEFycmF5TW9kZSBzdGF0 ZSBpbiB2YXJpb3VzICJieSB2YWwiIG9wY29kZXMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjQ5NAorICAgICAgICA8cmRhcjovLzczNjEzNDYwPgor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogc3RyZXNz L2RvbnQtYXNzZXJ0LWFpLXByb3ZlZC1hcnJheS1tb2RlLmpzOiBBZGRlZC4KKyAgICAgICAgKGJh cik6CisgICAgICAgIChmb28pOgorCiAyMDIxLTAyLTI1ICBZdXN1a2UgU3V6dWtpICA8eXN1enVr aUBhcHBsZS5jb20+CiAKICAgICAgICAgW0pTQ10gRml4IHR5cG8gaW4gd2FzbSBlcnJvciBtZXNz YWdlCkluZGV4OiBKU1Rlc3RzL3N0cmVzcy9kb250LWFzc2VydC1haS1wcm92ZWQtYXJyYXktbW9k ZS5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL3N0cmVzcy9kb250LWFzc2VydC1haS1wcm92ZWQt YXJyYXktbW9kZS5qcwkobm9uZXhpc3RlbnQpCisrKyBKU1Rlc3RzL3N0cmVzcy9kb250LWFzc2Vy dC1haS1wcm92ZWQtYXJyYXktbW9kZS5qcwkod29ya2luZyBjb3B5KQpAQCAtMCwwICsxLDE5IEBA CisvL0AgcmVxdWlyZU9wdGlvbnMoIi0taml0UG9saWN5U2NhbGU9MCIsICItLXNsb3dQYXRoQWxs b2NzQmV0d2VlbkdDcz0xNSIpCisKK2Z1bmN0aW9uIGZvbyhhMCwgYTEsIGEyLCBhMywgLi4uYTQp IHsKKyAgICBmdW5jdGlvbiBiYXIoKSB7CisgICAgICAgIGZvciAobGV0IGk9MDsgaTwxMDsgaSsr KSB7CisgICAgICAgICAgICBuZXcgVWludDhBcnJheShhcmd1bWVudHMpOworICAgICAgICAgICAg YXJndW1lbnRzWzBdOworICAgICAgICAgICAgdHJ5IHsKKyAgICAgICAgICAgICAgICAwLi53YWZm bGVzKCk7CisgICAgICAgICAgICB9IGNhdGNoIChlKSB7CisgICAgICAgICAgICB9CisgICAgICAg ICAgICBmb28uX19wcm90b19fID0gYXJndW1lbnRzOworICAgICAgICB9CisgICAgfQorICAgIGJh cigpOworfQorZm9yIChsZXQgaT0wOyBpPDEwMDsgaSsrKSB7CisgICAgZm9vKCk7Cit9CkluZGV4 OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9K YXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3MzI4MykKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwzNiBAQAorMjAy MS0wMi0yNiAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KKworICAgICAgICBSZW1v dmUgYmFkIGFzc2VydGlvbiBvZiBBSSBBcnJheU1vZGUgc3RhdGUgaW4gdmFyaW91cyAiYnkgdmFs IiBvcGNvZGVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMjI0OTQKKyAgICAgICAgPHJkYXI6Ly83MzYxMzQ2MD4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCdzIGludmFsaWQgdG8gZXZlciBhc3NlcnQg dGhhdCBBSSBtdXN0IGhhdmUgcHJvdmVkIHNvbWV0aGluZy4gV2UndmUgYmVlbgorICAgICAgICBz bG93bHkgcmVtb3ZpbmcgdGhlc2UgZmF1bHR5IGFzc2VydHMgZnJvbSB0aGUgY29tcGlsZXIsIGFu ZCB0aGlzIHBhdGNoCisgICAgICAgIHJlbW92ZXMgc29tZSBtb3JlIG9mIHRoZW0uIEFJIGlzIGNv bnNlcnZhdGl2ZSwgYW5kIGl0J3Mgbm90IGd1YXJhbnRlZWQKKyAgICAgICAgdGhhdCBpdCB3aWxs IHByb3ZlIFgsIGV2ZW4gaWYgWCBtdXN0IGJlIHRydWUuCisgICAgICAgIAorICAgICAgICBJbiB0 aGlzIHBhcnRpY3VsYXIgdGVzdCBjYXNlLCB3ZSBhcmUgbG9va2luZyBhdCBhIHJhY2UgYmV0d2Vl biB0aGUgY29uY3VycmVudAorICAgICAgICBjb21waWxlciB0aHJlYWQgYW5kIHRoZSBtYWluIHRo cmVhZCwgYW5kIHRoZSBjb21waWxhdGlvbiB3aWxsIGJlIHRocm93biBhd2F5CisgICAgICAgIGJl Y2F1c2Ugb2YgYSBTdHJ1Y3R1cmUgdHJhbnNpdGlvbi4KKyAgICAgICAgCisgICAgICAgIFdoYXQg aGFwcGVuZWQgaW4gdGhpcyBwYXJ0aWN1bGFyIHByb2dyYW0gaXMgd2UgaGFkIGEgQ2hlY2tTdHJ1 Y3R1cmUgdGhhdCB3YXMKKyAgICAgICAgcHJvdmVkIHRvIGV4aXQgaW4gYW4gZWFybHkgcnVuIG9m IEFJLCB0aGF0IGlzIG5vdCBzaG93biB0byBleGl0IGR1cmluZyBhIGxhdGVyCisgICAgICAgIHJ1 biBvZiBBSS4gQmVjYXVzZSBvZiB0aGF0LCBpbiB0aGUgZWFybGllciBBSSBydW4sIHdlIGhhdmUg c29tZSBuYXJyb3dlciB0eXBlCisgICAgICAgIGluZm8gKGJlY2F1c2UgZmV3ZXIgcHJlZGVjZXNz b3J5IHR5cGUgaW5mbykuIFRoaXMgbmFycm93ZXIgdHlwZSBpbmZvIGFsbG93ZWQKKyAgICAgICAg dXMgdG8gZWxpZGUgYSBDaGVja0FycmF5LiBUaGUgbGF0ZXIgcnVucyBkb24ndCBoYXZlIHRoaXMg bmFycm93ZXIgdHlwZSBpbmZvLAorICAgICAgICBiZWNhdXNlIHRoZSBDaGVja1N0cnVjdHVyZSBk b2Vzbid0IGV4aXQuIFRoZSBzYWZldHkgb2YgYWxsIG9mIHRoaXMgaXMKKyAgICAgICAgZ3VhcmFu dGVlZCBieSB0aGUgY29tcGlsYXRpb24gYmVpbmcgdGhyb3duIGF3YXkgYmVjYXVzZSB3ZSBmaXJl ZCB0aGUgdHJhbnNpdGlvbgorICAgICAgICB3YXRjaHBvaW50IGZyb20gdGhlIGVhcmxpZXIgU3Ry dWN0dXJlIHNlZW4gYnkgQUkuCisKKyAgICAgICAgKiBkZmcvREZHU3BlY3VsYXRpdmVKSVQuY3Bw OgorICAgICAgICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpjb21waWxlR2V0QnlWYWxPblN0 cmluZyk6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVQdXRCeVZh bEZvckZsb2F0VHlwZWRBcnJheSk6CisgICAgICAgIChKU0M6OkRGRzo6U3BlY3VsYXRpdmVKSVQ6 OmNvbXBpbGVHZXRCeVZhbE9uRGlyZWN0QXJndW1lbnRzKToKKyAgICAgICAgKEpTQzo6REZHOjpT cGVjdWxhdGl2ZUpJVDo6Y29tcGlsZUdldEJ5VmFsT25TY29wZWRBcmd1bWVudHMpOgorICAgICAg ICAoSlNDOjpERkc6OlNwZWN1bGF0aXZlSklUOjpjb21waWxlR2V0QXJyYXlMZW5ndGgpOgorCiAy MDIxLTAyLTIyICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgogCiAgICAg ICAgIFJlbW92ZSB1bnVzZWQgaW50ZXJuYWwgZmllbGRzIGZyb20gQWJzdHJhY3RNb2R1bGVMb2Fk ZXIKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVKSVQuY3Bw Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHU3BlY3VsYXRpdmVK SVQuY3BwCShyZXZpc2lvbiAyNzMyODMpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RG R1NwZWN1bGF0aXZlSklULmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjM2Miw4ICsyMzYyLDYgQEAg dm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZUdldEJ5VmFsT25TdAogICAgIH0KICNlbmRpZgog Ci0gICAgQVNTRVJUKEFycmF5TW9kZShBcnJheTo6U3RyaW5nLCBBcnJheTo6UmVhZCkuYWxyZWFk eUNoZWNrZWQobV9qaXQuZ3JhcGgoKSwgbm9kZSwgbV9zdGF0ZS5mb3JOb2RlKG1fZ3JhcGguY2hp bGQobm9kZSwgMCkpKSk7Ci0KICAgICAvLyB1bnNpZ25lZCBjb21wYXJpc29uIHNvIHdlIGNhbiBm aWx0ZXIgb3V0IG5lZ2F0aXZlIGluZGljZXMgYW5kIGluZGljZXMgdGhhdCBhcmUgdG9vIGxhcmdl CiAgICAgbV9qaXQubG9hZFB0cihNYWNyb0Fzc2VtYmxlcjo6QWRkcmVzcyhiYXNlUmVnLCBKU1N0 cmluZzo6b2Zmc2V0T2ZWYWx1ZSgpKSwgc2NyYXRjaFJlZyk7CiAgICAgSklUQ29tcGlsZXI6Okp1 bXAgb3V0T2ZCb3VuZHMgPSBtX2ppdC5icmFuY2gzMigKQEAgLTM0MjIsNyArMzQyMCw2IEBAIHZv aWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVQdXRCeVZhbEZvckYKICAgICBTdG9yYWdlT3BlcmFu ZCBzdG9yYWdlKHRoaXMsIG1faml0LmdyYXBoKCkudmFyQXJnQ2hpbGQobm9kZSwgMykpOwogICAg IEdQUlJlZyBzdG9yYWdlUmVnID0gc3RvcmFnZS5ncHIoKTsKICAgICAKLSAgICBFZGdlIGJhc2VV c2UgPSBtX2ppdC5ncmFwaCgpLnZhckFyZ0NoaWxkKG5vZGUsIDApOwogICAgIEVkZ2UgdmFsdWVV c2UgPSBtX2ppdC5ncmFwaCgpLnZhckFyZ0NoaWxkKG5vZGUsIDIpOwogCiAgICAgU3BlY3VsYXRl RG91YmxlT3BlcmFuZCB2YWx1ZU9wKHRoaXMsIHZhbHVlVXNlKTsKQEAgLTM0MzAsOCArMzQyNyw2 IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVQdXRCeVZhbEZvckYKICAgICBGUFJSZWcg dmFsdWVGUFIgPSB2YWx1ZU9wLmZwcigpOwogICAgIEZQUlJlZyBzY3JhdGNoRlBSID0gc2NyYXRj aC5mcHIoKTsKIAotICAgIEFTU0VSVF9VTlVTRUQoYmFzZVVzZSwgbm9kZS0+YXJyYXlNb2RlKCku YWxyZWFkeUNoZWNrZWQobV9qaXQuZ3JhcGgoKSwgbm9kZSwgbV9zdGF0ZS5mb3JOb2RlKGJhc2VV c2UpKSk7Ci0gICAgCiAgICAgTWFjcm9Bc3NlbWJsZXI6Okp1bXAgb3V0T2ZCb3VuZHMgPSBqdW1w Rm9yVHlwZWRBcnJheU91dE9mQm91bmRzKG5vZGUsIGJhc2UsIHByb3BlcnR5KTsKICAgICAKICAg ICBzd2l0Y2ggKGVsZW1lbnRTaXplKHR5cGUpKSB7CkBAIC03NjE2LDggKzc2MTEsNiBAQCB2b2lk IFNwZWN1bGF0aXZlSklUOjpjb21waWxlR2V0QnlWYWxPbkRpCiAgICAgaWYgKCFtX2NvbXBpbGVP a2F5KQogICAgICAgICByZXR1cm47CiAgICAgCi0gICAgQVNTRVJUKEFycmF5TW9kZShBcnJheTo6 RGlyZWN0QXJndW1lbnRzLCBBcnJheTo6UmVhZCkuYWxyZWFkeUNoZWNrZWQobV9qaXQuZ3JhcGgo KSwgbm9kZSwgbV9zdGF0ZS5mb3JOb2RlKG1fZ3JhcGgudmFyQXJnQ2hpbGQobm9kZSwgMCkpKSk7 Ci0gICAgCiAgICAgc3BlY3VsYXRpb25DaGVjaygKICAgICAgICAgRXhvdGljT2JqZWN0TW9kZSwg SlNWYWx1ZVNvdXJjZSgpLCBudWxscHRyLAogICAgICAgICBtX2ppdC5icmFuY2hUZXN0UHRyKApA QCAtNzY2MSw4ICs3NjU0LDYgQEAgdm9pZCBTcGVjdWxhdGl2ZUpJVDo6Y29tcGlsZUdldEJ5VmFs T25TYwogICAgIGlmICghbV9jb21waWxlT2theSkKICAgICAgICAgcmV0dXJuOwogICAgIAotICAg IEFTU0VSVChBcnJheU1vZGUoQXJyYXk6OlNjb3BlZEFyZ3VtZW50cywgQXJyYXk6OlJlYWQpLmFs cmVhZHlDaGVja2VkKG1faml0LmdyYXBoKCksIG5vZGUsIG1fc3RhdGUuZm9yTm9kZShtX2dyYXBo LnZhckFyZ0NoaWxkKG5vZGUsIDApKSkpOwotICAgIAogICAgIG1faml0LmxvYWRQdHIoCiAgICAg ICAgIE1hY3JvQXNzZW1ibGVyOjpBZGRyZXNzKGJhc2VSZWcsIFNjb3BlZEFyZ3VtZW50czo6b2Zm c2V0T2ZTdG9yYWdlKCkpLCByZXN1bHRSZWdzLnBheWxvYWRHUFIoKSk7CiAKQEAgLTc4MjcsOCAr NzgxOCw2IEBAIHZvaWQgU3BlY3VsYXRpdmVKSVQ6OmNvbXBpbGVHZXRBcnJheUxlbmcKICAgICAg ICAgaWYgKCFtX2NvbXBpbGVPa2F5KQogICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAKLSAg ICAgICAgQVNTRVJUKEFycmF5TW9kZShBcnJheTo6RGlyZWN0QXJndW1lbnRzLCBBcnJheTo6UmVh ZCkuYWxyZWFkeUNoZWNrZWQobV9qaXQuZ3JhcGgoKSwgbm9kZSwgbV9zdGF0ZS5mb3JOb2RlKG5v ZGUtPmNoaWxkMSgpKSkpOwotICAgICAgICAKICAgICAgICAgc3BlY3VsYXRpb25DaGVjaygKICAg ICAgICAgICAgIEV4b3RpY09iamVjdE1vZGUsIEpTVmFsdWVTb3VyY2UoKSwgbnVsbHB0ciwKICAg ICAgICAgICAgIG1faml0LmJyYW5jaFRlc3RQdHIoCkBAIC03ODUxLDggKzc4NDAsNiBAQCB2b2lk IFNwZWN1bGF0aXZlSklUOjpjb21waWxlR2V0QXJyYXlMZW5nCiAgICAgICAgIGlmICghbV9jb21w aWxlT2theSkKICAgICAgICAgICAgIHJldHVybjsKICAgICAgICAgCi0gICAgICAgIEFTU0VSVChB cnJheU1vZGUoQXJyYXk6OlNjb3BlZEFyZ3VtZW50cywgQXJyYXk6OlJlYWQpLmFscmVhZHlDaGVj a2VkKG1faml0LmdyYXBoKCksIG5vZGUsIG1fc3RhdGUuZm9yTm9kZShub2RlLT5jaGlsZDEoKSkp KTsKLSAgICAgICAgCiAgICAgICAgIHNwZWN1bGF0aW9uQ2hlY2soCiAgICAgICAgICAgICBFeG90 aWNPYmplY3RNb2RlLCBKU1ZhbHVlU291cmNlKCksIG51bGxwdHIsCiAgICAgICAgICAgICBtX2pp dC5icmFuY2hUZXN0OCgK