222482 2021-02-26 10:54:28 -0800 [git-webkit] Better error message when attempting to convert tag to identifier 2021-03-02 16:56:46 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 jbedard jbedard aakash_jain webkit-bug-importer oldest_to_newest 1733873 0 jbedard 2021-02-26 10:54:28 -0800 Aakash pointed to a case where we attempted to compute an identifier for a revision that matched a tag, which doesn't work. We should improve logging in this case: https://build.webkit.org/#/builders/66/builds/541 1733874 1 webkit-bug-importer 2021-02-26 10:55:02 -0800 <rdar://problem/74797495> 1733875 2 421676 jbedard 2021-02-26 10:56:49 -0800 Created attachment 421676 Patch 1733879 3 421676 aakash_jain 2021-02-26 11:01:59 -0800 Comment on attachment 421676 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421676&action=review > Tools/Scripts/libraries/webkitscmpy/webkitscmpy/local/svn.py:213 > raise self.Exception("Failed to find '{}' on '{}'".format(revision, branch)) This line can be re-worded something like: "Failed to find 'r{}' on branch: '{}'" 1735103 4 422015 jbedard 2021-03-02 16:10:54 -0800 Created attachment 422015 Patch for landing 1735133 5 ews-feeder 2021-03-02 16:56:45 -0800 Committed r273774: <https://commits.webkit.org/r273774> All reviewed patches have been landed. Closing bug and clearing flags on attachment 422015. 421676 2021-02-26 10:56:49 -0800 2021-03-02 16:10:51 -0800 Patch bug-222482-20210226105648.patch text/plain 2749 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3MzU2NikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIxLTAyLTI2ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbZ2l0LXdlYmtpdF0gQmV0dGVyIGxvZ2dpbmcgd2hlbiBhdHRlbXB0aW5n IHRvIGNvbnZlcnQgdGFnIHRvIGlkZW50aWZpZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjQ4MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzQ3 OTc0OTU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBTY3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvc2V0dXAucHk6IEJ1ZyB2ZXJzaW9uLgor ICAgICAgICAqIFNjcmlwdHMvbGlicmFyaWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkvX19p bml0X18ucHk6IERpdHRvLgorICAgICAgICAqIFNjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5 L3dlYmtpdHNjbXB5L2xvY2FsL3N2bi5weToKKyAgICAgICAgKFN2bi5fY29tbWl0X2NvdW50KToK KwogMjAyMS0wMi0yNiAgQWFrYXNoIEphaW4gIDxhYWthc2hfamFpbkBhcHBsZS5jb20+CiAKICAg ICAgICAgW2J1aWxkLndlYmtpdC5vcmddIFN0b3AgdXNpbmcgZGVwcmVjYXRlZCBidWlsZGJvdC5z dGF0dXMuYnVpbGRlcgpJbmRleDogVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0Y29yZXB5 L3NldHVwLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdGNv cmVweS9zZXR1cC5weQkocmV2aXNpb24gMjczNTYyKQorKysgVG9vbHMvU2NyaXB0cy9saWJyYXJp ZXMvd2Via2l0Y29yZXB5L3NldHVwLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0zMCw3ICszMCw3IEBA IGRlZiByZWFkbWUoKToKIAogc2V0dXAoCiAgICAgbmFtZT0nd2Via2l0Y29yZXB5JywKLSAgICB2 ZXJzaW9uPScwLjUuMicsCisgICAgdmVyc2lvbj0nMC41LjMnLAogICAgIGRlc2NyaXB0aW9uPSdM aWJyYXJ5IGNvbnRhaW5pbmcgdmFyaW91cyBQeXRob24gc3VwcG9ydCBjbGFzc2VzIGFuZCBmdW5j dGlvbnMuJywKICAgICBsb25nX2Rlc2NyaXB0aW9uPXJlYWRtZSgpLAogICAgIGNsYXNzaWZpZXJz PVsKSW5kZXg6IFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3Jl cHkvX19pbml0X18ucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Vi a2l0Y29yZXB5L3dlYmtpdGNvcmVweS9fX2luaXRfXy5weQkocmV2aXNpb24gMjczNTYyKQorKysg VG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0Y29yZXB5L3dlYmtpdGNvcmVweS9fX2luaXRf Xy5weQkod29ya2luZyBjb3B5KQpAQCAtMzYsNyArMzYsNyBAQCBmcm9tIHdlYmtpdGNvcmVweS5z dWJwcm9jZXNzX3V0aWxzIGltcG9yCiBmcm9tIHdlYmtpdGNvcmVweS5vdXRwdXRfY2FwdHVyZSBp bXBvcnQgTG9nZ2VyQ2FwdHVyZSwgT3V0cHV0Q2FwdHVyZSwgT3V0cHV0RHVwbGljYXRlCiBmcm9t IHdlYmtpdGNvcmVweS50YXNrX3Bvb2wgaW1wb3J0IFRhc2tQb29sCiAKLXZlcnNpb24gPSBWZXJz aW9uKDAsIDUsIDIpCit2ZXJzaW9uID0gVmVyc2lvbigwLCA1LCAzKQogCiBmcm9tIHdlYmtpdGNv cmVweS5hdXRvaW5zdGFsbCBpbXBvcnQgUGFja2FnZSwgQXV0b0luc3RhbGwKIGlmIHN5cy52ZXJz aW9uX2luZm8gPiAoMywgMCk6CkluZGV4OiBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRz Y21weS93ZWJraXRzY21weS9sb2NhbC9zdm4ucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0 cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0c2NtcHkvbG9jYWwvc3ZuLnB5CShyZXZpc2lv biAyNzM1NjIpCisrKyBUb29scy9TY3JpcHRzL2xpYnJhcmllcy93ZWJraXRzY21weS93ZWJraXRz Y21weS9sb2NhbC9zdm4ucHkJKHdvcmtpbmcgY29weSkKQEAgLTIwOCw2ICsyMDgsOCBAQCBjbGFz cyBTdm4oU2NtKToKIAogICAgICAgICBpZiByZXZpc2lvbjoKICAgICAgICAgICAgIGlmIHJldmlz aW9uIG5vdCBpbiBzZWxmLl9tZXRhZGF0YV9jYWNoZVticmFuY2hdOgorICAgICAgICAgICAgICAg IGlmICdicmFuY2gnIG5vdCBpbiBicmFuY2ggYW5kIGJyYW5jaCAhPSAndHJ1bmsnOgorICAgICAg ICAgICAgICAgICAgICBzeXMuc3RkZXJyLndyaXRlKCJDaGVjayBpZiAncnt9JyBpcyBhIHRhZ1xu Ii5mb3JtYXQocmV2aXNpb24pKQogICAgICAgICAgICAgICAgIHJhaXNlIHNlbGYuRXhjZXB0aW9u KCJGYWlsZWQgdG8gZmluZCAne30nIG9uICd7fSciLmZvcm1hdChyZXZpc2lvbiwgYnJhbmNoKSkK ICAgICAgICAgICAgIHJldHVybiBiaXNlY3QuYmlzZWN0X2xlZnQoc2VsZi5fbWV0YWRhdGFfY2Fj aGVbYnJhbmNoXSwgaW50KHJldmlzaW9uKSkKICAgICAgICAgaWYgYnJhbmNoID09IHNlbGYuZGVm YXVsdF9icmFuY2g6Cg== 422015 2021-03-02 16:10:54 -0800 2021-03-02 16:56:46 -0800 Patch for landing bug-222482-20210302161053.patch text/plain 2688 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3Mzc2OCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE2IEBACisyMDIxLTAzLTAyICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBbZ2l0LXdlYmtpdF0gQmV0dGVyIGxvZ2dpbmcgd2hlbiBhdHRlbXB0aW5n IHRvIGNvbnZlcnQgdGFnIHRvIGlkZW50aWZpZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjQ4MgorICAgICAgICA8cmRhcjovL3Byb2JsZW0vNzQ3 OTc0OTU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQWFrYXNoIEphaW4uCisKKyAgICAgICAgKiBT Y3JpcHRzL2xpYnJhcmllcy93ZWJraXRjb3JlcHkvc2V0dXAucHk6IEJ1ZyB2ZXJzaW9uLgorICAg ICAgICAqIFNjcmlwdHMvbGlicmFyaWVzL3dlYmtpdGNvcmVweS93ZWJraXRjb3JlcHkvX19pbml0 X18ucHk6IERpdHRvLgorICAgICAgICAqIFNjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dl YmtpdHNjbXB5L2xvY2FsL3N2bi5weToKKyAgICAgICAgKFN2bi5fY29tbWl0X2NvdW50KToKKwog MjAyMS0wMy0wMiAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAg ICAgW3dlYmtpdHNjbXB5XSBBZGQgVVVJRApJbmRleDogVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMv d2Via2l0c2NtcHkvc2V0dXAucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9saWJyYXJp ZXMvd2Via2l0c2NtcHkvc2V0dXAucHkJKHJldmlzaW9uIDI3Mzc2OCkKKysrIFRvb2xzL1Njcmlw dHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3NldHVwLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0yOSw3 ICsyOSw3IEBAIGRlZiByZWFkbWUoKToKIAogc2V0dXAoCiAgICAgbmFtZT0nd2Via2l0c2NtcHkn LAotICAgIHZlcnNpb249JzAuMTIuMCcsCisgICAgdmVyc2lvbj0nMC4xMi4xJywKICAgICBkZXNj cmlwdGlvbj0nTGlicmFyeSBkZXNpZ25lZCB0byBpbnRlcmFjdCB3aXRoIGdpdCBhbmQgc3ZuIHJl cG9zaXRvcmllcy4nLAogICAgIGxvbmdfZGVzY3JpcHRpb249cmVhZG1lKCksCiAgICAgY2xhc3Np ZmllcnM9WwpJbmRleDogVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMvd2Via2l0c2NtcHkvd2Via2l0 c2NtcHkvX19pbml0X18ucHkKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvU2NyaXB0cy9saWJyYXJpZXMv d2Via2l0c2NtcHkvd2Via2l0c2NtcHkvX19pbml0X18ucHkJKHJldmlzaW9uIDI3Mzc2OCkKKysr IFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5L19faW5pdF9f LnB5CSh3b3JraW5nIGNvcHkpCkBAIC00Niw3ICs0Niw3IEBAIGV4Y2VwdCBJbXBvcnRFcnJvcjoK ICAgICAgICAgIlBsZWFzZSBpbnN0YWxsIHdlYmtpdGNvcmVweSB3aXRoIGBwaXAgaW5zdGFsbCB3 ZWJraXRjb3JlcHkgLS1leHRyYS1pbmRleC11cmwgPHBhY2thZ2UgaW5kZXggVVJMPmAiCiAgICAg KQogCi12ZXJzaW9uID0gVmVyc2lvbigwLCAxMiwgMCkKK3ZlcnNpb24gPSBWZXJzaW9uKDAsIDEy LCAxKQogCiBBdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdmYXN0ZW5lcnMnLCBWZXJzaW9u KDAsIDE1LCAwKSkpCiBBdXRvSW5zdGFsbC5yZWdpc3RlcihQYWNrYWdlKCdtb25vdG9uaWMnLCBW ZXJzaW9uKDEsIDUpKSkKSW5kZXg6IFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5 L3dlYmtpdHNjbXB5L2xvY2FsL3N2bi5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9TY3JpcHRzL2xp YnJhcmllcy93ZWJraXRzY21weS93ZWJraXRzY21weS9sb2NhbC9zdm4ucHkJKHJldmlzaW9uIDI3 Mzc2OCkKKysrIFRvb2xzL1NjcmlwdHMvbGlicmFyaWVzL3dlYmtpdHNjbXB5L3dlYmtpdHNjbXB5 L2xvY2FsL3N2bi5weQkod29ya2luZyBjb3B5KQpAQCAtMjA4LDYgKzIwOCw4IEBAIGNsYXNzIFN2 bihTY20pOgogCiAgICAgICAgIGlmIHJldmlzaW9uOgogICAgICAgICAgICAgaWYgcmV2aXNpb24g bm90IGluIHNlbGYuX21ldGFkYXRhX2NhY2hlW2JyYW5jaF06CisgICAgICAgICAgICAgICAgaWYg J2JyYW5jaCcgbm90IGluIGJyYW5jaCBhbmQgYnJhbmNoICE9ICd0cnVuayc6CisgICAgICAgICAg ICAgICAgICAgIHN5cy5zdGRlcnIud3JpdGUoIkNoZWNrIGlmICdye30nIGlzIGEgdGFnXG4iLmZv cm1hdChyZXZpc2lvbikpCiAgICAgICAgICAgICAgICAgcmFpc2Ugc2VsZi5FeGNlcHRpb24oIkZh aWxlZCB0byBmaW5kICd7fScgb24gJ3t9JyIuZm9ybWF0KHJldmlzaW9uLCBicmFuY2gpKQogICAg ICAgICAgICAgcmV0dXJuIGJpc2VjdC5iaXNlY3RfbGVmdChzZWxmLl9tZXRhZGF0YV9jYWNoZVti cmFuY2hdLCBpbnQocmV2aXNpb24pKQogICAgICAgICBpZiBicmFuY2ggPT0gc2VsZi5kZWZhdWx0 X2JyYW5jaDoK