222480 2021-02-26 09:44:03 -0800 [GTK] Fails to build in i386: static assertion failed: divisor must be a power of two 2021-03-01 01:44:08 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 berto kkinnunen berto bugs-noreply cgarcia kkinnunen peng.liu6 oldest_to_newest 1733819 0 berto 2021-02-26 09:44:03 -0800 I can reproduce this with WebKitGTK 2.31.90: In file included from DerivedSources/ForwardingHeaders/wtf/FastMalloc.h:26, from ../Source/WebKit/config.h:42, from DerivedSources/WebKit/WebPageProxyMessageReceiver.cpp:25: DerivedSources/ForwardingHeaders/wtf/StdLibExtras.h: In instantiation of ‘constexpr size_t WTF::roundUpToMultipleOf(size_t) [with unsigned int divisor = 48; size_t = unsigned int]’: ../Source/WebKit/Platform/IPC/StreamConnectionBuffer.h:117:96: required from here DerivedSources/ForwardingHeaders/wtf/StdLibExtras.h:187:27: error: static assertion failed: divisor must be a power of two! 187 | static_assert(divisor && !(divisor & (divisor - 1)), "divisor must be a power of two!"); | ~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~ As you can see 'divisor' is 48, I suspect that the problem is in sizeof(Header) due to the differences in size_t between 32-bit and 64-bit platforms: https://trac.webkit.org/browser/webkit/trunk/Source/WebKit/Platform/IPC/StreamConnectionBuffer.h?rev=273204#L117 1733820 1 berto 2021-02-26 09:45:05 -0800 This was added in r273204. 1733847 2 kkinnunen 2021-02-26 10:12:21 -0800 Thanks! It's a typo: - roundUpToMultipleOf<sizeof(std::max_align_t)> + roundUpToMultipleOf<alignof(std::max_align_t)> 1733849 3 kkinnunen 2021-02-26 10:13:27 -0800 I can fix it on coming Monday the latest, if nobody gets around fixing it before. 1733942 4 421699 berto 2021-02-26 12:44:11 -0800 Created attachment 421699 Patch Here is the patch, thanks! 1734345 5 421699 kkinnunen 2021-03-01 00:59:51 -0800 Comment on attachment 421699 Patch Thanks, looks good. 1734349 6 berto 2021-03-01 01:44:08 -0800 Committed r273643: <https://commits.webkit.org/r273643> 421699 2021-02-26 12:44:11 -0800 2021-03-01 01:36:01 -0800 Patch patch-222480.diff text/plain 1433 berto ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggZTdmZWVkMjkxNjQ3Li43MDhkNWRiYWJlMmYgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTMgQEAKKzIwMjEtMDItMjYgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlhLmNvbT4K KworICAgICAgICBbR1RLXSBGYWlscyB0byBidWlsZCBpbiBpMzg2OiBzdGF0aWMgYXNzZXJ0aW9u IGZhaWxlZDogZGl2aXNvciBtdXN0IGJlIGEgcG93ZXIgb2YgdHdvCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI0ODAKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFBsYXRmb3JtL0lQQy9TdHJlYW1Db25u ZWN0aW9uQnVmZmVyLmg6CisgICAgICAgIChJUEM6OlN0cmVhbUNvbm5lY3Rpb25CdWZmZXI6Omhl YWRlclNpemUpOgorCiAyMDIxLTAyLTI2ICBQZXIgQXJuZSAgPHB2b2xsYW5AYXBwbGUuY29tPgog CiAgICAgICAgIFtDb2NvYV0gU2VuZCBRT1MgcGFyYW1ldGVycyBhcyBwYXJ0IG9mIFdlYiBwcm9j ZXNzIGNyZWF0aW9uIHBhcmFtZXRlcnMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZv cm0vSVBDL1N0cmVhbUNvbm5lY3Rpb25CdWZmZXIuaCBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0v SVBDL1N0cmVhbUNvbm5lY3Rpb25CdWZmZXIuaAppbmRleCA5NmYwYjhkMDQxMzcuLjM5NDYwMGNi YjAxOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9JUEMvU3RyZWFtQ29ubmVj dGlvbkJ1ZmZlci5oCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vSVBDL1N0cmVhbUNvbm5l Y3Rpb25CdWZmZXIuaApAQCAtMTE0LDcgKzExNCw3IEBAIHByaXZhdGU6CiAgICAgICAgIGFsaWdu YXMoc2l6ZW9mKHVpbnQ2NF90WzJdKSkgQXRvbWljPHNpemVfdD4gc2VuZGVyT2Zmc2V0OwogICAg IH07CiAgICAgSGVhZGVyJiBoZWFkZXIoKSBjb25zdCB7IHJldHVybiAqcmVpbnRlcnByZXRfY2Fz dDxIZWFkZXIqPihtX3NoYXJlZE1lbW9yeS0+ZGF0YSgpKTsgfQotICAgIHN0YXRpYyBjb25zdGV4 cHIgc2l6ZV90IGhlYWRlclNpemUoKSB7IHJldHVybiByb3VuZFVwVG9NdWx0aXBsZU9mPHNpemVv ZihzdGQ6Om1heF9hbGlnbl90KT4oc2l6ZW9mKEhlYWRlcikpOyB9CisgICAgc3RhdGljIGNvbnN0 ZXhwciBzaXplX3QgaGVhZGVyU2l6ZSgpIHsgcmV0dXJuIHJvdW5kVXBUb011bHRpcGxlT2Y8YWxp Z25vZihzdGQ6Om1heF9hbGlnbl90KT4oc2l6ZW9mKEhlYWRlcikpOyB9CiAKICAgICBzaXplX3Qg bV9kYXRhU2l6ZSB7IDAgfTsKICAgICBSZWY8V2ViS2l0OjpTaGFyZWRNZW1vcnk+IG1fc2hhcmVk TWVtb3J5Owo=