222471 2021-02-26 06:58:08 -0800 [WPE][GTK] Bogus Response.{status,ok} for successful fetch() requests to a custom URI scheme handler 2021-11-03 01:29:36 -0700 1 1 1 Unclassified WebKit WPE WebKit WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=203273 P2 Normal --- 1 aperez aperez achristensen berto bugs-noreply cgarcia ews-watchlist gustavo oldest_to_newest 1733741 0 aperez 2021-02-26 06:58:08 -0800 Steps to reproduce: 1. Use webkit_web_context_register_uri_scheme(), e.g. "myscheme", make the callback always finish requests with a valid GInputStream (for example, return the "Hello world" string for any requested URI). 2. Load a page that contains this: fetch("myscheme:/someresource", {mode: "no-cors"}) .then(response => { console.log("Status:", response.ok, response.status) response.text().then(text => { console.log("Text:", text); }); }) .catch(console.error); Expected outcome ---------------- * The response is considered successful. * The logged output contains: Status: true 200 Text: Hello, world Actual outcome -------------- * The response is NOT considered successful, yet the * The logged output contains: Status: false 0 Text: Hello, world 1733743 1 aperez 2021-02-26 07:00:23 -0800 This is somewhat related to bug #203273 but much, much smaller in scope, and I think setting the status to “200 OK” when an URI scheme request is finished with a valid “GInputStreams” should not be controversial, so let's tackle this small annoyance first. 1733776 2 421653 aperez 2021-02-26 08:45:48 -0800 Created attachment 421653 Patch 1733777 3 ews-watchlist 2021-02-26 08:47:00 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1734151 4 ews-feeder 2021-02-26 23:24:35 -0800 Committed r273618: <https://commits.webkit.org/r273618> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421653. 1811145 5 421653 achristensen 2021-11-02 09:12:22 -0700 Comment on attachment 421653 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421653&action=review > Source/WebKit/ChangeLog:8 > + No new tests needed. This should be easy to add a unit test for, especially if you care about not regressing this functionality in the future. 1811412 6 cgarcia 2021-11-03 01:29:36 -0700 We have recently added api to set the response, including api tests for checking the status and message. 421653 2021-02-26 08:45:48 -0800 2021-02-26 23:24:36 -0800 Patch bug-222471-20210226184547.patch text/plain 1975 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjczNTU4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDc2ZDI3MTVkOTFiYmE3MWI3 N2RmNDdkN2U1YWYyZDQxMmFkMzJlZTAuLmI1MDAyZWYzZmQ4M2U4YmUwNzY3Y2NmYTk4NWIxMTc1 N2RjM2I0NjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDItMjYgIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXVtHVEtd IEJvZ3VzIFJlc3BvbnNlLntzdGF0dXMsb2t9IGZvciBzdWNjZXNzZnVsIGZldGNoKCkgcmVxdWVz dHMgdG8gYSBjdXN0b20gVVJJIHNjaGVtZSBoYW5kbGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI0NzEKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMgbmVlZGVkLgorCisgICAgICAg ICogVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFVSSVNjaGVtZVJlcXVlc3QuY3BwOgorICAgICAg ICAod2Via2l0VVJJU2NoZW1lUmVxdWVzdFJlYWRDYWxsYmFjayk6IE1hcmsgcmVzcG9uc2UgYXMg aGF2aW5nIHN0YXR1cyAiMjAwIE9LIiB3aGVuCisgICAgICAgIHdlYmtpdF91cmlfc2NoZW1lX3Jl cXVlc3RfZmluaXNoKCkgZ2V0cyBwYXNzZWQgYSBHSW5wdXRTdHJlYW0uCisKIDIwMjEtMDItMjYg IFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgUkVHUkVT U0lPTiAocjI2OTgyNCk6IG1hY0NhdGFseXN0IFdLV2ViVmlldyBzaG93cyBjaHVua3Mgb2Ygb3Ro ZXIgdGlsZXMgaW4gdGhlIG1pZGRsZSBvZiBjb250ZW50CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi S2l0L1VJUHJvY2Vzcy9BUEkvZ2xpYi9XZWJLaXRVUklTY2hlbWVSZXF1ZXN0LmNwcCBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFVSSVNjaGVtZVJlcXVlc3QuY3BwCmlu ZGV4IDY3ZWM4MjNjMjZhMzdiNTRlMjFlOWUxMjE5ZjVlYWI4OGNkZWVhMjcuLjZhMGQ1OWMxMDI4 OWUxYjgwY2EyYTE1NWU0NmU3ZGQ5ODlmNWU5ZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQv VUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFVSSVNjaGVtZVJlcXVlc3QuY3BwCisrKyBiL1NvdXJj ZS9XZWJLaXQvVUlQcm9jZXNzL0FQSS9nbGliL1dlYktpdFVSSVNjaGVtZVJlcXVlc3QuY3BwCkBA IC0xODAsNiArMTgwLDggQEAgc3RhdGljIHZvaWQgd2Via2l0VVJJU2NoZW1lUmVxdWVzdFJlYWRD YWxsYmFjayhHSW5wdXRTdHJlYW0qIGlucHV0U3RyZWFtLCBHQXN5bmMKICAgICBpZiAoIXByaXYt PmJ5dGVzUmVhZCkgewogICAgICAgICBSZXNvdXJjZVJlc3BvbnNlIHJlc3BvbnNlKHByaXYtPnRh c2stPnJlcXVlc3QoKS51cmwoKSwgZXh0cmFjdE1JTUVUeXBlRnJvbU1lZGlhVHlwZShwcml2LT5j b250ZW50VHlwZS5kYXRhKCkpLCBwcml2LT5zdHJlYW1MZW5ndGgsIGVtcHR5U3RyaW5nKCkpOwog ICAgICAgICByZXNwb25zZS5zZXRUZXh0RW5jb2RpbmdOYW1lKGV4dHJhY3RDaGFyc2V0RnJvbU1l ZGlhVHlwZShwcml2LT5jb250ZW50VHlwZS5kYXRhKCkpKTsKKyAgICAgICAgcmVzcG9uc2Uuc2V0 SFRUUFN0YXR1c0NvZGUoMjAwKTsKKyAgICAgICAgcmVzcG9uc2Uuc2V0SFRUUFN0YXR1c1RleHQo Ik9LIl9zKTsKICAgICAgICAgaWYgKHJlc3BvbnNlLm1pbWVUeXBlKCkuaXNFbXB0eSgpKQogICAg ICAgICAgICAgcmVzcG9uc2Uuc2V0TWltZVR5cGUoTUlNRVR5cGVSZWdpc3RyeTo6bWltZVR5cGVG b3JQYXRoKHJlc3BvbnNlLnVybCgpLnBhdGgoKS50b1N0cmluZygpKSk7CiAgICAgICAgIHByaXYt PnRhc2stPmRpZFJlY2VpdmVSZXNwb25zZShyZXNwb25zZSk7Cg==