222467 2021-02-26 05:06:58 -0800 Fix clang compilation error in PlatformXR::ViewData initialization 2021-04-19 03:21:57 -0700 1 1 1 Unclassified WebKit WebXR WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ifernandez ifernandez pnormand webkit-bug-importer oldest_to_newest 1733720 0 ifernandez 2021-02-26 05:06:58 -0800 Compilation can fail if the related C99 extension is not supported. Mixture of designated and non-designated initializers in the same initializer list is a C99 extension [-Wc99-designator] ../../Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:218:24: warning: mixture of designated and non-designated initializers in the same initializer list is a C99 extension [-Wc99-designator] views.append({ .active = true, Eye::Right }); ^~~~~~~~~~~~~~ ../../Source/WebCore/platform/xr/openxr/PlatformXROpenXR.cpp:218:40: note: first non-designated initializer is here views.append({ .active = true, Eye::Right }); ^~~~~~~~~~ 1733723 1 421634 ifernandez 2021-02-26 05:35:55 -0800 Created attachment 421634 Patch 1733724 2 421634 pnormand 2021-02-26 05:37:48 -0800 Comment on attachment 421634 Patch Thanks! 1733727 3 ews-feeder 2021-02-26 06:07:22 -0800 Committed r273553: <https://commits.webkit.org/r273553> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421634. 1733728 4 webkit-bug-importer 2021-02-26 06:08:14 -0800 <rdar://problem/74787878> 421634 2021-02-26 05:35:55 -0800 2021-02-26 06:07:23 -0800 Patch bug-222467-20210226143554.patch text/plain 3563 ifernandez U3VidmVyc2lvbiBSZXZpc2lvbjogMjczNTUxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDUyNDJjMzM4NzgzNjQ5 ZTAzMDhmN2I0NmJmNjQxNTNjOGY2ZWIzNC4uZWVhYTBkN2E3NzFiNjc3NWZkZTZjNzAyYWQ0YmRj ZGJkZTQ3ZDFkNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTAyLTI2ICBJbWFu b2wgRmVybmFuZGV6ICA8aWZlcm5hbmRlekBpZ2FsaWEuY29tPgorCisgICAgICAgIEZpeCBjbGFu ZyBjb21waWxhdGlvbiBlcnJvciBpbiBQbGF0Zm9ybVhSOjpWaWV3RGF0YSBpbml0aWFsaXphdGlv bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyNDY3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWl4dHVy ZSBvZiBkZXNpZ25hdGVkIGFuZCBub24tZGVzaWduYXRlZCBzdHJ1Y3QgaW5pdGlhbGl6ZXJzIGlz IGEgQzk5IGV4dGVuc2lvbi4KKyAgICAgICAgU3dpdGNoIHRvIGRlc2lnbmF0ZWQgaW5pdGlhbGl6 ZXJzIHRvIGF2b2lkIGNvbXBpbGF0aW9uIGVycm9ycyBpbiBjb21waWxlcnMgbm90CisgICAgICAg IHN1cHBvcnRpbmcgdGhlIGV4dGVuc2lvbi4KKworICAgICAgICAqIE1vZHVsZXMvd2VieHIvV2Vi WFJTeXN0ZW0uY3BwOgorICAgICAgICAoV2ViQ29yZTo6V2ViWFJTeXN0ZW06OkR1bW15SW5saW5l RGV2aWNlOjp2aWV3cyBjb25zdCk6CisgICAgICAgICogcGxhdGZvcm0veHIvb3BlbnhyL1BsYXRm b3JtWFJPcGVuWFIuY3BwOgorICAgICAgICAoUGxhdGZvcm1YUjo6T3BlblhSRGV2aWNlOjp2aWV3 cyBjb25zdCk6CisgICAgICAgICogdGVzdGluZy9XZWJGYWtlWFJEZXZpY2UuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6U2ltdWxhdGVkWFJEZXZpY2U6OnZpZXdzIGNvbnN0KToKKwogMjAyMS0wMi0y NiAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHN1cHBv cnQgZm9yIFdlYlJUQyBwcmlvcml0eQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxl cy93ZWJ4ci9XZWJYUlN5c3RlbS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnhyL1dl YlhSU3lzdGVtLmNwcAppbmRleCBhMjZjNjI2NThjMDc1YTYxYTZjYzhmYmZiNzI5YWNiMTVlODk5 YWM4Li5mNmZiYTNkOWE3ODg2MTYwMzVkMzYwOGI2ODdiMjU2Nzg3NjI0MzBhIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnhyL1dlYlhSU3lzdGVtLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9Nb2R1bGVzL3dlYnhyL1dlYlhSU3lzdGVtLmNwcApAQCAtNTMzLDcgKzUzMyw3 IEBAIHZvaWQgV2ViWFJTeXN0ZW06OkR1bW15SW5saW5lRGV2aWNlOjpyZXF1ZXN0RnJhbWUoUGxh dGZvcm1YUjo6RGV2aWNlOjpSZXF1ZXN0RnJhCiAKIFZlY3RvcjxQbGF0Zm9ybVhSOjpEZXZpY2U6 OlZpZXdEYXRhPiBXZWJYUlN5c3RlbTo6RHVtbXlJbmxpbmVEZXZpY2U6OnZpZXdzKFhSU2Vzc2lv bk1vZGUpIGNvbnN0CiB7Ci0gICAgcmV0dXJuIHsgeyAuYWN0aXZlID0gdHJ1ZSwgUGxhdGZvcm1Y Ujo6RXllOjpOb25lIH0gfTsKKyAgICByZXR1cm4geyB7IC5hY3RpdmUgPSB0cnVlLCAuZXllID0g UGxhdGZvcm1YUjo6RXllOjpOb25lIH0gfTsKIH0KIAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS94ci9vcGVueHIvUGxhdGZvcm1YUk9wZW5YUi5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS94ci9vcGVueHIvUGxhdGZvcm1YUk9wZW5YUi5jcHAKaW5kZXggNTMxMmQ4 M2JmMmE3MjgwMjgwZmYxZDYyZWU0NzMwOTYzYjE3NzBlNS4uY2IyNmMzMGI1MzQ5ZTU3NDdkYjc1 MDM0ZWQ4ODIyYzczMjEyM2VlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v eHIvb3BlbnhyL1BsYXRmb3JtWFJPcGVuWFIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL3hyL29wZW54ci9QbGF0Zm9ybVhST3BlblhSLmNwcApAQCAtMjM3LDggKzIzNyw4IEBAIFZl Y3RvcjxEZXZpY2U6OlZpZXdEYXRhPiBPcGVuWFJEZXZpY2U6OnZpZXdzKFNlc3Npb25Nb2RlIG1v ZGUpIGNvbnN0CiAgICAgICAgIHZpZXdzLmFwcGVuZCh7IC5hY3RpdmUgPSB0cnVlLCAuZXllID0g RXllOjpOb25lIH0pOwogICAgIGVsc2UgewogICAgICAgICBBU1NFUlQoY29uZmlndXJhdGlvblR5 cGUgPT0gWFJfVklFV19DT05GSUdVUkFUSU9OX1RZUEVfUFJJTUFSWV9TVEVSRU8pOwotICAgICAg ICB2aWV3cy5hcHBlbmQoeyAuYWN0aXZlID0gdHJ1ZSwgRXllOjpMZWZ0IH0pOwotICAgICAgICB2 aWV3cy5hcHBlbmQoeyAuYWN0aXZlID0gdHJ1ZSwgRXllOjpSaWdodCB9KTsKKyAgICAgICAgdmll d3MuYXBwZW5kKHsgLmFjdGl2ZSA9IHRydWUsIC5leWUgPSBFeWU6OkxlZnQgfSk7CisgICAgICAg IHZpZXdzLmFwcGVuZCh7IC5hY3RpdmUgPSB0cnVlLCAuZXllID0gRXllOjpSaWdodCB9KTsKICAg ICB9CiAgICAgcmV0dXJuIHZpZXdzOwogfQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvdGVz dGluZy9XZWJGYWtlWFJEZXZpY2UuY3BwIGIvU291cmNlL1dlYkNvcmUvdGVzdGluZy9XZWJGYWtl WFJEZXZpY2UuY3BwCmluZGV4IGYyZTRlMGY2OWMyOTkwNThiMjk5MDM4NDE5NTVkNThiN2RiYjY0 NTUuLjdlNGE5ZGNjZjMxZDlhYTQzY2M5YmE0ZmM2M2Q1Mzk0YmZmNDU0MjMgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvV2ViRmFrZVhSRGV2aWNlLmNwcAorKysgYi9Tb3VyY2Uv V2ViQ29yZS90ZXN0aW5nL1dlYkZha2VYUkRldmljZS5jcHAKQEAgLTEyNSw5ICsxMjUsOSBAQCB2 b2lkIFNpbXVsYXRlZFhSRGV2aWNlOjpyZXF1ZXN0RnJhbWUoUmVxdWVzdEZyYW1lQ2FsbGJhY2sm JiBjYWxsYmFjaykKIFZlY3RvcjxQbGF0Zm9ybVhSOjpEZXZpY2U6OlZpZXdEYXRhPiBTaW11bGF0 ZWRYUkRldmljZTo6dmlld3MoUGxhdGZvcm1YUjo6U2Vzc2lvbk1vZGUgbW9kZSkgY29uc3QKIHsK ICAgICBpZiAobW9kZSA9PSBQbGF0Zm9ybVhSOjpTZXNzaW9uTW9kZTo6SW1tZXJzaXZlVnIpCi0g ICAgICAgIHJldHVybiB7IHsgLmFjdGl2ZSA9IHRydWUsIFBsYXRmb3JtWFI6OkV5ZTo6TGVmdCB9 LCB7IC5hY3RpdmUgPSB0cnVlLCBQbGF0Zm9ybVhSOjpFeWU6OlJpZ2h0IH0gfTsKKyAgICAgICAg cmV0dXJuIHsgeyAuYWN0aXZlID0gdHJ1ZSwgLmV5ZSA9IFBsYXRmb3JtWFI6OkV5ZTo6TGVmdCB9 LCB7IC5hY3RpdmUgPSB0cnVlLCAuZXllID0gUGxhdGZvcm1YUjo6RXllOjpSaWdodCB9IH07CiAK LSAgICByZXR1cm4geyB7IC5hY3RpdmUgPSB0cnVlLCBQbGF0Zm9ybVhSOjpFeWU6Ok5vbmUgfSB9 OworICAgIHJldHVybiB7IHsgLmFjdGl2ZSA9IHRydWUsIC5leWUgPSBQbGF0Zm9ybVhSOjpFeWU6 Ok5vbmUgfSB9OwogfQogCiB2b2lkIFNpbXVsYXRlZFhSRGV2aWNlOjpzY2hlZHVsZU9uTmV4dEZy YW1lKEZ1bmN0aW9uPHZvaWQoKT4mJiBmdW5jKQo=