222465 2021-02-26 02:14:12 -0800 Allow access to more cmio services from Web/GPU processes 2021-03-08 23:19:31 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf bfulgham eric.carlson jonlee mazander pvollan webkit-bug-importer youennf oldest_to_newest 1733703 0 youennf 2021-02-26 02:14:12 -0800 Allow access to more cmio services from Web/GPU processes 1733704 1 webkit-bug-importer 2021-02-26 02:16:04 -0800 <rdar://problem/74783208> 1733705 2 youennf 2021-02-26 02:16:16 -0800 <rdar://problem/74782404> 1733706 3 421626 youennf 2021-02-26 02:17:12 -0800 Created attachment 421626 Patch 1733792 4 ews-feeder 2021-02-26 09:20:13 -0800 mazander@apple.com does not have committer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/Tools/Scripts/webkitpy/common/config/contributors.json. Rejecting attachment 421626 from commit queue. 1733793 5 421626 youennf 2021-02-26 09:20:20 -0800 Comment on attachment 421626 Patch Let's wait for PerArne to validate this. 1733795 6 421626 pvollan 2021-02-26 09:22:19 -0800 Comment on attachment 421626 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421626&action=review R=me. > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1401 > + (global-name "com.apple.cmio.registerassistantservice") Are these needed in the WebContent process when they are present in the GPU process' sandbox? 1733797 7 youennf 2021-02-26 09:23:32 -0800 (In reply to Per Arne Vollan from comment #6) > Comment on attachment 421626 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=421626&action=review > > R=me. > > > Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1401 > > + (global-name "com.apple.cmio.registerassistantservice") > > Are these needed in the WebContent process when they are present in the GPU > process' sandbox? They are only needed in WebContent process when capturing in WebProcess. 1733815 8 421626 pvollan 2021-02-26 09:41:05 -0800 Comment on attachment 421626 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421626&action=review >>> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1401 >>> + (global-name "com.apple.cmio.registerassistantservice") >> >> Are these needed in the WebContent process when they are present in the GPU process' sandbox? > > They are only needed in WebContent process when capturing in WebProcess. Are they currently strictly needed in WebProcess, or can we rely on capturing being done in GPU process going forward? 1737477 9 youennf 2021-03-08 23:14:10 -0800 (In reply to Per Arne Vollan from comment #8) > Comment on attachment 421626 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=421626&action=review > > >>> Source/WebKit/WebProcess/com.apple.WebProcess.sb.in:1401 > >>> + (global-name "com.apple.cmio.registerassistantservice") > >> > >> Are these needed in the WebContent process when they are present in the GPU process' sandbox? > > > > They are only needed in WebContent process when capturing in WebProcess. > > Are they currently strictly needed in WebProcess, or can we rely on > capturing being done in GPU process going forward? The idea is indeed to do capture in GPUProcess going forward. These services are allowed with a camera sandbox extension. We should not send it to WebProcess it if capturing happens in GPUProcess. 1737479 10 ews-feeder 2021-03-08 23:19:29 -0800 Committed r274138: <https://commits.webkit.org/r274138> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421626. 421626 2021-02-26 02:17:12 -0800 2021-03-08 23:19:30 -0800 Patch bug-222465-20210226111710.patch text/plain 2466 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjczNDgwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGI5ZTBjNDQzZWUwMDJiZGRm YzkxZGYxZmM0MmQ4NjgwMDI3ZjBjMWEuLmU1MTYwYWYyMTg1MjI4YmQwNzk5YTkxNDkwNjU1MjRh NzE2M2U3MjAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDItMjYgIFlvdWVubiBG YWJsZXQgIDx5b3Vlbm5AYXBwbGUuY29tPgorCisgICAgICAgIEFsbG93IGFjY2VzcyB0byBtb3Jl IGNtaW8gc2VydmljZXMgZnJvbSBXZWIvR1BVIHByb2Nlc3NlcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyNDY1CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlc2UgbmV3IHNlcnZpY2VzIGFyZSB1c2Vk IHdoZW4gZ2V0dGluZyBjYW1lcmEgYWNjZXNzLgorICAgICAgICBNYW51YWxseSB0ZXN0ZWQuCisK KyAgICAgICAgKiBHUFVQcm9jZXNzL21hYy9jb20uYXBwbGUuV2ViS2l0LkdQVVByb2Nlc3Muc2Iu aW46CisgICAgICAgICogV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJvY2Vzcy5zYi5pbjoKKwog MjAyMS0wMi0yNCAgUGVuZyBMaXUgIDxwZW5nLmxpdTZAYXBwbGUuY29tPgogCiAgICAgICAgIFtH UFVQXSBVc2UgYSBXZWFrUHRyIG9mIEdQVUNvbm5lY3Rpb25Ub1dlYlByb2Nlc3MgaW5zdGVhZCBv ZiBhIHJlZmVyZW5jZSBpbiBzb21lIG1lZGlhIHJlbGF0ZWQgb2JqZWN0cwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdC9HUFVQcm9jZXNzL21hYy9jb20uYXBwbGUuV2ViS2l0LkdQVVByb2Nlc3Mu c2IuaW4gYi9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuR1BV UHJvY2Vzcy5zYi5pbgppbmRleCBiNjQ1ZDI5YjcwNGQwZGIxYzlhNjBkYmMwZTUyMWI1MzMxOTEz MGMyLi43ZTViYjhmNjUwNDQ4ZmYyNmJhYzFhNGQwOGI2ZjcwNmFmNTUxYzhjIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJLaXQuR1BVUHJvY2Vz cy5zYi5pbgorKysgYi9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3MvbWFjL2NvbS5hcHBsZS5XZWJL aXQuR1BVUHJvY2Vzcy5zYi5pbgpAQCAtODc2LDYgKzg3Niw4IEBACiAgICAgKGFsbG93IG1hY2gt bG9va3VwIChleHRlbnNpb24gImNvbS5hcHBsZS5hcHAtc2FuZGJveC5tYWNoIikpCiAgICAgKGFs bG93IG1hY2gtbG9va3VwCiAgICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmNtaW8uQXBw bGVDYW1lcmFBc3Npc3RhbnQiKQorICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5jbWlv LnJlZ2lzdGVyYXNzaXN0YW50c2VydmljZSIpCisgICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFw cGxlLmNtaW8ucmVnaXN0ZXJhc3Npc3RhbnRzZXJ2aWNlLnN5c3RlbS1leHRlbnNpb25zIikKICAg ICAgICAgOzsgQXBwbGUgREFMIGFzc2lzdGFudHMKICAgICAgICAgKGdsb2JhbC1uYW1lICJjb20u YXBwbGUuY21pby5WRENBc3Npc3RhbnQiKQogICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBs ZS5jbWlvLkFWQ0Fzc2lzdGFudCIpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nl c3MvY29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4gYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv Y29tLmFwcGxlLldlYlByb2Nlc3Muc2IuaW4KaW5kZXggZWM3Yzk5Y2JmMTQyMTQ5OWZlOGY1N2Y4 MzA4NjY0YTk1NzkwODI5NC4uNjBhNmE4NjhmMmJmMjcyM2I5MzJhNjEwMWUyOTNiYTE0ZGQ2Nzg5 OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL2NvbS5hcHBsZS5XZWJQcm9j ZXNzLnNiLmluCisrKyBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9jb20uYXBwbGUuV2ViUHJv Y2Vzcy5zYi5pbgpAQCAtMTM5OCw2ICsxMzk4LDggQEAKICAgICAoYWxsb3cgbWFjaC1sb29rdXAg KGV4dGVuc2lvbiAiY29tLmFwcGxlLmFwcC1zYW5kYm94Lm1hY2giKSkKICAgICAoYWxsb3cgbWFj aC1sb29rdXAKICAgICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuY21pby5BcHBsZUNhbWVy YUFzc2lzdGFudCIpCisgICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmNtaW8ucmVnaXN0 ZXJhc3Npc3RhbnRzZXJ2aWNlIikKKyAgICAgICAgKGdsb2JhbC1uYW1lICJjb20uYXBwbGUuY21p by5yZWdpc3RlcmFzc2lzdGFudHNlcnZpY2Uuc3lzdGVtLWV4dGVuc2lvbnMiKQogICAgICAgICA7 OyBBcHBsZSBEQUwgYXNzaXN0YW50cwogICAgICAgICAoZ2xvYmFsLW5hbWUgImNvbS5hcHBsZS5j bWlvLlZEQ0Fzc2lzdGFudCIpCiAgICAgICAgIChnbG9iYWwtbmFtZSAiY29tLmFwcGxlLmNtaW8u QVZDQXNzaXN0YW50IikK