222413 2021-02-25 04:48:04 -0800 [GTK][WPE] Bump libsoup3 version to 2.99.1 2021-02-26 01:39:43 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk P2 Normal --- 220508 1 cgarcia webkit-unassigned annulen aperez benjamin berto bugs-noreply cdumez cmarcelo ews-watchlist gustavo gyuyoung.kim ryuan.choi sergio oldest_to_newest 1733288 0 cgarcia 2021-02-25 04:48:04 -0800 . 1733289 1 421515 cgarcia 2021-02-25 04:50:12 -0800 Created attachment 421515 Patch 1733697 2 421515 aperez 2021-02-26 01:33:05 -0800 Comment on attachment 421515 Patch LGTM with a nit and a comment :) View in context: https://bugs.webkit.org/attachment.cgi?id=421515&action=review > Source/WebCore/ChangeLog:8 > + Use new session getters and setters instead og g_object_get/set. Typo: og → of > Source/WebCore/platform/network/soup/SoupNetworkSession.cpp:113 > + m_soupSession = adoptGRef(soup_session_new_with_options( I guess the idea to move the initialization of “m_soupSession” here was because now it's longer but I don't see any other reason to not keep using the constructor initializer list syntax (and also not needing to move the “maxConnections” and “maxConnectionsPerHost” constants, I guess?) In this case it's not much of an issue because a GRefPtr<> is cheap to construct with the default value, then assign to it inside the constructor body, so feel free to land as-is =) 1733698 3 cgarcia 2021-02-26 01:39:43 -0800 Committed r273545 (234608@main): <https://commits.webkit.org/234608@main> 421515 2021-02-25 04:50:12 -0800 2021-02-26 01:33:05 -0800 Patch wk2-soup3.diff text/plain 7076 cgarcia ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCAzM2E0MzRjOTc4NTUuLmM0 YThiZGE1NmI1ZSAxMDA2NDQKLS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwz ICsxLDEzIEBACisyMDIxLTAyLTI1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdh bGlhLmNvbT4KKworICAgICAgICBbR1RLXVtXUEVdIEJ1bXAgbGlic291cDMgdmVyc2lvbiB0byAy Ljk5LjEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIy MjQxMworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog U291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2U6CisgICAgICAgICogU291cmNlL2NtYWtlL09w dGlvbnNXUEUuY21ha2U6CisKIDIwMjEtMDItMjQgIENhbWVyb24gTWNDb3JtYWNrICA8aGV5Y2Ft QGFwcGxlLmNvbT4KIAogICAgICAgICBGaXggdHlwbyBpbiBJbnRyb2R1Y3Rpb24ubWQuCmRpZmYg LS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4 IGY1ZDJlYzE3MjM2YS4uYWNhMjVhNjNhMjhjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIxLTAy LTI1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAg ICBbR1RLXVtXUEVdIEJ1bXAgbGlic291cDMgdmVyc2lvbiB0byAyLjk5LjEKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjQxMworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6IFNl dCBtaW5pbXVtIHJlcXVpcmVkIHZlcnNpb24gdG8gMi45OQorCiAyMDIxLTAyLTI0ICBTYW0gV2Vp bmlnICA8d2VpbmlnQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgcGxhdGZvcm0gZW5hYmxlIGZv ciBzZXBhcmF0ZWQgbW9kZWwgaW52ZXN0aWdhdGlvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93 dGYvUGxhdGZvcm0uaCBiL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgKaW5kZXggNDFhZGQwYzUz NDhiLi5kNjNiNGRhY2IzZTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1BsYXRmb3JtLmgK KysrIGIvU291cmNlL1dURi93dGYvUGxhdGZvcm0uaApAQCAtOTksNyArOTksNyBAQAogI2lmIFVT RShTT1VQMikKICNkZWZpbmUgU09VUF9WRVJTSU9OX01JTl9SRVFVSVJFRCBTT1VQX1ZFUlNJT05f Ml81NAogI2Vsc2UKLSNkZWZpbmUgU09VUF9WRVJTSU9OX01JTl9SRVFVSVJFRCBTT1VQX1ZFUlNJ T05fMl85MAorI2RlZmluZSBTT1VQX1ZFUlNJT05fTUlOX1JFUVVJUkVEIFNPVVBfVkVSU0lPTl8y Xzk5CiAjZW5kaWYKICNlbmRpZgogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VM b2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTM3MDAwZTZhMTc2Li5hYjVlN2Ew MWFiNzAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9Tb3VyY2Uv V2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyMSBAQAorMjAyMS0wMi0yNSAgQ2FybG9zIEdh cmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bV1BFXSBC dW1wIGxpYnNvdXAzIHZlcnNpb24gdG8gMi45OS4xCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjI0MTMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBVc2UgbmV3IHNlc3Npb24gZ2V0dGVycyBhbmQgc2V0dGVy cyBpbnN0ZWFkIG9nIGdfb2JqZWN0X2dldC9zZXQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3 b3JrL3NvdXAvU291cE5ldHdvcmtTZXNzaW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlNvdXBO ZXR3b3JrU2Vzc2lvbjo6U291cE5ldHdvcmtTZXNzaW9uKToKKyAgICAgICAgKFdlYkNvcmU6OlNv dXBOZXR3b3JrU2Vzc2lvbjo6c2V0UHJveHlTZXR0aW5ncyk6CisgICAgICAgIChXZWJDb3JlOjpT b3VwTmV0d29ya1Nlc3Npb246OnNldEFjY2VwdExhbmd1YWdlcyk6CisgICAgICAgICogcGxhdGZv cm0vbmV0d29yay9zb3VwL1NvdXBWZXJzaW9uaW5nLmg6CisgICAgICAgIChzb3VwX3Nlc3Npb25f c2V0X3Byb3h5X3Jlc29sdmVyKToKKyAgICAgICAgKHNvdXBfc2Vzc2lvbl9nZXRfcHJveHlfcmVz b2x2ZXIpOgorICAgICAgICAoc291cF9zZXNzaW9uX3NldF9hY2NlcHRfbGFuZ3VhZ2UpOgorCiAy MDIxLTAyLTI1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAog ICAgICAgICBQYWdpbmF0aW9uIG1vZGU6IEluY3JlYXNlIHRoZSBhbW91bnQgb2YgcmVjdXJzaW9u cyBhbGxvd2VkIGJ5IFJlbmRlclRhYmxlOjpsYXlvdXQoKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1NvdXBOZXR3b3JrU2Vzc2lvbi5jcHAgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvU291cE5ldHdvcmtTZXNzaW9uLmNwcApp bmRleCA2ZGE3YjQwMzY4MDUuLjkwNzM3ZDAxNmQ1OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1NvdXBOZXR3b3JrU2Vzc2lvbi5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1NvdXBOZXR3b3JrU2Vzc2lvbi5jcHAK QEAgLTEwMSw4ICsxMDEsNyBAQCBzdGF0aWMgQWxsb3dlZENlcnRpZmljYXRlc01hcCYgYWxsb3dl ZENlcnRpZmljYXRlcygpCiB9CiAKIFNvdXBOZXR3b3JrU2Vzc2lvbjo6U291cE5ldHdvcmtTZXNz aW9uKFBBTDo6U2Vzc2lvbklEIHNlc3Npb25JRCkKLSAgICA6IG1fc291cFNlc3Npb24oYWRvcHRH UmVmKHNvdXBfc2Vzc2lvbl9uZXcoKSkpCi0gICAgLCBtX3Nlc3Npb25JRChzZXNzaW9uSUQpCisg ICAgOiBtX3Nlc3Npb25JRChzZXNzaW9uSUQpCiB7CiAgICAgLy8gVmFsdWVzIHRha2VuIGZyb20g aHR0cDovL3d3dy5icm93c2Vyc2NvcGUub3JnLyBmb2xsb3dpbmcKICAgICAvLyB0aGUgcnVsZSAi RG8gV2hhdCBFdmVyeSBPdGhlciBNb2Rlcm4gQnJvd3NlciBJcyBEb2luZyIuIFRoZXkgc2VlbQpA QCAtMTExLDEyICsxMTAsMTIgQEAgU291cE5ldHdvcmtTZXNzaW9uOjpTb3VwTmV0d29ya1Nlc3Np b24oUEFMOjpTZXNzaW9uSUQgc2Vzc2lvbklEKQogICAgIHN0YXRpYyBjb25zdCBpbnQgbWF4Q29u bmVjdGlvbnMgPSAxNzsKICAgICBzdGF0aWMgY29uc3QgaW50IG1heENvbm5lY3Rpb25zUGVySG9z dCA9IDY7CiAKLSAgICBnX29iamVjdF9zZXQobV9zb3VwU2Vzc2lvbi5nZXQoKSwKKyAgICBtX3Nv dXBTZXNzaW9uID0gYWRvcHRHUmVmKHNvdXBfc2Vzc2lvbl9uZXdfd2l0aF9vcHRpb25zKAogICAg ICAgICAibWF4LWNvbm5zIiwgbWF4Q29ubmVjdGlvbnMsCiAgICAgICAgICJtYXgtY29ubnMtcGVy LWhvc3QiLCBtYXhDb25uZWN0aW9uc1Blckhvc3QsCiAgICAgICAgICJ0aW1lb3V0IiwgMCwKICAg ICAgICAgImlkbGUtdGltZW91dCIsIDAsCi0gICAgICAgIG51bGxwdHIpOworICAgICAgICBudWxs cHRyKSk7CiAKICAgICBzb3VwX3Nlc3Npb25fYWRkX2ZlYXR1cmVfYnlfdHlwZShtX3NvdXBTZXNz aW9uLmdldCgpLCBTT1VQX1RZUEVfQ09OVEVOVF9TTklGRkVSKTsKICAgICBzb3VwX3Nlc3Npb25f YWRkX2ZlYXR1cmVfYnlfdHlwZShtX3NvdXBTZXNzaW9uLmdldCgpLCBTT1VQX1RZUEVfQVVUSF9O VExNKTsKQEAgLTI4MSwxMCArMjgwLDggQEAgdm9pZCBTb3VwTmV0d29ya1Nlc3Npb246OnNldFBy b3h5U2V0dGluZ3MoU291cE5ldHdvcmtQcm94eVNldHRpbmdzJiYgc2V0dGluZ3MpCiAgICAgR1Jl ZlB0cjxHUHJveHlSZXNvbHZlcj4gcmVzb2x2ZXI7CiAgICAgc3dpdGNoIChtX3Byb3h5U2V0dGlu Z3MubW9kZSkgewogICAgIGNhc2UgU291cE5ldHdvcmtQcm94eVNldHRpbmdzOjpNb2RlOjpEZWZh dWx0OiB7Ci0gICAgICAgIEdSZWZQdHI8R1Byb3h5UmVzb2x2ZXI+IGN1cnJlbnRSZXNvbHZlcjsK LSAgICAgICAgZ19vYmplY3RfZ2V0KG1fc291cFNlc3Npb24uZ2V0KCksICJwcm94eS1yZXNvbHZl ciIsICZjdXJyZW50UmVzb2x2ZXIub3V0UHRyKCksIG51bGxwdHIpOwogICAgICAgICBHUHJveHlS ZXNvbHZlciogZGVmYXVsdFJlc29sdmVyID0gZ19wcm94eV9yZXNvbHZlcl9nZXRfZGVmYXVsdCgp OwotICAgICAgICBpZiAoY3VycmVudFJlc29sdmVyLmdldCgpID09IGRlZmF1bHRSZXNvbHZlcikK KyAgICAgICAgaWYgKGRlZmF1bHRSZXNvbHZlciA9PSBzb3VwX3Nlc3Npb25fZ2V0X3Byb3h5X3Jl c29sdmVyKG1fc291cFNlc3Npb24uZ2V0KCkpKQogICAgICAgICAgICAgcmV0dXJuOwogICAgICAg ICByZXNvbHZlciA9IGRlZmF1bHRSZXNvbHZlcjsKICAgICAgICAgYnJlYWs7CkBAIC0zMDMsNyAr MzAwLDcgQEAgdm9pZCBTb3VwTmV0d29ya1Nlc3Npb246OnNldFByb3h5U2V0dGluZ3MoU291cE5l dHdvcmtQcm94eVNldHRpbmdzJiYgc2V0dGluZ3MpCiAgICAgICAgIGJyZWFrOwogICAgIH0KIAot ICAgIGdfb2JqZWN0X3NldChtX3NvdXBTZXNzaW9uLmdldCgpLCAicHJveHktcmVzb2x2ZXIiLCBy ZXNvbHZlci5nZXQoKSwgbnVsbHB0cik7CisgICAgc291cF9zZXNzaW9uX3NldF9wcm94eV9yZXNv bHZlcihtX3NvdXBTZXNzaW9uLmdldCgpLCByZXNvbHZlci5nZXQoKSk7CiAgICAgc291cF9zZXNz aW9uX2Fib3J0KG1fc291cFNlc3Npb24uZ2V0KCkpOwogfQogCkBAIC0zMTQsNyArMzExLDcgQEAg dm9pZCBTb3VwTmV0d29ya1Nlc3Npb246OnNldEluaXRpYWxBY2NlcHRMYW5ndWFnZXMoY29uc3Qg Q1N0cmluZyYgbGFuZ3VhZ2VzKQogCiB2b2lkIFNvdXBOZXR3b3JrU2Vzc2lvbjo6c2V0QWNjZXB0 TGFuZ3VhZ2VzKGNvbnN0IENTdHJpbmcmIGxhbmd1YWdlcykKIHsKLSAgICBnX29iamVjdF9zZXQo bV9zb3VwU2Vzc2lvbi5nZXQoKSwgImFjY2VwdC1sYW5ndWFnZSIsIGxhbmd1YWdlcy5kYXRhKCks IG51bGxwdHIpOworICAgIHNvdXBfc2Vzc2lvbl9zZXRfYWNjZXB0X2xhbmd1YWdlKG1fc291cFNl c3Npb24uZ2V0KCksIGxhbmd1YWdlcy5kYXRhKCkpOwogfQogCiB2b2lkIFNvdXBOZXR3b3JrU2Vz c2lvbjo6c2V0SWdub3JlVExTRXJyb3JzKGJvb2wgaWdub3JlVExTRXJyb3JzKQpkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1NvdXBWZXJzaW9uaW5nLmgg Yi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL3NvdXAvU291cFZlcnNpb25pbmcuaApp bmRleCBlZTA3MWVkOWRiY2UuLmRlYTA2NmI5NGQ4MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1NvdXBWZXJzaW9uaW5nLmgKKysrIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vbmV0d29yay9zb3VwL1NvdXBWZXJzaW9uaW5nLmgKQEAgLTEzOCw0ICsx MzgsMjQgQEAgc3RhdGljIGlubGluZSB2b2lkCiBzb3VwX2F1dGhfY2FuY2VsKFNvdXBBdXRoKikK IHsKIH0KKworc3RhdGljIGlubGluZSB2b2lkCitzb3VwX3Nlc3Npb25fc2V0X3Byb3h5X3Jlc29s dmVyKFNvdXBTZXNzaW9uKiBzZXNzaW9uLCBHUHJveHlSZXNvbHZlciogcmVzb2x2ZXIpCit7Cisg ICAgZ19vYmplY3Rfc2V0KHNlc3Npb24sICJwcm94eS1yZXNvbHZlciIsIHJlc29sdmVyLCBudWxs cHRyKTsKK30KKworc3RhdGljIGlubGluZSBHUHJveHlSZXNvbHZlcioKK3NvdXBfc2Vzc2lvbl9n ZXRfcHJveHlfcmVzb2x2ZXIoU291cFNlc3Npb24qIHNlc3Npb24pCit7CisgICAgR1JlZlB0cjxH UHJveHlSZXNvbHZlcj4gcmVzb2x2ZXI7CisgICAgZ19vYmplY3RfZ2V0KHNlc3Npb24sICJwcm94 eS1yZXNvbHZlciIsICZyZXNvbHZlci5vdXRQdHIoKSwgbnVsbHB0cik7CisgICAgcmV0dXJuIHJl c29sdmVyLmdldCgpOworfQorCitzdGF0aWMgaW5saW5lIHZvaWQKK3NvdXBfc2Vzc2lvbl9zZXRf YWNjZXB0X2xhbmd1YWdlKFNvdXBTZXNzaW9uKiBzZXNzaW9uLCBjb25zdCBjaGFyKiBhY2NlcHRM YW5ndWFnZSkKK3sKKyAgICBnX29iamVjdF9zZXQoc2Vzc2lvbiwgImFjY2VwdC1sYW5ndWFnZSIs IGFjY2VwdExhbmd1YWdlLCBudWxscHRyKTsKK30KICNlbmRpZiAvLyBVU0UoU09VUDIpCmRpZmYg LS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRp b25zR1RLLmNtYWtlCmluZGV4IGRiMDdhOWY1YmZiYy4uYWE0ZWE3YmMwYTUzIDEwMDY0NAotLS0g YS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9u c0dUSy5jbWFrZQpAQCAtMjAxLDcgKzIwMSw3IEBAIFdFQktJVF9PUFRJT05fRU5EKCkKIGlmIChV U0VfU09VUDIpCiAgICAgc2V0KFNPVVBfTUlOSU1VTV9WRVJTSU9OIDIuNTQuMCkKIGVsc2UgKCkK LSAgICBzZXQoU09VUF9NSU5JTVVNX1ZFUlNJT04gMi45MS4wKQorICAgIHNldChTT1VQX01JTklN VU1fVkVSU0lPTiAyLjk5LjEpCiBlbmRpZiAoKQogZmluZF9wYWNrYWdlKExpYlNvdXAgJHtTT1VQ X01JTklNVU1fVkVSU0lPTn0gUkVRVUlSRUQpCiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9P cHRpb25zV1BFLmNtYWtlIGIvU291cmNlL2NtYWtlL09wdGlvbnNXUEUuY21ha2UKaW5kZXggMjA4 NjNhMDhmMTY3Li5kZTQwZGU0YWE3YzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25z V1BFLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV1BFLmNtYWtlCkBAIC0xMzAsNyAr MTMwLDcgQEAgV0VCS0lUX09QVElPTl9FTkQoKQogaWYgKFVTRV9TT1VQMikKICAgICBzZXQoU09V UF9NSU5JTVVNX1ZFUlNJT04gMi41NC4wKQogZWxzZSAoKQotICAgIHNldChTT1VQX01JTklNVU1f VkVSU0lPTiAyLjkxLjApCisgICAgc2V0KFNPVVBfTUlOSU1VTV9WRVJTSU9OIDIuOTkuMSkKIGVu ZGlmICgpCiBmaW5kX3BhY2thZ2UoTGliU291cCAke1NPVVBfTUlOSU1VTV9WRVJTSU9OfSBSRVFV SVJFRCkKIAo=