222395 2021-02-24 17:44:04 -0800 Avoid setting page muted state if unchanged 2021-02-25 14:18:55 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham dean_johnson eric.carlson jer.noble simon.fraser webkit-bug-importer oldest_to_newest 1733168 0 pvollan 2021-02-24 17:44:04 -0800 Return early in Page::setMuted if muted state did not change. 1733169 1 421489 pvollan 2021-02-24 17:45:55 -0800 Created attachment 421489 Patch 1733410 2 421489 bfulgham 2021-02-25 10:48:35 -0800 Comment on attachment 421489 Patch Silly we didn't do this before! r=me. 1733437 3 421489 pvollan 2021-02-25 11:51:33 -0800 Comment on attachment 421489 Patch Thanks for reviewing! 1733440 4 ews-feeder 2021-02-25 11:55:21 -0800 Committed r273499: <https://commits.webkit.org/r273499> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421489. 1733441 5 webkit-bug-importer 2021-02-25 11:56:14 -0800 <rdar://problem/74754341> 1733444 6 421489 simon.fraser 2021-02-25 12:01:37 -0800 Comment on attachment 421489 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421489&action=review > Source/WebCore/ChangeLog:8 > + Return early in Page::setMuted if muted state did not change. Why? 1733501 7 pvollan 2021-02-25 14:01:31 -0800 (In reply to Simon Fraser (smfr) from comment #6) > Comment on attachment 421489 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=421489&action=review > > > Source/WebCore/ChangeLog:8 > > + Return early in Page::setMuted if muted state did not change. > > Why? This is to avoid work when creating the Web page in WP, and should be a small speedup. Thanks for reviewing! 1733505 8 simon.fraser 2021-02-25 14:03:25 -0800 (In reply to Per Arne Vollan from comment #7) > (In reply to Simon Fraser (smfr) from comment #6) > > Comment on attachment 421489 [details] > > Patch > > > > View in context: > > https://bugs.webkit.org/attachment.cgi?id=421489&action=review > > > > > Source/WebCore/ChangeLog:8 > > > + Return early in Page::setMuted if muted state did not change. > > > > Why? > > This is to avoid work when creating the Web page in WP, and should be a > small speedup. > > Thanks for reviewing! The changelog should have said that. Is there an associated radar? 1733515 9 pvollan 2021-02-25 14:18:55 -0800 (In reply to Simon Fraser (smfr) from comment #8) > (In reply to Per Arne Vollan from comment #7) > > (In reply to Simon Fraser (smfr) from comment #6) > > > Comment on attachment 421489 [details] > > > Patch > > > > > > View in context: > > > https://bugs.webkit.org/attachment.cgi?id=421489&action=review > > > > > > > Source/WebCore/ChangeLog:8 > > > > + Return early in Page::setMuted if muted state did not change. > > > > > > Why? > > > > This is to avoid work when creating the Web page in WP, and should be a > > small speedup. > > > > Thanks for reviewing! > > The changelog should have said that. Is there an associated radar? Yes, I agree, that change log entry was too short. This is the radar: <rdar://problem/74754341> 421489 2021-02-24 17:45:55 -0800 2021-02-25 11:55:21 -0800 Patch bug-222395-20210224174555.patch text/plain 1203 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3MzQ2NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDIxLTAyLTI0ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBBdm9pZCBzZXR0aW5nIHBh Z2UgbXV0ZWQgc3RhdGUgaWYgdW5jaGFuZ2VkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMjIzOTUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBSZXR1cm4gZWFybHkgaW4gUGFnZTo6c2V0TXV0ZWQgaWYgbXV0 ZWQgc3RhdGUgZGlkIG5vdCBjaGFuZ2UuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBjb3ZlcmVk IGJ5IGV4aXN0aW5nIHRlc3RzLgorCisgICAgICAgICogcGFnZS9QYWdlLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlBhZ2U6OnNldE11dGVkKToKKwogMjAyMS0wMi0yMyAgRGFyaW4gQWRsZXIgIDxk YXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10gUmVkdWNlIHVzZSBvZiByZXRhaW4vcmVs ZWFzZSBpbiBXQUtXaW5kb3cgYW5kIHJlbW92ZSB1bm5lZWRlZCBtZXRob2RzIGZyb20gdGhhdCBj bGFzcwpJbmRleDogU291cmNlL1dlYkNvcmUvcGFnZS9QYWdlLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wYWdlL1BhZ2UuY3BwCShyZXZpc2lvbiAyNzM0MDUpCisrKyBTb3VyY2Uv V2ViQ29yZS9wYWdlL1BhZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yMTA4LDYgKzIxMDgsOSBA QCB2b2lkIFBhZ2U6OnBsYXliYWNrQ29udHJvbHNNZWRpYUVuZ2luZUNoCiAKIHZvaWQgUGFnZTo6 c2V0TXV0ZWQoTWVkaWFQcm9kdWNlcjo6TXV0ZWRTdGF0ZUZsYWdzIG11dGVkKQogeworICAgIGlm IChtX211dGVkU3RhdGUgPT0gbXV0ZWQpCisgICAgICAgIHJldHVybjsKKwogICAgIG1fbXV0ZWRT dGF0ZSA9IG11dGVkOwogCiAgICAgZm9yRWFjaERvY3VtZW50KFtdIChEb2N1bWVudCYgZG9jdW1l bnQpIHsK