<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>22238</bug_id>
          
          <creation_ts>2008-11-13 13:49:32 -0800</creation_ts>
          <short_desc>Avoid unnecessary reads of temporaries when the target machine register is not eax</short_desc>
          <delta_ts>2008-11-19 13:08:35 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>JavaScriptCore</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Cameron Zwarich (cpst)">zwarich</reporter>
          <assigned_to name="Cameron Zwarich (cpst)">zwarich</assigned_to>
          
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>98645</commentid>
    <comment_count>0</comment_count>
    <who name="Cameron Zwarich (cpst)">zwarich</who>
    <bug_when>2008-11-13 13:49:32 -0800</bug_when>
    <thetext>Currently we don&apos;t apply the optimization of not reading a value back from memory that we just wrote when the target machine register is not eax. A few opcodes will read into edx and not read into eax. In these cases we could just do a register-register move.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>98649</commentid>
    <comment_count>1</comment_count>
      <attachid>25134</attachid>
    <who name="Cameron Zwarich (cpst)">zwarich</who>
    <bug_when>2008-11-13 14:04:14 -0800</bug_when>
    <thetext>Created attachment 25134
Proposed patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>98650</commentid>
    <comment_count>2</comment_count>
      <attachid>25134</attachid>
    <who name="Darin Adler">darin</who>
    <bug_when>2008-11-13 14:09:08 -0800</bug_when>
    <thetext>Comment on attachment 25134
Proposed patch

r=me</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>99372</commentid>
    <comment_count>3</comment_count>
    <who name="Cameron Zwarich (cpst)">zwarich</who>
    <bug_when>2008-11-19 13:08:35 -0800</bug_when>
    <thetext>Landed in r38377.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>25134</attachid>
            <date>2008-11-13 14:04:14 -0800</date>
            <delta_ts>2008-11-13 14:09:08 -0800</delta_ts>
            <desc>Proposed patch</desc>
            <filename>edx.diff</filename>
            <type>text/plain</type>
            <size>0</size>
            <attacher name="Cameron Zwarich (cpst)">zwarich</attacher>
            
              <data encoding="base64"></data>
<flag name="review"
          id="11577"
          type_id="1"
          status="+"
          setter="darin"
    />
          </attachment>
      

    </bug>

</bugzilla>