<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>222364</bug_id>
          
          <creation_ts>2021-02-24 09:12:35 -0800</creation_ts>
          <short_desc>Web Inspector: List of grid nodes is incomplete in Layout sidebar panel</short_desc>
          <delta_ts>2021-02-25 12:31:08 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Web Inspector</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Razvan Caliman">rcaliman</reporter>
          <assigned_to name="Razvan Caliman">rcaliman</assigned_to>
          <cc>bburg</cc>
    
    <cc>ews-watchlist</cc>
    
    <cc>hi</cc>
    
    <cc>inspector-bugzilla-changes</cc>
    
    <cc>joepeck</cc>
    
    <cc>keith_miller</cc>
    
    <cc>mark.lam</cc>
    
    <cc>msaboff</cc>
    
    <cc>pangle</cc>
    
    <cc>saam</cc>
    
    <cc>tzagallo</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1732902</commentid>
    <comment_count>0</comment_count>
    <who name="Razvan Caliman">rcaliman</who>
    <bug_when>2021-02-24 09:12:35 -0800</bug_when>
    <thetext>The list of grid nodes is incomplete when opening Web Inspector and the Layout sidebar panel is selected by default.

Steps to reproduce:

- Open Web Inspector and select the Layout sidebar panel of the Elements Tab
- Close Web Inspector 
- Navigate to https://stripe.com
- Open Web Inspector again

Expected result:
 
A long list of grid nodes (100+) in the CSS Grid section of the Layout sidebar panel.

Actual result:

Either no nodes or a short list of nodes matching any grid nodes already expanded in the DOM tree.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1732904</commentid>
    <comment_count>1</comment_count>
    <who name="Razvan Caliman">rcaliman</who>
    <bug_when>2021-02-24 09:16:05 -0800</bug_when>
    <thetext>Workaround: 

Select another sidebar panel (ex: Computed), then select Layout again.
This populates the list with all the grid nodes.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1732915</commentid>
    <comment_count>2</comment_count>
      <attachid>421416</attachid>
    <who name="Razvan Caliman">rcaliman</who>
    <bug_when>2021-02-24 09:35:38 -0800</bug_when>
    <thetext>Created attachment 421416
WIP

quick hack that works</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1732922</commentid>
    <comment_count>3</comment_count>
    <who name="Razvan Caliman">rcaliman</who>
    <bug_when>2021-02-24 09:52:20 -0800</bug_when>
    <thetext>Seems that the backend doesn&apos;t push nodes to the frontend when first setting `WI.cssManager.layoutContextTypeChangedMode = WI.CSSManager.LayoutContextTypeChangedMode.All` in `WI.LayoutDetailsSidebarPanel.attached()`

When that is set, `WI.DOMNode` instances for grid nodes should be created automatically  and `WI.DOMNode.Event.LayoutContextTypeChanged` events should fire (see last line of `WI.DOMNode` constructor). But none do. The workaround of switching between panels unblocks this and events come through as expected.

The only thing that jumps out is that `WI.LayoutDetailsSidebarPanel.detached()` changes the mode to &quot;Observed&quot;. 🤔 

Strangely, toggling the mode in `WI.LayoutDetailsSidebarPanel.attached()` solves the bug:

```diff
+ WI.cssManager.layoutContextTypeChangedMode = WI.CSSManager.LayoutContextTypeChangedMode.Observed;
  WI.cssManager.layoutContextTypeChangedMode = WI.CSSManager.LayoutContextTypeChangedMode.All;
```

See [WIP](https://bugs.webkit.org/attachment.cgi?id=421416)

This is a hack.

@Patrick Angle, is there any reason why nodes wouldn&apos;t get pushed to the frontend when first setting the mode to &quot;All&quot;?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1732935</commentid>
    <comment_count>4</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2021-02-24 10:06:55 -0800</bug_when>
    <thetext>&lt;rdar://problem/74700960&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1732938</commentid>
    <comment_count>5</comment_count>
    <who name="Patrick Angle">pangle</who>
    <bug_when>2021-02-24 10:15:51 -0800</bug_when>
    <thetext>(In reply to Razvan Caliman from comment #3)
&gt; @Patrick Angle, is there any reason why nodes wouldn&apos;t get pushed to the
&gt; frontend when first setting the mode to &quot;All&quot;?

I think I see my mistake. I&apos;m not honoring the current layout state when enabling the `WebCore::InspectorCSSAgent` because the assumption is that it will be in the `Observed` state, but that isn&apos;t the case here because it was already in the `All` state when we enable it. Two solutions here, but I think the better one is to add `m_layoutContextTypeChangedMode = Protocol::CSS::LayoutContextTypeChangedMode::Observed;` to `WebCore::InspectorCSSAgent::reset`. This would be consistent with other properties that get reset when the agent is reset (which also happens when the agent is disabled).</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1733376</commentid>
    <comment_count>6</comment_count>
      <attachid>421538</attachid>
    <who name="Razvan Caliman">rcaliman</who>
    <bug_when>2021-02-25 10:04:04 -0800</bug_when>
    <thetext>Created attachment 421538
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1733377</commentid>
    <comment_count>7</comment_count>
    <who name="EWS Watchlist">ews-watchlist</who>
    <bug_when>2021-02-25 10:04:53 -0800</bug_when>
    <thetext>This patch modifies the inspector protocol. Please ensure that any frontend changes appropriately use feature checks for new protocol features.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1733413</commentid>
    <comment_count>8</comment_count>
      <attachid>421538</attachid>
    <who name="Patrick Angle">pangle</who>
    <bug_when>2021-02-25 10:57:07 -0800</bug_when>
    <thetext>Comment on attachment 421538
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=421538&amp;action=review

&gt; Source/JavaScriptCore/inspector/protocol/CSS.json:266
&gt; +            &quot;description&quot;: &quot;The mode for how layout context type changes are handled (default: observed). &lt;code&gt;Observed&lt;/code&gt; limits handling to those nodes already known to the frontend by other means (generally, this means the node is a visible item in the Elements tab). &lt;code&gt;All&lt;/code&gt; informs the frontend of all layout context type changes and all nodes with a known layout context are sent to the frontend.&quot;

NIT: `(default: &lt;code&gt;Observed&lt;/code&gt;)`</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1733425</commentid>
    <comment_count>9</comment_count>
      <attachid>421548</attachid>
    <who name="Razvan Caliman">rcaliman</who>
    <bug_when>2021-02-25 11:11:25 -0800</bug_when>
    <thetext>Created attachment 421548
Patch

Address nit</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1733435</commentid>
    <comment_count>10</comment_count>
      <attachid>421548</attachid>
    <who name="Devin Rousso">hi</who>
    <bug_when>2021-02-25 11:49:44 -0800</bug_when>
    <thetext>Comment on attachment 421548
Patch

r=me assuming EWS is green :)</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1733452</commentid>
    <comment_count>11</comment_count>
      <attachid>421548</attachid>
    <who name="Blaze Burg">bburg</who>
    <bug_when>2021-02-25 12:24:16 -0800</bug_when>
    <thetext>Comment on attachment 421548
Patch

mac-wk2 passed, setting cq+</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1733461</commentid>
    <comment_count>12</comment_count>
    <who name="EWS">ews-feeder</who>
    <bug_when>2021-02-25 12:31:05 -0800</bug_when>
    <thetext>Committed r273502: &lt;https://commits.webkit.org/r273502&gt;

All reviewed patches have been landed. Closing bug and clearing flags on attachment 421548.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>421416</attachid>
            <date>2021-02-24 09:35:38 -0800</date>
            <delta_ts>2021-02-25 10:04:00 -0800</delta_ts>
            <desc>WIP</desc>
            <filename>bug-222364-20210224183537.patch</filename>
            <type>text/plain</type>
            <size>1763</size>
            <attacher name="Razvan Caliman">rcaliman</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi
SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDZiZDBlNjg1MGY1OTMyMmI0NzRmNjZjZDM5ZjU0
OGUzODFmYWYxMmUuLmYxZGEyMDgyMzRmZmE5ZGFkOGI0YTgwMjVhNDk3MDlkMzQ5ZWY2NmYgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl
Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDIxLTAyLTI0ICBSYXp2
YW4gQ2FsaW1hbiAgPHJjYWxpbWFuQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y
OiBMaXN0IG9mIGdyaWQgbm9kZXMgaXMgaW5jb21wbGV0ZSBpbiBMYXlvdXQgc2lkZWJhciBwYW5l
bAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyMzY0
CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2Vy
SW50ZXJmYWNlL1ZpZXdzL0xheW91dERldGFpbHNTaWRlYmFyUGFuZWwuanM6CisgICAgICAgIChX
SS5MYXlvdXREZXRhaWxzU2lkZWJhclBhbmVsLnByb3RvdHlwZS5hdHRhY2hlZCk6CisKIDIwMjEt
MDItMjMgIFBhdHJpY2sgQW5nbGUgIDxwYW5nbGVAYXBwbGUuY29tPgogCiAgICAgICAgIFtDb2Nv
YV0gV2ViIEluc3BlY3RvcjogQWRkIHN1cHBvcnQgZm9yIHJlbG9hZGluZyB0aGUgaW5zcGVjdGVk
IHBhZ2UgdmlhIF9XS0luc3BlY3RvckV4dGVuc2lvbgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu
c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTGF5b3V0RGV0YWlsc1NpZGViYXJQYW5lbC5q
cyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xheW91dERldGFp
bHNTaWRlYmFyUGFuZWwuanMKaW5kZXggZDVjOTQ4OWFhYjk3OWIwMDNmMjg2Y2Q5M2UyZTU1N2Iw
NzFjMzI0Zi4uMTVmMjI0YmNhNGRiM2UxZjMwMzUzYjMyZmVhZjRiNDQ1YTg3ZjMzZiAxMDA2NDQK
LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvTGF5b3V0RGV0
YWlsc1NpZGViYXJQYW5lbC5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy
ZmFjZS9WaWV3cy9MYXlvdXREZXRhaWxzU2lkZWJhclBhbmVsLmpzCkBAIC04NSw2ICs4NSw3IEBA
IFdJLkxheW91dERldGFpbHNTaWRlYmFyUGFuZWwgPSBjbGFzcyBMYXlvdXREZXRhaWxzU2lkZWJh
clBhbmVsIGV4dGVuZHMgV0kuRE9NRGV0CiAgICAgICAgIFdJLkRPTU5vZGUuYWRkRXZlbnRMaXN0
ZW5lcihXSS5ET01Ob2RlLkV2ZW50LkxheW91dENvbnRleHRUeXBlQ2hhbmdlZCwgdGhpcy5faGFu
ZGxlTGF5b3V0Q29udGV4dFR5cGVDaGFuZ2VkLCB0aGlzKTsKICAgICAgICAgV0kuRnJhbWUuYWRk
RXZlbnRMaXN0ZW5lcihXSS5GcmFtZS5FdmVudC5NYWluUmVzb3VyY2VEaWRDaGFuZ2UsIHRoaXMu
X21haW5SZXNvdXJjZURpZENoYW5nZSwgdGhpcyk7CiAKKyAgICAgICAgV0kuY3NzTWFuYWdlci5s
YXlvdXRDb250ZXh0VHlwZUNoYW5nZWRNb2RlID0gV0kuQ1NTTWFuYWdlci5MYXlvdXRDb250ZXh0
VHlwZUNoYW5nZWRNb2RlLk9ic2VydmVkOwogICAgICAgICBXSS5jc3NNYW5hZ2VyLmxheW91dENv
bnRleHRUeXBlQ2hhbmdlZE1vZGUgPSBXSS5DU1NNYW5hZ2VyLkxheW91dENvbnRleHRUeXBlQ2hh
bmdlZE1vZGUuQWxsOwogCiAgICAgICAgIHRoaXMuX3JlZnJlc2hHcmlkTm9kZVNldCgpOwo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>421538</attachid>
            <date>2021-02-25 10:04:04 -0800</date>
            <delta_ts>2021-02-25 11:11:21 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-222364-20210225190403.patch</filename>
            <type>text/plain</type>
            <size>3661</size>
            <attacher name="Razvan Caliman">rcaliman</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGE0NzIzY2RhMWM0YmVmOTlhM2FiMDM2NzM2ZDFj
YTQ1ZDFiMGU0ZGMuLjEzODU2YmU3YzQ1ZjVhZmNmYmJmYjVmZDI1ZWE3MzBmMTVhZjg5MDAgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0ph
dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAyLTI1ICBSYXp2
YW4gQ2FsaW1hbiAgPHJjYWxpbWFuQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y
OiBMaXN0IG9mIGdyaWQgbm9kZXMgaXMgaW5jb21wbGV0ZSBpbiBMYXlvdXQgc2lkZWJhciBwYW5l
bAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyMzY0
CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NDcwMDk2MD4KKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgaW5zcGVjdG9yIHByb3RvY29sIGRl
c2NyaXB0aW9uIGZvciBDU1MgZG9tYWluIHRvIG1lbnRpb24gZGVmYXVsdCB2YWx1ZSBmb3IKKyAg
ICAgICAgYGxheW91dENvbnRleHRUeXBlQ2hhbmdlZE1vZGVgICgib2JzZXJ2ZWQiKSBhbmQgY2xh
cmlmeSBiZWhhdmlvciBvZiAiYWxsIiB2YWx1ZS4KKworICAgICAgICAqIGluc3BlY3Rvci9wcm90
b2NvbC9DU1MuanNvbjoKKwogMjAyMS0wMi0yNSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVl
QHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIHIyNzM0NjkuCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu
Z2VMb2cKaW5kZXggNGUyODBhMzM2OGI5YTk5MDA1M2IyYzdjM2Q2Y2I0OGJiNjE0MmFhNC4uYWVk
NGE4ZGEwMWQ3ZDgwNmNjYmVjZjI5NmM2YmNjZTE4NDBjZmM0NCAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwz
ICsxLDE3IEBACisyMDIxLTAyLTI1ICBSYXp2YW4gQ2FsaW1hbiAgPHJjYWxpbWFuQGFwcGxlLmNv
bT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBMaXN0IG9mIGdyaWQgbm9kZXMgaXMgaW5jb21w
bGV0ZSBpbiBMYXlvdXQgc2lkZWJhciBwYW5lbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyMzY0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NDcw
MDk2MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBF
bnN1cmUgZGVmYXVsdCB2YWx1ZSBvZiBgbGF5b3V0Q29udGV4dFR5cGVDaGFuZ2VkTW9kZWAgaXMg
c2V0IGZvciBJbnNwZWN0b3JDU1NBZ2VudAorICAgICAgICB0byByZWNvZ25pemUgdGhlIG1vZGUg
Y2hhbmdlIHdoZW4gc3dpdGNoaW5nIG1vbml0b3IgbGF5b3V0IGNvbnRleHRzIG9mIGFsbCBub2Rl
cy4KKworICAgICAgICAqIGluc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yQ1NTQWdlbnQuY3BwOgor
ICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ1NTQWdlbnQ6OnJlc2V0KToKKwogMjAyMS0wMi0y
NSAgQWxleGFuZGVyIE1pa2hheWxlbmtvICA8YWxleG1AZ25vbWUub3JnPgogCiAgICAgICAgIFtH
VEtdIEFkd2FpdGEgY29udHJvbHMgaGF2ZSBnbGl0Y2h5IGNvcm5lcnMKZGlmZiAtLWdpdCBhL1Nv
dXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcHJvdG9jb2wvQ1NTLmpzb24gYi9Tb3VyY2Uv
SmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Byb3RvY29sL0NTUy5qc29uCmluZGV4IGYwMjJjNTQ4
MWE4YTY1Yjk2NWJkYzJmZWRiY2ZlNzg2ZTYxZjUwN2EuLjNiOTU0NTg4ZjgzM2Q1NTI1ZDFkZmJk
NWFjNmUxODI0N2E3ZjM3NmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNw
ZWN0b3IvcHJvdG9jb2wvQ1NTLmpzb24KKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3Bl
Y3Rvci9wcm90b2NvbC9DU1MuanNvbgpAQCAtMjYzLDcgKzI2Myw3IEBACiAgICAgICAgICAgICAi
aWQiOiAiTGF5b3V0Q29udGV4dFR5cGVDaGFuZ2VkTW9kZSIsCiAgICAgICAgICAgICAidHlwZSI6
ICJzdHJpbmciLAogICAgICAgICAgICAgImVudW0iOiBbIm9ic2VydmVkIiwgImFsbCJdLAotICAg
ICAgICAgICAgImRlc2NyaXB0aW9uIjogIlRoZSBtb2RlIGZvciBob3cgbGF5b3V0IGNvbnRleHQg
dHlwZSBjaGFuZ2VzIGFyZSBoYW5kbGVkLiA8Y29kZT5PYnNlcnZlZDwvY29kZT4gbGltaXRzIGhh
bmRsaW5nIHRvIHRob3NlIG5vZGVzIGFscmVhZHkga25vd24gdG8gdGhlIGZyb250ZW5kIGJ5IG90
aGVyIG1lYW5zIChnZW5lcmFsbHksIHRoaXMgbWVhbnMgdGhlIG5vZGUgaXMgYSB2aXNpYmxlIGl0
ZW0gaW4gdGhlIEVsZW1lbnRzIHRhYikuIDxjb2RlPkFsbDwvY29kZT4gaW5mb3JtcyB0aGUgZnJv
bnRlbmQgb2YgYWxsIGxheW91dCBjb250ZXh0IHR5cGUgY2hhbmdlcyBhbmQuIgorICAgICAgICAg
ICAgImRlc2NyaXB0aW9uIjogIlRoZSBtb2RlIGZvciBob3cgbGF5b3V0IGNvbnRleHQgdHlwZSBj
aGFuZ2VzIGFyZSBoYW5kbGVkIChkZWZhdWx0OiBvYnNlcnZlZCkuIDxjb2RlPk9ic2VydmVkPC9j
b2RlPiBsaW1pdHMgaGFuZGxpbmcgdG8gdGhvc2Ugbm9kZXMgYWxyZWFkeSBrbm93biB0byB0aGUg
ZnJvbnRlbmQgYnkgb3RoZXIgbWVhbnMgKGdlbmVyYWxseSwgdGhpcyBtZWFucyB0aGUgbm9kZSBp
cyBhIHZpc2libGUgaXRlbSBpbiB0aGUgRWxlbWVudHMgdGFiKS4gPGNvZGU+QWxsPC9jb2RlPiBp
bmZvcm1zIHRoZSBmcm9udGVuZCBvZiBhbGwgbGF5b3V0IGNvbnRleHQgdHlwZSBjaGFuZ2VzIGFu
ZCBhbGwgbm9kZXMgd2l0aCBhIGtub3duIGxheW91dCBjb250ZXh0IGFyZSBzZW50IHRvIHRoZSBm
cm9udGVuZC4iCiAgICAgICAgIH0KICAgICBdLAogICAgICJjb21tYW5kcyI6IFsKZGlmZiAtLWdp
dCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yQ1NTQWdlbnQuY3Bw
IGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JDU1NBZ2VudC5jcHAK
aW5kZXggZDUyZWQwY2M3YzNkYzExYjYzZTljYWZlZWIzOTZhYmRkN2M5Yzc1NC4uMjA4MTA5NTY1
YzUzYmY2OGJiZDNjOGJiYzVjNTM1NjJmNzcyNDliYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv
cmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JDU1NBZ2VudC5jcHAKKysrIGIvU291cmNlL1dl
YkNvcmUvaW5zcGVjdG9yL2FnZW50cy9JbnNwZWN0b3JDU1NBZ2VudC5jcHAKQEAgLTMyNiw2ICsz
MjYsNyBAQCB2b2lkIEluc3BlY3RvckNTU0FnZW50OjpyZXNldCgpCiAgICAgbV9ub2RlVG9JbnNw
ZWN0b3JTdHlsZVNoZWV0LmNsZWFyKCk7CiAgICAgbV9kb2N1bWVudFRvSW5zcGVjdG9yU3R5bGVT
aGVldC5jbGVhcigpOwogICAgIG1fZG9jdW1lbnRUb0tub3duQ1NTU3R5bGVTaGVldHMuY2xlYXIo
KTsKKyAgICBtX2xheW91dENvbnRleHRUeXBlQ2hhbmdlZE1vZGUgPSBQcm90b2NvbDo6Q1NTOjpM
YXlvdXRDb250ZXh0VHlwZUNoYW5nZWRNb2RlOjpPYnNlcnZlZDsKICAgICByZXNldFBzZXVkb1N0
YXRlcygpOwogfQogCg==
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>421548</attachid>
            <date>2021-02-25 11:11:25 -0800</date>
            <delta_ts>2021-02-25 12:31:07 -0800</delta_ts>
            <desc>Patch</desc>
            <filename>bug-222364-20210225201124.patch</filename>
            <type>text/plain</type>
            <size>3674</size>
            <attacher name="Razvan Caliman">rcaliman</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvSmF2
YVNjcmlwdENvcmUvQ2hhbmdlTG9nCmluZGV4IGE0NzIzY2RhMWM0YmVmOTlhM2FiMDM2NzM2ZDFj
YTQ1ZDFiMGU0ZGMuLjEzODU2YmU3YzQ1ZjVhZmNmYmJmYjVmZDI1ZWE3MzBmMTVhZjg5MDAgMTAw
NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL0ph
dmFTY3JpcHRDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIxLTAyLTI1ICBSYXp2
YW4gQ2FsaW1hbiAgPHJjYWxpbWFuQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y
OiBMaXN0IG9mIGdyaWQgbm9kZXMgaXMgaW5jb21wbGV0ZSBpbiBMYXlvdXQgc2lkZWJhciBwYW5l
bAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyMzY0
CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NDcwMDk2MD4KKworICAgICAgICBSZXZpZXdlZCBi
eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUgaW5zcGVjdG9yIHByb3RvY29sIGRl
c2NyaXB0aW9uIGZvciBDU1MgZG9tYWluIHRvIG1lbnRpb24gZGVmYXVsdCB2YWx1ZSBmb3IKKyAg
ICAgICAgYGxheW91dENvbnRleHRUeXBlQ2hhbmdlZE1vZGVgICgib2JzZXJ2ZWQiKSBhbmQgY2xh
cmlmeSBiZWhhdmlvciBvZiAiYWxsIiB2YWx1ZS4KKworICAgICAgICAqIGluc3BlY3Rvci9wcm90
b2NvbC9DU1MuanNvbjoKKwogMjAyMS0wMi0yNSAgQ29tbWl0IFF1ZXVlICA8Y29tbWl0LXF1ZXVl
QHdlYmtpdC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcmV2ZXJ0aW5nIHIyNzM0NjkuCmRp
ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFu
Z2VMb2cKaW5kZXggNGUyODBhMzM2OGI5YTk5MDA1M2IyYzdjM2Q2Y2I0OGJiNjE0MmFhNC4uYWVk
NGE4ZGEwMWQ3ZDgwNmNjYmVjZjI5NmM2YmNjZTE4NDBjZmM0NCAxMDA2NDQKLS0tIGEvU291cmNl
L1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwz
ICsxLDE3IEBACisyMDIxLTAyLTI1ICBSYXp2YW4gQ2FsaW1hbiAgPHJjYWxpbWFuQGFwcGxlLmNv
bT4KKworICAgICAgICBXZWIgSW5zcGVjdG9yOiBMaXN0IG9mIGdyaWQgbm9kZXMgaXMgaW5jb21w
bGV0ZSBpbiBMYXlvdXQgc2lkZWJhciBwYW5lbAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0
Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjIyMzY0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NDcw
MDk2MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBF
bnN1cmUgZGVmYXVsdCB2YWx1ZSBvZiBgbGF5b3V0Q29udGV4dFR5cGVDaGFuZ2VkTW9kZWAgaXMg
c2V0IGZvciBJbnNwZWN0b3JDU1NBZ2VudAorICAgICAgICB0byByZWNvZ25pemUgdGhlIG1vZGUg
Y2hhbmdlIHdoZW4gc3dpdGNoaW5nIG1vbml0b3IgbGF5b3V0IGNvbnRleHRzIG9mIGFsbCBub2Rl
cy4KKworICAgICAgICAqIGluc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yQ1NTQWdlbnQuY3BwOgor
ICAgICAgICAoV2ViQ29yZTo6SW5zcGVjdG9yQ1NTQWdlbnQ6OnJlc2V0KToKKwogMjAyMS0wMi0y
NSAgQWxleGFuZGVyIE1pa2hheWxlbmtvICA8YWxleG1AZ25vbWUub3JnPgogCiAgICAgICAgIFtH
VEtdIEFkd2FpdGEgY29udHJvbHMgaGF2ZSBnbGl0Y2h5IGNvcm5lcnMKZGlmZiAtLWdpdCBhL1Nv
dXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNwZWN0b3IvcHJvdG9jb2wvQ1NTLmpzb24gYi9Tb3VyY2Uv
SmF2YVNjcmlwdENvcmUvaW5zcGVjdG9yL3Byb3RvY29sL0NTUy5qc29uCmluZGV4IGYwMjJjNTQ4
MWE4YTY1Yjk2NWJkYzJmZWRiY2ZlNzg2ZTYxZjUwN2EuLmZjN2YyZTVlMThiMjkwNDgxY2Q0ZjNk
YWRlNTQzNGFmMDk2ZjQ1MWQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnNw
ZWN0b3IvcHJvdG9jb2wvQ1NTLmpzb24KKysrIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2luc3Bl
Y3Rvci9wcm90b2NvbC9DU1MuanNvbgpAQCAtMjYzLDcgKzI2Myw3IEBACiAgICAgICAgICAgICAi
aWQiOiAiTGF5b3V0Q29udGV4dFR5cGVDaGFuZ2VkTW9kZSIsCiAgICAgICAgICAgICAidHlwZSI6
ICJzdHJpbmciLAogICAgICAgICAgICAgImVudW0iOiBbIm9ic2VydmVkIiwgImFsbCJdLAotICAg
ICAgICAgICAgImRlc2NyaXB0aW9uIjogIlRoZSBtb2RlIGZvciBob3cgbGF5b3V0IGNvbnRleHQg
dHlwZSBjaGFuZ2VzIGFyZSBoYW5kbGVkLiA8Y29kZT5PYnNlcnZlZDwvY29kZT4gbGltaXRzIGhh
bmRsaW5nIHRvIHRob3NlIG5vZGVzIGFscmVhZHkga25vd24gdG8gdGhlIGZyb250ZW5kIGJ5IG90
aGVyIG1lYW5zIChnZW5lcmFsbHksIHRoaXMgbWVhbnMgdGhlIG5vZGUgaXMgYSB2aXNpYmxlIGl0
ZW0gaW4gdGhlIEVsZW1lbnRzIHRhYikuIDxjb2RlPkFsbDwvY29kZT4gaW5mb3JtcyB0aGUgZnJv
bnRlbmQgb2YgYWxsIGxheW91dCBjb250ZXh0IHR5cGUgY2hhbmdlcyBhbmQuIgorICAgICAgICAg
ICAgImRlc2NyaXB0aW9uIjogIlRoZSBtb2RlIGZvciBob3cgbGF5b3V0IGNvbnRleHQgdHlwZSBj
aGFuZ2VzIGFyZSBoYW5kbGVkIChkZWZhdWx0OiA8Y29kZT5PYnNlcnZlZDwvY29kZT4pLiA8Y29k
ZT5PYnNlcnZlZDwvY29kZT4gbGltaXRzIGhhbmRsaW5nIHRvIHRob3NlIG5vZGVzIGFscmVhZHkg
a25vd24gdG8gdGhlIGZyb250ZW5kIGJ5IG90aGVyIG1lYW5zIChnZW5lcmFsbHksIHRoaXMgbWVh
bnMgdGhlIG5vZGUgaXMgYSB2aXNpYmxlIGl0ZW0gaW4gdGhlIEVsZW1lbnRzIHRhYikuIDxjb2Rl
PkFsbDwvY29kZT4gaW5mb3JtcyB0aGUgZnJvbnRlbmQgb2YgYWxsIGxheW91dCBjb250ZXh0IHR5
cGUgY2hhbmdlcyBhbmQgYWxsIG5vZGVzIHdpdGggYSBrbm93biBsYXlvdXQgY29udGV4dCBhcmUg
c2VudCB0byB0aGUgZnJvbnRlbmQuIgogICAgICAgICB9CiAgICAgXSwKICAgICAiY29tbWFuZHMi
OiBbCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvYWdlbnRzL0luc3BlY3Rv
ckNTU0FnZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9y
Q1NTQWdlbnQuY3BwCmluZGV4IGQ1MmVkMGNjN2MzZGMxMWI2M2U5Y2FmZWViMzk2YWJkZDdjOWM3
NTQuLjIwODEwOTU2NWM1M2JmNjhiYmQzYzhiYmM1YzUzNTYyZjc3MjQ5YmEgMTAwNjQ0Ci0tLSBh
L1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yQ1NTQWdlbnQuY3BwCisr
KyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9hZ2VudHMvSW5zcGVjdG9yQ1NTQWdlbnQuY3Bw
CkBAIC0zMjYsNiArMzI2LDcgQEAgdm9pZCBJbnNwZWN0b3JDU1NBZ2VudDo6cmVzZXQoKQogICAg
IG1fbm9kZVRvSW5zcGVjdG9yU3R5bGVTaGVldC5jbGVhcigpOwogICAgIG1fZG9jdW1lbnRUb0lu
c3BlY3RvclN0eWxlU2hlZXQuY2xlYXIoKTsKICAgICBtX2RvY3VtZW50VG9Lbm93bkNTU1N0eWxl
U2hlZXRzLmNsZWFyKCk7CisgICAgbV9sYXlvdXRDb250ZXh0VHlwZUNoYW5nZWRNb2RlID0gUHJv
dG9jb2w6OkNTUzo6TGF5b3V0Q29udGV4dFR5cGVDaGFuZ2VkTW9kZTo6T2JzZXJ2ZWQ7CiAgICAg
cmVzZXRQc2V1ZG9TdGF0ZXMoKTsKIH0KIAo=
</data>

          </attachment>
      

    </bug>

</bugzilla>