222359 2021-02-24 07:50:07 -0800 [ews] Make unit-test compatible with latest buildbot 2021-02-24 09:26:15 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1732871 0 aakash_jain 2021-02-24 07:50:07 -0800 EWS unit-tests currently work with Buildbot v1.8.2. But on newer buildbot (e.g.: v2.8.4) they fail with error: ====================================================================== ERROR: test_unexpected_failure (steps_unittest.TestWebKitPyPython3Tests) test_unexpected_failure ---------------------------------------------------------------------- Traceback (most recent call last): File "/Library/Python/3.7/site-packages/twisted/internet/defer.py", line 151, in maybeDeferred result = f(*args, **kw) File "/Library/Python/3.7/site-packages/twisted/internet/utils.py", line 221, in runWithWarningsSuppressed reraise(exc_info[1], exc_info[2]) File "/Library/Python/3.7/site-packages/twisted/python/compat.py", line 464, in reraise raise exception.with_traceback(traceback) File "/Library/Python/3.7/site-packages/twisted/internet/utils.py", line 217, in runWithWarningsSuppressed result = f(*a, **kw) File "Tools/CISupport/ews-build/steps_unittest.py", line 542, in setUp return self.setUpBuildStep() File "Tools/CISupport/ews-build/steps_unittest.py", line 114, in setUpBuildStep super(BuildStepMixinAdditions, self).setUpBuildStep() File "/Library/Python/3.7/site-packages/buildbot/test/util/steps.py", line 119, in setUpBuildStep raise Exception('Reactor has not yet been setup for step') Exception: Reactor has not yet been setup for step We should make the unit-tests compatible with newer version of buildbot. 1732872 1 aakash_jain 2021-02-24 07:50:16 -0800 This is because of recent change in Buildbot in https://github.com/buildbot/buildbot/commit/16c2c931a0 (in v2.8.0) 1732873 2 421410 aakash_jain 2021-02-24 07:55:38 -0800 Created attachment 421410 Patch 1732909 3 ews-feeder 2021-02-24 09:25:20 -0800 Committed r273403: <https://commits.webkit.org/r273403> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421410. 1732911 4 webkit-bug-importer 2021-02-24 09:26:15 -0800 <rdar://problem/74698904> 421410 2021-02-24 07:55:38 -0800 2021-02-24 09:25:20 -0800 Patch bug-222359-20210224105537.patch text/plain 2169 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3MzM4NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIxLTAyLTI0ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBNYWtlIHVuaXQtdGVzdCBjb21wYXRpYmxlIHdpdGggbGF0ZXN0 IGJ1aWxkYm90CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0yMjIzNTkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIENJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHk6CisgICAgICAgIChCdWls ZFN0ZXBNaXhpbkFkZGl0aW9ucyk6CisgICAgICAgIChCdWlsZFN0ZXBNaXhpbkFkZGl0aW9ucy5z ZXRVcEJ1aWxkU3RlcCk6IEludm9rZSBzZXRVcFRlc3RSZWFjdG9yLgorCiAyMDIxLTAyLTI0ICBE b24gT2xtc3RlYWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CiAKICAgICAgICAgT25seSBpbXBv cnQgUHl0aG9uIGZsYXRwYWsgbW9kdWxlIG9uIExpbnV4CkluZGV4OiBUb29scy9DSVN1cHBvcnQv ZXdzLWJ1aWxkL3N0ZXBzX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL0NJU3VwcG9y dC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJKHJldmlzaW9uIDI3MzM4NCkKKysrIFRvb2xz L0NJU3VwcG9ydC9ld3MtYnVpbGQvc3RlcHNfdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAg LTM4LDYgKzM4LDEyIEBAIGZyb20gdHdpc3RlZC5pbnRlcm5ldCBpbXBvcnQgZGVmZXIsIGVycm8K IGZyb20gdHdpc3RlZC5weXRob24gaW1wb3J0IGZhaWx1cmUsIGxvZwogZnJvbSB0d2lzdGVkLnRy aWFsIGltcG9ydCB1bml0dGVzdAogCitpZiBzeXMudmVyc2lvbl9pbmZvID4gKDMsIDApOgorICAg IGZyb20gYnVpbGRib3QudGVzdC51dGlsLm1pc2MgaW1wb3J0IFRlc3RSZWFjdG9yTWl4aW4KK2Vs c2U6CisgICAgVGVzdFJlYWN0b3JNaXhpbiA9IHR5cGUoJ1Rlc3RSZWFjdG9yTWl4aW4nLCAob2Jq ZWN0LCksIHt9KQorICAgIFRlc3RSZWFjdG9yTWl4aW4uc2V0VXBUZXN0UmVhY3RvciA9IGxhbWJk YSBzZWxmOiBOb25lCisKIGZyb20gc3RlcHMgaW1wb3J0IChBbmFseXplQVBJVGVzdHNSZXN1bHRz LCBBbmFseXplQ29tcGlsZVdlYktpdFJlc3VsdHMsIEFuYWx5emVKU0NUZXN0c1Jlc3VsdHMsCiAg ICAgICAgICAgICAgICAgICAgQW5hbHl6ZUxheW91dFRlc3RzUmVzdWx0cywgQXBwbHlQYXRjaCwg QXBwbHlXYXRjaExpc3QsIEFyY2hpdmVCdWlsdFByb2R1Y3QsIEFyY2hpdmVUZXN0UmVzdWx0cywK ICAgICAgICAgICAgICAgICAgICBDaGVja091dFNvdXJjZSwgQ2hlY2tPdXRTcGVjaWZpY1Jldmlz aW9uLCBDaGVja1BhdGNoUmVsZXZhbmNlLCBDaGVja1BhdGNoU3RhdHVzT25FV1NRdWV1ZXMsIENo ZWNrU3R5bGUsCkBAIC05NSwxMCArMTAxLDExIEBAIGNsYXNzIEV4cGVjdE1hc3RlclNoZWxsQ29t bWFuZChvYmplY3QpOgogICAgICAgICByZXR1cm4gJ0V4cGVjdE1hc3RlclNoZWxsQ29tbWFuZCh7 MH0pJy5mb3JtYXQocmVwcihzZWxmLmFyZ3MpKQogCiAKLWNsYXNzIEJ1aWxkU3RlcE1peGluQWRk aXRpb25zKEJ1aWxkU3RlcE1peGluKToKK2NsYXNzIEJ1aWxkU3RlcE1peGluQWRkaXRpb25zKEJ1 aWxkU3RlcE1peGluLCBUZXN0UmVhY3Rvck1peGluKToKICAgICBkZWYgc2V0VXBCdWlsZFN0ZXAo c2VsZik6CiAgICAgICAgIHNlbGYucGF0Y2gocmVhY3RvciwgJ3NwYXduUHJvY2VzcycsIGxhbWJk YSAqYXJncywgKiprd2FyZ3M6IHNlbGYuX2NoZWNrU3Bhd25Qcm9jZXNzKCphcmdzLCAqKmt3YXJn cykpCiAgICAgICAgIHNlbGYuX2V4cGVjdGVkX2xvY2FsX2NvbW1hbmRzID0gW10KKyAgICAgICAg c2VsZi5zZXRVcFRlc3RSZWFjdG9yKCkKIAogICAgICAgICBzZWxmLl90ZW1wX2RpcmVjdG9yeSA9 IHRlbXBmaWxlLm1rZHRlbXAoKQogICAgICAgICBvcy5jaGRpcihzZWxmLl90ZW1wX2RpcmVjdG9y eSkK