222348 2021-02-24 01:42:15 -0800 [GPU Process] Implement ImageBufferShareableBitmapBackend::bytesPerRow() 2021-02-24 09:53:19 -0800 1 1 1 Unclassified WebKit Canvas WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sabouhallawa sabouhallawa dino simon.fraser thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1732807 0 sabouhallawa 2021-02-24 01:42:15 -0800 The ShareableBitmapCG aligns the rows using IOSurfaceAlignProperty(kIOSurfaceBytesPerRow, ...). This means the default implementation which is "width x 4" is wrong for ImageBufferShareableBitmapBackend. This will fix the layout failure: fast/canvas/canvas-large-dimensions.html [ Failure ] 1732808 1 421390 sabouhallawa 2021-02-24 01:46:08 -0800 Created attachment 421390 Patch 1732921 2 ews-feeder 2021-02-24 09:52:01 -0800 Committed r273406: <https://commits.webkit.org/r273406> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421390. 1732923 3 webkit-bug-importer 2021-02-24 09:53:19 -0800 <rdar://problem/74700179> 421390 2021-02-24 01:46:08 -0800 2021-02-24 09:52:02 -0800 Patch bug-222348-20210224014607.patch text/plain 4834 sabouhallawa U3VidmVyc2lvbiBSZXZpc2lvbjogMjczMzAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDczYTQzODE3YzZlZWI5NGYz YjZiNmJiNDQ1MmI3YmU0NzNjZjlkNzUuLjY3NzEzMTM5OGMwZjZhMTA5ZWY1ZDNkZDRlMTA0MDU5 ZTQwNmRiMzggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjAgQEAKKzIwMjEtMDItMjQgIFNhaWQgQWJv dS1IYWxsYXdhICA8c2FpZEBhcHBsZS5jb20+CisKKyAgICAgICAgW0dQVSBQcm9jZXNzXSBJbXBs ZW1lbnQgSW1hZ2VCdWZmZXJTaGFyZWFibGVCaXRtYXBCYWNrZW5kOjpieXRlc1BlclJvdygpCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjIzNDgKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGUgZGVmYXVs dCBpbXBsZW1lbnRhdGlvbiBJbWFnZUJ1ZmZlckJhY2tlbmQ6OmJ5dGVzUGVyUm93KCkgaXMgbm90 IGNvcnJlY3QKKyAgICAgICAgZm9yIEltYWdlQnVmZmVyU2hhcmVhYmxlQml0bWFwQmFja2VuZCBi ZWNhdXNlIFNoYXJlYWJsZUJpdG1hcCBhbGlnbnMgdGhlCisgICAgICAgIHJvd3MgdXNpbmcgSU9T dXJmYWNlQWxpZ25Qcm9wZXJ0eShrSU9TdXJmYWNlQnl0ZXNQZXJSb3csIC4uLikuCisKKyAgICAg ICAgKiBTaGFyZWQvU2hhcmVhYmxlQml0bWFwLmg6CisgICAgICAgIChXZWJLaXQ6OlNoYXJlYWJs ZUJpdG1hcDo6Ynl0ZXNQZXJSb3cgY29uc3QpOgorICAgICAgICAqIFdlYlByb2Nlc3MvR1BVL2dy YXBoaWNzL0ltYWdlQnVmZmVyU2hhcmVhYmxlQml0bWFwQmFja2VuZC5jcHA6CisgICAgICAgIChX ZWJLaXQ6OkltYWdlQnVmZmVyU2hhcmVhYmxlQml0bWFwQmFja2VuZDo6Ynl0ZXNQZXJSb3cgY29u c3QpOgorICAgICAgICAqIFdlYlByb2Nlc3MvR1BVL2dyYXBoaWNzL0ltYWdlQnVmZmVyU2hhcmVh YmxlQml0bWFwQmFja2VuZC5oOgorCiAyMDIxLTAyLTIzICBLaW1tbyBLaW5udW5lbiAgPGtraW5u dW5lbkBhcHBsZS5jb20+CiAKICAgICAgICAgSFRNTENhbnZhc0VsZW1lbnQ6OmNvcGllZEltYWdl KCkgY29udGFpbnMgb2xkIGltYWdlIHdpdGggR1BVIFByb2Nlc3Mgb24KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvU2hhcmVkL1NoYXJlYWJsZUJpdG1hcC5oIGIvU291cmNlL1dlYktpdC9TaGFy ZWQvU2hhcmVhYmxlQml0bWFwLmgKaW5kZXggYTZkMjI5YTQyNDc4OWM5MTg4MWExMzk0N2U1MDBj NzNhMTcyZTRkNi4uYzcxOTNiY2NiOWZlYjA2MWZiNDRjZDI5NWU2YjNiZDRiN2UzYmQ5MSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYktpdC9TaGFyZWQvU2hhcmVhYmxlQml0bWFwLmgKKysrIGIvU291 cmNlL1dlYktpdC9TaGFyZWQvU2hhcmVhYmxlQml0bWFwLmgKQEAgLTE2Nyw2ICsxNjcsOCBAQCBw cml2YXRlOgogCiBwdWJsaWM6CiAgICAgdm9pZCogZGF0YSgpIGNvbnN0OworICAgIHNpemVfdCBi eXRlc1BlclJvdygpIGNvbnN0IHsgcmV0dXJuIGNhbGN1bGF0ZUJ5dGVzUGVyUm93KG1fc2l6ZSwg bV9jb25maWd1cmF0aW9uKS51bnNhZmVHZXQoKTsgfQorICAgIAogcHJpdmF0ZToKICAgICBzaXpl X3Qgc2l6ZUluQnl0ZXMoKSBjb25zdCB7IHJldHVybiBudW1CeXRlc0ZvclNpemUobV9zaXplLCBt X2NvbmZpZ3VyYXRpb24pLnVuc2FmZUdldCgpOyB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJL aXQvV2ViUHJvY2Vzcy9HUFUvZ3JhcGhpY3MvSW1hZ2VCdWZmZXJTaGFyZWFibGVCaXRtYXBCYWNr ZW5kLmNwcCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvZ3JhcGhpY3MvSW1hZ2VCdWZm ZXJTaGFyZWFibGVCaXRtYXBCYWNrZW5kLmNwcAppbmRleCAxZDdhZjZiYjhjNTdlYzZhNzY3MTAw NTdkNGMxOGNiYTZjNDY3MjYxLi5lMTlhOWFiY2M1MGE0MmMxMDYyNmIzMGU5YmRmZWQwN2UzOWUw YTliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL2dyYXBoaWNzL0lt YWdlQnVmZmVyU2hhcmVhYmxlQml0bWFwQmFja2VuZC5jcHAKKysrIGIvU291cmNlL1dlYktpdC9X ZWJQcm9jZXNzL0dQVS9ncmFwaGljcy9JbWFnZUJ1ZmZlclNoYXJlYWJsZUJpdG1hcEJhY2tlbmQu Y3BwCkBAIC0xMDMsNiArMTAzLDExIEBAIEludFNpemUgSW1hZ2VCdWZmZXJTaGFyZWFibGVCaXRt YXBCYWNrZW5kOjpiYWNrZW5kU2l6ZSgpIGNvbnN0CiAgICAgcmV0dXJuIG1fYml0bWFwLT5zaXpl KCk7CiB9CiAKK3Vuc2lnbmVkIEltYWdlQnVmZmVyU2hhcmVhYmxlQml0bWFwQmFja2VuZDo6Ynl0 ZXNQZXJSb3coKSBjb25zdAoreworICAgIHJldHVybiBtX2JpdG1hcC0+Ynl0ZXNQZXJSb3coKTsK K30KKwogUmVmUHRyPE5hdGl2ZUltYWdlPiBJbWFnZUJ1ZmZlclNoYXJlYWJsZUJpdG1hcEJhY2tl bmQ6OmNvcHlOYXRpdmVJbWFnZShCYWNraW5nU3RvcmVDb3B5KSBjb25zdAogewogICAgIHJldHVy biBOYXRpdmVJbWFnZTo6Y3JlYXRlKG1fYml0bWFwLT5jcmVhdGVQbGF0Zm9ybUltYWdlKCkpOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS9ncmFwaGljcy9JbWFnZUJ1 ZmZlclNoYXJlYWJsZUJpdG1hcEJhY2tlbmQuaCBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9H UFUvZ3JhcGhpY3MvSW1hZ2VCdWZmZXJTaGFyZWFibGVCaXRtYXBCYWNrZW5kLmgKaW5kZXggNTU1 MDZhNDlkMDNlMzllODhlMDM2MWU0OTE1NWYxMzFkNzk5MDEwZi4uNTEyYzc4ZTU1NGI3YzQzMWVh N2FiM2I3ODVlNzRiYWUzMDQ3ZjMzZSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9j ZXNzL0dQVS9ncmFwaGljcy9JbWFnZUJ1ZmZlclNoYXJlYWJsZUJpdG1hcEJhY2tlbmQuaAorKysg Yi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvR1BVL2dyYXBoaWNzL0ltYWdlQnVmZmVyU2hhcmVh YmxlQml0bWFwQmFja2VuZC5oCkBAIC02Miw2ICs2Miw4IEBAIHB1YmxpYzoKICAgICB2b2lkIHB1 dEltYWdlRGF0YShXZWJDb3JlOjpBbHBoYVByZW11bHRpcGxpY2F0aW9uIGlucHV0Rm9ybWF0LCBj b25zdCBXZWJDb3JlOjpJbWFnZURhdGEmLCBjb25zdCBXZWJDb3JlOjpJbnRSZWN0JiBzcmNSZWN0 LCBjb25zdCBXZWJDb3JlOjpJbnRQb2ludCYgZGVzdFBvaW50LCBXZWJDb3JlOjpBbHBoYVByZW11 bHRpcGxpY2F0aW9uIGRlc3RGb3JtYXQpIG92ZXJyaWRlOwogCiBwcml2YXRlOgorICAgIHVuc2ln bmVkIGJ5dGVzUGVyUm93KCkgY29uc3Qgb3ZlcnJpZGU7CisKICAgICBSZWZQdHI8U2hhcmVhYmxl Qml0bWFwPiBtX2JpdG1hcDsKICAgICBzdGQ6OnVuaXF1ZV9wdHI8V2ViQ29yZTo6R3JhcGhpY3ND b250ZXh0PiBtX2NvbnRleHQ7CiB9OwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9n IGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IGJiZTg3ZDM1NGJkMzk2M2UxMjY2ZWI3Mjky ZmZhYWExNGE3OWY4NjcuLjRjYmQzM2JhNzg3NWM3N2Y2ZWViZWQwOTA2ZWFkMDZkOTJiOTFlMjYg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAyMS0wMi0yNCAgU2FpZCBBYm91LUhhbGxhd2EgIDxz YWlkQGFwcGxlLmNvbT4KKworICAgICAgICBbR1BVIFByb2Nlc3NdIEltcGxlbWVudCBJbWFnZUJ1 ZmZlclNoYXJlYWJsZUJpdG1hcEJhY2tlbmQ6OmJ5dGVzUGVyUm93KCkKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjM0OAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogZ3B1LXByb2Nlc3MvVGVzdEV4cGVj dGF0aW9uczoKKwogMjAyMS0wMi0yMyAgS2ltbW8gS2lubnVuZW4gIDxra2lubnVuZW5AYXBwbGUu Y29tPgogCiAgICAgICAgIEhUTUxDYW52YXNFbGVtZW50Ojpjb3BpZWRJbWFnZSgpIGNvbnRhaW5z IG9sZCBpbWFnZSB3aXRoIEdQVSBQcm9jZXNzIG9uCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9n cHUtcHJvY2Vzcy9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvZ3B1LXByb2Nlc3MvVGVz dEV4cGVjdGF0aW9ucwppbmRleCA5MGVmNzA4MzNiNjFjYzhlNDdmY2Y5OWUwZThlODNkZGQ5NTdh NWFkLi5hYzgzNGE0YjY4MGMzZGQxZmFiZTQ2ZDlhM2VlZGZmZDI2ZmViYWU3IDEwMDY0NAotLS0g YS9MYXlvdXRUZXN0cy9ncHUtcHJvY2Vzcy9UZXN0RXhwZWN0YXRpb25zCisrKyBiL0xheW91dFRl c3RzL2dwdS1wcm9jZXNzL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTEzLDcgKzEzLDYgQEAgZmFzdC9j YW52YXMvY2FudmFzLWJlemllci1zYW1lLWVuZHBvaW50Lmh0bWwgWyBGYWlsdXJlIFBhc3MgXQog ZmFzdC9jYW52YXMvY2FudmFzLWJsZW5kLWltYWdlLmh0bWwgWyBGYWlsdXJlIFBhc3MgXQogZmFz dC9jYW52YXMvY2FudmFzLWJsZW5kLXNvbGlkLmh0bWwgWyBGYWlsdXJlIFBhc3MgXQogZmFzdC9j YW52YXMvY2FudmFzLWRyYXdJbWFnZS1jb21wb3NpdGUtY29weS5odG1sIFsgSW1hZ2VPbmx5RmFp bHVyZSBdCi1mYXN0L2NhbnZhcy9jYW52YXMtbGFyZ2UtZGltZW5zaW9ucy5odG1sIFsgRmFpbHVy ZSBdCiBmYXN0L2NhbnZhcy9jYW52YXMtcmVuZGVyLWxheWVyLmh0bWwgWyBGYWlsdXJlIF0KIGZh c3QvY2FudmFzL2hpZHBpLXJlcGFpbnQtb24tcmV0aW5hLWxlYXZlcy1iaXRzLWJlaGluZC5odG1s IFsgSW1hZ2VPbmx5RmFpbHVyZSBdCiBmYXN0L2NhbnZhcy93ZWJnbC90ZXgtaW1hZ2UtYW5kLXN1 Yi1pbWFnZS0yZC13aXRoLXZpZGVvLXJnYjU2NS5odG1sIFsgRmFpbHVyZSBdCg==