222346 2021-02-23 23:51:54 -0800 Fix linker warnings building gtest for macCatalyst 2021-02-24 16:41:09 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 thorton thorton ap webkit-bug-importer wenson_hsieh oldest_to_newest 1732797 0 thorton 2021-02-23 23:51:54 -0800 Fix linker warnings building gtest for macCatalyst 1732798 1 421388 thorton 2021-02-23 23:52:14 -0800 Created attachment 421388 Patch 1732799 2 thorton 2021-02-23 23:52:18 -0800 <rdar://problem/74405116> 1732925 3 421388 ap 2021-02-24 09:54:07 -0800 Comment on attachment 421388 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421388&action=review r=me too, with comments. > Source/ThirdParty/gtest/xcode/Config/FrameworkTarget.xcconfig:22 > +INSTALL_PATH_SDK_VARIANT_macos = $(MACOS_UNZIPPERED_TWIN_PRIVATE_FRAMEWORK_INSTALL_PATH); > +INSTALL_PATH_SDK_VARIANT_iosmac = $(IOS_UNZIPPERED_TWIN_PRIVATE_FRAMEWORK_INSTALL_PATH); This is not how we do this elsewhere (cf. WK_ALTERNATE_FRAMEWORKS_DIR). Do we need to modernize all other projects to use these constants? Do they exist on all OS versions we need? > Source/ThirdParty/gtest/xcode/Config/General.xcconfig:11 > +#include "<DEVELOPER_DIR>/AppleInternal/XcodeConfig/PlatformSupport.xcconfig" Shouldn't this be "include?"? It is in other projects, and obviously not everyone has it. 1732926 4 ap 2021-02-24 09:56:28 -0800 Also, I don't imagine that removing INSTALL_PATH altogether fixes the problem - or does it? 1732944 5 421388 thorton 2021-02-24 10:18:56 -0800 Comment on attachment 421388 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421388&action=review >> Source/ThirdParty/gtest/xcode/Config/FrameworkTarget.xcconfig:22 >> +INSTALL_PATH_SDK_VARIANT_iosmac = $(IOS_UNZIPPERED_TWIN_PRIVATE_FRAMEWORK_INSTALL_PATH); > > This is not how we do this elsewhere (cf. WK_ALTERNATE_FRAMEWORKS_DIR). Do we need to modernize all other projects to use these constants? Do they exist on all OS versions we need? They do exist where we need them, and I don't think any of the other parts of this matter? >> Source/ThirdParty/gtest/xcode/Config/General.xcconfig:11 >> +#include "<DEVELOPER_DIR>/AppleInternal/XcodeConfig/PlatformSupport.xcconfig" > > Shouldn't this be "include?"? It is in other projects, and obviously not everyone has it. Yes, this is a good point. 1732945 6 thorton 2021-02-24 10:19:18 -0800 (In reply to Alexey Proskuryakov from comment #4) > Also, I don't imagine that removing INSTALL_PATH altogether fixes the > problem - or does it? I have not tried that! 1733003 7 thorton 2021-02-24 11:45:41 -0800 (In reply to Tim Horton from comment #6) > (In reply to Alexey Proskuryakov from comment #4) > > Also, I don't imagine that removing INSTALL_PATH altogether fixes the > > problem - or does it? > > I have not tried that! It does! 1733006 8 421435 thorton 2021-02-24 11:51:01 -0800 Created attachment 421435 Patch 1733037 9 421435 ap 2021-02-24 12:58:09 -0800 Comment on attachment 421435 Patch Yay. 1733049 10 ews-feeder 2021-02-24 13:13:30 -0800 Committed r273430: <https://commits.webkit.org/r273430> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421435. 1733142 11 ap 2021-02-24 16:41:09 -0800 > They do exist where we need them, and I don't think any of the other parts of this matter? Doesn't matter for landing the original patch, definitely doesn't matter for the final patch, matters for understanding what future cleanup is ahead of us. Using multiple ways to do the same thing forever wouldn't have been great. 421388 2021-02-23 23:52:14 -0800 2021-02-24 11:50:59 -0800 Patch bug-222346-20210223235213.patch text/plain 2369 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjczMzcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9DaGFuZ2VMb2cKaW5kZXggOWFjMTY5MDJk ODZjMTk0YTNmMjQ0OTI4NzAxZTYxYzcxMWFkOWIwMC4uNWJiYTZlOWY2N2U2ZTIwMzQ2M2NiYzk0 OWVmNTc0NGUzYThmODJjZCAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIx LTAyLTIzICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAg IEZpeCBsaW5rZXIgd2FybmluZ3MgYnVpbGRpbmcgZ3Rlc3QgZm9yIG1hY0NhdGFseXN0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjIzNDYKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzc0NDA1MTE2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogZ3Rlc3QveGNvZGUvQ29uZmlnL0ZyYW1ld29ya1Rhcmdl dC54Y2NvbmZpZzoKKyAgICAgICAgKiBndGVzdC94Y29kZS9Db25maWcvR2VuZXJhbC54Y2NvbmZp ZzoKKyAgICAgICAgV29yayBhcm91bmQgYSBsaW5rZXIgd2FybmluZyBhYm91dCBtYWNDYXRhbHlz dCBieSAiaW5zdGFsbGluZyIgZ3Rlc3QKKyAgICAgICAgdG8gYSBwbGFjZSB3aGVyZSB1bnppcHBl cmVkIGZyYW1ld29ya3MgYXJlIGFsbG93ZWQgdG8gbGl2ZS4KKwogMjAyMS0wMS0wOCAgUnlhbiBI b3N0ZXRsZXIgIDxyaG9zdEBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHN1cHBvcnQgZm9yIHNv dXJjZSBjYWNoaW5nIGJldHdlZW4gcGxhdGZvcm1zCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQ YXJ0eS9ndGVzdC94Y29kZS9Db25maWcvRnJhbWV3b3JrVGFyZ2V0LnhjY29uZmlnIGIvU291cmNl L1RoaXJkUGFydHkvZ3Rlc3QveGNvZGUvQ29uZmlnL0ZyYW1ld29ya1RhcmdldC54Y2NvbmZpZwpp bmRleCA3ZDAyNGNkMjk0ODY3YzE1NzMyYmUyZTg5Yzc5Yjg3ZWJhZWRhZjQ1Li4xNjRjYTY1MGI0 MWM0MGE4Nzg2ZWE1MjVhZmUwOWJlYThkOWRkM2NmIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQ YXJ0eS9ndGVzdC94Y29kZS9Db25maWcvRnJhbWV3b3JrVGFyZ2V0LnhjY29uZmlnCisrKyBiL1Nv dXJjZS9UaGlyZFBhcnR5L2d0ZXN0L3hjb2RlL0NvbmZpZy9GcmFtZXdvcmtUYXJnZXQueGNjb25m aWcKQEAgLTE2LDQgKzE2LDcgQEAgU1RSSVBfU1RZTEUgPSBub24tZ2xvYmFsCiAvLyBMZXQgdGhl IHVzZXIgaW5zdGFsbCBieSBzcGVjaWZ5aW5nIHRoZSAkRFNUUk9PVCB3aXRoIHhjb2RlYnVpbGQK IFNLSVBfSU5TVEFMTCA9IE5PCiAKLUlOU1RBTExfUEFUSCA9ICQoU1lTVEVNX0xJQlJBUllfRElS KS9Qcml2YXRlRnJhbWV3b3JrczsKK0lOU1RBTExfUEFUSCA9ICQoSU5TVEFMTF9QQVRIX1NES19W QVJJQU5UXyQoU0RLX1ZBUklBTlQpKTsKK0lOU1RBTExfUEFUSF9TREtfVkFSSUFOVF8gPSAkKFNZ U1RFTV9MSUJSQVJZX0RJUikvUHJpdmF0ZUZyYW1ld29ya3M7CitJTlNUQUxMX1BBVEhfU0RLX1ZB UklBTlRfbWFjb3MgPSAkKE1BQ09TX1VOWklQUEVSRURfVFdJTl9QUklWQVRFX0ZSQU1FV09SS19J TlNUQUxMX1BBVEgpOworSU5TVEFMTF9QQVRIX1NES19WQVJJQU5UX2lvc21hYyA9ICQoSU9TX1VO WklQUEVSRURfVFdJTl9QUklWQVRFX0ZSQU1FV09SS19JTlNUQUxMX1BBVEgpOwpkaWZmIC0tZ2l0 IGEvU291cmNlL1RoaXJkUGFydHkvZ3Rlc3QveGNvZGUvQ29uZmlnL0dlbmVyYWwueGNjb25maWcg Yi9Tb3VyY2UvVGhpcmRQYXJ0eS9ndGVzdC94Y29kZS9Db25maWcvR2VuZXJhbC54Y2NvbmZpZwpp bmRleCAyMTJkMmZiMmJjY2FiN2NjMTcyZTA5YzFjNTA5ZWQ1OWE2ZmU1MmE2Li44Mzc0Y2EwMzVi NjQ1MzdmOGVkYmY3ZGJkYjE3MjM5OGZjNjg4MGFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvVGhpcmRQ YXJ0eS9ndGVzdC94Y29kZS9Db25maWcvR2VuZXJhbC54Y2NvbmZpZworKysgYi9Tb3VyY2UvVGhp cmRQYXJ0eS9ndGVzdC94Y29kZS9Db25maWcvR2VuZXJhbC54Y2NvbmZpZwpAQCAtOCw2ICs4LDcg QEAKIC8vCiAKICNpbmNsdWRlPyAiLi4vLi4vLi4vLi4vLi4vLi4vSW50ZXJuYWwvQ29uZmlndXJh dGlvbnMvSGF2ZUludGVybmFsU0RLLnhjY29uZmlnIgorI2luY2x1ZGUgIjxERVZFTE9QRVJfRElS Pi9BcHBsZUludGVybmFsL1hjb2RlQ29uZmlnL1BsYXRmb3JtU3VwcG9ydC54Y2NvbmZpZyIKICNp bmNsdWRlICJTREtWYXJpYW50LnhjY29uZmlnIgogCiBVU0VfSU5URVJOQUxfU0RLID0gJChVU0Vf SU5URVJOQUxfU0RLXyQoQ09ORklHVVJBVElPTikpOwo= 421435 2021-02-24 11:51:01 -0800 2021-02-24 13:13:31 -0800 Patch bug-222346-20210224115100.patch text/plain 1495 thorton U3VidmVyc2lvbiBSZXZpc2lvbjogMjczMzcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvVGhpcmRQYXJ0 eS9DaGFuZ2VMb2cgYi9Tb3VyY2UvVGhpcmRQYXJ0eS9DaGFuZ2VMb2cKaW5kZXggOWFjMTY5MDJk ODZjMTk0YTNmMjQ0OTI4NzAxZTYxYzcxMWFkOWIwMC4uYzE0MDg2OWY4MmVjZDYwNTQzOTViMDk0 MTRlOWQwZDI4MTJkMGNiZiAxMDA2NDQKLS0tIGEvU291cmNlL1RoaXJkUGFydHkvQ2hhbmdlTG9n CisrKyBiL1NvdXJjZS9UaGlyZFBhcnR5L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIx LTAyLTIzICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgorCisgICAgICAg IEZpeCBsaW5rZXIgd2FybmluZ3MgYnVpbGRpbmcgZ3Rlc3QgZm9yIG1hY0NhdGFseXN0CisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjIzNDYKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzc0NDA1MTE2PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogZ3Rlc3QveGNvZGUvQ29uZmlnL0ZyYW1ld29ya1Rhcmdl dC54Y2NvbmZpZzoKKyAgICAgICAgKiBndGVzdC94Y29kZS9Db25maWcvR2VuZXJhbC54Y2NvbmZp ZzoKKyAgICAgICAgV29yayBhcm91bmQgYSBsaW5rZXIgd2FybmluZyBhYm91dCBtYWNDYXRhbHlz dCBieSBub3Qgc3BlY2lmeWluZworICAgICAgICBhbiBJTlNUQUxMX05BTUUgdGhhdCBpcyBvdXRz aWRlIG9mIC9TeXN0ZW0vaU9TU3VwcG9ydCwgd2hlcmUgYWxsCisgICAgICAgIG1hY0NhdGFseXN0 LW9ubHkgYmluYXJpZXMgbXVzdCBsaXZlLgorCiAyMDIxLTAxLTA4ICBSeWFuIEhvc3RldGxlciAg PHJob3N0QGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgc3VwcG9ydCBmb3Igc291cmNlIGNhY2hp bmcgYmV0d2VlbiBwbGF0Zm9ybXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9UaGlyZFBhcnR5L2d0ZXN0 L3hjb2RlL0NvbmZpZy9GcmFtZXdvcmtUYXJnZXQueGNjb25maWcgYi9Tb3VyY2UvVGhpcmRQYXJ0 eS9ndGVzdC94Y29kZS9Db25maWcvRnJhbWV3b3JrVGFyZ2V0LnhjY29uZmlnCmluZGV4IDdkMDI0 Y2QyOTQ4NjdjMTU3MzJiZTJlODljNzliODdlYmFlZGFmNDUuLjc3MDgxZmJjYjA1YTA2NTk2YWM3 NDE5ZGVlNDhhZjY0MzJlY2YzMWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9UaGlyZFBhcnR5L2d0ZXN0 L3hjb2RlL0NvbmZpZy9GcmFtZXdvcmtUYXJnZXQueGNjb25maWcKKysrIGIvU291cmNlL1RoaXJk UGFydHkvZ3Rlc3QveGNvZGUvQ29uZmlnL0ZyYW1ld29ya1RhcmdldC54Y2NvbmZpZwpAQCAtMTUs NSArMTUsMyBAQCBTVFJJUF9TVFlMRSA9IG5vbi1nbG9iYWwKIAogLy8gTGV0IHRoZSB1c2VyIGlu c3RhbGwgYnkgc3BlY2lmeWluZyB0aGUgJERTVFJPT1Qgd2l0aCB4Y29kZWJ1aWxkCiBTS0lQX0lO U1RBTEwgPSBOTwotCi1JTlNUQUxMX1BBVEggPSAkKFNZU1RFTV9MSUJSQVJZX0RJUikvUHJpdmF0 ZUZyYW1ld29ya3M7Cg==