222338 2021-02-23 16:44:34 -0800 [iOS] Add null checks for Node before accessing treeScope() in rangeForPointInRootViewCoordinates 2021-02-23 18:18:46 -0800 1 1 1 Unclassified WebKit HTML Editing WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wenson_hsieh wenson_hsieh hi megan_gardner thorton webkit-bug-importer wenson_hsieh oldest_to_newest 1732732 0 wenson_hsieh 2021-02-23 16:44:34 -0800 Speculative fix for <rdar://problem/72292289> 1732735 1 421370 wenson_hsieh 2021-02-23 17:04:26 -0800 Created attachment 421370 Patch 1732761 2 ews-feeder 2021-02-23 18:18:44 -0800 Committed r273367: <https://commits.webkit.org/r273367> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421370. 421370 2021-02-23 17:04:26 -0800 2021-02-23 18:18:45 -0800 Patch bug-222338-20210223170425.patch text/plain 3949 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjczMzA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDcxYTYzNzQ1NGQ1NGM3YjQ2 ZmNmZDUyZjNiZGI0ZjA0NmE1YTNmNjAuLjI2OWYzNWM4MzliOGYwNjRhZWExN2Q0OThiZTc5Nzli OWFmY2M3OTAgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMjEtMDItMjMgIFdlbnNvbiBI c2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gQWRkIG51bGwg Y2hlY2tzIGZvciBOb2RlIGJlZm9yZSBhY2Nlc3NpbmcgdHJlZVNjb3BlKCkgaW4gcmFuZ2VGb3JQ b2ludEluUm9vdFZpZXdDb29yZGluYXRlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MjIyMzM4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83MjI5MjI4 OT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQg YSBudWxsIGNoZWNrIGZvciB0aGUgaGl0IHRlc3QgcmVzdWx0J3MgYHRhcmdldE5vZGVgIGluc2lk ZSBgcmFuZ2VGb3JQb2ludEluUm9vdFZpZXdDb29yZGluYXRlcygpYCB0byBhdm9pZAorICAgICAg ICBjcmFzaGluZyBpbiB0aGUgY2FzZSB3aGVyZSB0aGUgdGFyZ2V0IG5vZGUgaXMgbnVsbCBhbmQg ZWl0aGVyIGByZXN1bHQgPD0gc2VsZWN0aW9uU3RhcnRgIGlzIGBmYWxzZWAgb3IKKyAgICAgICAg YHNlbGVjdGlvbkVuZCA8PSByZXN1bHRgIGlzIGBmYWxzZWAuCisKKyAgICAgICAgQWRkaXRpb25h bGx5LCBhdm9pZCBhIHBvdGVudGlhbCBudWxsIGRlcmVmIG9uIGBzZWxlY3Rpb25TdGFydC5kZWVw RXF1aXZhbGVudCgpLmFuY2hvck5vZGUoKWAgYW5kCisgICAgICAgIGBzZWxlY3Rpb25FbmQuZGVl cEVxdWl2YWxlbnQoKS5hbmNob3JOb2RlKClgIGJ5IHVzaW5nIGBQb3NpdGlvbjo6dHJlZVNjb3Bl KClgICh3aGljaCBudWxsIGNoZWNrcyB0aGUgYW5jaG9yCisgICAgICAgIG5vZGUpIGluc3RlYWQg b2YgZGlyZWN0bHkgYXNraW5nIHRoZSBhbmNob3Igbm9kZS4KKworICAgICAgICBOb3RlIHRoYXQg dGhlIGNhbGwgc2l0ZXMgb2YgYHJhbmdlRm9yUG9pbnRJblJvb3RWaWV3Q29vcmRpbmF0ZXMoKWAg YWxyZWFkeSBoYW5kbGUgYSBgV1RGOjpudWxsb3B0YCByZXR1cm4gdmFsdWUKKyAgICAgICAgZ3Jh Y2VmdWxseSwgYnkgc2tpcHBpbmcgdGhlIHNlbGVjdGlvbiB1cGRhdGUuCisKKyAgICAgICAgKiBX ZWJQcm9jZXNzL1dlYlBhZ2UvaW9zL1dlYlBhZ2VJT1MubW06CisgICAgICAgIChXZWJLaXQ6OnJh bmdlRm9yUG9pbnRJblJvb3RWaWV3Q29vcmRpbmF0ZXMpOgorCiAyMDIxLTAyLTIzICBXZW5zb24g SHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIEFkZCBhIHdh dGNoZG9nIHRpbWVyIHRvIGZvcmNpYmx5IHJlc2V0IGRlZmVycmluZyBnZXN0dXJlIHJlY29nbml6 ZXJzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9pb3MvV2Vi UGFnZUlPUy5tbSBiL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdl SU9TLm1tCmluZGV4IDI1ZDY2YmY0YmJlNTE5MjViOWRiOGYxMDAzZTUyZWVjZjAwMmRlNzcuLjZh Mjk0ZWJkOTUxZDc4OTcwYjBlYmQ1ZGQzMTMwYmI2ZDY3YjU3N2UgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCisrKyBiL1NvdXJj ZS9XZWJLaXQvV2ViUHJvY2Vzcy9XZWJQYWdlL2lvcy9XZWJQYWdlSU9TLm1tCkBAIC0xNTE4LDIz ICsxNTE4LDI0IEBAIHN0YXRpYyBPcHRpb25hbDxTaW1wbGVSYW5nZT4gcmFuZ2VGb3JQb2ludElu Um9vdFZpZXdDb29yZGluYXRlcyhGcmFtZSYgZnJhbWUsIGNvCiAgICAgT3B0aW9uYWw8U2ltcGxl UmFuZ2U+IHJhbmdlOwogCiAgICAgY29uc3RleHByIE9wdGlvblNldDxIaXRUZXN0UmVxdWVzdDo6 UmVxdWVzdFR5cGU+IGhpdFR5cGUgeyBIaXRUZXN0UmVxdWVzdDo6UmVhZE9ubHksIEhpdFRlc3RS ZXF1ZXN0OjpBY3RpdmUsIEhpdFRlc3RSZXF1ZXN0OjpBbGxvd1Zpc2libGVDaGlsZEZyYW1lQ29u dGVudE9ubHkgfTsKLSAgICBIaXRUZXN0UmVzdWx0IGhpdFRlc3QgPSBmcmFtZS5ldmVudEhhbmRs ZXIoKS5oaXRUZXN0UmVzdWx0QXRQb2ludChwb2ludEluRG9jdW1lbnQsIGhpdFR5cGUpOwotICAg IGlmIChoaXRUZXN0LnRhcmdldE5vZGUoKSkKLSAgICAgICAgcmVzdWx0ID0gZnJhbWUuZXZlbnRI YW5kbGVyKCkuc2VsZWN0aW9uRXh0ZW50UmVzcGVjdGluZ0VkaXRpbmdCb3VuZGFyeShmcmFtZS5z ZWxlY3Rpb24oKS5zZWxlY3Rpb24oKSwgaGl0VGVzdC5sb2NhbFBvaW50KCksIGhpdFRlc3QudGFy Z2V0Tm9kZSgpKS5kZWVwRXF1aXZhbGVudCgpOworICAgIGF1dG8gaGl0VGVzdCA9IGZyYW1lLmV2 ZW50SGFuZGxlcigpLmhpdFRlc3RSZXN1bHRBdFBvaW50KHBvaW50SW5Eb2N1bWVudCwgaGl0VHlw ZSk7CisgICAgYXV0byB0YXJnZXROb2RlID0gbWFrZVJlZlB0cihoaXRUZXN0LnRhcmdldE5vZGUo KSk7CisgICAgaWYgKHRhcmdldE5vZGUpCisgICAgICAgIHJlc3VsdCA9IGZyYW1lLmV2ZW50SGFu ZGxlcigpLnNlbGVjdGlvbkV4dGVudFJlc3BlY3RpbmdFZGl0aW5nQm91bmRhcnkoZnJhbWUuc2Vs ZWN0aW9uKCkuc2VsZWN0aW9uKCksIGhpdFRlc3QubG9jYWxQb2ludCgpLCB0YXJnZXROb2RlLmdl dCgpKS5kZWVwRXF1aXZhbGVudCgpOwogICAgIGVsc2UKICAgICAgICAgcmVzdWx0ID0gZnJhbWUu dmlzaWJsZVBvc2l0aW9uRm9yUG9pbnQocG9pbnRJbkRvY3VtZW50KS5kZWVwRXF1aXZhbGVudCgp OwogICAgIAogICAgIGlmIChiYXNlSXNTdGFydCkgewogICAgICAgICBpZiAocmVzdWx0IDw9IHNl bGVjdGlvblN0YXJ0KQogICAgICAgICAgICAgcmVzdWx0ID0gc2VsZWN0aW9uU3RhcnQubmV4dCgp OwotICAgICAgICBlbHNlIGlmICgmc2VsZWN0aW9uU3RhcnQuZGVlcEVxdWl2YWxlbnQoKS5hbmNo b3JOb2RlKCktPnRyZWVTY29wZSgpICE9ICZoaXRUZXN0LnRhcmdldE5vZGUoKS0+dHJlZVNjb3Bl KCkpCisgICAgICAgIGVsc2UgaWYgKHRhcmdldE5vZGUgJiYgc2VsZWN0aW9uU3RhcnQuZGVlcEVx dWl2YWxlbnQoKS50cmVlU2NvcGUoKSAhPSAmdGFyZ2V0Tm9kZS0+dHJlZVNjb3BlKCkpCiAgICAg ICAgICAgICByZXN1bHQgPSBWaXNpYmxlU2VsZWN0aW9uOjphZGp1c3RQb3NpdGlvbkZvckVuZChy ZXN1bHQuZGVlcEVxdWl2YWxlbnQoKSwgc2VsZWN0aW9uU3RhcnQuZGVlcEVxdWl2YWxlbnQoKS5j b250YWluZXJOb2RlKCkpOwogCiAgICAgICAgIHJhbmdlID0gbWFrZVNpbXBsZVJhbmdlKHNlbGVj dGlvblN0YXJ0LCByZXN1bHQpOwogICAgIH0gZWxzZSB7CiAgICAgICAgIGlmIChzZWxlY3Rpb25F bmQgPD0gcmVzdWx0KQogICAgICAgICAgICAgcmVzdWx0ID0gc2VsZWN0aW9uRW5kLnByZXZpb3Vz KCk7Ci0gICAgICAgIGVsc2UgaWYgKCZoaXRUZXN0LnRhcmdldE5vZGUoKS0+dHJlZVNjb3BlKCkg IT0gJnNlbGVjdGlvbkVuZC5kZWVwRXF1aXZhbGVudCgpLmFuY2hvck5vZGUoKS0+dHJlZVNjb3Bl KCkpCisgICAgICAgIGVsc2UgaWYgKHRhcmdldE5vZGUgJiYgc2VsZWN0aW9uRW5kLmRlZXBFcXVp dmFsZW50KCkudHJlZVNjb3BlKCkgIT0gJnRhcmdldE5vZGUtPnRyZWVTY29wZSgpKQogICAgICAg ICAgICAgcmVzdWx0ID0gVmlzaWJsZVNlbGVjdGlvbjo6YWRqdXN0UG9zaXRpb25Gb3JTdGFydChy ZXN1bHQuZGVlcEVxdWl2YWxlbnQoKSwgc2VsZWN0aW9uRW5kLmRlZXBFcXVpdmFsZW50KCkuY29u dGFpbmVyTm9kZSgpKTsKIAogICAgICAgICByYW5nZSA9IG1ha2VTaW1wbGVSYW5nZShyZXN1bHQs IHNlbGVjdGlvbkVuZCk7Cg==