222327 2021-02-23 11:38:35 -0800 Only import Python flatpak module on Linux 2021-02-24 06:02:16 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 221815 1 don.olmstead don.olmstead aperez clopez jbedard pnormand webkit-bug-importer zdobersek oldest_to_newest 1732632 0 don.olmstead 2021-02-23 11:38:35 -0800 Can't import it on Windows. 1732651 1 421341 don.olmstead 2021-02-23 12:28:48 -0800 Created attachment 421341 Patch 1732679 2 421341 jbedard 2021-02-23 13:43:55 -0800 Comment on attachment 421341 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421341&action=review > Tools/Scripts/run-bindings-tests:-39 > -flatpakutils.run_in_sandbox_if_available(sys.argv) Looks like flatpakutils already centralizes the linux check...can we not fix this Windows problem there? 1732747 3 421341 don.olmstead 2021-02-23 17:29:25 -0800 Comment on attachment 421341 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421341&action=review >> Tools/Scripts/run-bindings-tests:-39 >> -flatpakutils.run_in_sandbox_if_available(sys.argv) > > Looks like flatpakutils already centralizes the linux check...can we not fix this Windows problem there? I commented on the change that caused the issue at https://bugs.webkit.org/show_bug.cgi?id=222247#c4 which has the error. In this case it’s another issue of the signal library having differences between *nix and Windows. Honestly I think it’s safer in the long run for importing flatpack to be conditional on Linux since it’s really tied to that OS. 1732853 4 ews-feeder 2021-02-24 06:01:11 -0800 Committed r273384: <https://commits.webkit.org/r273384> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421341. 1732854 5 webkit-bug-importer 2021-02-24 06:02:16 -0800 <rdar://problem/74692332> 421341 2021-02-23 12:28:48 -0800 2021-02-24 06:01:13 -0800 Patch bug-222327.diff text/plain 7136 don.olmstead ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA2Y2Yz ZTRmYTRlMmUuLmIwYzM4YmJhNjI1NSAxMDA2NDQKLS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBi L1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIxLTAyLTIzICBEb24gT2xtc3Rl YWQgIDxkb24ub2xtc3RlYWRAc29ueS5jb20+CisKKyAgICAgICAgT25seSBpbXBvcnQgUHl0aG9u IGZsYXRwYWsgbW9kdWxlIG9uIExpbnV4CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0yMjIzMjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBJbXBvcnRpbmcgZmxhdHBhayBpcyBvbmx5IHJlbGF2ZW50IGZvciBH VEsvV1BFIHBvcnRzLiBBbHNvIFdpbmRvd3MgY2FuIGZhaWwgd2hlbiBpbXBvcnRpbmcKKyAgICAg ICAgaXQgZHVlIHRvIHBsYXRmb3JtIGRpZmZlcmVuY2VzLgorCisgICAgICAgICogU2NyaXB0cy9y dW4tYmluZGluZ3MtdGVzdHM6CisgICAgICAgICogU2NyaXB0cy9ydW4tYnVpbHRpbnMtZ2VuZXJh dG9yLXRlc3RzOgorICAgICAgICAqIFNjcmlwdHMvcnVuLW1pbmlicm93c2VyOgorICAgICAgICAq IFNjcmlwdHMvcnVuLXBlcmYtdGVzdHM6CisgICAgICAgICogU2NyaXB0cy9ydW4td2Via2l0LWh0 dHBkOgorICAgICAgICAqIFNjcmlwdHMvcnVuLXdlYmtpdC10ZXN0czoKKyAgICAgICAgKiBTY3Jp cHRzL3Rlc3Qtd2Via2l0cHk6CisKIDIwMjEtMDItMjMgIENvbW1pdCBRdWV1ZSAgPGNvbW1pdC1x dWV1ZUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQsIHJldmVydGluZyByMjczMzA3 LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4tYmluZGluZ3MtdGVzdHMgYi9Ub29scy9T Y3JpcHRzL3J1bi1iaW5kaW5ncy10ZXN0cwppbmRleCAwYWMwYjNhMzEwODguLjZjZTU0M2EwZjJi MCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tYmluZGluZ3MtdGVzdHMKKysrIGIvVG9v bHMvU2NyaXB0cy9ydW4tYmluZGluZ3MtdGVzdHMKQEAgLTMzLDEwICszMywxMiBAQCBpbXBvcnQg b3MKIGltcG9ydCBzeXMKIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbSBpbXBvcnQgZXhlY3V0 aXZlCiAKLXRvcF9sZXZlbF9kaXJlY3RvcnkgPSBvcy5wYXRoLm5vcm1wYXRoKG9zLnBhdGguam9p bihvcy5wYXRoLmRpcm5hbWUoX19maWxlX18pLCAnLi4nLCAnLi4nKSkKLXN5cy5wYXRoLmluc2Vy dCgwLCBvcy5wYXRoLmpvaW4odG9wX2xldmVsX2RpcmVjdG9yeSwgJ1Rvb2xzJywgJ2ZsYXRwYWsn KSkKLWltcG9ydCBmbGF0cGFrdXRpbHMKLWZsYXRwYWt1dGlscy5ydW5faW5fc2FuZGJveF9pZl9h dmFpbGFibGUoc3lzLmFyZ3YpCitpZiBzeXMucGxhdGZvcm0uc3RhcnRzd2l0aCgnbGludXgnKToK KyAgICB0b3BfbGV2ZWxfZGlyZWN0b3J5ID0gb3MucGF0aC5ub3JtcGF0aChvcy5wYXRoLmpvaW4o b3MucGF0aC5kaXJuYW1lKF9fZmlsZV9fKSwgJy4uJywgJy4uJykpCisgICAgc3lzLnBhdGguaW5z ZXJ0KDAsIG9zLnBhdGguam9pbih0b3BfbGV2ZWxfZGlyZWN0b3J5LCAnVG9vbHMnLCAnZmxhdHBh aycpKQorCisgICAgaW1wb3J0IGZsYXRwYWt1dGlscworICAgIGZsYXRwYWt1dGlscy5ydW5faW5f c2FuZGJveF9pZl9hdmFpbGFibGUoc3lzLmFyZ3YpCiAKIGRlZiBtYWluKGFyZ3YpOgogICAgICIi IlJ1bnMgV2ViQ29yZSBiaW5kaW5ncyBjb2RlIGdlbmVyYXRvcnMgb24gdGVzdCBJREwgZmlsZXMg YW5kIGNvbXBhcmVzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1idWlsdGlucy1nZW5l cmF0b3ItdGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi1idWlsdGlucy1nZW5lcmF0b3ItdGVzdHMK aW5kZXggZmJiMDg2NDI0MTk3Li5mMTUyMzE1YTEzNGMgMTAwNzU1Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvcnVuLWJ1aWx0aW5zLWdlbmVyYXRvci10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1i dWlsdGlucy1nZW5lcmF0b3ItdGVzdHMKQEAgLTI1LDExICsyNSwxMyBAQAogaW1wb3J0IHN5cwog ZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVtIGltcG9ydCBleGVjdXRpdmUKIAotaW1wb3J0IG9z Ci10b3BfbGV2ZWxfZGlyZWN0b3J5ID0gb3MucGF0aC5ub3JtcGF0aChvcy5wYXRoLmpvaW4ob3Mu cGF0aC5kaXJuYW1lKF9fZmlsZV9fKSwgJy4uJywgJy4uJykpCi1zeXMucGF0aC5pbnNlcnQoMCwg b3MucGF0aC5qb2luKHRvcF9sZXZlbF9kaXJlY3RvcnksICdUb29scycsICdmbGF0cGFrJykpCi1p bXBvcnQgZmxhdHBha3V0aWxzCi1mbGF0cGFrdXRpbHMucnVuX2luX3NhbmRib3hfaWZfYXZhaWxh YmxlKHN5cy5hcmd2KQoraWYgc3lzLnBsYXRmb3JtLnN0YXJ0c3dpdGgoJ2xpbnV4Jyk6CisgICAg aW1wb3J0IG9zCisgICAgdG9wX2xldmVsX2RpcmVjdG9yeSA9IG9zLnBhdGgubm9ybXBhdGgob3Mu cGF0aC5qb2luKG9zLnBhdGguZGlybmFtZShfX2ZpbGVfXyksICcuLicsICcuLicpKQorICAgIHN5 cy5wYXRoLmluc2VydCgwLCBvcy5wYXRoLmpvaW4odG9wX2xldmVsX2RpcmVjdG9yeSwgJ1Rvb2xz JywgJ2ZsYXRwYWsnKSkKKworICAgIGltcG9ydCBmbGF0cGFrdXRpbHMKKyAgICBmbGF0cGFrdXRp bHMucnVuX2luX3NhbmRib3hfaWZfYXZhaWxhYmxlKHN5cy5hcmd2KQogCiBkZWYgbWFpbihhcmd2 KToKICAgICAiIiJSdW5zIHRoZSBKUyBidWlsdGlucyBjb2RlIGdlbmVyYXRvciBvbiB0ZXN0IGlu cHV0IGZpbGVzIGFuZCBjb21wYXJlcwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4tbWlu aWJyb3dzZXIgYi9Ub29scy9TY3JpcHRzL3J1bi1taW5pYnJvd3NlcgppbmRleCA1OWY1NGYwNTBl MDIuLjVjODgwOTcyODE3MiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tbWluaWJyb3dz ZXIKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tbWluaWJyb3dzZXIKQEAgLTE3LDEzICsxNywxNCBA QAogIyBCb3N0b24sIE1BIDAyMTEwLTEzMDEsIFVTQS4KIAogIiIiV3JhcHBlciBhcm91bmQgd2Vi a2l0cHkvbWluaWJyb3dzZXIvcnVuX3dlYmtpdF9hcHAucHkiIiIKLWltcG9ydCBvcwogaW1wb3J0 IHN5cwogZnJvbSB3ZWJraXRweS5taW5pYnJvd3NlciBpbXBvcnQgcnVuX3dlYmtpdF9hcHAKIAot dG9wX2xldmVsX2RpcmVjdG9yeSA9IG9zLnBhdGgubm9ybXBhdGgob3MucGF0aC5qb2luKG9zLnBh dGguZGlybmFtZShfX2ZpbGVfXyksICcuLicsICcuLicpKQogaWYgc3lzLnBsYXRmb3JtLnN0YXJ0 c3dpdGgoJ2xpbnV4Jyk6CisgICAgaW1wb3J0IG9zCisgICAgdG9wX2xldmVsX2RpcmVjdG9yeSA9 IG9zLnBhdGgubm9ybXBhdGgob3MucGF0aC5qb2luKG9zLnBhdGguZGlybmFtZShfX2ZpbGVfXyks ICcuLicsICcuLicpKQogICAgIHN5cy5wYXRoLmluc2VydCgwLCBvcy5wYXRoLmpvaW4odG9wX2xl dmVsX2RpcmVjdG9yeSwgJ1Rvb2xzJywgJ2ZsYXRwYWsnKSkKKwogICAgIGltcG9ydCBmbGF0cGFr dXRpbHMKICAgICBmbGF0cGFrdXRpbHMucnVuX2luX3NhbmRib3hfaWZfYXZhaWxhYmxlKHN5cy5h cmd2KQogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi1wZXJmLXRlc3RzIGIvVG9vbHMv U2NyaXB0cy9ydW4tcGVyZi10ZXN0cwppbmRleCBjMGQ4NzgzZTZjMTYuLmRlYmI1ZDZmMTM5MSAx MDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tcGVyZi10ZXN0cworKysgYi9Ub29scy9TY3Jp cHRzL3J1bi1wZXJmLXRlc3RzCkBAIC0zMCwxMyArMzAsMTUgQEAKICIiIlJ1biBwZXJmb3JtYW5j ZSB0ZXN0cy4iIiIKIAogaW1wb3J0IGxvZ2dpbmcKLWltcG9ydCBvcwogaW1wb3J0IHN5cwogCi10 b3BfbGV2ZWxfZGlyZWN0b3J5ID0gb3MucGF0aC5ub3JtcGF0aChvcy5wYXRoLmpvaW4ob3MucGF0 aC5kaXJuYW1lKF9fZmlsZV9fKSwgJy4uJywgJy4uJykpCi1zeXMucGF0aC5pbnNlcnQoMCwgb3Mu cGF0aC5qb2luKHRvcF9sZXZlbF9kaXJlY3RvcnksICdUb29scycsICdmbGF0cGFrJykpCi1pbXBv cnQgZmxhdHBha3V0aWxzCi1mbGF0cGFrdXRpbHMucnVuX2luX3NhbmRib3hfaWZfYXZhaWxhYmxl KHN5cy5hcmd2KQoraWYgc3lzLnBsYXRmb3JtLnN0YXJ0c3dpdGgoJ2xpbnV4Jyk6CisgICAgaW1w b3J0IG9zCisgICAgdG9wX2xldmVsX2RpcmVjdG9yeSA9IG9zLnBhdGgubm9ybXBhdGgob3MucGF0 aC5qb2luKG9zLnBhdGguZGlybmFtZShfX2ZpbGVfXyksICcuLicsICcuLicpKQorICAgIHN5cy5w YXRoLmluc2VydCgwLCBvcy5wYXRoLmpvaW4odG9wX2xldmVsX2RpcmVjdG9yeSwgJ1Rvb2xzJywg J2ZsYXRwYWsnKSkKKworICAgIGltcG9ydCBmbGF0cGFrdXRpbHMKKyAgICBmbGF0cGFrdXRpbHMu cnVuX2luX3NhbmRib3hfaWZfYXZhaWxhYmxlKHN5cy5hcmd2KQogCiBmcm9tIHdlYmtpdHB5LnBl cmZvcm1hbmNlX3Rlc3RzLnBlcmZ0ZXN0c3J1bm5lciBpbXBvcnQgUGVyZlRlc3RzUnVubmVyCiAK ZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC1odHRwZCBiL1Rvb2xzL1Njcmlw dHMvcnVuLXdlYmtpdC1odHRwZAppbmRleCBlZTAwODhjZjZhOTYuLmIwMThmNDY3ZjA3OCAxMDA3 NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4td2Via2l0LWh0dHBkCisrKyBiL1Rvb2xzL1Njcmlw dHMvcnVuLXdlYmtpdC1odHRwZApAQCAtMjgsMTUgKzI4LDE1IEBACiAjIChJTkNMVURJTkcgTkVH TElHRU5DRSBPUiBPVEhFUldJU0UpIEFSSVNJTkcgSU4gQU5ZIFdBWSBPVVQgT0YgVEhFIFVTRSBP RgogIyBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9G IFNVQ0ggREFNQUdFLgogCi1pbXBvcnQgb3MKIGltcG9ydCBzeXMKIAogZnJvbSB3ZWJraXRweS5s YXlvdXRfdGVzdHMuc2VydmVycy5ydW5fd2Via2l0X2h0dHBkIGltcG9ydCBwYXJzZV9hcmdzLCBy dW5fc2VydmVyCiAKLQotdG9wX2xldmVsX2RpcmVjdG9yeSA9IG9zLnBhdGgubm9ybXBhdGgob3Mu cGF0aC5qb2luKG9zLnBhdGguZGlybmFtZShfX2ZpbGVfXyksICcuLicsICcuLicpKQogaWYgc3lz LnBsYXRmb3JtLnN0YXJ0c3dpdGgoJ2xpbnV4Jyk6CisgICAgaW1wb3J0IG9zCisgICAgdG9wX2xl dmVsX2RpcmVjdG9yeSA9IG9zLnBhdGgubm9ybXBhdGgob3MucGF0aC5qb2luKG9zLnBhdGguZGly bmFtZShfX2ZpbGVfXyksICcuLicsICcuLicpKQogICAgIHN5cy5wYXRoLmluc2VydCgwLCBvcy5w YXRoLmpvaW4odG9wX2xldmVsX2RpcmVjdG9yeSwgJ1Rvb2xzJywgJ2ZsYXRwYWsnKSkKKwogICAg IGltcG9ydCBmbGF0cGFrdXRpbHMKICAgICBmbGF0cGFrdXRpbHMucnVuX2luX3NhbmRib3hfaWZf YXZhaWxhYmxlKHN5cy5hcmd2KQogCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1bi13ZWJr aXQtdGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMKaW5kZXggNTk2YTJjNzFi NDcxLi5lODlmNWI4OGQ0YzAgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvcnVuLXdlYmtpdC10 ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi13ZWJraXQtdGVzdHMKQEAgLTMwLDE0ICszMCwx NSBAQAogIyBPRiBUSElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklM SVRZIE9GIFNVQ0ggREFNQUdFLgogCiAiIiJXcmFwcGVyIGFyb3VuZCB3ZWJraXRweS9sYXlvdXRf dGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5weSIiIgotaW1wb3J0IG9zCiBpbXBvcnQgc3lzCiAKIGZy b20gd2Via2l0cHkuY29tbW9uIGltcG9ydCBtdWx0aXByb2Nlc3NpbmdfYm9vdHN0cmFwCiAKLXRv cF9sZXZlbF9kaXJlY3RvcnkgPSBvcy5wYXRoLm5vcm1wYXRoKG9zLnBhdGguam9pbihvcy5wYXRo LmRpcm5hbWUoX19maWxlX18pLCAnLi4nLCAnLi4nKSkKIGlmIHN5cy5wbGF0Zm9ybS5zdGFydHN3 aXRoKCdsaW51eCcpOgorICAgIGltcG9ydCBvcworICAgIHRvcF9sZXZlbF9kaXJlY3RvcnkgPSBv cy5wYXRoLm5vcm1wYXRoKG9zLnBhdGguam9pbihvcy5wYXRoLmRpcm5hbWUoX19maWxlX18pLCAn Li4nLCAnLi4nKSkKICAgICBzeXMucGF0aC5pbnNlcnQoMCwgb3MucGF0aC5qb2luKHRvcF9sZXZl bF9kaXJlY3RvcnksICdUb29scycsICdmbGF0cGFrJykpCisKICAgICBpbXBvcnQgZmxhdHBha3V0 aWxzCiAgICAgZmxhdHBha3V0aWxzLnJ1bl9pbl9zYW5kYm94X2lmX2F2YWlsYWJsZShzeXMuYXJn dikKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy90ZXN0LXdlYmtpdHB5IGIvVG9vbHMvU2Ny aXB0cy90ZXN0LXdlYmtpdHB5CmluZGV4IGI0NjBiMTJmYzJlYS4uNmE5MGJhZjg3YjQ1IDEwMDc1 NQotLS0gYS9Ub29scy9TY3JpcHRzL3Rlc3Qtd2Via2l0cHkKKysrIGIvVG9vbHMvU2NyaXB0cy90 ZXN0LXdlYmtpdHB5CkBAIC0yOSwxMCArMjksMTQgQEAKICMgT0YgVEhJUyBTT0ZUV0FSRSwgRVZF TiBJRiBBRFZJU0VEIE9GIFRIRSBQT1NTSUJJTElUWSBPRiBTVUNIIERBTUFHRS4KIGZyb20gd2Vi a2l0cHkuY29tbW9uIGltcG9ydCBtdWx0aXByb2Nlc3NpbmdfYm9vdHN0cmFwCiAKLWltcG9ydCBv cywgc3lzCi10b3BfbGV2ZWxfZGlyZWN0b3J5ID0gb3MucGF0aC5ub3JtcGF0aChvcy5wYXRoLmpv aW4ob3MucGF0aC5kaXJuYW1lKF9fZmlsZV9fKSwgJy4uJywgJy4uJykpCi1zeXMucGF0aC5pbnNl cnQoMCwgb3MucGF0aC5qb2luKHRvcF9sZXZlbF9kaXJlY3RvcnksICdUb29scycsICdmbGF0cGFr JykpCi1pbXBvcnQgZmxhdHBha3V0aWxzCi1mbGF0cGFrdXRpbHMucnVuX2luX3NhbmRib3hfaWZf YXZhaWxhYmxlKHN5cy5hcmd2KQoraW1wb3J0IHN5cworCitpZiBzeXMucGxhdGZvcm0uc3RhcnRz d2l0aCgnbGludXgnKToKKyAgICBpbXBvcnQgb3MKKyAgICB0b3BfbGV2ZWxfZGlyZWN0b3J5ID0g b3MucGF0aC5ub3JtcGF0aChvcy5wYXRoLmpvaW4ob3MucGF0aC5kaXJuYW1lKF9fZmlsZV9fKSwg Jy4uJywgJy4uJykpCisgICAgc3lzLnBhdGguaW5zZXJ0KDAsIG9zLnBhdGguam9pbih0b3BfbGV2 ZWxfZGlyZWN0b3J5LCAnVG9vbHMnLCAnZmxhdHBhaycpKQorCisgICAgaW1wb3J0IGZsYXRwYWt1 dGlscworICAgIGZsYXRwYWt1dGlscy5ydW5faW5fc2FuZGJveF9pZl9hdmFpbGFibGUoc3lzLmFy Z3YpCiAKIG11bHRpcHJvY2Vzc2luZ19ib290c3RyYXAucnVuKCd3ZWJraXRweScsICd0ZXN0Jywg J21haW4ucHknKQo=