222323 2021-02-23 10:47:10 -0800 Fix model test differences between platforms 2021-02-24 12:12:02 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 sam sam ap darin koivisto rniwa simon.fraser webkit-bug-importer zalan oldest_to_newest 1732597 0 sam 2021-02-23 10:47:10 -0800 Fix model test differences between platforms - see https://bugs.webkit.org/show_bug.cgi?id=222114#c7. 1732624 1 421334 sam 2021-02-23 11:20:11 -0800 Created attachment 421334 Patch 1732625 2 421335 sam 2021-02-23 11:22:13 -0800 Created attachment 421335 Patch 1732666 3 421335 darin 2021-02-23 13:05:06 -0800 Comment on attachment 421335 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421335&action=review > LayoutTests/ChangeLog:10 > + Try to fix these on iOS by removing the doctype. Wow, why does that matter? 1732778 4 ews-feeder 2021-02-23 21:34:24 -0800 Committed r273372: <https://commits.webkit.org/r273372> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421335. 1732779 5 webkit-bug-importer 2021-02-23 21:35:17 -0800 <rdar://problem/74678133> 1732788 6 ap 2021-02-23 22:09:57 -0800 I'm also very interested in an answer to Darin's question. 1732885 7 sam 2021-02-24 08:44:27 -0800 Re-opening, because the test is now skipped. 1732888 8 421413 sam 2021-02-24 08:45:55 -0800 Created attachment 421413 Patch 1732891 9 sam 2021-02-24 08:50:01 -0800 (In reply to Darin Adler from comment #3) > Comment on attachment 421335 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=421335&action=review > > > LayoutTests/ChangeLog:10 > > + Try to fix these on iOS by removing the doctype. > > Wow, why does that matter? I'm not sure it does. Was putting the patch up to see. (I don't have a usable iOS currently to test it myself). On slack, there was discussion about why iOS and macOS would have different render trees for this very simple test, and there wasn't a conclusive answer. Maybe something about rounding? I filed https://bugs.webkit.org/show_bug.cgi?id=222362 to track figuring it out. 1732973 10 sam 2021-02-24 11:09:07 -0800 Antti, Alan, Simon, did any of you have an explanation of why iOS and macOS are different in the end? 1732975 11 zalan 2021-02-24 11:10:14 -0800 (In reply to Sam Weinig from comment #10) > Antti, Alan, Simon, did any of you have an explanation of why iOS and macOS > are different in the end? I would need to debug this but I don't have a working iOS sim atm. 1732984 12 zalan 2021-02-24 11:18:22 -0800 (In reply to Darin Adler from comment #3) > Comment on attachment 421335 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=421335&action=review > > > LayoutTests/ChangeLog:10 > > + Try to fix these on iOS by removing the doctype. > > Wow, why does that matter? Removing the doctype puts the document in non-standards mode which makes the descent on the line collapse. It means that the line is only stretched by the replaced box and since the box sits on the baseline and has no descent, the line is going to be as tall as the replaced box is. In standards mode the line is also stretched by the root inline box which has the default font's descent. (Now I just need to figure out if we produce different geometries on iOS because of some odd rounding mismatching or font differences) 1733016 13 ews-feeder 2021-02-24 12:11:59 -0800 Committed r273421: <https://commits.webkit.org/r273421> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421413. 421334 2021-02-23 11:20:11 -0800 2021-02-23 11:22:12 -0800 Patch bug-222323-20210223112010.patch text/plain 1689 sam SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI3MzMxOCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDIxLTAyLTIzICBTYW0gV2VpbmlnICA8d2Vp bmlnQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggbW9kZWwgdGVzdCBkaWZmZXJlbmNlcyBiZXR3 ZWVuIHBsYXRmb3JtcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjIyMzIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBtb2RlbC1lbGVtZW50L21vZGVsLWVsZW1lbnQtcmVuZGVyZXItbm8tc291cmNlLmh0 bWw6CisgICAgICAgICogbW9kZWwtZWxlbWVudC9tb2RlbC1lbGVtZW50LXJlbmRlcmVyLmh0bWw6 CisgICAgICAgIFRyeSB0byBmaXggdGhlc2Ugb24gaU9TIGJ5IHJlbW92aW5nIHRoZSBkb2N0eXBl LgorCiAyMDIxLTAyLTIyICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAg ICAgICAgIFtCaWdTdXJdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1j b3VudGVyLXN0eWxlcy90aWJldGFuL2NzczMtY291bnRlci1zdHlsZXMtMTU2Lmh0bWwgaXMgY29u c2lzdGVudGx5IGZhaWxpbmcKSW5kZXg6IExheW91dFRlc3RzL21vZGVsLWVsZW1lbnQvbW9kZWwt ZWxlbWVudC1yZW5kZXJlci1uby1zb3VyY2UuaHRtbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9tb2RlbC1lbGVtZW50L21vZGVsLWVsZW1lbnQtcmVuZGVyZXItbm8tc291cmNlLmh0bWwJKHJl dmlzaW9uIDI3MzMwNikKKysrIExheW91dFRlc3RzL21vZGVsLWVsZW1lbnQvbW9kZWwtZWxlbWVu dC1yZW5kZXJlci1uby1zb3VyY2UuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMSw0ICsxLDQgQEAK LTwhRE9DVFlQRSBodG1sPjwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsgTW9kZWxFbGVtZW50RW5h YmxlZD10cnVlIF0gLS0+Cis8IS0tIHdlYmtpdC10ZXN0LXJ1bm5lciBbIE1vZGVsRWxlbWVudEVu YWJsZWQ9dHJ1ZSBdIC0tPgogPGh0bWw+CiA8Ym9keT4KIDxtb2RlbD4KSW5kZXg6IExheW91dFRl c3RzL21vZGVsLWVsZW1lbnQvbW9kZWwtZWxlbWVudC1yZW5kZXJlci5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL21vZGVsLWVsZW1lbnQvbW9kZWwtZWxlbWVudC1yZW5kZXJlci5odG1s CShyZXZpc2lvbiAyNzMzMDYpCisrKyBMYXlvdXRUZXN0cy9tb2RlbC1lbGVtZW50L21vZGVsLWVs ZW1lbnQtcmVuZGVyZXIuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMSw0ICsxLDQgQEAKLTwhRE9D VFlQRSBodG1sPjwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsgTW9kZWxFbGVtZW50RW5hYmxlZD10 cnVlIF0gLS0+Cis8IS0tIHdlYmtpdC10ZXN0LXJ1bm5lciBbIE1vZGVsRWxlbWVudEVuYWJsZWQ9 dHJ1ZSBdIC0tPgogPGh0bWw+CiA8Ym9keT4KIDxtb2RlbD4K 421335 2021-02-23 11:22:13 -0800 2021-02-24 08:45:53 -0800 Patch bug-222323-20210223112212.patch text/plain 3143 sam SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI3MzMxOCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDIxLTAyLTIzICBTYW0gV2VpbmlnICA8d2Vp bmlnQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggbW9kZWwgdGVzdCBkaWZmZXJlbmNlcyBiZXR3 ZWVuIHBsYXRmb3JtcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjIyMzIzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBtb2RlbC1lbGVtZW50L21vZGVsLWVsZW1lbnQtcmVuZGVyZXItbm8tc291cmNlLmh0 bWw6CisgICAgICAgICogbW9kZWwtZWxlbWVudC9tb2RlbC1lbGVtZW50LXJlbmRlcmVyLmh0bWw6 CisgICAgICAgIFRyeSB0byBmaXggdGhlc2Ugb24gaU9TIGJ5IHJlbW92aW5nIHRoZSBkb2N0eXBl LgorCiAyMDIxLTAyLTIyICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAg ICAgICAgIFtCaWdTdXJdIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvY3NzL2Nzcy1j b3VudGVyLXN0eWxlcy90aWJldGFuL2NzczMtY291bnRlci1zdHlsZXMtMTU2Lmh0bWwgaXMgY29u c2lzdGVudGx5IGZhaWxpbmcKSW5kZXg6IExheW91dFRlc3RzL21vZGVsLWVsZW1lbnQvbW9kZWwt ZWxlbWVudC1yZW5kZXJlci1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv bW9kZWwtZWxlbWVudC9tb2RlbC1lbGVtZW50LXJlbmRlcmVyLWV4cGVjdGVkLnR4dAkocmV2aXNp b24gMjczMzA2KQorKysgTGF5b3V0VGVzdHMvbW9kZWwtZWxlbWVudC9tb2RlbC1lbGVtZW50LXJl bmRlcmVyLWV4cGVjdGVkLnR4dAkod29ya2luZyBjb3B5KQpAQCAtMSw3ICsxLDcgQEAKIGxheWVy IGF0ICgwLDApIHNpemUgODAweDYwMAogICBSZW5kZXJWaWV3IGF0ICgwLDApIHNpemUgODAweDYw MAotbGF5ZXIgYXQgKDAsMCkgc2l6ZSA4MDB4MTcwCi0gIFJlbmRlckJsb2NrIHtIVE1MfSBhdCAo MCwwKSBzaXplIDgwMHgxNzAKLSAgICBSZW5kZXJCb2R5IHtCT0RZfSBhdCAoOCw4KSBzaXplIDc4 NHgxNTQKK2xheWVyIGF0ICgwLDApIHNpemUgODAweDYwMAorICBSZW5kZXJCbG9jayB7SFRNTH0g YXQgKDAsMCkgc2l6ZSA4MDB4NjAwCisgICAgUmVuZGVyQm9keSB7Qk9EWX0gYXQgKDgsOCkgc2l6 ZSA3ODR4NTg0CiAgICAgICBSZW5kZXJNb2RlbCB7TU9ERUx9IGF0ICgwLDApIHNpemUgMzAweDE1 MAogICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUgMHgwCkluZGV4OiBMYXlv dXRUZXN0cy9tb2RlbC1lbGVtZW50L21vZGVsLWVsZW1lbnQtcmVuZGVyZXItbm8tc291cmNlLWV4 cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9tb2RlbC1lbGVtZW50L21vZGVs LWVsZW1lbnQtcmVuZGVyZXItbm8tc291cmNlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMjczMzA2 KQorKysgTGF5b3V0VGVzdHMvbW9kZWwtZWxlbWVudC9tb2RlbC1lbGVtZW50LXJlbmRlcmVyLW5v LXNvdXJjZS1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTEsNyArMSw3IEBACiBsYXll ciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKICAgUmVuZGVyVmlldyBhdCAoMCwwKSBzaXplIDgwMHg2 MDAKLWxheWVyIGF0ICgwLDApIHNpemUgODAweDE3MAotICBSZW5kZXJCbG9jayB7SFRNTH0gYXQg KDAsMCkgc2l6ZSA4MDB4MTcwCi0gICAgUmVuZGVyQm9keSB7Qk9EWX0gYXQgKDgsOCkgc2l6ZSA3 ODR4MTU0CitsYXllciBhdCAoMCwwKSBzaXplIDgwMHg2MDAKKyAgUmVuZGVyQmxvY2sge0hUTUx9 IGF0ICgwLDApIHNpemUgODAweDYwMAorICAgIFJlbmRlckJvZHkge0JPRFl9IGF0ICg4LDgpIHNp emUgNzg0eDU4NAogICAgICAgUmVuZGVyTW9kZWwge01PREVMfSBhdCAoMCwwKSBzaXplIDMwMHgx NTAKICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXplIDB4MApJbmRleDogTGF5 b3V0VGVzdHMvbW9kZWwtZWxlbWVudC9tb2RlbC1lbGVtZW50LXJlbmRlcmVyLW5vLXNvdXJjZS5o dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL21vZGVsLWVsZW1lbnQvbW9kZWwtZWxlbWVu dC1yZW5kZXJlci1uby1zb3VyY2UuaHRtbAkocmV2aXNpb24gMjczMzA2KQorKysgTGF5b3V0VGVz dHMvbW9kZWwtZWxlbWVudC9tb2RlbC1lbGVtZW50LXJlbmRlcmVyLW5vLXNvdXJjZS5odG1sCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsNCBAQAotPCFET0NUWVBFIGh0bWw+PCEtLSB3ZWJraXQt dGVzdC1ydW5uZXIgWyBNb2RlbEVsZW1lbnRFbmFibGVkPXRydWUgXSAtLT4KKzwhLS0gd2Via2l0 LXRlc3QtcnVubmVyIFsgTW9kZWxFbGVtZW50RW5hYmxlZD10cnVlIF0gLS0+CiA8aHRtbD4KIDxi b2R5PgogPG1vZGVsPgpJbmRleDogTGF5b3V0VGVzdHMvbW9kZWwtZWxlbWVudC9tb2RlbC1lbGVt ZW50LXJlbmRlcmVyLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvbW9kZWwtZWxlbWVu dC9tb2RlbC1lbGVtZW50LXJlbmRlcmVyLmh0bWwJKHJldmlzaW9uIDI3MzMwNikKKysrIExheW91 dFRlc3RzL21vZGVsLWVsZW1lbnQvbW9kZWwtZWxlbWVudC1yZW5kZXJlci5odG1sCSh3b3JraW5n IGNvcHkpCkBAIC0xLDQgKzEsNCBAQAotPCFET0NUWVBFIGh0bWw+PCEtLSB3ZWJraXQtdGVzdC1y dW5uZXIgWyBNb2RlbEVsZW1lbnRFbmFibGVkPXRydWUgXSAtLT4KKzwhLS0gd2Via2l0LXRlc3Qt cnVubmVyIFsgTW9kZWxFbGVtZW50RW5hYmxlZD10cnVlIF0gLS0+CiA8aHRtbD4KIDxib2R5Pgog PG1vZGVsPgo= 421413 2021-02-24 08:45:55 -0800 2021-02-24 12:12:00 -0800 Patch bug-222323-20210224084555.patch text/plain 1336 sam SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDI3MzM4NCkKKysrIExheW91dFRlc3RzL0NoYW5nZUxvZwkod29y a2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDIxLTAyLTI0ICBTYW0gV2VpbmlnICA8d2Vp bmlnQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggbW9kZWwgdGVzdCBkaWZmZXJlbmNlcyBiZXR3 ZWVuIHBsYXRmb3JtcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjIyMzIzCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS83NDY3ODEzMz4KKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL2lvcy9U ZXN0RXhwZWN0YXRpb25zOgorICAgICAgICBVbnNraXAgdGhlIHRlc3RzIHRoYXQgd2VyZSBjaGFu Z2VkIHRvIG5vIGxvbmdlciByZWx5IG9uIHBsYXRmb3JtIGRpZmZlcmVuY2VzLgorCiAyMDIxLTAy LTI0ICBJbWFub2wgRmVybmFuZGV6ICA8aWZlcm5hbmRlekBpZ2FsaWEuY29tPgogCiAgICAgICAg IEltcGxlbWVudCBXZWJYUiBnZXRWaWV3cG9ydApJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0v aW9zL1Rlc3RFeHBlY3RhdGlvbnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0v aW9zL1Rlc3RFeHBlY3RhdGlvbnMJKHJldmlzaW9uIDI3MzM4NCkKKysrIExheW91dFRlc3RzL3Bs YXRmb3JtL2lvcy9UZXN0RXhwZWN0YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC0zNTA3LDYgKzM1 MDcsMyBAQCB3ZWJraXQub3JnL2IvMjIxNDg2IGltcG9ydGVkL3czYy93ZWItcGxhCiAKIHdlYmtp dC5vcmcvYi8yMjE0NjYgaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy91aWV2ZW50cy9r ZXlib2FyZC9tb2RpZmllci1rZXlzLmh0bWwgWyBTa2lwIF0KIHdlYmtpdC5vcmcvYi8yMjE0NjUg aW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy91aWV2ZW50cy9rZXlib2FyZC9tb2RpZmll ci1rZXlzLWNvbWJpbmF0aW9ucy5odG1sIFsgU2tpcCBdCi0KLXdlYmtpdC5vcmcvYi8yMjIzMjMg bW9kZWwtZWxlbWVudC9tb2RlbC1lbGVtZW50LXJlbmRlcmVyLW5vLXNvdXJjZS5odG1sIFsgRmFp bHVyZSBdCi13ZWJraXQub3JnL2IvMjIyMzIzIG1vZGVsLWVsZW1lbnQvbW9kZWwtZWxlbWVudC1y ZW5kZXJlci5odG1sIFsgRmFpbHVyZSBdCg==