222314 2021-02-23 07:52:47 -0800 [GStreamer][EME][Thunder] Initialize decryptor lazily 2021-02-25 06:39:24 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 calvaris calvaris cgarcia ews-watchlist gustavo menard pnormand vjaquez webkit-bug-importer oldest_to_newest 1732526 0 calvaris 2021-02-23 07:52:47 -0800 [GStreamer][EME][Thunder] Initialize decryptor lazily 1732527 1 421311 calvaris 2021-02-23 07:57:43 -0800 Created attachment 421311 Patch 1732528 2 421311 pnormand 2021-02-23 08:00:50 -0800 Comment on attachment 421311 Patch ok! please fix coding style though 1732546 3 421311 calvaris 2021-02-23 08:46:04 -0800 Comment on attachment 421311 Patch (In reply to Philippe Normand from comment #2) > Comment on attachment 421311 [details] > Patch > > ok! please fix coding style though I can't, part is under an ifdef so if I fix that I have to add another coding style glitch. 1732554 4 ews-feeder 2021-02-23 09:09:57 -0800 Committed r273311: <https://commits.webkit.org/r273311> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421311. 1732555 5 webkit-bug-importer 2021-02-23 09:10:15 -0800 <rdar://problem/74644647> 1733285 6 pnormand 2021-02-25 04:40:04 -0800 This introduced a new warning: [95/830] Building CXX object Source/WebCore/CMakeFiles/WebCore.dir/platform/graphics/gstreamer/eme/CDMThunder.cpp.o ../../Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp:134:457: warning: format specifies type 'unsigned int' but the argument has type 'size_t' (aka 'unsigned long') [-Wformat] do{ if ((__builtin_expect (__extension__ ({ int _g_boolean_var_; if ((GST_LEVEL_DEBUG) <= GST_LEVEL_COUNT && (GST_LEVEL_DEBUG) <= _gst_debug_min) _g_boolean_var_ = 1; else _g_boolean_var_ = 0; _g_boolean_var_; }), 0))) { gst_debug_log ((webkitMediaThunderDebugCategory), (GST_LEVEL_DEBUG), "../../Source/WebCore/platform/graphics/gstreamer/eme/CDMThunder.cpp", ((const char*) (__FUNCTION__)), 134, (GObject *) (__null), "%u supported key systems", supportedKeySystems.size()); } }while (0); ~~ ^~~~~~~~~~~~~~~~~~~~~~~~~~ %zu 1 warning generated. 1733305 7 pnormand 2021-02-25 06:39:24 -0800 Fixed in r273481 421311 2021-02-23 07:57:43 -0800 2021-02-23 09:09:59 -0800 Patch bug-222314-20210223165741.patch text/plain 6053 calvaris U3VidmVyc2lvbiBSZXZpc2lvbjogMjczMTY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODY0ZTkwYTdkNWJkNDMx MzlmZmU1NTIxNzc1YzE2YTEyMWJiMTE1My4uMmIwM2VmNTE5YjhlNmExN2ExNzExZDg0NDFjNzE3 ZTU0MjZmOGRiYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI4IEBACisyMDIxLTAyLTIzICBYYWJp ZXIgUm9kcmlndWV6IENhbHZhciAgPGNhbHZhcmlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dT dHJlYW1lcl1bRU1FXVtUaHVuZGVyXSBJbml0aWFsaXplIGRlY3J5cHRvciBsYXppbHkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIyMjMxNAorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHNvbWUgY2FzZXMs IFdlYktpdCBjYW4gYmUgcnVuIGJlZm9yZSBUaHVuZGVyIG5hbm8gc2VydmljZXMgYXJlCisgICAg ICAgIHVwIGFuZCB3aXRob3V0IFBTT04sIHRoZSByZXN1bHQgY2FuIGJlIHRoYXQgeW91IGVuZCB1 cCB3aXRoIFdlYktpdAorICAgICAgICB0aGlua2luZyB0aGVyZSBpcyBubyBEUk0gc3lzdGVtIGF2 YWlsYWJsZS4KKworICAgICAgICBGaXJzdCB0aGluZyB0aGlzIHBhdGNoIGRvZXMgaXQgcmVtb3Zp bmcgdGhlIG9uY2UgZmxhZyBzbyB3ZSBrZWVwCisgICAgICAgIGFza2luZyBpZiB0aGVyZSBhcmUg RFJNIHN5c3RlbXMgYXZhaWxhYmxlIGlmIHdlIGFyZSBhc2tlZCBhYm91dAorICAgICAgICB0aGVt IGZyb20gSlMuCisKKyAgICAgICAgU2Vjb25kIHRoaW5nIGlzIHRoYXQgaWYgd2UgYXJlIHF1ZXJp ZWQgZnJvbSBKUyBhYm91dCB0aGUKKyAgICAgICAgYXZhaWxhYmlsaXR5IG9mIERSTSBzeXN0ZW1z IGFuZCB0aGVyZSBhcmUgc29tZSBhdmFpbGFibGUsIHdlCisgICAgICAgIGluaXRpYWxpemUgdGhl IGRlY3J5cHRvci4KKworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HU3Ry ZWFtZXJDb21tb24uY3BwOgorICAgICAgICAoV2ViQ29yZTo6cmVnaXN0ZXJXZWJLaXRHU3RyZWFt ZXJFbGVtZW50cyk6CisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL2VtZS9D RE1UaHVuZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNETUZhY3RvcnlUaHVuZGVyOjpzdXBw b3J0ZWRLZXlTeXN0ZW1zIGNvbnN0KToKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9nc3Ry ZWFtZXIvZW1lL1dlYktpdFRodW5kZXJEZWNyeXB0b3JHU3RyZWFtZXIuY3BwOgorCiAyMDIxLTAy LTE5ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFwcGxlLmNvbT4KIAogICAgICAgICBbUGF5bWVu dCBSZXF1ZXN0XSBhZGQgc3VwcG9ydCBmb3IgQXBwbGUgUGF5IHBheW1lbnQgbWV0aG9kIG1vZGUK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9H U3RyZWFtZXJDb21tb24uY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0 cmVhbWVyL0dTdHJlYW1lckNvbW1vbi5jcHAKaW5kZXggYWE3NjI1MWExYzZmM2NjMjAyM2I1YmYw N2UzOWM0MTBmYTFjYTQ0Ni4uM2RmNzY0NTYzODRhMTAwYjYyMDUyODc2ODVjZTRhZjU4MDI0ODg5 NiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVy L0dTdHJlYW1lckNvbW1vbi5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvZ3N0cmVhbWVyL0dTdHJlYW1lckNvbW1vbi5jcHAKQEAgLTMxMSwxMCArMzExLDYgQEAgdm9p ZCByZWdpc3RlcldlYktpdEdTdHJlYW1lckVsZW1lbnRzKCkKIAogI2lmIEVOQUJMRShFTkNSWVBU RURfTUVESUEpCiAgICAgICAgIGdzdF9lbGVtZW50X3JlZ2lzdGVyKG51bGxwdHIsICJ3ZWJraXRj bGVhcmtleSIsIEdTVF9SQU5LX1BSSU1BUlkgKyAyMDAsIFdFQktJVF9UWVBFX01FRElBX0NLX0RF Q1JZUFQpOwotI2lmIEVOQUJMRShUSFVOREVSKQotICAgICAgICB1bnNpZ25lZCB0aHVuZGVyUmFu ayA9IGlzVGh1bmRlclJhbmtlZCgpID8gMzAwIDogMTAwOwotICAgICAgICBnc3RfZWxlbWVudF9y ZWdpc3RlcihudWxscHRyLCAid2Via2l0dGh1bmRlciIsIEdTVF9SQU5LX1BSSU1BUlkgKyB0aHVu ZGVyUmFuaywgV0VCS0lUX1RZUEVfTUVESUFfVEhVTkRFUl9ERUNSWVBUKTsKLSNlbmRpZgogI2Vu ZGlmCiAKICNpZiBFTkFCTEUoTUVESUFfU1RSRUFNKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL2VtZS9DRE1UaHVuZGVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9lbWUvQ0RNVGh1bmRlci5jcHAK aW5kZXggZmNhMThlNmU3ZTFlMGFkZjBkMmU0NWY5ODI0ZjAzZWY1MWNmZDYyMy4uMWNmZmY3OGVl NWU1NTM1NGFhMjViODBiOTA0YzJkZTBlMzUzNmEwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL2VtZS9DRE1UaHVuZGVyLmNwcAorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvZW1lL0NETVRodW5kZXIu Y3BwCkBAIC00Miw2ICs0Miw3IEBACiAjaW5jbHVkZSAiTWVkaWFLZXlTdGF0dXMuaCIKICNpbmNs dWRlICJOb3RJbXBsZW1lbnRlZC5oIgogI2luY2x1ZGUgIlNoYXJlZEJ1ZmZlci5oIgorI2luY2x1 ZGUgIldlYktpdFRodW5kZXJEZWNyeXB0b3JHU3RyZWFtZXIuaCIKICNpbmNsdWRlIDxhbGdvcml0 aG0+CiAjaW5jbHVkZSA8aXRlcmF0b3I+CiAjaW5jbHVkZSA8d3RmL01haW5UaHJlYWQuaD4KQEAg LTExNCwxOSArMTE1LDI0IEBAIFJlZlB0cjxDRE1Qcm94eT4gQ0RNRmFjdG9yeVRodW5kZXI6OmNy ZWF0ZUNETVByb3h5KGNvbnN0IFN0cmluZyYga2V5U3lzdGVtKQogCiBjb25zdCBWZWN0b3I8U3Ry aW5nPiYgQ0RNRmFjdG9yeVRodW5kZXI6OnN1cHBvcnRlZEtleVN5c3RlbXMoKSBjb25zdAogewot ICAgIHN0YXRpYyBzdGQ6Om9uY2VfZmxhZyBvbmNlRmxhZzsKKyAgICBBU1NFUlQoaXNNYWluVGhy ZWFkKCkpOworCiAgICAgc3RhdGljIFZlY3RvcjxTdHJpbmc+IHN1cHBvcnRlZEtleVN5c3RlbXM7 Ci0gICAgc3RkOjpjYWxsX29uY2Uob25jZUZsYWcsIFtdIHsKKyAgICBpZiAoc3VwcG9ydGVkS2V5 U3lzdGVtcy5pc0VtcHR5KCkpIHsKICAgICAgICAgc3RkOjpzdHJpbmcgZW1wdHlTdHJpbmc7CiAg ICAgICAgIGlmIChvcGVuY2RtX2lzX3R5cGVfc3VwcG9ydGVkKEdTdHJlYW1lckVNRVV0aWxpdGll czo6c19XaWRldmluZUtleVN5c3RlbSwgZW1wdHlTdHJpbmcuY19zdHIoKSkgPT0gRVJST1JfTk9O RSkKICAgICAgICAgICAgIHN1cHBvcnRlZEtleVN5c3RlbXMuYXBwZW5kKEdTdHJlYW1lckVNRVV0 aWxpdGllczo6c19XaWRldmluZUtleVN5c3RlbSk7CisgICAgICAgIGlmICghc3VwcG9ydGVkS2V5 U3lzdGVtcy5pc0VtcHR5KCkpIHsKKyAgICAgICAgICAgIHVuc2lnbmVkIHRodW5kZXJSYW5rID0g aXNUaHVuZGVyUmFua2VkKCkgPyAzMDAgOiAxMDA7CisgICAgICAgICAgICBnc3RfZWxlbWVudF9y ZWdpc3RlcihudWxscHRyLCAid2Via2l0dGh1bmRlciIsIEdTVF9SQU5LX1BSSU1BUlkgKyB0aHVu ZGVyUmFuaywgV0VCS0lUX1RZUEVfTUVESUFfVEhVTkRFUl9ERUNSWVBUKTsKKyAgICAgICAgfQog I2lmbmRlZiBOREVCVUcKLSAgICAgICAgaWYgKHN1cHBvcnRlZEtleVN5c3RlbXMuaXNFbXB0eSgp ICYmIGlzVGh1bmRlclJhbmtlZCgpKSB7Ci0gICAgICAgICAgICBBU1NFUlRfTk9UX1JFQUNIRURf V0lUSF9NRVNTQUdFKCJUaHVuZGVyIGlzIHVwLXJhbmtlZCBhcyBwcmVmZXJyZWQgZGVjcnlwdG9y IGJ1dCBUaHVuZGVyIGlzIG5vdCBzdXBwb3J0aW5nIGFueSBlbmNyeXB0aW9uIHN5c3RlbS4gSXMg IgorICAgICAgICBlbHNlIGlmIChpc1RodW5kZXJSYW5rZWQoKSkKKyAgICAgICAgICAgIEdTVF9X QVJOSU5HKCJUaHVuZGVyIGlzIHVwLXJhbmtlZCBhcyBwcmVmZXJyZWQgZGVjcnlwdG9yIGJ1dCBU aHVuZGVyIGlzIG5vdCBzdXBwb3J0aW5nIGFueSBlbmNyeXB0aW9uIHN5c3RlbS4gSXMgIgogICAg ICAgICAgICAgICAgICJUaHVuZGVyIHJ1bm5pbmc/IEFyZSB0aGUgcGx1Z2lucyBidWlsdD8iKTsK LSAgICAgICAgfQogI2VuZGlmCi0gICAgfSk7CisgICAgICAgIEdTVF9ERUJVRygiJXUgc3VwcG9y dGVkIGtleSBzeXN0ZW1zIiwgc3VwcG9ydGVkS2V5U3lzdGVtcy5zaXplKCkpOworICAgIH07CiAg ICAgcmV0dXJuIHN1cHBvcnRlZEtleVN5c3RlbXM7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9lbWUvV2ViS2l0VGh1bmRlckRlY3J5 cHRvckdTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3Ry ZWFtZXIvZW1lL1dlYktpdFRodW5kZXJEZWNyeXB0b3JHU3RyZWFtZXIuY3BwCmluZGV4IDZmZGQ5 ODc3MmYyNWUyNWIzYTJlMDY2ZGM3YmMzODEwODJjODljMDUuLmEyMjY3MGQ5MTA1ZDBmNDY1Zjkz YTZhOGY2YWM2NWRjZTAyNGQ1ZGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2dzdHJlYW1lci9lbWUvV2ViS2l0VGh1bmRlckRlY3J5cHRvckdTdHJlYW1lci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL2VtZS9X ZWJLaXRUaHVuZGVyRGVjcnlwdG9yR1N0cmVhbWVyLmNwcApAQCAtNzAsNyArNzAsOSBAQCBzdGF0 aWMgR1JlZlB0cjxHc3RDYXBzPiBjcmVhdGVTaW5rUGFkVGVtcGxhdGVDYXBzKCkKIHsKICAgICBH UmVmUHRyPEdzdENhcHM+IGNhcHMgPSBhZG9wdEdSZWYoZ3N0X2NhcHNfbmV3X2VtcHR5KCkpOwog Ci0gICAgaWYgKENETUZhY3RvcnlUaHVuZGVyOjpzaW5nbGV0b24oKS5zdXBwb3J0ZWRLZXlTeXN0 ZW1zKCkuaXNFbXB0eSgpKSB7CisgICAgYXV0byYgc3VwcG9ydGVkS2V5U3lzdGVtcyA9IENETUZh Y3RvcnlUaHVuZGVyOjpzaW5nbGV0b24oKS5zdXBwb3J0ZWRLZXlTeXN0ZW1zKCk7CisKKyAgICBp ZiAoc3VwcG9ydGVkS2V5U3lzdGVtcy5pc0VtcHR5KCkpIHsKICAgICAgICAgR1NUX1dBUk5JTkco Im5vIHN1cHBvcnRlZCBrZXkgc3lzdGVtcyBpbiBUaHVuZGVyLCB3ZSB3b24ndCBiZSBhYmxlIHRv IGRlY3J5cHQgYW55dGhpbmcgd2l0aCB0aGUgaXRzIGRlY3J5cHRvciIpOwogICAgICAgICByZXR1 cm4gY2FwczsKICAgICB9CkBAIC03OSw3ICs4MSw3IEBAIHN0YXRpYyBHUmVmUHRyPEdzdENhcHM+ IGNyZWF0ZVNpbmtQYWRUZW1wbGF0ZUNhcHMoKQogICAgICAgICBnc3RfY2Fwc19hcHBlbmRfc3Ry dWN0dXJlKGNhcHMuZ2V0KCksIGdzdF9zdHJ1Y3R1cmVfbmV3KCJhcHBsaWNhdGlvbi94LWNlbmMi LCAib3JpZ2luYWwtbWVkaWEtdHlwZSIsIEdfVFlQRV9TVFJJTkcsCiAgICAgICAgICAgICBjZW5j RW5jcnlwdGlvbk1lZGlhVHlwZXNbaV0sIG51bGxwdHIpKTsKICAgICB9Ci0gICAgZm9yIChjb25z dCBhdXRvJiBrZXlTeXN0ZW0gOiBDRE1GYWN0b3J5VGh1bmRlcjo6c2luZ2xldG9uKCkuc3VwcG9y dGVkS2V5U3lzdGVtcygpKSB7CisgICAgZm9yIChjb25zdCBhdXRvJiBrZXlTeXN0ZW0gOiBzdXBw b3J0ZWRLZXlTeXN0ZW1zKSB7CiAgICAgICAgIGZvciAoaW50IGkgPSAwOyBjZW5jRW5jcnlwdGlv bk1lZGlhVHlwZXNbaV07ICsraSkgewogICAgICAgICAgICAgZ3N0X2NhcHNfYXBwZW5kX3N0cnVj dHVyZShjYXBzLmdldCgpLCBnc3Rfc3RydWN0dXJlX25ldygiYXBwbGljYXRpb24veC1jZW5jIiwg Im9yaWdpbmFsLW1lZGlhLXR5cGUiLCBHX1RZUEVfU1RSSU5HLAogICAgICAgICAgICAgICAgIGNl bmNFbmNyeXB0aW9uTWVkaWFUeXBlc1tpXSwgInByb3RlY3Rpb24tc3lzdGVtIiwgR19UWVBFX1NU UklORywgR1N0cmVhbWVyRU1FVXRpbGl0aWVzOjprZXlTeXN0ZW1Ub1V1aWQoa2V5U3lzdGVtKSwg bnVsbHB0cikpOwo=