222287 2021-02-22 14:00:36 -0800 [ews] Commit queue should show commit identifier every time it updates local checkout 2021-02-26 12:32:14 -0800 1 1 1 Unclassified WebKit Tools / Tests Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 aakash_jain aakash_jain jbedard ryanhaddad webkit-bug-importer oldest_to_newest 1732294 0 aakash_jain 2021-02-22 14:00:36 -0800 Commit queue should show commit identifier every time it updates local checkout. Currently it doesn't show the identifier after the second update (e.g.: in step #17 of https://ews-build.webkit.org/#/builders/28/builds/9207). 1733848 1 421670 aakash_jain 2021-02-26 10:12:59 -0800 Created attachment 421670 Patch 1733861 2 421670 jbedard 2021-02-26 10:28:08 -0800 Comment on attachment 421670 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421670&action=review > Tools/CISupport/ews-build/factories.py:278 > self.addStep(CheckOutSource()) I think we want to 'fetch' before ShowIdentifier 1733894 3 aakash_jain 2021-02-26 11:41:44 -0800 (In reply to Jonathan Bedard from comment #2) > I think we want to 'fetch' before ShowIdentifier Fetch is already done once in the same build. This is for the case when in same build, commit-queue updates checkout a second time (e.g.: step 18 in https://ews-build.webkit.org/#/builders/28/builds/9351) 1733906 4 jbedard 2021-02-26 12:03:45 -0800 (In reply to Aakash Jain from comment #3) > (In reply to Jonathan Bedard from comment #2) > > I think we want to 'fetch' before ShowIdentifier > Fetch is already done once in the same build. This is for the case when in > same build, commit-queue updates checkout a second time (e.g.: step 18 in > https://ews-build.webkit.org/#/builders/28/builds/9351) Looking closer, we should be fine, but not because we ran fetch earlier, because we're updating the checkout in general instead of updating to a specific revision. 1733933 5 ews-feeder 2021-02-26 12:31:08 -0800 Committed r273581: <https://commits.webkit.org/r273581> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421670. 1733935 6 webkit-bug-importer 2021-02-26 12:32:14 -0800 <rdar://problem/74802160> 421670 2021-02-26 10:12:59 -0800 2021-02-26 12:31:08 -0800 Patch bug-222287-20210226131258.patch text/plain 2094 aakash_jain SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDI3MzU2MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDIxLTAyLTI2ICBBYWthc2ggSmFpbiAgPGFha2FzaF9qYWluQGFwcGxlLmNv bT4KKworICAgICAgICBbZXdzXSBDb21taXQgcXVldWUgc2hvdWxkIHNob3cgY29tbWl0IGlkZW50 aWZpZXIgZXZlcnkgdGltZSBpdCB1cGRhdGVzIGxvY2FsIGNoZWNrb3V0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjIyODcKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIENJU3VwcG9ydC9ld3MtYnVpbGQv ZmFjdG9yaWVzLnB5OgorICAgICAgICAoQ29tbWl0UXVldWVGYWN0b3J5Ll9faW5pdF9fKTogQWRk ZWQgU2hvd0lkZW50aWZpZXIgc3RlcC4KKyAgICAgICAgKiBDSVN1cHBvcnQvZXdzLWJ1aWxkL2Zh Y3Rvcmllc191bml0dGVzdC5weTogVXBkYXRlZCB1bml0LXRlc3QuCisKIDIwMjEtMDItMjYgIEFh a2FzaCBKYWluICA8YWFrYXNoX2phaW5AYXBwbGUuY29tPgogCiAgICAgICAgIFtidWlsZC53ZWJr aXQub3JnXSBTdG9wIHVzaW5nIGRlcHJlY2F0ZWQgYnVpbGRib3Quc3RhdHVzLmJ1aWxkZXIKSW5k ZXg6IFRvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzLnB5Cj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFRvb2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzLnB5CShyZXZpc2lvbiAyNzM1NjIp CisrKyBUb29scy9DSVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllcy5weQkod29ya2luZyBjb3B5 KQpAQCAtMjc2LDYgKzI3Niw3IEBAIGNsYXNzIENvbW1pdFF1ZXVlRmFjdG9yeShmYWN0b3J5LkJ1 aWxkRmEKICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1bldlYktpdFRlc3RzKCkpCiAgICAgICAgIHNl bGYuYWRkU3RlcChWYWxpZGF0ZVBhdGNoKGFkZFVSTHM9RmFsc2UsIHZlcmlmeWNxcGx1cz1UcnVl KSkKICAgICAgICAgc2VsZi5hZGRTdGVwKENoZWNrT3V0U291cmNlKCkpCisgICAgICAgIHNlbGYu YWRkU3RlcChTaG93SWRlbnRpZmllcigpKQogICAgICAgICBzZWxmLmFkZFN0ZXAoVXBkYXRlV29y a2luZ0RpcmVjdG9yeSgpKQogICAgICAgICBzZWxmLmFkZFN0ZXAoQXBwbHlQYXRjaCgpKQogICAg ICAgICBzZWxmLmFkZFN0ZXAoQ3JlYXRlTG9jYWxHSVRDb21taXQoKSkKSW5kZXg6IFRvb2xzL0NJ U3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzX3VuaXR0ZXN0LnB5Cj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRv b2xzL0NJU3VwcG9ydC9ld3MtYnVpbGQvZmFjdG9yaWVzX3VuaXR0ZXN0LnB5CShyZXZpc2lvbiAy NzM1NjIpCisrKyBUb29scy9DSVN1cHBvcnQvZXdzLWJ1aWxkL2ZhY3Rvcmllc191bml0dGVzdC5w eQkod29ya2luZyBjb3B5KQpAQCAtNDI1LDYgKzQyNSw3IEBAIGNsYXNzIFRlc3RDb21taXRRdWV1 ZUZhY3RvcnkoVGVzdENhc2UpOgogICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMu UnVuV2ViS2l0VGVzdHMpLAogICAgICAgICAgICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuVmFs aWRhdGVQYXRjaCwgYWRkVVJMcz1GYWxzZSwgdmVyaWZ5Y3FwbHVzPVRydWUpLAogICAgICAgICAg ICAgX0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuQ2hlY2tPdXRTb3VyY2UpLAorICAgICAgICAgICAg X0J1aWxkU3RlcEZhY3Rvcnkoc3RlcHMuU2hvd0lkZW50aWZpZXIpLAogICAgICAgICAgICAgX0J1 aWxkU3RlcEZhY3Rvcnkoc3RlcHMuVXBkYXRlV29ya2luZ0RpcmVjdG9yeSksCiAgICAgICAgICAg ICBfQnVpbGRTdGVwRmFjdG9yeShzdGVwcy5BcHBseVBhdGNoKSwKICAgICAgICAgICAgIF9CdWls ZFN0ZXBGYWN0b3J5KHN0ZXBzLkNyZWF0ZUxvY2FsR0lUQ29tbWl0KSwK