222245 2021-02-21 03:48:18 -0800 [Paint Timing] Return early from contentful paint check when no contentful pixels/characters at all 2021-02-21 11:08:14 -0800 1 1 1 Unclassified WebKit Layout and Rendering Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=222186 InRadar P2 Normal --- 211736 1 noam noam bfulgham cdumez esprehn+autocc ews-watchlist kangil.han sabouhallawa simon.fraser webkit-bug-importer zalan oldest_to_newest 1731932 0 noam 2021-02-21 03:48:18 -0800 The MotionMark tests captured an edge case that causes expensive contentfulness computations. See https://browserbench.org/MotionMark1.1/developer.html (Focus/Multiply tests) This edge case is not plausible in real websites, but happens in this benchmark: - There are lots of elements, performing rendering-intensive rendering - There is nothing "contentful" in the page, so "first contenful paint" has to be computed multiple times. 1731933 1 421136 noam 2021-02-21 03:53:05 -0800 Created attachment 421136 Patch 1731957 2 421136 simon.fraser 2021-02-21 09:23:53 -0800 Comment on attachment 421136 Patch If the test elements contained one glyph each, what would happen? 1731962 3 noam 2021-02-21 10:09:42 -0800 (In reply to Simon Fraser (smfr) from comment #2) > Comment on attachment 421136 [details] > Patch > > If the test elements contained one glyph each, what would happen? FCP will be marked the moment one of them become visible, and from that point on the check wouldn't run (as it only measures the *first* contentful paint). 1731966 4 ews-feeder 2021-02-21 11:07:38 -0800 Committed r273220: <https://commits.webkit.org/r273220> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421136. 1731967 5 webkit-bug-importer 2021-02-21 11:08:14 -0800 <rdar://problem/74570604> 421136 2021-02-21 03:53:05 -0800 2021-02-21 11:07:40 -0800 Patch bug-222245-20210221135304.patch text/plain 2750 noam SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDI3MzIxNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIwIEBACisyMDIxLTAyLTIxICBOb2FtIFJv c2VudGhhbCAgPG5vYW1Ad2Via2l0Lm9yZz4KKworICAgICAgICBbUGFpbnQgVGltaW5nXSBSZXR1 cm4gZWFybHkgZnJvbSBjb250ZW50ZnVsIHBhaW50IGNoZWNrIHdoZW4gbm8gY29udGVudGZ1bCBw aXhlbHMvY2hhcmFjdGVycyBhdCBhbGwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIyMjI0NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIEJhaWwgZnJvbSByZWN1cnNpdmUgY29udGVuZnVsLXBhaW50IGNoZWNr IGlmIHRoZXJlIGFyZSBubyBwaXhlbHMvdGV4dCBjaGFyYWN0ZXJzIGluIHRoZSBlbnRpcmUgZG9j dW1lbnQuCisgICAgICAgIAorICAgICAgICBDb3ZlcmVkIGJ5IGV4aXN0aW5nIHRlc3RzLCBhbiBv cHRpbWl6YXRpb24gb25seS4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAg IChXZWJDb3JlOjpEb2N1bWVudDo6ZW5xdWV1ZVBhaW50VGltaW5nRW50cnlJZk5lZWRlZCk6Cisg ICAgICAgICogcGFnZS9GcmFtZVZpZXcuY3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVWaWV3 OjpoYXNDb250ZW5mdWxEZXNjZW5kYW50cyBjb25zdCk6CisgICAgICAgICogcGFnZS9GcmFtZVZp ZXcuaDoKKwogMjAyMS0wMi0yMCAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29t PgogCiAgICAgICAgIEFYOiBJbWFnZSBzaG91bGQgcmVwb3J0IHRoZSBlbWJlZGRlZCBhY2Nlc3Np YmlsaXR5IGRlc2NyaXB0aW9uIGlmIGF2YWlsYWJsZQpJbmRleDogU291cmNlL1dlYkNvcmUvZG9t L0RvY3VtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQu Y3BwCShyZXZpc2lvbiAyNzMyMTUpCisrKyBTb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0zMjQ0LDYgKzMyNDQsOSBAQCB2b2lkIERvY3VtZW50OjplbnF1 ZXVlUGFpbnRUaW1pbmdFbnRyeUlmCiAgICAgaWYgKCF2aWV3KCktPmlzVmlzdWFsbHlOb25FbXB0 eSgpIHx8IHZpZXcoKS0+bmVlZHNMYXlvdXQoKSkKICAgICAgICAgcmV0dXJuOwogCisgICAgaWYg KCF2aWV3KCktPmhhc0NvbnRlbmZ1bERlc2NlbmRhbnRzKCkpCisgICAgICAgIHJldHVybjsKKwog ICAgIGlmICghQ29udGVudGZ1bFBhaW50Q2hlY2tlcjo6cXVhbGlmaWVzRm9yQ29udGVudGZ1bFBh aW50KCp2aWV3KCkpKQogICAgICAgICByZXR1cm47CiAKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bh Z2UvRnJhbWVWaWV3LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wYWdlL0ZyYW1l Vmlldy5jcHAJKHJldmlzaW9uIDI3MzIxNSkKKysrIFNvdXJjZS9XZWJDb3JlL3BhZ2UvRnJhbWVW aWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNDYxNiw2ICs0NjE2LDExIEBAIHZvaWQgRnJhbWVW aWV3OjpjaGVja0FuZERpc3BhdGNoRGlkUmVhY2gKICAgICAgICAgZnJhbWUoKS5sb2FkZXIoKS5k aWRSZWFjaFZpc3VhbGx5Tm9uRW1wdHlTdGF0ZSgpOwogfQogCitib29sIEZyYW1lVmlldzo6aGFz Q29udGVuZnVsRGVzY2VuZGFudHMoKSBjb25zdAoreworICAgIHJldHVybiBtX3Zpc3VhbGx5Tm9u RW1wdHlDaGFyYWN0ZXJDb3VudCB8fCBtX3Zpc3VhbGx5Tm9uRW1wdHlQaXhlbENvdW50OworfQor CiBib29sIEZyYW1lVmlldzo6aXNWaWV3Rm9yRG9jdW1lbnRJbkZyYW1lKCkgY29uc3QKIHsKICAg ICBSZW5kZXJWaWV3KiByZW5kZXJWaWV3ID0gdGhpcy0+cmVuZGVyVmlldygpOwpJbmRleDogU291 cmNlL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29y ZS9wYWdlL0ZyYW1lVmlldy5oCShyZXZpc2lvbiAyNzMyMTUpCisrKyBTb3VyY2UvV2ViQ29yZS9w YWdlL0ZyYW1lVmlldy5oCSh3b3JraW5nIGNvcHkpCkBAIC00MTMsNiArNDEzLDcgQEAgcHVibGlj OgogICAgIHZvaWQgaW5jcmVtZW50VmlzdWFsbHlOb25FbXB0eUNoYXJhY3RlckNvdW50KGNvbnN0 IFN0cmluZyYpOwogICAgIHZvaWQgaW5jcmVtZW50VmlzdWFsbHlOb25FbXB0eVBpeGVsQ291bnQo Y29uc3QgSW50U2l6ZSYpOwogICAgIGJvb2wgaXNWaXN1YWxseU5vbkVtcHR5KCkgY29uc3QgeyBy ZXR1cm4gbV9jb250ZW50UXVhbGlmaWVzQXNWaXN1YWxseU5vbkVtcHR5OyB9CisgICAgYm9vbCBo YXNDb250ZW5mdWxEZXNjZW5kYW50cygpIGNvbnN0OwogICAgIHZvaWQgY2hlY2tBbmREaXNwYXRj aERpZFJlYWNoVmlzdWFsbHlOb25FbXB0eVN0YXRlKCk7CiAKICAgICBXRUJDT1JFX0VYUE9SVCB2 b2lkIGVuYWJsZUZpeGVkV2lkdGhBdXRvU2l6ZU1vZGUoYm9vbCBlbmFibGUsIGNvbnN0IEludFNp emUmIG1pblNpemUpOwo=