222236 2021-02-20 13:41:00 -0800 UserMediaPermissionRequestManagerProxy may be released while computing capture device list 2021-03-19 10:45:34 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 eric.carlson eric.carlson ajuma darin ews-watchlist glenn jer.noble peng.liu6 philipj sergio webkit-bug-importer youennf oldest_to_newest 1731848 0 eric.carlson 2021-02-20 13:41:00 -0800 UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList should NULL-check after computing capture device list 1731849 1 eric.carlson 2021-02-20 13:41:28 -0800 <rdar://74480265> 1731852 2 421110 eric.carlson 2021-02-20 13:51:22 -0800 Created attachment 421110 Patch 1731856 3 421110 peng.liu6 2021-02-20 14:20:26 -0800 Comment on attachment 421110 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=421110&action=review > Source/WebKit/ChangeLog:3 > + UserMediaPermissionRequestManagerProxy::computeFilteredDeviceList may be released Sounds like UserMediaPermissionRequestManagerProxy may be released? 1731925 4 421110 youennf 2021-02-21 00:26:28 -0800 Comment on attachment 421110 Patch I guess the issue is log identifier, that is subtle… maybe this is an indication we should not site this in lambdas but just weakptr. 1732145 5 421198 eric.carlson 2021-02-22 08:49:11 -0800 Created attachment 421198 Patch for landing 1732223 6 ews-feeder 2021-02-22 11:44:54 -0800 Committed r273265: <https://commits.webkit.org/r273265> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421198. 1732224 7 421198 darin 2021-02-22 11:47:28 -0800 Comment on attachment 421198 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=421198&action=review > Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:741 > - if (weakThis) > - m_hasFilteredDeviceList = !revealIdsAndLabels; > - > + weakThis->m_hasFilteredDeviceList = !revealIdsAndLabels; Why capture "this" but use "weakThis" here? 1732320 8 eric.carlson 2021-02-22 15:09:10 -0800 Reopening to attach new patch. 1732321 9 421244 eric.carlson 2021-02-22 15:09:11 -0800 Created attachment 421244 Patch 1732324 10 421198 eric.carlson 2021-02-22 15:10:18 -0800 Comment on attachment 421198 Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=421198&action=review >> Source/WebKit/UIProcess/UserMediaPermissionRequestManagerProxy.cpp:741 >> + weakThis->m_hasFilteredDeviceList = !revealIdsAndLabels; > > Why capture "this" but use "weakThis" here? Oops, that is left over from a bigger refactoring I (tried to) undo to make this a more targeted change. I'll remove it in a follow. 1732391 11 ews-feeder 2021-02-22 17:11:02 -0800 Committed r273289: <https://commits.webkit.org/r273289> All reviewed patches have been landed. Closing bug and clearing flags on attachment 421244. 1741782 12 eric.carlson 2021-03-19 10:45:34 -0700 *** Bug 223476 has been marked as a duplicate of this bug. *** 421110 2021-02-20 13:51:22 -0800 2021-02-22 08:49:09 -0800 Patch bug-222236-20210220135122.patch text/plain 2272 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyOTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFjMTRmYzI4ZDBlZjM1MjI4 ZDk0YjcxY2QwMTdkMDdhMWFiOWNlN2EuLmRmMDcwMTExOWMzMjQ0MTNiODliZTdhYTMyNGViY2Yx M2Q3OGU4NmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjEtMDItMjAgIEVyaWMgQ2Fy bHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlck1lZGlhUGVybWlz c2lvblJlcXVlc3RNYW5hZ2VyUHJveHk6OmNvbXB1dGVGaWx0ZXJlZERldmljZUxpc3QgbWF5IGJl IHJlbGVhc2VkCisgICAgICAgIHdoaWxlIGNvbXB1dGluZyBjYXB0dXJlIGRldmljZSBsaXN0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjIyMzYKKyAg ICAgICAgPHJkYXI6Ly83NDQ4MDI2NT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9Vc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1h bmFnZXJQcm94eS5jcHA6CisgICAgICAgIChXZWJLaXQ6OlVzZXJNZWRpYVBlcm1pc3Npb25SZXF1 ZXN0TWFuYWdlclByb3h5Ojpjb21wdXRlRmlsdGVyZWREZXZpY2VMaXN0KTogUmV0dXJuIGVhcmx5 CisgICAgICAgIGlmIGB3ZWFrVGhpc2AgaXMgTlVMTC4KKwogMjAyMS0wMi0xNiAgS2ltbW8gS2lu bnVuZW4gIDxra2lubnVuZW5AYXBwbGUuY29tPgogCiAgICAgICAgIFJlbW90ZUF1ZGlvU291cmNl UHJvdmlkZXJNYW5hZ2VyIGlzIGFjY2Vzc2VkIGluIG5vbi10aHJlYWQtc2FmZSBtYW5uZXIKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1VzZXJNZWRpYVBlcm1pc3Npb25SZXF1 ZXN0TWFuYWdlclByb3h5LmNwcCBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL1VzZXJNZWRpYVBl cm1pc3Npb25SZXF1ZXN0TWFuYWdlclByb3h5LmNwcAppbmRleCBiNjdlMTJmZTY3N2ZlZTFhNWFj NzVhMGFjMGE4ZjFlMDIyYWI0MGM4Li5mNWIxN2JlYzE0MmZiZWZlZjZmN2ExMGI1NDBiN2Q4ZTUw MTU1MmQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Vc2VyTWVkaWFQZXJt aXNzaW9uUmVxdWVzdE1hbmFnZXJQcm94eS5jcHAKKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nl c3MvVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyUHJveHkuY3BwCkBAIC03MTAsNiAr NzEwLDEwIEBAIHZvaWQgVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyUHJveHk6OmNv bXB1dGVGaWx0ZXJlZERldmljZUxpc3QoYm9vbCByZXZlCiAgICAgc3RhdGljIGNvbnN0IHVuc2ln bmVkIGRlZmF1bHRNYXhpbXVtTWljcm9waG9uZUNvdW50ID0gMTsKIAogICAgIHBsYXRmb3JtR2V0 TWVkaWFTdHJlYW1EZXZpY2VzKFt0aGlzLCB3ZWFrVGhpcyA9IG1ha2VXZWFrUHRyKHRoaXMpLCBy ZXZlYWxJZHNBbmRMYWJlbHMsIGNvbXBsZXRpb24gPSBXVEZNb3ZlKGNvbXBsZXRpb24pXShhdXRv JiYgZGV2aWNlcykgbXV0YWJsZSB7CisKKyAgICAgICAgaWYgKCF3ZWFrVGhpcykKKyAgICAgICAg ICAgIGNvbXBsZXRpb24oeyB9KTsKKwogICAgICAgICB1bnNpZ25lZCBjYW1lcmFDb3VudCA9IDA7 CiAgICAgICAgIHVuc2lnbmVkIG1pY3JvcGhvbmVDb3VudCA9IDA7CiAKQEAgLTczNCwxMCArNzM4 LDkgQEAgdm9pZCBVc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXJQcm94eTo6Y29tcHV0 ZUZpbHRlcmVkRGV2aWNlTGlzdChib29sIHJldmUKICAgICAgICAgICAgIGZpbHRlcmVkRGV2aWNl cy5hcHBlbmQocmV2ZWFsSWRzQW5kTGFiZWxzID8gZGV2aWNlIDogQ2FwdHVyZURldmljZSh7IH0s IGRldmljZS50eXBlKCksIHsgfSwgeyB9KSk7CiAgICAgICAgIH0KIAotICAgICAgICBpZiAod2Vh a1RoaXMpCi0gICAgICAgICAgICBtX2hhc0ZpbHRlcmVkRGV2aWNlTGlzdCA9ICFyZXZlYWxJZHNB bmRMYWJlbHM7Ci0KKyAgICAgICAgd2Vha1RoaXMtPm1faGFzRmlsdGVyZWREZXZpY2VMaXN0ID0g IXJldmVhbElkc0FuZExhYmVsczsKICAgICAgICAgQUxXQVlTX0xPRyhMT0dJREVOVElGSUVSLCBm aWx0ZXJlZERldmljZXMuc2l6ZSgpLCAiIGRldmljZXMgcmV2ZWFsZWQiKTsKKwogICAgICAgICBj b21wbGV0aW9uKFdURk1vdmUoZmlsdGVyZWREZXZpY2VzKSk7CiAgICAgfSk7CiB9Cg== 421198 2021-02-22 08:49:11 -0800 2021-02-22 11:44:55 -0800 Patch for landing bug-222236-20210222084910.patch text/plain 2235 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjcyOTE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IDFjMTRmYzI4ZDBlZjM1MjI4 ZDk0YjcxY2QwMTdkMDdhMWFiOWNlN2EuLjFkM2I0Mjk4YzkxNjdmMGJhMzdjMmYzMDBlNTc0OGE4 NDVmNDgyYjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDItMjAgIEVyaWMgQ2Fy bHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlck1lZGlhUGVybWlz c2lvblJlcXVlc3RNYW5hZ2VyUHJveHkgbWF5IGJlIHJlbGVhc2VkIHdoaWxlIGNvbXB1dGluZyBj YXB0dXJlIGRldmljZSBsaXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMjIyMzYKKyAgICAgICAgPHJkYXI6Ly83NDQ4MDI2NT4KKworICAgICAgICBS ZXZpZXdlZCBieSBZb3Vlbm4gRmFibGV0LgorCisgICAgICAgICogVUlQcm9jZXNzL1VzZXJNZWRp YVBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlclByb3h5LmNwcDoKKyAgICAgICAgKFdlYktpdDo6VXNl ck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyUHJveHk6OmNvbXB1dGVGaWx0ZXJlZERldmlj ZUxpc3QpOiBSZXR1cm4gZWFybHkKKyAgICAgICAgaWYgYHdlYWtUaGlzYCBpcyBOVUxMLgorCiAy MDIxLTAyLTE2ICBLaW1tbyBLaW5udW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CiAKICAgICAg ICAgUmVtb3RlQXVkaW9Tb3VyY2VQcm92aWRlck1hbmFnZXIgaXMgYWNjZXNzZWQgaW4gbm9uLXRo cmVhZC1zYWZlIG1hbm5lcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvVXNl ck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyUHJveHkuY3BwIGIvU291cmNlL1dlYktpdC9V SVByb2Nlc3MvVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyUHJveHkuY3BwCmluZGV4 IGI2N2UxMmZlNjc3ZmVlMWE1YWM3NWEwYWMwYThmMWUwMjJhYjQwYzguLmY1YjE3YmVjMTQyZmJl ZmVmNmY3YTEwYjU0MGI3ZDhlNTAxNTUyZDMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvVUlQ cm9jZXNzL1VzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlclByb3h5LmNwcAorKysgYi9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Vc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXJQ cm94eS5jcHAKQEAgLTcxMCw2ICs3MTAsMTAgQEAgdm9pZCBVc2VyTWVkaWFQZXJtaXNzaW9uUmVx dWVzdE1hbmFnZXJQcm94eTo6Y29tcHV0ZUZpbHRlcmVkRGV2aWNlTGlzdChib29sIHJldmUKICAg ICBzdGF0aWMgY29uc3QgdW5zaWduZWQgZGVmYXVsdE1heGltdW1NaWNyb3Bob25lQ291bnQgPSAx OwogCiAgICAgcGxhdGZvcm1HZXRNZWRpYVN0cmVhbURldmljZXMoW3RoaXMsIHdlYWtUaGlzID0g bWFrZVdlYWtQdHIodGhpcyksIHJldmVhbElkc0FuZExhYmVscywgY29tcGxldGlvbiA9IFdURk1v dmUoY29tcGxldGlvbildKGF1dG8mJiBkZXZpY2VzKSBtdXRhYmxlIHsKKworICAgICAgICBpZiAo IXdlYWtUaGlzKQorICAgICAgICAgICAgY29tcGxldGlvbih7IH0pOworCiAgICAgICAgIHVuc2ln bmVkIGNhbWVyYUNvdW50ID0gMDsKICAgICAgICAgdW5zaWduZWQgbWljcm9waG9uZUNvdW50ID0g MDsKIApAQCAtNzM0LDEwICs3MzgsOSBAQCB2b2lkIFVzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0 TWFuYWdlclByb3h5Ojpjb21wdXRlRmlsdGVyZWREZXZpY2VMaXN0KGJvb2wgcmV2ZQogICAgICAg ICAgICAgZmlsdGVyZWREZXZpY2VzLmFwcGVuZChyZXZlYWxJZHNBbmRMYWJlbHMgPyBkZXZpY2Ug OiBDYXB0dXJlRGV2aWNlKHsgfSwgZGV2aWNlLnR5cGUoKSwgeyB9LCB7IH0pKTsKICAgICAgICAg fQogCi0gICAgICAgIGlmICh3ZWFrVGhpcykKLSAgICAgICAgICAgIG1faGFzRmlsdGVyZWREZXZp Y2VMaXN0ID0gIXJldmVhbElkc0FuZExhYmVsczsKLQorICAgICAgICB3ZWFrVGhpcy0+bV9oYXNG aWx0ZXJlZERldmljZUxpc3QgPSAhcmV2ZWFsSWRzQW5kTGFiZWxzOwogICAgICAgICBBTFdBWVNf TE9HKExPR0lERU5USUZJRVIsIGZpbHRlcmVkRGV2aWNlcy5zaXplKCksICIgZGV2aWNlcyByZXZl YWxlZCIpOworCiAgICAgICAgIGNvbXBsZXRpb24oV1RGTW92ZShmaWx0ZXJlZERldmljZXMpKTsK ICAgICB9KTsKIH0K 421244 2021-02-22 15:09:11 -0800 2021-02-22 17:11:03 -0800 Patch bug-222236-20210222150911.patch text/plain 1719 eric.carlson U3VidmVyc2lvbiBSZXZpc2lvbjogMjczMjY5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGZlNDI5ODc3ZTFhMzUxZTk3 YmI3MzQwZTliMGE2OTMxOTRjMzFkZjkuLjgzNjBiNTg1M2Y2N2QyNDE3ZjJkNmYyMWQ3ZWU4ZTAw MjRmY2RmNDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjEtMDItMjIgIEVyaWMgQ2Fy bHNvbiAgPGVyaWMuY2FybHNvbkBhcHBsZS5jb20+CisKKyAgICAgICAgVXNlck1lZGlhUGVybWlz c2lvblJlcXVlc3RNYW5hZ2VyUHJveHkgbWF5IGJlIHJlbGVhc2VkIHdoaWxlIGNvbXB1dGluZyBj YXB0dXJlIGRldmljZSBsaXN0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMjIyMzYKKyAgICAgICAgPHJkYXI6Ly83NDQ4MDI2NT4KKworICAgICAgICBV bnJldmlld2VkLCBhZGRyZXNzIHBvc3QtcmV2aWV3IGNvbW1lbnQuCisKKyAgICAgICAgKiBVSVBy b2Nlc3MvVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyUHJveHkuY3BwOgorICAgICAg ICAoV2ViS2l0OjpVc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVzdE1hbmFnZXJQcm94eTo6Y29tcHV0 ZUZpbHRlcmVkRGV2aWNlTGlzdCk6IFVzZQorICAgICAgICBjYXB0dXJlZCBgdGhpc2AuCisKIDIw MjEtMDItMjIgIFNhbSBTbmVkZG9uICA8Z3NuZWRkZXJzQGFwcGxlLmNvbT4KIAogICAgICAgICBS RUdSRVNTSU9OKHIyNzMyMDQpOiB3ZWJraXRweSB0ZXN0cyBkb24ndCBydW4gb24gUHkzCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Vc2VyTWVkaWFQZXJtaXNzaW9uUmVxdWVz dE1hbmFnZXJQcm94eS5jcHAgYi9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9Vc2VyTWVkaWFQZXJt aXNzaW9uUmVxdWVzdE1hbmFnZXJQcm94eS5jcHAKaW5kZXggZjViMTdiZWMxNDJmYmVmZWY2Zjdh MTBiNTQwYjdkOGU1MDE1NTJkMy4uMWJkMzRiZGRiZmE2ZjQzYWI0NDMwN2Y0OTgzZDI2YjI3MWMx OGI2NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvVXNlck1lZGlhUGVybWlz c2lvblJlcXVlc3RNYW5hZ2VyUHJveHkuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNz L1VzZXJNZWRpYVBlcm1pc3Npb25SZXF1ZXN0TWFuYWdlclByb3h5LmNwcApAQCAtNzM4LDcgKzcz OCw3IEBAIHZvaWQgVXNlck1lZGlhUGVybWlzc2lvblJlcXVlc3RNYW5hZ2VyUHJveHk6OmNvbXB1 dGVGaWx0ZXJlZERldmljZUxpc3QoYm9vbCByZXZlCiAgICAgICAgICAgICBmaWx0ZXJlZERldmlj ZXMuYXBwZW5kKHJldmVhbElkc0FuZExhYmVscyA/IGRldmljZSA6IENhcHR1cmVEZXZpY2UoeyB9 LCBkZXZpY2UudHlwZSgpLCB7IH0sIHsgfSkpOwogICAgICAgICB9CiAKLSAgICAgICAgd2Vha1Ro aXMtPm1faGFzRmlsdGVyZWREZXZpY2VMaXN0ID0gIXJldmVhbElkc0FuZExhYmVsczsKKyAgICAg ICAgbV9oYXNGaWx0ZXJlZERldmljZUxpc3QgPSAhcmV2ZWFsSWRzQW5kTGFiZWxzOwogICAgICAg ICBBTFdBWVNfTE9HKExPR0lERU5USUZJRVIsIGZpbHRlcmVkRGV2aWNlcy5zaXplKCksICIgZGV2 aWNlcyByZXZlYWxlZCIpOwogCiAgICAgICAgIGNvbXBsZXRpb24oV1RGTW92ZShmaWx0ZXJlZERl dmljZXMpKTsK