22222 2008-11-12 16:42:29 -0800 selectKeyViewPrecedingView: with document view that can't be first responder makes WebFrameView be first responder 2008-11-15 10:06:28 -0800 1 1 1 Unclassified WebKit WebKit API 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 1 darin darin oldest_to_newest 98549 0 darin 2008-11-12 16:42:29 -0800 This came up while doing some Safari experimentation; it doesn't currently affect Safari. Calling -[NSWindow selectKeyViewPrecedingView:] was causing the WebFrameView to become the first responder. I tracked it down to a bug in -[WebFrameView becomeFirstResponder] that is easy to fix. 98553 1 25107 darin 2008-11-12 16:56:21 -0800 Created attachment 25107 patch 98586 2 25107 mrowe 2008-11-12 22:23:16 -0800 Comment on attachment 25107 patch > + // If we couldn't find a previous valid key view, ask the WebView. This handles frameset > + // cases like. Note that previousValidKeyView should never be self but can be due to > + // AppKit oddness. The second sentence of this comment has lost the Radar number. r=me 98874 3 darin 2008-11-15 10:06:28 -0800 http://trac.webkit.org/changeset/38402 25107 2008-11-12 16:56:21 -0800 2008-11-12 22:23:16 -0800 patch PrecedingViewPatch.txt text/plain 3697 darin SW5kZXg6IG1hYy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gbWFjL0NoYW5nZUxvZwkocmV2aXNp b24gMzgzNTApCisrKyBtYWMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYg QEAKKzIwMDgtMTEtMTIgIERhcmluIEFkbGVyICA8ZGFyaW5AYXBwbGUuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIC0gZml4IGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMjIyMgorICAgICAgICAgIHNlbGVjdEtleVZp ZXdQcmVjZWRpbmdWaWV3OiB3aXRoIGRvY3VtZW50IHZpZXcgdGhhdCBjYW4ndCBiZSBmaXJzdCBy ZXNwb25kZXIKKyAgICAgICAgICBtYWtlcyBXZWJGcmFtZVZpZXcgYmUgZmlyc3QgcmVzcG9uZGVy CisKKyAgICAgICAgKiBXZWJWaWV3L1dlYkZyYW1lVmlldy5tbTogKC1bV2ViRnJhbWVWaWV3IGJl Y29tZUZpcnN0UmVzcG9uZGVyXSk6CisgICAgICAgIE1vdmVkIHRoZSBhY2NlcHRzRmlyc3RSZXNw b25kZXIgc3BlY2lhbCBjYXNlIGluc2lkZSB0aGUgaWYgc3RhdGVtZW50IHNvIGl0IHdvbid0Cisg ICAgICAgIHJ1biBpbiB0aGUgInNlbGVjdGluZyBwcmV2aW91cyIgY2FzZS4gQWxzbyByZW1vdmVk IHRoZSAianVzdCBiZWZvcmUgc2hpcHBpbmcgVGlnZXIiCisgICAgICAgIGNvZGUgdGhhdCBkb2Vz bid0IG5lZWQgdG8gYmUgaGVyZSBhbnkgbW9yZS4KKwogMjAwOC0xMS0xMiAgQW5kZXJzIENhcmxz c29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEtldmluIERl Y2tlci4KSW5kZXg6IG1hYy9XZWJWaWV3L1dlYkZyYW1lVmlldy5tbQo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBt YWMvV2ViVmlldy9XZWJGcmFtZVZpZXcubW0JKHJldmlzaW9uIDM4MzQ2KQorKysgbWFjL1dlYlZp ZXcvV2ViRnJhbWVWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zOTQsMjkgKzM5NCwyMiBAQCBz dGF0aWMgaW5saW5lIHZvaWQgYWRkVHlwZXNGcm9tQ2xhc3MoTlNNCiAgICAgLy8gdGhlIGtleSBs b29wIHNpbWlsYXIgdG8gdGhlIHdheSBOU1Njcm9sbFZpZXcgZG9lcyB0aGlzLiBOb3RlIHRoYXQK ICAgICAvLyBXZWJWaWV3IGhhcyBzaW1pbGFyIGNvZGUuCiAgICAgCi0gICAgLy8gSWYgdGhlIHNj cm9sbFZpZXcgd29uJ3QgYWNjZXB0IGZpcnN0LXJlc3BvbmRlcm5lc3Mgbm93LCB0aGVuIHdlIGp1 c3QgYmVjb21lCi0gICAgLy8gdGhlIGZpcnN0IHJlc3BvbmRlciBvdXJzZWxmIGxpa2UgYSBub3Jt YWwgdmlldy4gVGhpcyBsZXRzIHVzIGJlIHRoZSBmaXJzdCAKLSAgICAvLyByZXNwb25kZXIgaW4g Y2FzZXMgd2hlcmUgbm8gcGFnZSBoYXMgeWV0IGJlZW4gbG9hZGVkIChzZWUgMzQ2OTc5MSkuCi0g ICAgaWYgKFtbc2VsZiBfc2Nyb2xsVmlld10gYWNjZXB0c0ZpcnN0UmVzcG9uZGVyXSkgewotICAg ICAgICBOU1dpbmRvdyAqd2luZG93ID0gW3NlbGYgd2luZG93XTsKLSAgICAgICAgaWYgKFt3aW5k b3cga2V5Vmlld1NlbGVjdGlvbkRpcmVjdGlvbl0gPT0gTlNTZWxlY3RpbmdQcmV2aW91cykgewot ICAgICAgICAgICAgTlNWaWV3ICpwcmV2aW91c1ZhbGlkS2V5VmlldyA9IFtzZWxmIHByZXZpb3Vz VmFsaWRLZXlWaWV3XTsKLSAgICAgICAgICAgIC8vIElmIHdlIGNvdWxkbid0IGZpbmQgYSBwcmV2 aW91cyB2YWxpZCBrZXkgdmlldywgYXNrIHRoZSB3ZWJ2aWV3LiBUaGlzIGhhbmRsZXMgZnJhbWVz ZXQKLSAgICAgICAgICAgIC8vIGNhc2VzIGxpa2UgMzc0ODYyOC4gTm90ZSB0aGF0IHByZXZpb3Vz VmFsaWRLZXlWaWV3IHNob3VsZCBuZXZlciBiZSBzZWxmIGJ1dCBjYW4gYmUKLSAgICAgICAgICAg IC8vIGR1ZSB0byBBcHBLaXQgb2RkbmVzcyAobWVudGlvbmVkIGluIDM3NDg2MjgpLgotICAgICAg ICAgICAgaWYgKHByZXZpb3VzVmFsaWRLZXlWaWV3ID09IG5pbCB8fCBwcmV2aW91c1ZhbGlkS2V5 VmlldyA9PSBzZWxmKSB7Ci0gICAgICAgICAgICAgICAgcHJldmlvdXNWYWxpZEtleVZpZXcgPSBb W1tzZWxmIHdlYkZyYW1lXSB3ZWJWaWV3XSBwcmV2aW91c1ZhbGlkS2V5Vmlld107Ci0gICAgICAg ICAgICB9Ci0gICAgICAgICAgICAvLyBJIGRvbid0IGtub3cgaWYgdGhlIGZvbGxvd2luZyBjYXNl cyBldmVyIG9jY3VyIGFueW1vcmUsIGJ1dCBJJ20gbGVhdmluZyBpbiB0aGUgb2xkIHRlc3QgZm9y Ci0gICAgICAgICAgICAvLyBub3cgdG8gYXZvaWQgY2F1c2luZyB0cm91YmxlIGp1c3QgYmVmb3Jl IHNoaXBwaW5nIFRpZ2VyLgotICAgICAgICAgICAgQVNTRVJUKChwcmV2aW91c1ZhbGlkS2V5Vmll dyAhPSBzZWxmKSAmJiAocHJldmlvdXNWYWxpZEtleVZpZXcgIT0gW3NlbGYgX3Njcm9sbFZpZXdd KSk7Ci0gICAgICAgICAgICBpZiAoKHByZXZpb3VzVmFsaWRLZXlWaWV3ICE9IHNlbGYpICYmIChw cmV2aW91c1ZhbGlkS2V5VmlldyAhPSBbc2VsZiBfc2Nyb2xsVmlld10pKSB7Ci0gICAgICAgICAg ICAgICAgW3dpbmRvdyBtYWtlRmlyc3RSZXNwb25kZXI6cHJldmlvdXNWYWxpZEtleVZpZXddOwot ICAgICAgICAgICAgfQotICAgICAgICB9IGVsc2UgeworICAgIE5TV2luZG93ICp3aW5kb3cgPSBb c2VsZiB3aW5kb3ddOworICAgIGlmIChbd2luZG93IGtleVZpZXdTZWxlY3Rpb25EaXJlY3Rpb25d ID09IE5TU2VsZWN0aW5nUHJldmlvdXMpIHsKKyAgICAgICAgTlNWaWV3ICpwcmV2aW91c1ZhbGlk S2V5VmlldyA9IFtzZWxmIHByZXZpb3VzVmFsaWRLZXlWaWV3XTsKKyAgICAgICAgLy8gSWYgd2Ug Y291bGRuJ3QgZmluZCBhIHByZXZpb3VzIHZhbGlkIGtleSB2aWV3LCBhc2sgdGhlIFdlYlZpZXcu IFRoaXMgaGFuZGxlcyBmcmFtZXNldAorICAgICAgICAvLyBjYXNlcyBsaWtlLiBOb3RlIHRoYXQg cHJldmlvdXNWYWxpZEtleVZpZXcgc2hvdWxkIG5ldmVyIGJlIHNlbGYgYnV0IGNhbiBiZSBkdWUg dG8KKyAgICAgICAgLy8gQXBwS2l0IG9kZG5lc3MuCisgICAgICAgIGlmIChwcmV2aW91c1ZhbGlk S2V5VmlldyA9PSBuaWwgfHwgcHJldmlvdXNWYWxpZEtleVZpZXcgPT0gc2VsZikKKyAgICAgICAg ICAgIHByZXZpb3VzVmFsaWRLZXlWaWV3ID0gW1tbc2VsZiB3ZWJGcmFtZV0gd2ViVmlld10gcHJl dmlvdXNWYWxpZEtleVZpZXddOworICAgICAgICBbd2luZG93IG1ha2VGaXJzdFJlc3BvbmRlcjpw cmV2aW91c1ZhbGlkS2V5Vmlld107CisgICAgfSBlbHNlIHsKKyAgICAgICAgLy8gSWYgdGhlIHNj cm9sbCB2aWV3IHdvbid0IGFjY2VwdCBmaXJzdC1yZXNwb25kZXJuZXNzIG5vdywgdGhlbiBqdXN0 IGJlY29tZQorICAgICAgICAvLyB0aGUgZmlyc3QgcmVzcG9uZGVyIG91cnNlbGYgbGlrZSBhIG5v cm1hbCB2aWV3LiBUaGlzIGxldHMgdXMgYmUgdGhlIGZpcnN0IAorICAgICAgICAvLyByZXNwb25k ZXIgaW4gY2FzZXMgd2hlcmUgbm8gcGFnZSBoYXMgeWV0IGJlZW4gbG9hZGVkLgorICAgICAgICBp ZiAoW1tzZWxmIF9zY3JvbGxWaWV3XSBhY2NlcHRzRmlyc3RSZXNwb25kZXJdKQogICAgICAgICAg ICAgW3dpbmRvdyBtYWtlRmlyc3RSZXNwb25kZXI6W3NlbGYgX3Njcm9sbFZpZXddXTsKLSAgICAg ICAgfQotICAgIH0gICAgCisgICAgfQogICAgIAogICAgIHJldHVybiBZRVM7CiB9Cg==